147699 2015-08-05 15:43:35 -0700 Web Inspector: REGRESSION (r187900): Breakpoint context menu is broken in Debugger tab 2015-08-05 16:57:04 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1115142 0 mattbaker 2015-08-05 15:43:35 -0700 * SUMMARY Breakpoint context menu is broken in Debugger tab. Context menu has incorrect/missing items. * STEPS TO REPRODUCE 1. Create breakpoint in Debugger tab 2. Right click breakpoint in text editor gutter => Edit menu item is missing, and other problems * NOTES Regressed in: http://trac.webkit.org/changeset/187900 1115145 1 258311 mattbaker 2015-08-05 15:47:45 -0700 Created attachment 258311 [Patch] Proposed Fix 1115186 2 258311 commit-queue 2015-08-05 16:57:02 -0700 Comment on attachment 258311 [Patch] Proposed Fix Clearing flags on attachment: 258311 Committed r188007: <http://trac.webkit.org/changeset/188007> 1115187 3 commit-queue 2015-08-05 16:57:04 -0700 All reviewed patches have been landed. Closing bug. 258311 2015-08-05 15:47:45 -0700 2015-08-05 16:57:02 -0700 [Patch] Proposed Fix bug-147699-20150805154737.patch text/plain 2018 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3OTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ODQ4OTcwZTBmNTQwZGUyN2YxZmYyYjk4YThmNzg4MjJjMDgzYTk5Li5iOWMyOTE3ZTE3YzI5YWM3 ZTZkZjAyYjY1OTkyOTUyMmNiNDcyZTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wOC0wNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjE4NzkwMCk6IEJyZWFrcG9p bnQgY29udGV4dCBtZW51IGlzIGJyb2tlbiBpbiBEZWJ1Z2dlciB0YWIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzY5OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9T b3VyY2VDb2RlVGV4dEVkaXRvci5qczoKKyAgICAgICAgU2tpcCBvbmx5IHRoZSBzZXBhcmF0b3Ig YW5kICJSZXZlYWwgaW4gRGVidWdnZXIgdGFiIiBtZW51IGl0ZW1zLgorCiAyMDE1LTA4LTA1ICBC cmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJl bW92ZSB1bnVzZWQgT2JqZWN0LmRlcHJlY2F0ZWRBZGRDb25zdHJ1Y3RvckZ1bmN0aW9ucwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNl Q29kZVRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcwppbmRleCA0ZThlMjU2NWJmNjdhNmYzOGY0YzJl NTU1MDBmY2Y0ZDk2NWNjNzdhLi44ZTFlOTZiMDVhMDZiZDk0NDdiODA4ZjA5Y2I1NzBhNDYwNmQ0 ZGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcwpAQCAtMTAyMiwxMiArMTAy MiwxNiBAQCBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VD b2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICB9CiAKICAgICAgICAgLy8g U2luZ2xlIGJyZWFrcG9pbnQuCi0gICAgICAgIGlmIChicmVha3BvaW50cy5sZW5ndGggPT09IDEg JiYgIVdlYkluc3BlY3Rvci5pc1Nob3dpbmdEZWJ1Z2dlclRhYigpKSB7CisgICAgICAgIGlmIChi cmVha3BvaW50cy5sZW5ndGggPT09IDEpIHsKICAgICAgICAgICAgIHZhciBicmVha3BvaW50ID0g YnJlYWtwb2ludHNbMF07CiAKICAgICAgICAgICAgIGJyZWFrcG9pbnQuYXBwZW5kQ29udGV4dE1l bnVJdGVtcyhjb250ZXh0TWVudSwgZXZlbnQudGFyZ2V0KTsKLSAgICAgICAgICAgIGNvbnRleHRN ZW51LmFwcGVuZFNlcGFyYXRvcigpOwotICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRl bShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJldmVhbCBpbiBEZWJ1Z2dlciBUYWIiKSwgcmV2ZWFs SW5TaWRlYmFyKTsKKworICAgICAgICAgICAgaWYgKCFXZWJJbnNwZWN0b3IuaXNTaG93aW5nRGVi dWdnZXJUYWIoKSkgeworICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRv cigpOworICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9y LlVJU3RyaW5nKCJSZXZlYWwgaW4gRGVidWdnZXIgVGFiIiksIHJldmVhbEluU2lkZWJhcik7Cisg ICAgICAgICAgICB9CisKICAgICAgICAgICAgIGNvbnRleHRNZW51LnNob3coKTsKICAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgfQo=