147688 2015-08-05 11:10:47 -0700 Bytecodegenerator emits crappy code for returns in a lexical scope. 2022-02-27 23:37:30 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam basile_clement benjamin fpizlo ggaren mark.lam mmirman msaboff oliver ysuzuki oldest_to_newest 1115058 0 saam 2015-08-05 11:10:47 -0700 I introduced bad codegen in r187003 by having returns first pop to scope depth zero, always when there is local scope depth. This is *only* necessary if we have "finally" blocks. This should be an easy fix. 1115078 1 258289 saam 2015-08-05 11:38:24 -0700 Created attachment 258289 patch 1115116 2 258289 mark.lam 2015-08-05 14:32:05 -0700 Comment on attachment 258289 patch r=me nit: Can you add a comment in the ChangeLog to indicate that this is a perf bug, and not a correctness bug? 1115122 3 saam 2015-08-05 14:46:06 -0700 landed in: http://trac.webkit.org/changeset/187991 258289 2015-08-05 11:38:24 -0700 2022-02-27 23:37:30 -0800 patch a-backup.diff text/plain 2467 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg3OTY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE1LTA4LTA1ICBTYWFtIGJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBCeXRlY29kZWdlbmVyYXRvciBlbWl0cyBjcmFwcHkgY29kZSBmb3IgcmV0dXJucyBpbiBh IGxleGljYWwgc2NvcGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDc2ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIHJldHVybmluZywgd2Ugb25seSBuZWVkIHRvIGVtaXQgY29tcGxleCBwb3Ag c2NvcGVzIGlmIHdlJ3JlIGluIAorICAgICAgICBhIGZpbmFsbHkgYmxvY2suIE90aGVyd2lzZSwg d2UgY2FuIGp1c3QgcmV0dXJuIGxpa2Ugbm9ybWFsLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVy L0J5dGVjb2RlR2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjpp c0luRmluYWxseUJsb2NrKToKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6Omhhc0Zp bmFsaXNlcik6IERlbGV0ZWQuCisgICAgICAgICogYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5j cHA6CisgICAgICAgIChKU0M6OlJldHVybk5vZGU6OmVtaXRCeXRlY29kZSk6CisKIDIwMTUtMDgt MDUgIFNhYW0gYmFyYXRpICA8c2FhbWJhcmF0aTFAZ21haWwuY29tPgogCiAgICAgICAgIFJlcGxh Y2UgSlNGdW5jdGlvbk5hbWVTY29wZSB3aXRoIEpTTGV4aWNhbEVudmlyb25tZW50IGZvciB0aGUg ZnVuY3Rpb24gbmFtZSBzY29wZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29t cGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgJKHJldmlzaW9uIDE4Nzk2OSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3Iu aAkod29ya2luZyBjb3B5KQpAQCAtNjAwLDcgKzYwMCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAg ICAgICAgIHZvaWQgZW1pdERlYnVnSG9vayhEZWJ1Z0hvb2tJRCwgdW5zaWduZWQgbGluZSwgdW5z aWduZWQgY2hhck9mZnNldCwgdW5zaWduZWQgbGluZVN0YXJ0KTsKIAotICAgICAgICBib29sIGhh c0ZpbmFsaXNlcigpIHsgcmV0dXJuIG1fZmluYWxseURlcHRoICE9IDA7IH0KKyAgICAgICAgYm9v bCBpc0luRmluYWxseUJsb2NrKCkgeyByZXR1cm4gbV9maW5hbGx5RGVwdGggPiAwOyB9CiAKICAg ICAgICAgdm9pZCBwdXNoRmluYWxseUNvbnRleHQoU3RhdGVtZW50Tm9kZSogZmluYWxseUJsb2Nr KTsKICAgICAgICAgdm9pZCBwb3BGaW5hbGx5Q29udGV4dCgpOwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAkocmV2aXNp b24gMTg3OTY5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0Nv ZGVnZW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTUyLDcgKzI1NTIsNyBAQCB2b2lkIFJldHVy bk5vZGU6OmVtaXRCeXRlY29kZShCeXRlY29kZUdlCiAKICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4g cmV0dXJuUmVnaXN0ZXIgPSBtX3ZhbHVlID8gZ2VuZXJhdG9yLmVtaXROb2RlKGRzdCwgbV92YWx1 ZSkgOiBnZW5lcmF0b3IuZW1pdExvYWQoZHN0LCBqc1VuZGVmaW5lZCgpKTsKICAgICBnZW5lcmF0 b3IuZW1pdFByb2ZpbGVUeXBlKHJldHVyblJlZ2lzdGVyLmdldCgpLCBQcm9maWxlVHlwZUJ5dGVj b2RlRnVuY3Rpb25SZXR1cm5TdGF0ZW1lbnQsIGRpdm90U3RhcnQoKSwgZGl2b3RFbmQoKSk7Ci0g ICAgaWYgKGdlbmVyYXRvci5sYWJlbFNjb3BlRGVwdGgoKSkgeworICAgIGlmIChnZW5lcmF0b3Iu aXNJbkZpbmFsbHlCbG9jaygpKSB7CiAgICAgICAgIHJldHVyblJlZ2lzdGVyID0gZ2VuZXJhdG9y LmVtaXRNb3ZlKGdlbmVyYXRvci5uZXdUZW1wb3JhcnkoKSwgcmV0dXJuUmVnaXN0ZXIuZ2V0KCkp OwogICAgICAgICBnZW5lcmF0b3IuZW1pdFBvcFNjb3BlcyhnZW5lcmF0b3Iuc2NvcGVSZWdpc3Rl cigpLCAwKTsKICAgICB9Cg==