147682 2015-08-05 05:40:51 -0700 [GTK] Crash closing a page when a context menu is open 2015-08-06 01:14:41 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned svillar zan oldest_to_newest 1115007 0 cgarcia 2015-08-05 05:40:51 -0700 This was fixed in mac port in r180094, but I don't know which previous revision introduced the regression. It can be reproduced with /webkit2/WebKitWebView/populate-menu but we didn't notice it because the TestContextMenu test is still skipped in the bots :-/ This also affects to 2.8 branch. 1115008 1 258274 cgarcia 2015-08-05 05:55:56 -0700 Created attachment 258274 Patch 1115307 2 258274 svillar 2015-08-06 00:27:49 -0700 Comment on attachment 258274 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258274&action=review > Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:196 > + for (auto iter = m_signalHandlers.begin(); iter != m_signalHandlers.end(); ++iter) for (auto handler : m_signalHandlers) 1115314 3 cgarcia 2015-08-06 01:14:41 -0700 Committed r188031: <http://trac.webkit.org/changeset/188031> 258274 2015-08-05 05:55:56 -0700 2015-08-06 00:27:49 -0700 Patch wk2-context-menu-crash.diff text/plain 3133 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxZjgxNDM2Li4zNDNjNzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTUtMDgtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIENyYXNoIGNsb3NpbmcgYSBwYWdlIHdoZW4gYSBjb250ZXh0IG1l bnUgaXMgb3BlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ3NjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW1wbGVtZW50IFdlYkNvbnRleHRNZW51UHJveHk6OmNhbmNlbFRyYWNraW5nKCkgdG8gY2xl YXIgdGhlCisgICAgICAgIGludGVybmFsIG1lbnUgd2hlbiB0aGUgd2ViIHBhZ2UgaXMgY2xvc2Vk LgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0TWVudVByb3h5R3RrLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVQcm94eUd0azo6Y2FuY2VsVHJhY2tpbmcp OgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudVByb3h5R3RrOjp+V2ViQ29udGV4dE1l bnVQcm94eUd0ayk6IERlbGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0 TWVudVByb3h5R3RrLmg6CisKIDIwMTUtMDgtMDQgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBw bGUuY29tPgogCiAgICAgICAgIE5ldHdvcmsgY2FjaGUgZmV0Y2hlcyBzaG91bGQgaGF2ZSB0aW1l b3V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRN ZW51UHJveHlHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0 TWVudVByb3h5R3RrLmNwcAppbmRleCA5OTMyOTU3Li4zZThhN2RhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRNZW51UHJveHlHdGsuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dE1lbnVQcm94eUd0ay5jcHAK QEAgLTE3MSwxMCArMTcxLDcgQEAgV2ViQ29udGV4dE1lbnVQcm94eUd0azo6V2ViQ29udGV4dE1l bnVQcm94eUd0ayhHdGtXaWRnZXQqIHdlYlZpZXcsIFdlYlBhZ2VQcm94eSoKIAogV2ViQ29udGV4 dE1lbnVQcm94eUd0azo6fldlYkNvbnRleHRNZW51UHJveHlHdGsoKQogewotICAgIGZvciAoYXV0 byBpdGVyID0gbV9zaWduYWxIYW5kbGVycy5iZWdpbigpOyBpdGVyICE9IG1fc2lnbmFsSGFuZGxl cnMuZW5kKCk7ICsraXRlcikKLSAgICAgICAgZ19zaWduYWxfaGFuZGxlcl9kaXNjb25uZWN0KGl0 ZXItPnZhbHVlLCBpdGVyLT5rZXkpOwotCi0gICAgd2Via2l0V2ViVmlld0Jhc2VTZXRBY3RpdmVD b250ZXh0TWVudVByb3h5KFdFQktJVF9XRUJfVklFV19CQVNFKG1fd2ViVmlldyksIDApOworICAg IGNhbmNlbFRyYWNraW5nKCk7CiB9CiAKIHZvaWQgV2ViQ29udGV4dE1lbnVQcm94eUd0azo6bWVu dVBvc2l0aW9uRnVuY3Rpb24oR3RrTWVudSogbWVudSwgZ2ludCogeCwgZ2ludCogeSwgZ2Jvb2xl YW4qIHB1c2hJbiwgV2ViQ29udGV4dE1lbnVQcm94eUd0ayogcG9wdXBNZW51KQpAQCAtMTk0LDUg KzE5MSwxNSBAQCB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlHdGs6Om1lbnVQb3NpdGlvbkZ1bmN0 aW9uKEd0a01lbnUqIG1lbnUsIGdpbnQqIHgsIGdpbnQqCiAgICAgKnB1c2hJbiA9IEZBTFNFOwog fQogCit2b2lkIFdlYkNvbnRleHRNZW51UHJveHlHdGs6OmNhbmNlbFRyYWNraW5nKCkKK3sKKyAg ICBmb3IgKGF1dG8gaXRlciA9IG1fc2lnbmFsSGFuZGxlcnMuYmVnaW4oKTsgaXRlciAhPSBtX3Np Z25hbEhhbmRsZXJzLmVuZCgpOyArK2l0ZXIpCisgICAgICAgIGdfc2lnbmFsX2hhbmRsZXJfZGlz Y29ubmVjdChpdGVyLT52YWx1ZSwgaXRlci0+a2V5KTsKKyAgICBtX3NpZ25hbEhhbmRsZXJzLmNs ZWFyKCk7CisKKyAgICB3ZWJraXRXZWJWaWV3QmFzZVNldEFjdGl2ZUNvbnRleHRNZW51UHJveHko V0VCS0lUX1dFQl9WSUVXX0JBU0UobV93ZWJWaWV3KSwgbnVsbHB0cik7CisgICAgbV9tZW51LnNl dFBsYXRmb3JtRGVzY3JpcHRpb24obnVsbHB0cik7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktp dAogI2VuZGlmIC8vIEVOQUJMRShDT05URVhUX01FTlVTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0TWVudVByb3h5R3RrLmggYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRNZW51UHJveHlHdGsuaAppbmRleCBhODBlYmYy Li4wYmQ4ZTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNv bnRleHRNZW51UHJveHlHdGsuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dl YkNvbnRleHRNZW51UHJveHlHdGsuaApAQCAtNDcsOCArNDcsOSBAQCBwdWJsaWM6CiAgICAgfQog ICAgIH5XZWJDb250ZXh0TWVudVByb3h5R3RrKCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQgc2hvd0Nv bnRleHRNZW51KGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiwgY29uc3QgVmVjdG9yPFJlZlB0cjxX ZWJDb250ZXh0TWVudUl0ZW0+PiYsIGNvbnN0IENvbnRleHRNZW51Q29udGV4dERhdGEmKTsKLSAg ICB2aXJ0dWFsIHZvaWQgaGlkZUNvbnRleHRNZW51KCk7CisgICAgdmlydHVhbCB2b2lkIHNob3dD b250ZXh0TWVudShjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYsIGNvbnN0IFZlY3RvcjxSZWZQdHI8 V2ViQ29udGV4dE1lbnVJdGVtPj4mLCBjb25zdCBDb250ZXh0TWVudUNvbnRleHREYXRhJikgb3Zl cnJpZGU7CisgICAgdmlydHVhbCB2b2lkIGhpZGVDb250ZXh0TWVudSgpIG92ZXJyaWRlOworICAg IHZpcnR1YWwgdm9pZCBjYW5jZWxUcmFja2luZygpIG92ZXJyaWRlOwogCiAgICAgdm9pZCBwb3B1 bGF0ZShWZWN0b3I8V2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtPiYpOwogICAgIEd0a01lbnUqIGd0 a01lbnUoKSBjb25zdCB7IHJldHVybiBtX21lbnUucGxhdGZvcm1EZXNjcmlwdGlvbigpOyB9Cg==