147655 2015-08-04 15:10:21 -0700 Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage 2015-08-10 14:33:34 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck ap bburg commit-queue graouts joepeck jonowells mattbaker nvasilyev simon.fraser timothy webkit-bug-importer oldest_to_newest 1114800 0 joepeck 2015-08-04 15:10:21 -0700 * SUMMARY Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage. I was seeing an issue where tests with reloadPage might duplicate some output. After much logging, it appears to be related to ordering of operations. A test might call InspectorTest.reloadPage, but before the callback runs to say "test is reloading" another InspectorTest.log would sneak and send a result, then get resent once the page loads. Making InspectorTest.reloadPage immediately say "we are reloading" removes the flakiness, as the early InspectorTest.log wouldn't send its message as it knows it will be resent after the reload. 1114801 1 joepeck 2015-08-04 15:11:19 -0700 * STEPS TO REPRODUCE 1. shell> run-webkit-tests --release --no-retry-failures --iterations=1000 inspector/page/main-frame-resource.html => 10 failures out of 1000 runs for me. 1114802 2 joepeck 2015-08-04 15:11:46 -0700 Err, throw a "--v" on there as well to see the result of each test run. 1114804 3 joepeck 2015-08-04 15:13:55 -0700 *** Bug 147517 has been marked as a duplicate of this bug. *** 1114805 4 258218 joepeck 2015-08-04 15:14:15 -0700 Created attachment 258218 [PATCH] Proposed Fix 1114839 5 258218 commit-queue 2015-08-04 15:51:01 -0700 Comment on attachment 258218 [PATCH] Proposed Fix Clearing flags on attachment: 258218 Committed r187903: <http://trac.webkit.org/changeset/187903> 1114840 6 commit-queue 2015-08-04 15:51:04 -0700 All reviewed patches have been landed. Closing bug. 258218 2015-08-04 15:14:15 -0700 2015-08-04 15:51:01 -0700 [PATCH] Proposed Fix yay.patch text/plain 3184 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNTY5ODU4Li42Njk0NGVlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDgt MDQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBJbXBy b3ZlIHNvbWUgTGF5b3V0VGVzdHMvaW5zcGVjdG9yIGZsYWtleSBvdXRwdXQgZm9yIHRlc3RzIHdp dGggSW5zcGVjdG9yVGVzdC5yZWxvYWRQYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc2NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTUtMDctMzEgIEpv c2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXByb3ZlIHNv bWUgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZSB0ZXN0cywgcmVkdWNlIGZsYWtleSBv dXRwdXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDI4MDIyYTYuLjBhMTMyYzggMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVj dGF0aW9ucwpAQCAtOTgsOCArOTgsNiBAQCB3ZWJraXQub3JnL2IvMTQ3NTAyIGluc3BlY3Rvci9k ZWJ1Z2dlci9icmVhay1vbi11bmNhdWdodC1leGNlcHRpb24tdGhyb3ctaW4tcHJvbQogd2Via2l0 Lm9yZy9iLzE0NzUwMiBpbnNwZWN0b3IvZGVidWdnZXIvYnJlYWstb24tdW5jYXVnaHQtZXhjZXB0 aW9uLXRocm93LWluLXByb21pc2Utd2l0aC1jYXRjaC5odG1sIFsgU2tpcCBdCiB3ZWJraXQub3Jn L2IvMTQ3NTAyIGluc3BlY3Rvci9kZWJ1Z2dlci9icmVhay1vbi11bmNhdWdodC1leGNlcHRpb24t dGhyb3ctaW4tcHJvbWlzZS5odG1sIFsgU2tpcCBdCiAKLXdlYmtpdC5vcmcvYi8xNDc1MTcgaW5z cGVjdG9yL3BhZ2UvbWFpbi1mcmFtZS1yZXNvdXJjZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQog d2Via2l0Lm9yZy9iLzE0MjIwOCBpbnNwZWN0b3IvdGltZWxpbmUvZGVidWdnZXItcGF1c2VkLXdo aWxlLXJlY29yZGluZy5odG1sIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMTQyMjA4IGluc3BlY3Rv ci90aW1lbGluZS9leGNlcHRpb24taW4taW5qZWN0ZWQtc2NyaXB0LXdoaWxlLXJlY29yZGluZy5o dG1sIFsgU2tpcCBdCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU5YWI0MmIuLjdjNjNi ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTA0 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgSW1wcm92 ZSBzb21lIExheW91dFRlc3RzL2luc3BlY3RvciBmbGFrZXkgb3V0cHV0IGZvciB0ZXN0cyB3aXRo IEluc3BlY3RvclRlc3QucmVsb2FkUGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NjU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvVGVzdC5qczoKKyAgICAgICAg KEluc3BlY3RvclRlc3QucmVsb2FkUGFnZSk6CisgICAgICAgIEltbWVkaWF0ZWx5IG1hcmsgdGhl IHBhZ2UgYXMgcmVsb2FkaW5nIHNvIHRoYXQgYW55IGxvZ3MgdGhhdCBtYXkgaGFwcGVuCisgICAg ICAgIGJlZm9yZSB0aGUgY2FsbGJhY2sgZm9yIFBhZ2VBZ2VudC5yZWxvYWQgd2FpdCB0byBiZSBz ZW50IGFmdGVyIHRoZSBwYWdlCisgICAgICAgIGxvYWQuIFdoYXQgd2FzIGhhcHBlbmluZyBpbiBm bGFrZXkgcmVzdWx0cyB3YXMgdGhhdCB0aGUgbG9ncyB3ZXJlCisgICAgICAgIGhhcHBlbmluZyBi ZWZvcmUgdGhpcyBjYWxsYmFjaywgYW5kIHRoZXJlZm9yZSBnZXR0aW5nIGxvZ2dlZCBhbmQgdGhl bgorICAgICAgICByZXNlbnQgYWZ0ZXIgcGFnZSBsb2FkIGFuZCBnZXR0aW5nIHJlbG9nZ2VkLgor CiAyMDE1LTA4LTAzICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OIChyMTg3NzA4KTogQnJlYWtwb2ludCBkaWFsb2cg c2NyaXB0IGFjdGlvbiBlZGl0aW5nIGJyb2tlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9UZXN0LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQmFzZS9UZXN0LmpzCmluZGV4IDY2ZDUyNDguLmEyODQ1OGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVGVzdC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1Rlc3QuanMKQEAg LTIyMywxMCArMjIzLDE1IEBAIEluc3BlY3RvclRlc3QudGVzdFBhZ2VEaWRMb2FkID0gZnVuY3Rp b24oKQogCiBJbnNwZWN0b3JUZXN0LnJlbG9hZFBhZ2UgPSBmdW5jdGlvbihzaG91bGRJZ25vcmVD YWNoZSkKIHsKKyAgICBjb25zb2xlLmFzc2VydCghdGhpcy5fdGVzdFBhZ2VJc1JlbG9hZGluZyk7 CisgICAgY29uc29sZS5hc3NlcnQoIXRoaXMuX3Rlc3RQYWdlUmVsb2FkZWRPbmNlKTsKKworICAg IHRoaXMuX3Rlc3RQYWdlSXNSZWxvYWRpbmcgPSB0cnVlOworCiAgICAgcmV0dXJuIFBhZ2VBZ2Vu dC5yZWxvYWQucHJvbWlzZSghIXNob3VsZElnbm9yZUNhY2hlKQogICAgICAgICAudGhlbihmdW5j dGlvbigpIHsKICAgICAgICAgICAgIHRoaXMuX3Nob3VsZFJlc2VuZFJlc3VsdHMgPSB0cnVlOwot ICAgICAgICAgICAgdGhpcy5fdGVzdFBhZ2VJc1JlbG9hZGluZyA9IHRydWU7CisgICAgICAgICAg ICB0aGlzLl90ZXN0UGFnZVJlbG9hZGVkT25jZSA9IHRydWU7CiAKICAgICAgICAgICAgIHJldHVy biBQcm9taXNlLnJlc29sdmUobnVsbCk7CiAgICAgICAgIH0uYmluZCh0aGlzKSk7Cg==