147652 2015-08-04 14:30:58 -0700 Web Inspector: Timeline ruler handle tooltip shows wrong value when handles overlap 2015-08-08 19:06:30 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mattbaker hi bburg commit-queue graouts hi joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1114777 0 mattbaker 2015-08-04 14:30:58 -0700 * SUMMARY Timeline ruler handle tooltip shows wrong value when handles overlap. The tooltip should show the value closest to the edge of the graph to which the handles are clamped. * STEPS TO REPRODUCE 1. Record a timeline, create a ruler selection. 2. Scroll the timeline to the right, until the selection scrolls completely off the left edge of the graph. 3. Hover over the handles clamped to the left edge of the ruler. => Tooltip shows selection start time. Should show end time. 4. Scroll the timeline to the left, until the selection scrolls completely off the right edge of the graph. 5. Hover over the handles clamped to the right edge of the ruler. => Tooltip shows selection end time. Should show start time. 1116070 1 258585 hi 2015-08-08 18:09:11 -0700 Created attachment 258585 Patch 1116074 2 258585 commit-queue 2015-08-08 19:06:24 -0700 Comment on attachment 258585 Patch Clearing flags on attachment: 258585 Committed r188192: <http://trac.webkit.org/changeset/188192> 1116075 3 commit-queue 2015-08-08 19:06:30 -0700 All reviewed patches have been landed. Closing bug. 258585 2015-08-08 18:09:11 -0700 2015-08-08 19:06:24 -0700 Patch bug-147652-20150808180859.patch text/plain 3968 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVjOTI2Mjc0YmJhNWE0NzgyMDA3OGJlODQ2YmIx NzkzYTAwY2ZlZjUuLmYzNTJlOGU0ZGI1YWNmMWFhYzQwZTE2MWIyYTM2ZGFmMzQyNDhkOGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTA4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBU aW1lbGluZSBydWxlciBoYW5kbGUgdG9vbHRpcCBzaG93cyB3cm9uZyB2YWx1ZSB3aGVuIGhhbmRs ZXMgb3ZlcmxhcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ3NjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVSdWxlci5wcm90b3R5cGUuX3VwZGF0ZVNlbGVjdGlvbik6CisgICAg ICAgIE5vdyBjaGFuZ2VzIHRoZSB0aXRsZSBkZXBlbmRpbmcgb24gd2hldGhlciB0aGUgc2VsZWN0 aW9uIHN0YXJ0L2VuZCBpcyBjbGFtcGVkLgorCiAyMDE1LTA4LTA3ICBEZXZpbiBSb3Vzc28gIDxk cm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEZWNyZWFzZSB0aGUg cGFkZGluZyBvZiBlYWNoIHJ1bGUgaW4gdGhlIFJ1bGVzIHNpZGViYXIgdG8gYWxsb3cgbW9yZSBj b250ZW50IHRvIHNob3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1bGVyLmpzCmluZGV4IGM4MTllMGZiZjE1NjcyN2Rl OTRiY2I0MmE3ZjE0MTYyMGE4Yjg1NzUuLmZiYjk0YTVlMTEwZjM1YjMzYzRmZTRkMWYxYjUzZjE4 NTQ1ZjhkMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGltZWxpbmVSdWxlci5qcwpAQCAtNTg3LDIxICs1ODcsMjcgQEAgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIgPSBjbGFzcyBUaW1lbGluZVJ1bGVyIGV4dGVuZHMgV2Vi SW5zcGVjdG9yLk9iamVjdAogICAgICAgICBpZiAoIXRoaXMuX2FsbG93c1RpbWVSYW5nZVNlbGVj dGlvbikKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgbmV3TGVmdFBvc2l0aW9u ID0gTWF0aC5tYXgoMCwgKHRoaXMuX3NlbGVjdGlvblN0YXJ0VGltZSAtIHRoaXMuX3N0YXJ0VGlt ZSkgLyBkdXJhdGlvbik7CisgICAgICAgIGxldCBzdGFydFRpbWVDbGFtcGVkID0gdGhpcy5fc2Vs ZWN0aW9uU3RhcnRUaW1lIDwgdGhpcy5fc3RhcnRUaW1lOworICAgICAgICBsZXQgZW5kVGltZUNs YW1wZWQgPSB0aGlzLl9zZWxlY3Rpb25FbmRUaW1lID4gdGhpcy5fZW5kVGltZTsKKworICAgICAg ICBsZXQgZm9ybWF0dGVkU3RhcnRUaW1lVGV4dCA9IHRoaXMuX2Zvcm1hdERpdmlkZXJMYWJlbFRl eHQodGhpcy5fc2VsZWN0aW9uU3RhcnRUaW1lKTsKKyAgICAgICAgbGV0IGZvcm1hdHRlZEVuZFRp bWVUZXh0ID0gdGhpcy5fZm9ybWF0RGl2aWRlckxhYmVsVGV4dCh0aGlzLl9zZWxlY3Rpb25FbmRU aW1lKTsKKworICAgICAgICBsZXQgbmV3TGVmdFBvc2l0aW9uID0gTWF0aC5tYXgoMCwgKHRoaXMu X3NlbGVjdGlvblN0YXJ0VGltZSAtIHRoaXMuX3N0YXJ0VGltZSkgLyBkdXJhdGlvbik7CiAgICAg ICAgIHRoaXMuX3VwZGF0ZVBvc2l0aW9uT2ZFbGVtZW50KHRoaXMuX2xlZnRTaGFkZWRBcmVhRWxl bWVudCwgbmV3TGVmdFBvc2l0aW9uLCB2aXNpYmxlV2lkdGgsICJ3aWR0aCIpOwogICAgICAgICB0 aGlzLl91cGRhdGVQb3NpdGlvbk9mRWxlbWVudCh0aGlzLl9sZWZ0U2VsZWN0aW9uSGFuZGxlRWxl bWVudCwgbmV3TGVmdFBvc2l0aW9uLCB2aXNpYmxlV2lkdGgsICJsZWZ0Iik7CiAgICAgICAgIHRo aXMuX3VwZGF0ZVBvc2l0aW9uT2ZFbGVtZW50KHRoaXMuX3NlbGVjdGlvbkRyYWdFbGVtZW50LCBu ZXdMZWZ0UG9zaXRpb24sIHZpc2libGVXaWR0aCwgImxlZnQiKTsKIAotICAgICAgICB0aGlzLl9s ZWZ0U2VsZWN0aW9uSGFuZGxlRWxlbWVudC5jbGFzc0xpc3QudG9nZ2xlKCJjbGFtcGVkIiwgdGhp cy5fc2VsZWN0aW9uU3RhcnRUaW1lIDwgdGhpcy5fc3RhcnRUaW1lKTsKLSAgICAgICAgdGhpcy5f bGVmdFNlbGVjdGlvbkhhbmRsZUVsZW1lbnQudGl0bGUgPSB0aGlzLl9zZWxlY3Rpb25TdGFydFRp bWUgPCB0aGlzLl9zdGFydFRpbWUgPyB0aGlzLl9mb3JtYXREaXZpZGVyTGFiZWxUZXh0KHRoaXMu X3NlbGVjdGlvblN0YXJ0VGltZSkgOiAiIjsKKyAgICAgICAgdGhpcy5fbGVmdFNlbGVjdGlvbkhh bmRsZUVsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiY2xhbXBlZCIsIHN0YXJ0VGltZUNsYW1wZWQp OworICAgICAgICB0aGlzLl9sZWZ0U2VsZWN0aW9uSGFuZGxlRWxlbWVudC50aXRsZSA9IHN0YXJ0 VGltZUNsYW1wZWQgICYmIHRoaXMuX3NlbGVjdGlvbkVuZFRpbWUgPCB0aGlzLl9zdGFydFRpbWUg PyBmb3JtYXR0ZWRFbmRUaW1lVGV4dCA6IGZvcm1hdHRlZFN0YXJ0VGltZVRleHQ7CiAKLSAgICAg ICAgdmFyIG5ld1JpZ2h0UG9zaXRpb24gPSAxIC0gTWF0aC5taW4oKHRoaXMuX3NlbGVjdGlvbkVu ZFRpbWUgLSB0aGlzLl9zdGFydFRpbWUpIC8gZHVyYXRpb24sIDEpOworICAgICAgICBsZXQgbmV3 UmlnaHRQb3NpdGlvbiA9IDEgLSBNYXRoLm1pbigodGhpcy5fc2VsZWN0aW9uRW5kVGltZSAtIHRo aXMuX3N0YXJ0VGltZSkgLyBkdXJhdGlvbiwgMSk7CiAgICAgICAgIHRoaXMuX3VwZGF0ZVBvc2l0 aW9uT2ZFbGVtZW50KHRoaXMuX3JpZ2h0U2hhZGVkQXJlYUVsZW1lbnQsIG5ld1JpZ2h0UG9zaXRp b24sIHZpc2libGVXaWR0aCwgIndpZHRoIik7CiAgICAgICAgIHRoaXMuX3VwZGF0ZVBvc2l0aW9u T2ZFbGVtZW50KHRoaXMuX3JpZ2h0U2VsZWN0aW9uSGFuZGxlRWxlbWVudCwgbmV3UmlnaHRQb3Np dGlvbiwgdmlzaWJsZVdpZHRoLCAicmlnaHQiKTsKICAgICAgICAgdGhpcy5fdXBkYXRlUG9zaXRp b25PZkVsZW1lbnQodGhpcy5fc2VsZWN0aW9uRHJhZ0VsZW1lbnQsIG5ld1JpZ2h0UG9zaXRpb24s IHZpc2libGVXaWR0aCwgInJpZ2h0Iik7CiAKLSAgICAgICAgdGhpcy5fcmlnaHRTZWxlY3Rpb25I YW5kbGVFbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoImNsYW1wZWQiLCB0aGlzLl9zZWxlY3Rpb25F bmRUaW1lID4gdGhpcy5fZW5kVGltZSk7Ci0gICAgICAgIHRoaXMuX3JpZ2h0U2VsZWN0aW9uSGFu ZGxlRWxlbWVudC50aXRsZSA9IHRoaXMuX3NlbGVjdGlvbkVuZFRpbWUgPiB0aGlzLl9lbmRUaW1l ID8gdGhpcy5fZm9ybWF0RGl2aWRlckxhYmVsVGV4dCh0aGlzLl9zZWxlY3Rpb25FbmRUaW1lKSA6 ICIiOworICAgICAgICB0aGlzLl9yaWdodFNlbGVjdGlvbkhhbmRsZUVsZW1lbnQuY2xhc3NMaXN0 LnRvZ2dsZSgiY2xhbXBlZCIsIGVuZFRpbWVDbGFtcGVkKTsKKyAgICAgICAgdGhpcy5fcmlnaHRT ZWxlY3Rpb25IYW5kbGVFbGVtZW50LnRpdGxlID0gZW5kVGltZUNsYW1wZWQgJiYgdGhpcy5fc2Vs ZWN0aW9uU3RhcnRUaW1lID4gdGhpcy5fZW5kVGltZSA/IGZvcm1hdHRlZFN0YXJ0VGltZVRleHQg OiBmb3JtYXR0ZWRFbmRUaW1lVGV4dDsKIAogICAgICAgICBpZiAoIXRoaXMuX3NlbGVjdGlvbkRy YWdFbGVtZW50LnBhcmVudE5vZGUpIHsKICAgICAgICAgICAgIHRoaXMuX2VsZW1lbnQuYXBwZW5k Q2hpbGQodGhpcy5fc2VsZWN0aW9uRHJhZ0VsZW1lbnQpOwo=