147646 2015-08-04 12:32:54 -0700 [Win] Layout Test http/tests/security/contentSecurityPolicy/source-list-parsing-10.html is failing 2016-07-05 22:56:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham pvollan bfulgham peavo pvollan webkit-bug-importer oldest_to_newest 1114711 0 bfulgham 2015-08-04 12:32:54 -0700 The following layout test is failing on Windows: http/tests/security/contentSecurityPolicy/source-list-parsing-10.html Probable cause: Possibly related to my CSP_NEXT changes. I'm reviewing now. 1114744 1 bfulgham 2015-08-04 13:35:32 -0700 Skipped failing test in r187879 <http://trac.webkit.org/changeset/187879>. 1197171 2 webkit-bug-importer 2016-05-27 12:33:43 -0700 <rdar://problem/26522796> 1207760 3 282751 pvollan 2016-07-05 00:04:42 -0700 Created attachment 282751 Patch 1207764 4 pvollan 2016-07-05 00:26:17 -0700 (In reply to comment #3) > Created attachment 282751 [details] > Patch Another option is to add Windows specific test results, since Windows has enabled CSP_NEXT. 1207847 5 282751 bfulgham 2016-07-05 08:39:19 -0700 Comment on attachment 282751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282751&action=review Could you please generate a Windows result with CSP_NEXT active instead of turning off the feature? > ChangeLog:8 > + Disable CSP_NEXT. We can then use the common expected test results for this test. We should leave it activated, and provide a test result. We want CSP_NEXT available on Windows, just like it is on Mac/iOS. > Source/cmake/OptionsWin.cmake:13 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSP_NEXT PUBLIC OFF) I don't like this change. We should keep CSP_NEXT activated and just provide a test result so we can confirm it functions properly. 1207855 6 pvollan 2016-07-05 08:52:32 -0700 (In reply to comment #5) > Comment on attachment 282751 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282751&action=review > > Could you please generate a Windows result with CSP_NEXT active instead of > turning off the feature? > > > ChangeLog:8 > > + Disable CSP_NEXT. We can then use the common expected test results for this test. > > We should leave it activated, and provide a test result. We want CSP_NEXT > available on Windows, just like it is on Mac/iOS. > > > Source/cmake/OptionsWin.cmake:13 > > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSP_NEXT PUBLIC OFF) > > I don't like this change. We should keep CSP_NEXT activated and just provide > a test result so we can confirm it functions properly. Thanks for reviewing! I'll add Windows test results instead :) I have probably got this all wrong, but it seems to me that CSP_NEXT is disabled on Mac? The Mac test expectations also seem to indicate this. 1207954 7 bfulgham 2016-07-05 15:22:12 -0700 (In reply to comment #6) > (In reply to comment #5) > > Comment on attachment 282751 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=282751&action=review > > > > Could you please generate a Windows result with CSP_NEXT active instead of > > turning off the feature? > > > > > ChangeLog:8 > > > + Disable CSP_NEXT. We can then use the common expected test results for this test. > > > > We should leave it activated, and provide a test result. We want CSP_NEXT > > available on Windows, just like it is on Mac/iOS. > > > > > Source/cmake/OptionsWin.cmake:13 > > > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSP_NEXT PUBLIC OFF) > > > > I don't like this change. We should keep CSP_NEXT activated and just provide > > a test result so we can confirm it functions properly. > > Thanks for reviewing! > > I'll add Windows test results instead :) > > I have probably got this all wrong, but it seems to me that CSP_NEXT is > disabled on Mac? The Mac test expectations also seem to indicate this. No! I'm wrong. I just looked at the Mac build configuration and CSP_NEXT is definitely turned off. I was confused because Dan has been moving things out of CSP_NEXT as we've been adding support for CSP 2.0, and I thought for some reason that CSP_NEXT was turned on as well. Go ahead and deactivate CSP_NEXT on Windows. 1208079 8 pvollan 2016-07-05 22:55:38 -0700 Thanks, Brent! 1208080 9 pvollan 2016-07-05 22:56:39 -0700 Committed r202848: <https://trac.webkit.org/changeset/202848> 282751 2016-07-05 00:04:42 -0700 2016-07-05 15:22:30 -0700 Patch bug-147646-20160705000516.patch text/plain 4112 pvollan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjgx MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA3 LTA0ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2lu XSBMYXlvdXQgVGVzdCBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9z b3VyY2UtbGlzdC1wYXJzaW5nLTEwLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NjQ2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlzYWJsZSBDU1BfTkVYVC4gV2UgY2FuIHRo ZW4gdXNlIHRoZSBjb21tb24gZXhwZWN0ZWQgdGVzdCByZXN1bHRzIGZvciB0aGlzIHRlc3QuIAor CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2U6CisKIDIwMTYtMDctMDMg IERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbWGNvZGVdIFdpdGgg ZGVmYXVsdCB2ZXJib3NpdHksIG1ha2UoMSkgb3V0cHV0IG5vIGxvbmdlciBoaWRlcyBlbnZpcm9u bWVudCB2YXJpYWJsZSBsaXN0aW5ncwpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNzk4KQor KysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTYtMDctMDQgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisg ICAgICAgIFtXaW5dIExheW91dCBUZXN0IGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3Vy aXR5UG9saWN5L3NvdXJjZS1saXN0LXBhcnNpbmctMTAuaHRtbCBpcyBmYWlsaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc2NDYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYnVpbGQgZXJyb3Ig d2hlbiBDU1BfTkVYVCBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLmNw cDoKKwogMjAxNi0wNy0wMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgU3luY2hyb25vdXMgcHJlZmxpZ2h0IGNoZWNrZXIgc2hvdWxkIHNldCBsb2FkaW5nIG9w dGlvbnMgdG8gbm90IHVzZSBjcmVkZW50aWFscwpJbmRleDogU291cmNlL1dlYkNvcmUvRGVyaXZl ZFNvdXJjZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2Vz LmNwcAkocmV2aXNpb24gMjAyNzk4KQorKysgU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjEsOSArNDIxLDcgQEAKICNpbmNsdWRlICJKU1JUQ1Ry YWNrRXZlbnQuY3BwIgogI2luY2x1ZGUgIkpTU2NyZWVuLmNwcCIKICNpbmNsdWRlICJKU1Njcmlw dFByb2Nlc3Nvck5vZGUuY3BwIgotI2lmIEVOQUJMRShDU1BfTkVYVCkKICNpbmNsdWRlICJKU1Nl Y3VyaXR5UG9saWN5VmlvbGF0aW9uRXZlbnQuY3BwIgotI2VuZGlmCiAjaW5jbHVkZSAiSlNTb3Vy Y2VCdWZmZXIuY3BwIgogI2luY2x1ZGUgIkpTU291cmNlQnVmZmVyTGlzdC5jcHAiCiAjaW5jbHVk ZSAiSlNTb3VyY2VJbmZvLmNwcCIKSW5kZXg6IFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtl Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCShyZXZpc2lvbiAy MDI3OTgpCisrKyBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZQkod29ya2luZyBjb3B5KQpA QCAtMTAsNyArMTAsNyBAQCBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf CiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ0FOVkFTX1BBVEggUFVC TElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NBTlZBU19Q Uk9YWSBQVUJMSUMgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxF X0NIQU5ORUxfTUVTU0FHSU5HIFBVQkxJQyBPTikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9DU1BfTkVYVCBQVUJMSUMgT04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRf UE9SVF9WQUxVRShFTkFCTEVfQ1NQX05FWFQgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05fREVG QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1MzX1RFWFQgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUsgUFVC TElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19DT01Q T1NJVElORyBQVUJMSUMgT0ZGKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyODAyKQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDct MDQgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d IExheW91dCBUZXN0IGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L3Nv dXJjZS1saXN0LXBhcnNpbmctMTAuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc2NDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGVzdCBleHBlY3RhdGlvbnMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNi0wNy0wNCAg UGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIFdp bmRvd3MgdGVzdCBleHBlY3RhdGlvbnMgZm9yIGZhc3QvY3NzL2ZvbnRsb2FkZXItZG93bmxvYWQt ZXJyb3IuaHRtbC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRp b25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRp b25zCShyZXZpc2lvbiAyMDI4MDIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vVGVzdEV4 cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMjE4MSw3ICsyMTgxLDYgQEAgaHR0cC90ZXN0 cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpYwogaHR0cC90ZXN0cy9zZWN1cml0eS9jb250 ZW50U2VjdXJpdHlQb2xpY3kvb2JqZWN0LXNyYy11cmwtYWxsb3dlZC5odG1sIFsgRmFpbHVyZSBd CiBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9vYmplY3Qtc3JjLXVy bC1ibG9ja2VkLmh0bWwgWyBGYWlsdXJlIF0KIGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNl Y3VyaXR5UG9saWN5L3NjcmlwdC1zcmMtc3Rhci1jcm9zcy1zY2hlbWUuaHRtbCBbIEZhaWx1cmUg XQotd2Via2l0Lm9yZy9iLzE0NzY0NiBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0 eVBvbGljeS9zb3VyY2UtbGlzdC1wYXJzaW5nLTEwLmh0bWwgWyBGYWlsdXJlIF0KIAogIyBDcmFz aGVzCiBodHRwL3Rlc3RzL21pc2MvZHJhZy1ub3QtbG9hZGVkLWltYWdlLmh0bWwgWyBTa2lwIF0g IyBDcmFzaAo=