147643 2015-08-04 12:00:37 -0700 Render to GraphicsContext MediaPlayerPrivateMediaStreamAVFObjC 2015-08-04 13:39:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED PlatformOnly P2 Normal --- 1 mdaiter mdaiter bfulgham commit-queue eric.carlson jeremyj-wk jer.noble jonlee mdaiter webkit-bug-importer webkit.review.bot oldest_to_newest 1114687 0 mdaiter 2015-08-04 12:00:37 -0700 Really, painting a MediaStream is just painting a MediaStream in a currentFrameInContext. So we feed in the parameters from paint() to paintCurrentFrameInContext(). 1114688 1 258196 mdaiter 2015-08-04 12:03:25 -0700 Created attachment 258196 Patch 1114706 2 258196 eric.carlson 2015-08-04 12:23:12 -0700 Comment on attachment 258196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258196&action=review > Source/WebCore/ChangeLog:3 > + Need to pipe paint() into paintCurrentFrameInContext() for MediaStream Please use the actual bug title. 1114709 3 258196 commit-queue 2015-08-04 12:27:21 -0700 Comment on attachment 258196 Patch Rejecting attachment 258196 from commit-queue. mdaiter@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1114721 4 258196 eric.carlson 2015-08-04 12:57:31 -0700 Comment on attachment 258196 Patch Please update the title in the ChangeLog 1114723 5 258200 mdaiter 2015-08-04 12:59:40 -0700 Created attachment 258200 Patch 1114725 6 258196 mdaiter 2015-08-04 13:00:00 -0700 Comment on attachment 258196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258196&action=review >> Source/WebCore/ChangeLog:3 >> + Need to pipe paint() into paintCurrentFrameInContext() for MediaStream > > Please use the actual bug title. Fixed. 1114736 7 258200 commit-queue 2015-08-04 13:24:30 -0700 Comment on attachment 258200 Patch Rejecting attachment 258200 from commit-queue. mdaiter@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1114747 8 258200 commit-queue 2015-08-04 13:39:18 -0700 Comment on attachment 258200 Patch Clearing flags on attachment: 258200 Committed r187884: <http://trac.webkit.org/changeset/187884> 1114748 9 commit-queue 2015-08-04 13:39:22 -0700 All reviewed patches have been landed. Closing bug. 258196 2015-08-04 12:03:25 -0700 2015-08-04 12:59:37 -0700 Patch bug-147643-20150804120318.patch text/plain 1741 mdaiter U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjYxNDE5YmZkYzA5NjVl NzAwYWJhMzgyMzZlNzMwYWMyOWUwNTUxOC4uMWE0M2UzNDgwNzE5ZmVkYTQwMWUzYzFhZDJjNTQ2 MTAyN2Y4M2Y2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4LTA0ICBNYXR0 aGV3IERhaXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgorCisgICAgICAgIE5lZWQgdG8gcGlwZSBw YWludCgpIGludG8gcGFpbnRDdXJyZW50RnJhbWVJbkNvbnRleHQoKSBmb3IgTWVkaWFTdHJlYW0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzY0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJl YW1BVkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFT dHJlYW1BVkZPYmpDOjpwYWludCk6CisKIDIwMTUtMDgtMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBFbmFibGUgV2ViR0wgb24gV2luZG93 cyBDTWFrZSBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2Jq Qy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5tbQppbmRleCAzN2YxMGM2MmRl MDc3Yjc2NzBkMDg2MGUxOWY1NDk1YzhkY2JiYjM4Li44Y2NiNjM3NzFkOWIwNjEzOWQ4MmYxYjU2 OTRmZDUwYWQ4ZjljMWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9i akMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDLm1tCkBAIC0zNDUsOSAr MzQ1LDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6OnNldFNp emUoY29uc3QgSW50U2l6ZSYpCiAgICAgLy8gTm8tb3AuCiB9CiAKLXZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjpwYWludChHcmFwaGljc0NvbnRleHQqLCBjb25zdCBG bG9hdFJlY3QmKQordm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6OnBh aW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiByZWN0KQogewot ICAgIC8vIEZJWE1FKDEyNTE1Nyk6IEltcGxlbWVudCBwYWludGluZy4KKyAgICBwYWludEN1cnJl bnRGcmFtZUluQ29udGV4dChjb250ZXh0LCByZWN0KTsKIH0KIAogdm9pZCBNZWRpYVBsYXllclBy aXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6OnBhaW50Q3VycmVudEZyYW1lSW5Db250ZXh0KEdyYXBo aWNzQ29udGV4dCosIGNvbnN0IEZsb2F0UmVjdCYpCg== 258200 2015-08-04 12:59:40 -0700 2015-08-04 13:39:18 -0700 Patch bug-147643-20150804125933.patch text/plain 1733 mdaiter U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjYxNDE5YmZkYzA5NjVl NzAwYWJhMzgyMzZlNzMwYWMyOWUwNTUxOC4uYTExZTNhOGE3YWE4ZGEyYzZhNTI3MWNiY2U4YTI4 NjVkZTRmMzFlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4LTA0ICBNYXR0 aGV3IERhaXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmRlciB0byBHcmFw aGljc0NvbnRleHQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc2NDMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2Jq Qy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZG T2JqQzo6cGFpbnQpOgorCiAyMDE1LTA4LTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRW5hYmxlIFdlYkdMIG9uIFdpbmRvd3MgQ01ha2Ug YnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBs YXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW0KaW5kZXggMzdmMTBjNjJkZTA3N2I3Njcw ZDA4NjBlMTlmNTQ5NWM4ZGNiYmIzOC4uOGNjYjYzNzcxZDliMDYxMzlkODJmMWI1Njk0ZmQ1MGFk OGY5YzFhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDLm1tCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5tbQpAQCAtMzQ1LDkgKzM0NSw5IEBA IHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjpzZXRTaXplKGNvbnN0 IEludFNpemUmKQogICAgIC8vIE5vLW9wLgogfQogCi12b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhU3RyZWFtQVZGT2JqQzo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgRmxvYXRSZWN0 JikKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjpwYWludChHcmFw aGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKIHsKLSAgICAvLyBG SVhNRSgxMjUxNTcpOiBJbXBsZW1lbnQgcGFpbnRpbmcuCisgICAgcGFpbnRDdXJyZW50RnJhbWVJ bkNvbnRleHQoY29udGV4dCwgcmVjdCk7CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFTdHJlYW1BVkZPYmpDOjpwYWludEN1cnJlbnRGcmFtZUluQ29udGV4dChHcmFwaGljc0NvbnRl eHQqLCBjb25zdCBGbG9hdFJlY3QmKQo=