147627 2015-08-04 05:19:07 -0700 [CoordinatedGraphics] Fixed position element didn't make the compositing layer in WTR. 2015-09-23 22:56:08 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 147019 1 hs85.jeong hs85.jeong gyuyoung.kim lucas.de.marchi ossy simon.fraser thorton oldest_to_newest 1114595 0 hs85.jeong 2015-08-04 05:19:07 -0700 compositing/fixed-with-fixed-layout.html failed after r186911 because # 49 line in LayoutTests/compositing/fixed-with-fixed-layout.html if (window.internals) { internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true); 'internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true)' didn't work properly in WTR. CoordinatedGrapihcs set the 'AcceleratedCompositingForFixedPosition' in WebPage::setUseFixedLayout normally. But only 'frameView->setUseFixedLayout()' was invoked in WTR if I use the 'internals.settings.setAcceleratedCompositingForFixedPositionEnabled' in test. So we need to set the AcceleratedCompositingForFixedPositionEnabled in Internals::setUseFixedLayout() to work correctly. 1114596 1 258171 hs85.jeong 2015-08-04 05:27:38 -0700 Created attachment 258171 Patch 1114610 2 ossy 2015-08-04 07:56:39 -0700 I have some questions about this change: - How does this change affect the layout test results? - Will we have more passing tests? If yes, we should unskip them. - Do we reset this setting to the default between each test? 1114612 3 258171 simon.fraser 2015-08-04 08:37:06 -0700 Comment on attachment 258171 Patch I don't think this makes sense. fixed layout and these two settings should be orthogonal. 1114650 4 thorton 2015-08-04 11:07:06 -0700 (In reply to comment #3) > Comment on attachment 258171 [details] > Patch > > I don't think this makes sense. fixed layout and these two settings should > be orthogonal. Right. This: > CoordinatedGrapihcs set the 'AcceleratedCompositingForFixedPosition' in WebPage::setUseFixedLayout normally. Is totally bizarre and wrong, and needs fixing/deconflating. 1114941 5 hs85.jeong 2015-08-04 19:32:11 -0700 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 258171 [details] > > Patch > > > > I don't think this makes sense. fixed layout and these two settings should > > be orthogonal. > > Right. > > This: > > > CoordinatedGrapihcs set the 'AcceleratedCompositingForFixedPosition' in WebPage::setUseFixedLayout normally. > > Is totally bizarre and wrong, and needs fixing/deconflating. You mean, 'setAcceleratedCompositingForFixedPositionEnabled' & 'setFixedPositionCreatesStackingContext' isn't related with fixedLayout? Now CoordinatedGraphics turn on these options in WebPage::setUseFixedLayout. On mac, these options was set in RemoteLayerTreeDrawingArea::updatePreferences. Could I separate these options from the fixedLayout? 1114969 6 hs85.jeong 2015-08-04 22:02:54 -0700 (In reply to comment #2) > I have some questions about this change: > - How does this change affect the layout test results? This patch can composite the layer for the element that has the fixed position. CoordinatedGraphics didn't composite the fixed position element in WTR. Is it expected result? > - Will we have more passing tests? If yes, we should unskip them. It makes about 30 tests passed, but sadly 200 more tests failed. If compositing the fixed position element is right, we need to rebaseline the expected results. > - Do we reset this setting to the default between each test? 1115068 7 thorton 2015-08-05 11:26:24 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Comment on attachment 258171 [details] > > > Patch > > > > > > I don't think this makes sense. fixed layout and these two settings should > > > be orthogonal. > > > > Right. > > > > This: > > > > > CoordinatedGrapihcs set the 'AcceleratedCompositingForFixedPosition' in WebPage::setUseFixedLayout normally. > > > > Is totally bizarre and wrong, and needs fixing/deconflating. > > You mean, 'setAcceleratedCompositingForFixedPositionEnabled' & > 'setFixedPositionCreatesStackingContext' isn't related with fixedLayout? Yes, that's what I mean. These are totally unrelated settings which the CoordinatedGraphics code for whatever reason conflates. > Now CoordinatedGraphics turn on these options in WebPage::setUseFixedLayout. > On mac, these options was set in > RemoteLayerTreeDrawingArea::updatePreferences. Turning it on in the drawing areas is still a little weird, but a thousand times better than turning it on because another unrelated setting (fixed layout) was turned on. > Could I separate these options from the fixedLayout? Could, and should! 1128443 8 hs85.jeong 2015-09-23 22:56:08 -0700 gyuyoung, Do you know the reason that setAcceleratedCompositingForFixedPositionEnabled() and setFixedPositionCreatesStackingContext() was tied with fixedLayout? In mac, set the setting values of FixedPositionCreatesStackingContext() and AcceleratedCompositingForFixedPositionEnabled() in updatePreferences() of the DrawingArea. I think CoordinatedGraphics also need to set the FixedPositionCreatesStackingContext and AcceleratedCompositingForFixedPositionEnabled with true for the fixed position element to composite the layer. If I move the setAcceleratedCompositingForFixedPositionEnabled() and setFixedPositionCreatesStackingContext() from WebPage::setUseFixedLayout() to CoordinatedDrawingArea::updatePreferences(), is it possible to make some problems? 258171 2015-08-04 05:27:38 -0700 2015-08-04 08:37:06 -0700 Patch bug-147627-20150804212730.patch text/plain 1744 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzNiMzQxOGIyOGFkOTE1 NWFmNTEzMzMxNWNlYTNkM2UxMzMyZGQ4ZS4uNzlhOTE0ZGM4MTk5MDc3ZTczZGYzYWFlM2E2Njdl NTQzMDBkMmE1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA4LTA0ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ29vcmRpbmF0 ZWRHcmFwaGljc10gc2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZvckZpeGVkUG9zaXRpb25FbmFi bGVkIGRpZG4ndCB3b3JrIHByb3Blcmx5IGluIFdUUi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzYyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENvb3JkaW5hdGVkR3JhcGhpY3MgbmVlZCB0byBzZXQg dGhlIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxlZCAmCisgICAg ICAgIEZpeGVkUG9zaXRpb25DcmVhdGVzU3RhY2tpbmdDb250ZXh0IGlmIHVzaW5nIHRoZSBmaXhl ZExheW91dCBpbiBXVFIuCisKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6OnNldFVzZUZpeGVkTGF5b3V0KToKKwogMjAxNS0wOC0w MSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBP biBzb21lIGNvbXBsZXggc2l0ZXMsIGlPUyBpbnN0YW50bHkgY3Jhc2hlcyBvbmNlIFZvaWNlT3Zl ciBpcyB0dXJuZWQgb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJu YWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAppbmRleCA1YTIy MGIxMmVjZDRjNDZmN2ExMDc1NWJhZGM2N2QyNThiM2E0NGFiLi5kMWIxMDE3MjViMmFiMWI5MzFj NWM3ZmUzYWU2Nzc4NjI3YjdmNTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3Bw CkBAIC0yMDMyLDYgKzIwMzIsMTQgQEAgdm9pZCBJbnRlcm5hbHM6OnNldFVzZUZpeGVkTGF5b3V0 KGJvb2wgdXNlRml4ZWRMYXlvdXQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgICAgICBlYyA9IElO VkFMSURfQUNDRVNTX0VSUjsKICAgICAgICAgcmV0dXJuOwogICAgIH0KKyNpZiBVU0UoQ09PUkRJ TkFURURfR1JBUEhJQ1MpCisgICAgaWYgKGRvY3VtZW50LT5wYWdlKCkpIHsKKyAgICAgICAgUGFn ZSogcGFnZSA9IGRvY3VtZW50LT5wYWdlKCk7CisKKyAgICAgICAgcGFnZS0+c2V0dGluZ3MoKS5z ZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQodXNlRml4ZWRM YXlvdXQpOworICAgICAgICBwYWdlLT5zZXR0aW5ncygpLnNldEZpeGVkUG9zaXRpb25DcmVhdGVz U3RhY2tpbmdDb250ZXh0KHVzZUZpeGVkTGF5b3V0KTsKKyAgICB9CisjZW5kaWYKICAgICBGcmFt ZVZpZXcqIGZyYW1lVmlldyA9IGRvY3VtZW50LT52aWV3KCk7CiAgICAgZnJhbWVWaWV3LT5zZXRV c2VGaXhlZExheW91dCh1c2VGaXhlZExheW91dCk7CiB9Cg==