147621 2015-08-04 00:50:33 -0700 [CoordinatedGraphics] Remove unused functions in Coordinated TiledBackingStore 2015-08-06 10:58:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cmarcelo commit-queue kondapallykalyan luiz noam ossy yoon oldest_to_newest 1114567 0 gyuyoung.kim 2015-08-04 00:50:33 -0700 I think we don't need to update tile size when new size is same with exist size. 1114568 1 258163 gyuyoung.kim 2015-08-04 00:51:38 -0700 Created attachment 258163 Patch 1114584 2 ossy 2015-08-04 03:25:36 -0700 (In reply to comment #0) > I think we don't need to update tile size when new size is same with exist > size. Does this case happen frequently? 1114943 3 gyuyoung.kim 2015-08-04 19:44:14 -0700 (In reply to comment #2) > (In reply to comment #0) > > I think we don't need to update tile size when new size is same with exist > > size. > > Does this case happen frequently? This case doesn't happen frequently honestly. But it seems to me that it would be good if this condition is added. 1115210 4 gyuyoung.kim 2015-08-05 18:09:03 -0700 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #0) > > > I think we don't need to update tile size when new size is same with exist > > > size. > > > > Does this case happen frequently? > > This case doesn't happen frequently honestly. But it seems to me that it > would be good if this condition is added. Ossy ping ? 1115326 5 258163 ossy 2015-08-06 04:35:19 -0700 Comment on attachment 258163 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258163&action=review > Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:58 > void TiledBackingStore::setTileSize(const IntSize& size) > { > + if (m_tileSize == size) > + return; > + > m_tileSize = size; > m_tiles.clear(); > } It seems setTileSize() is an unused function now and can be removed. :) Or do you plan to push patches in the future which rely on its functionality? 1115335 6 258363 gyuyoung.kim 2015-08-06 06:58:44 -0700 Created attachment 258363 Patch 1115336 7 gyuyoung.kim 2015-08-06 06:59:57 -0700 (In reply to comment #5) > Comment on attachment 258163 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258163&action=review > > > Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:58 > > void TiledBackingStore::setTileSize(const IntSize& size) > > { > > + if (m_tileSize == size) > > + return; > > + > > m_tileSize = size; > > m_tiles.clear(); > > } > > It seems setTileSize() is an unused function now and can be removed. :) > Or do you plan to push patches in the future which rely on its functionality? Ok, let's remove it. 1115370 8 258363 commit-queue 2015-08-06 10:58:25 -0700 Comment on attachment 258363 Patch Clearing flags on attachment: 258363 Committed r188046: <http://trac.webkit.org/changeset/188046> 1115371 9 commit-queue 2015-08-06 10:58:30 -0700 All reviewed patches have been landed. Closing bug. 258163 2015-08-04 00:51:38 -0700 2015-08-06 06:58:37 -0700 Patch bug-147621-20150804165131.patch text/plain 1567 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3ODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM4YThhMzIwYmY3NmI3 YWY0ZjIwY2ZhNTA0MjZhOTlhYjhkZmQ3My4uZGM1MmZmNWQ0ZDA4ZDY0YTRlMTE0MTZlOWMwNTJi MDlhZDYwZTEwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA4LTA0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbQ29vcmRpbmF0 ZWRHcmFwaGljc10gRG8gbm90IGNoYW5nZSB0aWxlIHNpemUgd2hlbiBuZXcgc2l6ZSBpcyBzYW1l IHdpdGggZXhpc3Rpbmcgb25lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDc2MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaWxlZEJhY2tpbmdTdG9yZTo6c2V0VGlsZVNpemUgaGFzIHVwZGF0ZWQgdGls ZSBzaXplIGV2ZW4gd2hlbiBuZXcgc2l6ZSBpcyBzYW1lIHdpdGggY3VycmVudAorICAgICAgICB0 aWxlIHNpemUuIEl0IHdhc3RlcyBjcHUgY3ljbGUgYW5kIHJlc2V0IHVubmVjZXNzYXJ5IFRpbGVN YXAgdmVjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL1RpbGVkQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkQmFja2lu Z1N0b3JlOjpzZXRUaWxlU2l6ZSk6CisKIDIwMTUtMDgtMDMgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHBvc3QtcmV2aWV3IGZl ZWRiYWNrIG9uIHIxODc3OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvVGlsZWRCYWNraW5n U3RvcmUuY3BwCmluZGV4IGNkODJjZmYwNGUwNmI4OGMzZGYxNDA4ZmZkNDBmY2MzNzQ0ODU3YjMu LjhjZGY1Y2JhNWU0MDEwYmViODkxZWU4OGI0ZTJkNzJlZWEyMjVhNTAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJh Y2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmNwcApAQCAtNTAsNiArNTAsOSBAQCBU aWxlZEJhY2tpbmdTdG9yZTo6flRpbGVkQmFja2luZ1N0b3JlKCkKIAogdm9pZCBUaWxlZEJhY2tp bmdTdG9yZTo6c2V0VGlsZVNpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkKIHsKKyAgICBpZiAobV90 aWxlU2l6ZSA9PSBzaXplKQorICAgICAgICByZXR1cm47CisKICAgICBtX3RpbGVTaXplID0gc2l6 ZTsKICAgICBtX3RpbGVzLmNsZWFyKCk7CiB9Cg== 258363 2015-08-06 06:58:44 -0700 2015-08-06 10:58:25 -0700 Patch bug-147621-20150806225834.patch text/plain 2226 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhkNTVhY2YzNWY5NTcx N2I1ZmVjOWZhOGIzZWJjNTU5M2MyNTcxZC4uNTk3NjkxYmFhMzdkYWFjNWExNGY2NGZiMGIyYjFm NThlMmE3YjYxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4LTA2ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbQ29vcmRpbmF0 ZWRHcmFwaGljc10gUmVtb3ZlIHVudXNlZCBmdW5jdGlvbnMgaW4gQ29vcmRpbmF0ZWQgVGlsZWRC YWNraW5nU3RvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NzYyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0 b3JlLmNwcDogUmVtb3ZlIHNldFRpbGVTaXplKCkgYW5kIHRpbGVTaXplKCkuCisgICAgICAgIChX ZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6c2V0VGlsZVNpemUpOgorCiAyMDE1LTA4LTA0ICBN YXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYSBTZXNzaW9uOiBw dXNoIHBhdXNlZCBzdGF0ZSB0byB0aGUgbWVkaWEgc2Vzc2lvbiBmb2N1cyBtYW5hZ2VyIGluc3Rl YWQgb2YgcG9sbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdTdG9y ZS5jcHAKaW5kZXggY2Q4MmNmZjA0ZTA2Yjg4YzNkZjE0MDhmZmQ0MGZjYzM3NDQ4NTdiMy4uMjc3 YzBjMTE4NDllMGRkMjUwNjU4NzcwODU5YjFhM2NmODI2M2ZlMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2lu Z1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv Y29vcmRpbmF0ZWQvVGlsZWRCYWNraW5nU3RvcmUuY3BwCkBAIC00OCwxMiArNDgsNiBAQCBUaWxl ZEJhY2tpbmdTdG9yZTo6flRpbGVkQmFja2luZ1N0b3JlKCkKIHsKIH0KIAotdm9pZCBUaWxlZEJh Y2tpbmdTdG9yZTo6c2V0VGlsZVNpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkKLXsKLSAgICBtX3Rp bGVTaXplID0gc2l6ZTsKLSAgICBtX3RpbGVzLmNsZWFyKCk7Ci19Ci0KIHZvaWQgVGlsZWRCYWNr aW5nU3RvcmU6OnNldFRyYWplY3RvcnlWZWN0b3IoY29uc3QgRmxvYXRQb2ludCYgdHJhamVjdG9y eVZlY3RvcikKIHsKICAgICBtX3BlbmRpbmdUcmFqZWN0b3J5VmVjdG9yID0gdHJhamVjdG9yeVZl Y3RvcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9jb29yZGluYXRlZC9UaWxlZEJhY2tpbmdTdG9yZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmgKaW5kZXgg YWY3MDc2OWRmYTczOTAwYzRiOGUxNGY5NTEzNzVhMWQxZDU1YzhkZC4uYTEzNjc1YTgxMDQwZjUx ZDdjNjM1NjVkYjczOWM5NmFlMmQ2NTZhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1RpbGVkQmFja2luZ1N0b3JlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL1Rp bGVkQmFja2luZ1N0b3JlLmgKQEAgLTUyLDkgKzUyLDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBp bnZhbGlkYXRlKGNvbnN0IEludFJlY3QmIGRpcnR5UmVjdCk7CiAKLSAgICBJbnRTaXplIHRpbGVT aXplKCkgeyByZXR1cm4gbV90aWxlU2l6ZTsgfQotICAgIHZvaWQgc2V0VGlsZVNpemUoY29uc3Qg SW50U2l6ZSYpOwotCiAgICAgSW50UmVjdCBtYXBUb0NvbnRlbnRzKGNvbnN0IEludFJlY3QmKSBj b25zdDsKICAgICBJbnRSZWN0IG1hcEZyb21Db250ZW50cyhjb25zdCBJbnRSZWN0JikgY29uc3Q7 CiAK