147618 2015-08-03 20:25:43 -0700 Clean up casts between NSFont*s and CTFontRefs 2015-08-03 20:34:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield oldest_to_newest 1114498 0 mmaxfield 2015-08-03 20:25:43 -0700 Clean up casts between NSFont*s and CTFontRefs 1114499 1 258147 mmaxfield 2015-08-03 20:26:47 -0700 Created attachment 258147 Patch 1114500 2 258147 mitz 2015-08-03 20:29:28 -0700 Comment on attachment 258147 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258147&action=review > Source/WebCore/ChangeLog:8 > + Mitz gives me permission to use C-style casts in this case. I don’t thin this line is necessary. You should simply name me as the reviewer > Source/WebKit/mac/ChangeLog:8 > + Mitz gives me permission to use C-style casts in this case. Ditto. 1114501 3 258148 mmaxfield 2015-08-03 20:30:09 -0700 Created attachment 258148 Patch 1114502 4 mmaxfield 2015-08-03 20:33:02 -0700 Committed r187805: <http://trac.webkit.org/changeset/187805> 258147 2015-08-03 20:26:47 -0700 2015-08-03 20:30:07 -0700 Patch bug-147618-20150803202641.patch text/plain 3583 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk1YzYxY2EyYWUwZWNk ZDEwNDBkZmNjNWM5NjBkZWRjZDM4MTQ5NS4uZGNlNmZlMTYxZTQ2YzFiZDQwYTZlZjMyMDljYzQ2 NzVjMzhhNmIwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTAzICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAg Y2FzdHMgYmV0d2VlbiBOU0ZvbnQqcyBhbmQgQ1RGb250UmVmcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NjE4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWl0eiBnaXZlcyBtZSBwZXJtaXNzaW9uIHRv IHVzZSBDLXN0eWxlIGNhc3RzIGluIHRoaXMgY2FzZS4KKworICAgICAgICBObyBuZXcgdGVzdHMg YmVjYXVzZSB0aGVyZSBpcyBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9Gb250UGxhdGZvcm1EYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxh dGZvcm1EYXRhOjpuc0ZvbnQpOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6 aGFzaCk6CisKIDIwMTUtMDgtMDMgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxODc3MDcsIHIxODc3MDks IHIxODc3MjQsIGFuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmluZGV4IDc4YmE5MDAzZWIxMzZhMzdkM2JiYzI1 YzZlOWY5Yjk0NTJmY2Y1NGMuLjJiZWM1ZGI4ZTc1ODZhNzExYjUzM2Q1YTIzYWUwMDllNzJiOTc3 M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxNS0wOC0wMyAgTXlsZXMg Qy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCisgICAgICAgIENsZWFuIHVwIGNh c3RzIGJldHdlZW4gTlNGb250KnMgYW5kIENURm9udFJlZnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzYxOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pdHogZ2l2ZXMgbWUgcGVybWlzc2lvbiB0byB1 c2UgQy1zdHlsZSBjYXN0cyBpbiB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhU TUxWaWV3Lm1tOgorICAgICAgICAoLVtXZWJIVE1MVmlldyBfdXBkYXRlRm9udFBhbmVsXSk6CisK KzIwMTUtMDgtMDMgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKwog ICAgICAgICBGaXggdGhlIFlvc2VtaXRlIGJ1aWxkIGFmdGVyIHIxODc3OTcKIAogICAgICAgICBV bnJldmlld2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Rm9udFBsYXRmb3JtRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9u dFBsYXRmb3JtRGF0YS5oCmluZGV4IGQ2ZTQ1YjE5YmUxYmFkNjE2YjA4MTQ0Nzc5YWQ0ZTZhMmU1 YmY5OTIuLjk3ODdhMzc0YmJhMWY4Zjk5NmRjMzk0ZGZlNzZkYmRjOGIyMmY0OGYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRQbGF0Zm9ybURhdGEuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1EYXRhLmgK QEAgLTExOSw3ICsxMTksNyBAQCBwdWJsaWM6CiAKICNpZiBVU0UoQVBQS0lUKQogICAgIC8vIEZJ WE1FOiBSZW1vdmUgdGhpcyB3aGVuIGFsbCBOU0ZvbnQgdXNhZ2UgaXMgcmVtb3ZlZC4KLSAgICBO U0ZvbnQgKm5zRm9udCgpIGNvbnN0IHsgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8TlNGb250ICo+ KGNvbnN0X2Nhc3Q8X19DVEZvbnQqPihtX2ZvbnQuZ2V0KCkpKTsgfQorICAgIE5TRm9udCAqbnNG b250KCkgY29uc3QgeyByZXR1cm4gKE5TRm9udCAqKW1fZm9udC5nZXQoKTsgfQogICAgIHZvaWQg c2V0TlNGb250KE5TRm9udCAqZm9udCkgeyBzZXRGb250KHJlaW50ZXJwcmV0X2Nhc3Q8Q1RGb250 UmVmPihmb250KSk7IH0KICNlbmRpZgogI2VuZGlmCkBAIC0xNTMsNyArMTUzLDcgQEAgcHVibGlj OgogICAgICAgICBBU1NFUlQobV9mb250IHx8ICFtX2NnRm9udCB8fCBpc0Vtb2ppKCkpOwogICAg ICAgICB1aW50cHRyX3QgZmxhZ3MgPSBzdGF0aWNfY2FzdDx1aW50cHRyX3Q+KG1faXNIYXNoVGFi bGVEZWxldGVkVmFsdWUgPDwgNCB8IGlzRW1vamkoKSA8PCAzIHwgbV9vcmllbnRhdGlvbiA8PCAy IHwgbV9zeW50aGV0aWNCb2xkIDw8IDEgfCBtX3N5bnRoZXRpY09ibGlxdWUpOwogI2lmIFVTRShB UFBLSVQpCi0gICAgICAgIHVpbnRwdHJfdCBmb250SGFzaCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dWlu dHB0cl90Pihjb25zdF9jYXN0PF9fQ1RGb250Kj4obV9mb250LmdldCgpKSk7CisgICAgICAgIHVp bnRwdHJfdCBmb250SGFzaCA9ICh1aW50cHRyX3QpbV9mb250LmdldCgpOwogI2Vsc2UKICAgICAg ICAgdWludHB0cl90IGZvbnRIYXNoID0gcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KENGSGFz aChtX2ZvbnQuZ2V0KCkpKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJIVE1MVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRN TFZpZXcubW0KaW5kZXggMjM0ZThhYjRlZmRkMTk4MTMyMzA1OWZmMDk4YjcwNjY3ODQ3NTY1MC4u ZDM1ZTBhZTE3OThlZDg0NDJhMDM4NWIyNTQxYzU3M2QzNzQ1MjQ3MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCkBAIC01NDg1LDcgKzU0ODUsNyBAQCAtICh2b2lk KV91cGRhdGVGb250UGFuZWwKICAgICBOU0RpY3Rpb25hcnkgKmF0dHJpYnV0ZXMgPSBuaWw7CiAg ICAgaWYgKEZyYW1lKiBjb3JlRnJhbWUgPSBjb3JlKFtzZWxmIF9mcmFtZV0pKSB7CiAgICAgICAg IGlmIChjb25zdCBGb250KiBmZCA9IGNvcmVGcmFtZS0+ZWRpdG9yKCkuZm9udEZvclNlbGVjdGlv bihtdWx0aXBsZUZvbnRzKSkKLSAgICAgICAgICAgIGZvbnQgPSByZWludGVycHJldF9jYXN0PE5T Rm9udCAqPihjb25zdF9jYXN0PF9fQ1RGb250Kj4oZmQtPnBsYXRmb3JtRGF0YSgpLmFjdGl2YXRl ZEZvbnQoKSkpOworICAgICAgICAgICAgZm9udCA9IChOU0ZvbnQgKilmZC0+cGxhdGZvcm1EYXRh KCkuYWN0aXZhdGVkRm9udCgpOwogICAgICAgICBhdHRyaWJ1dGVzID0gY29yZUZyYW1lLT5lZGl0 b3IoKS5mb250QXR0cmlidXRlc0ZvclNlbGVjdGlvblN0YXJ0KCk7CiAgICAgfQogCg== 258148 2015-08-03 20:30:09 -0700 2015-08-03 20:34:37 -0700 Patch bug-147618-20150803203003.patch text/plain 3711 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk1YzYxY2EyYWUwZWNk ZDEwNDBkZmNjNWM5NjBkZWRjZDM4MTQ5NS4uM2JjZTM5NzVmZDdjMjk5MGUxMzhhNzQ4ZjEyNWI1 YWVkODcxYjMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA4LTAzICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAg Y2FzdHMgYmV0d2VlbiBOU0ZvbnQqcyBhbmQgQ1RGb250UmVmcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NjE4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIHRvbGwgZnJlZSBicmlkZ2VkIHR5cGVz LCBpdCBtYWtlcyBtb3JlIHNlbnNlIHRvIGRvIGEgQy1zdHlsZSBjYXN0LCB0aGFuIGp1bXAKKyAg ICAgICAgdGhyb3VnaCBob29wcyBmb3Igb2xkZXIgY29tcGlsZXJzCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvRm9udFBsYXRmb3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6 Rm9udFBsYXRmb3JtRGF0YTo6bnNGb250KToKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9y bURhdGE6Omhhc2gpOgorCiAyMDE1LTA4LTAzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVA d2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTg3NzA3LCBy MTg3NzA5LCByMTg3NzI0LCBhbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCA3OGJhOTAwM2ViMTM2YTM3 ZDNiYmMyNWM2ZTlmOWI5NDUyZmNmNTRjLi43Yzc4NmMzMzFkYjcxZWU1YWRlYjIxYTYyOTA2N2U1 Y2M3NGFkMWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTUtMDgtMDMg IE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAorICAgICAgICBDbGVh biB1cCBjYXN0cyBiZXR3ZWVuIE5TRm9udCpzIGFuZCBDVEZvbnRSZWZzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc2MTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgdG9sbCBmcmVlIGJyaWRnZWQg dHlwZXMsIGl0IG1ha2VzIG1vcmUgc2Vuc2UgdG8gZG8gYSBDLXN0eWxlIGNhc3QsIHRoYW4ganVt cAorICAgICAgICB0aHJvdWdoIGhvb3BzIGZvciBvbGRlciBjb21waWxlcnMKKworICAgICAgICAq IFdlYlZpZXcvV2ViSFRNTFZpZXcubW06CisgICAgICAgICgtW1dlYkhUTUxWaWV3IF91cGRhdGVG b250UGFuZWxdKToKKworMjAxNS0wOC0wMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRA YXBwbGUuY29tPgorCiAgICAgICAgIEZpeCB0aGUgWW9zZW1pdGUgYnVpbGQgYWZ0ZXIgcjE4Nzc5 NwogCiAgICAgICAgIFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1EYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9Gb250UGxhdGZvcm1EYXRhLmgKaW5kZXggZDZlNDViMTliZTFiYWQ2MTZiMDgx NDQ3NzlhZDRlNmEyZTViZjk5Mi4uOTc4N2EzNzRiYmExZjhmOTk2ZGMzOTRkZmU3NmRiZGM4YjIy ZjQ4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFBs YXRmb3JtRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRQ bGF0Zm9ybURhdGEuaApAQCAtMTE5LDcgKzExOSw3IEBAIHB1YmxpYzoKIAogI2lmIFVTRShBUFBL SVQpCiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIHdoZW4gYWxsIE5TRm9udCB1c2FnZSBpcyBy ZW1vdmVkLgotICAgIE5TRm9udCAqbnNGb250KCkgY29uc3QgeyByZXR1cm4gcmVpbnRlcnByZXRf Y2FzdDxOU0ZvbnQgKj4oY29uc3RfY2FzdDxfX0NURm9udCo+KG1fZm9udC5nZXQoKSkpOyB9Cisg ICAgTlNGb250ICpuc0ZvbnQoKSBjb25zdCB7IHJldHVybiAoTlNGb250ICopbV9mb250LmdldCgp OyB9CiAgICAgdm9pZCBzZXROU0ZvbnQoTlNGb250ICpmb250KSB7IHNldEZvbnQocmVpbnRlcnBy ZXRfY2FzdDxDVEZvbnRSZWY+KGZvbnQpKTsgfQogI2VuZGlmCiAjZW5kaWYKQEAgLTE1Myw3ICsx NTMsNyBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVChtX2ZvbnQgfHwgIW1fY2dGb250IHx8IGlz RW1vamkoKSk7CiAgICAgICAgIHVpbnRwdHJfdCBmbGFncyA9IHN0YXRpY19jYXN0PHVpbnRwdHJf dD4obV9pc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSA8PCA0IHwgaXNFbW9qaSgpIDw8IDMgfCBtX29y aWVudGF0aW9uIDw8IDIgfCBtX3N5bnRoZXRpY0JvbGQgPDwgMSB8IG1fc3ludGhldGljT2JsaXF1 ZSk7CiAjaWYgVVNFKEFQUEtJVCkKLSAgICAgICAgdWludHB0cl90IGZvbnRIYXNoID0gcmVpbnRl cnByZXRfY2FzdDx1aW50cHRyX3Q+KGNvbnN0X2Nhc3Q8X19DVEZvbnQqPihtX2ZvbnQuZ2V0KCkp KTsKKyAgICAgICAgdWludHB0cl90IGZvbnRIYXNoID0gKHVpbnRwdHJfdCltX2ZvbnQuZ2V0KCk7 CiAjZWxzZQogICAgICAgICB1aW50cHRyX3QgZm9udEhhc2ggPSByZWludGVycHJldF9jYXN0PHVp bnRwdHJfdD4oQ0ZIYXNoKG1fZm9udC5nZXQoKSkpOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJIVE1MVmlldy5tbQppbmRleCAyMzRlOGFiNGVmZGQxOTgxMzIzMDU5ZmYwOThi NzA2Njc4NDc1NjUwLi5kMzVlMGFlMTc5OGVkODQ0MmEwMzg1YjI1NDFjNTczZDM3NDUyNDcyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KQEAgLTU0ODUsNyArNTQ4 NSw3IEBAIC0gKHZvaWQpX3VwZGF0ZUZvbnRQYW5lbAogICAgIE5TRGljdGlvbmFyeSAqYXR0cmli dXRlcyA9IG5pbDsKICAgICBpZiAoRnJhbWUqIGNvcmVGcmFtZSA9IGNvcmUoW3NlbGYgX2ZyYW1l XSkpIHsKICAgICAgICAgaWYgKGNvbnN0IEZvbnQqIGZkID0gY29yZUZyYW1lLT5lZGl0b3IoKS5m b250Rm9yU2VsZWN0aW9uKG11bHRpcGxlRm9udHMpKQotICAgICAgICAgICAgZm9udCA9IHJlaW50 ZXJwcmV0X2Nhc3Q8TlNGb250ICo+KGNvbnN0X2Nhc3Q8X19DVEZvbnQqPihmZC0+cGxhdGZvcm1E YXRhKCkuYWN0aXZhdGVkRm9udCgpKSk7CisgICAgICAgICAgICBmb250ID0gKE5TRm9udCAqKWZk LT5wbGF0Zm9ybURhdGEoKS5hY3RpdmF0ZWRGb250KCk7CiAgICAgICAgIGF0dHJpYnV0ZXMgPSBj b3JlRnJhbWUtPmVkaXRvcigpLmZvbnRBdHRyaWJ1dGVzRm9yU2VsZWN0aW9uU3RhcnQoKTsKICAg ICB9CiAK