14761 2007-07-24 22:01:48 -0700 Web Inspector leaks JS objects and DOM nodes 2007-11-15 22:16:17 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 1 john timothy aroben timothy oldest_to_newest 3756 0 john 2007-07-24 22:01:48 -0700 Open any page, right click Inspect Element, close both windows. Lots of items will not be garbage collected (heap.numLiveObjects will be large). You can repeat and the number will continue to grow. InspectorController::m_scriptObject is never unprotected, because the call to JSObjectSetPrivate() in the InspectorController destructor causes unloading() to never call windowUnloading(). A Fix: In InspectorController.cpp, InspectorController destructor, move: m_client->inspectorDestroyed(); before: if (m_scriptContext) { and remove: m_client->closeWindow(); It seems to fix the leak and things seem to still work, but I've been playing with the WebKit code for less than a day, so who knows? 61376 1 17312 timothy 2007-11-15 22:04:04 -0800 Created attachment 17312 Patch 61378 2 17312 mrowe 2007-11-15 22:12:46 -0800 Comment on attachment 17312 Patch r=me, but "Zero" should be "zero" in the changelog. 61382 3 timothy 2007-11-15 22:16:17 -0800 Landed in r27839. http://trac.webkit.org/projects/webkit/changeset/27839 17312 2007-11-15 22:04:04 -0800 2007-11-15 22:12:46 -0800 Patch 14761.patch text/plain 1765 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODM0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTEt MTUgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxNDc2MTogV2ViIEluc3BlY3Rv ciBsZWFrcyBKUyBvYmplY3RzIGFuZCBET00gbm9kZXMKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NjEKKworICAgICAgICAqIHBhZ2UvSW5zcGVjdG9y Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjp+ SW5zcGVjdG9yQ29udHJvbGxlcik6CisgICAgICAgIENoYW5nZSB0aGUgdGVhciBkb3duIG9yZGVy IHNvIHRoYXQgaW5zcGVjdG9yRGVzdHJveWVkKCkgaXMgY2FsbGVkIGJlZm9yZQorICAgICAgICBJ bnNwZWN0b3JDb250cm9sbGVyIHByaXZhdGUgZGF0YSBpcyBzZXQgdG8gWmVyby4gVGhlIGluc3Bl Y3RvckRlc3Ryb3llZCgpCisgICAgICAgIGNhbGwgZW5kcyB1cCBjbG9zaW5nIHRoZSBXZWJWaWV3 IGFuZCB0cmlnZ2VyaW5nIEluc3BlY3RvckNvbnRyb2xsZXI6OmNsb3NlKCkKKyAgICAgICAgd2hp Y2ggdW5wcm90ZWN0cyBtX3NjcmlwdE9iamVjdC4gVGhpcyBkaWRuJ3QgaGFwcGVuIHdoZW4gdGhl IHByaXZhdGUgZGF0YQorICAgICAgICB3YXMgY2xlYXJlZCBiZWZvcmUgY2FsbGluZyBpbnNwZWN0 b3JEZXN0cm95ZWQoKS4KKwogMjAwNy0xMS0xNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlIGFuZCBTYW0uCkluZGV4 OiBwYWdlL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvSW5zcGVj dG9yQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDI3ODM0KQorKysgcGFnZS9JbnNwZWN0b3JDb250 cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTYxLDYgKzU2MSw4IEBAIEluc3BlY3RvckNv bnRyb2xsZXI6Okluc3BlY3RvckNvbnRyb2xsZXIKIAogSW5zcGVjdG9yQ29udHJvbGxlcjo6fklu c3BlY3RvckNvbnRyb2xsZXIoKQogeworICAgIG1fY2xpZW50LT5pbnNwZWN0b3JEZXN0cm95ZWQo KTsKKwogICAgIGlmIChtX3NjcmlwdENvbnRleHQpIHsKICAgICAgICAgSlNPYmplY3RSZWYgZ2xv YmFsID0gSlNDb250ZXh0R2V0R2xvYmFsT2JqZWN0KG1fc2NyaXB0Q29udGV4dCk7CiAgICAgICAg IEpTU3RyaW5nUmVmIGNvbnRyb2xsZXJQcm9wZXJ0eSA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhD U3RyaW5nKCJJbnNwZWN0b3JDb250cm9sbGVyIik7CkBAIC01NjksOSArNTcxLDYgQEAgSW5zcGVj dG9yQ29udHJvbGxlcjo6fkluc3BlY3RvckNvbnRyb2xsZQogICAgICAgICBKU09iamVjdFNldFBy aXZhdGUoY29udHJvbGxlciwgMCk7CiAgICAgfQogCi0gICAgbV9jbGllbnQtPmNsb3NlV2luZG93 KCk7Ci0gICAgbV9jbGllbnQtPmluc3BlY3RvckRlc3Ryb3llZCgpOwotCiAgICAgaWYgKG1fcGFn ZSkKICAgICAgICAgbV9wYWdlLT5zZXRQYXJlbnRJbnNwZWN0b3JDb250cm9sbGVyKDApOwogCg==