147581 2015-08-03 12:38:34 -0700 Clean up the naming for AST expression generation. 2015-08-03 13:48:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller webkit-unassigned commit-queue oldest_to_newest 1114302 0 keith_miller 2015-08-03 12:38:34 -0700 Currently, some of the AST expression factory creation functions do not follow a consistent naming scheme, we should fix it. 1114305 1 258098 keith_miller 2015-08-03 12:42:40 -0700 Created attachment 258098 Patch 1114310 2 258098 ysuzuki 2015-08-03 12:57:39 -0700 Comment on attachment 258098 Patch r+ 1114337 3 258098 commit-queue 2015-08-03 13:48:05 -0700 Comment on attachment 258098 Patch Clearing flags on attachment: 258098 Committed r187760: <http://trac.webkit.org/changeset/187760> 1114338 4 commit-queue 2015-08-03 13:48:07 -0700 All reviewed patches have been landed. Closing bug. 258098 2015-08-03 12:42:40 -0700 2015-08-03 13:48:05 -0700 Patch 0001-Clean-up-the-naming-for-AST-expression-generation.patch text/plain 5709 keith_miller RnJvbSAwZjk4OWJhODQzNmIzYmIwZDViOTg0NDI2YmYzNjYyNWQ3NDFhM2Q2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZWl0aCBNaWxsZXIgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+ CkRhdGU6IE1vbiwgMyBBdWcgMjAxNSAxMjo0MDozOCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIENs ZWFuIHVwIHRoZSBuYW1pbmcgZm9yIEFTVCBleHByZXNzaW9uIGdlbmVyYXRpb24uCgotLS0KIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgIHwgMjUgKysrKysrKysr KysrKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVy LmggICAgfCAgNiArKystLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNw cCAgICAgIHwgIDYgKysrLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1N5bnRheENo ZWNrZXIuaCB8ICA2ICsrKy0tLQogNCBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ5ZGEzZjUuLjcyNmU4 ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA4LTAz ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIENsZWFu IHVwIHRoZSBuYW1pbmcgZm9yIEFTVCBleHByZXNzaW9uIGdlbmVyYXRpb24uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc1ODEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhcnNlci9BU1RCdWlsZGVy Lmg6CisgICAgICAgIChKU0M6OkFTVEJ1aWxkZXI6OmNyZWF0ZVRoaXNFeHByKToKKyAgICAgICAg KEpTQzo6QVNUQnVpbGRlcjo6Y3JlYXRlU3VwZXJFeHByKToKKyAgICAgICAgKEpTQzo6QVNUQnVp bGRlcjo6Y3JlYXRlTmV3VGFyZ2V0RXhwcik6CisgICAgICAgIChKU0M6OkFTVEJ1aWxkZXI6OnRo aXNFeHByKTogRGVsZXRlZC4KKyAgICAgICAgKEpTQzo6QVNUQnVpbGRlcjo6c3VwZXJFeHByKTog RGVsZXRlZC4KKyAgICAgICAgKEpTQzo6QVNUQnVpbGRlcjo6bmV3VGFyZ2V0RXhwcik6IERlbGV0 ZWQuCisgICAgICAgICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxM ZXhlclR5cGU+OjpwYXJzZVByaW1hcnlFeHByZXNzaW9uKToKKyAgICAgICAgKEpTQzo6UGFyc2Vy PExleGVyVHlwZT46OnBhcnNlTWVtYmVyRXhwcmVzc2lvbik6CisgICAgICAgICogcGFyc2VyL1N5 bnRheENoZWNrZXIuaDoKKyAgICAgICAgKEpTQzo6U3ludGF4Q2hlY2tlcjo6Y3JlYXRlVGhpc0V4 cHIpOgorICAgICAgICAoSlNDOjpTeW50YXhDaGVja2VyOjpjcmVhdGVTdXBlckV4cHIpOgorICAg ICAgICAoSlNDOjpTeW50YXhDaGVja2VyOjpjcmVhdGVOZXdUYXJnZXRFeHByKToKKyAgICAgICAg KEpTQzo6U3ludGF4Q2hlY2tlcjo6dGhpc0V4cHIpOiBEZWxldGVkLgorICAgICAgICAoSlNDOjpT eW50YXhDaGVja2VyOjpzdXBlckV4cHIpOiBEZWxldGVkLgorICAgICAgICAoSlNDOjpTeW50YXhD aGVja2VyOjpuZXdUYXJnZXRFeHByKTogRGVsZXRlZC4KKwogMjAxNS0wNy0yMCAgS2VpdGggTWls bGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3Ig dGhlIG5ldy50YXJnZXQgc3ludGF4LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9BU1RCdWlsZGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0FTVEJ1 aWxkZXIuaAppbmRleCAyMjRlYWY1Li4yZmJiNDE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcGFyc2VyL0FTVEJ1aWxkZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cGFyc2VyL0FTVEJ1aWxkZXIuaApAQCAtMTcxLDE2ICsxNzEsMTYgQEAgcHVibGljOgogICAgICAg ICBpbmNDb25zdGFudHMoKTsKICAgICAgICAgcmV0dXJuIG5ldyAobV9wYXJzZXJBcmVuYSkgVm9p ZE5vZGUobG9jYXRpb24sIGV4cHIpOwogICAgIH0KLSAgICBFeHByZXNzaW9uTm9kZSogdGhpc0V4 cHIoY29uc3QgSlNUb2tlbkxvY2F0aW9uJiBsb2NhdGlvbiwgVGhpc1REWk1vZGUgdGhpc1REWk1v ZGUpCisgICAgRXhwcmVzc2lvbk5vZGUqIGNyZWF0ZVRoaXNFeHByKGNvbnN0IEpTVG9rZW5Mb2Nh dGlvbiYgbG9jYXRpb24sIFRoaXNURFpNb2RlIHRoaXNURFpNb2RlKQogICAgIHsKICAgICAgICAg dXNlc1RoaXMoKTsKICAgICAgICAgcmV0dXJuIG5ldyAobV9wYXJzZXJBcmVuYSkgVGhpc05vZGUo bG9jYXRpb24sIHRoaXNURFpNb2RlKTsKICAgICB9Ci0gICAgRXhwcmVzc2lvbk5vZGUqIHN1cGVy RXhwcihjb25zdCBKU1Rva2VuTG9jYXRpb24mIGxvY2F0aW9uKQorICAgIEV4cHJlc3Npb25Ob2Rl KiBjcmVhdGVTdXBlckV4cHIoY29uc3QgSlNUb2tlbkxvY2F0aW9uJiBsb2NhdGlvbikKICAgICB7 CiAgICAgICAgIHJldHVybiBuZXcgKG1fcGFyc2VyQXJlbmEpIFN1cGVyTm9kZShsb2NhdGlvbik7 CiAgICAgfQotICAgIEV4cHJlc3Npb25Ob2RlKiBuZXdUYXJnZXRFeHByKGNvbnN0IEpTVG9rZW5M b2NhdGlvbiBsb2NhdGlvbikKKyAgICBFeHByZXNzaW9uTm9kZSogY3JlYXRlTmV3VGFyZ2V0RXhw cihjb25zdCBKU1Rva2VuTG9jYXRpb24gbG9jYXRpb24pCiAgICAgewogICAgICAgICByZXR1cm4g bmV3IChtX3BhcnNlckFyZW5hKSBOZXdUYXJnZXROb2RlKGxvY2F0aW9uKTsKICAgICB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKaW5kZXggNDgxYWZhNC4uOWU0OGM1NiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtMjc4Myw3ICsyNzgz LDcgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzc2lvbiBQYXJzZXI8 TGV4ZXJUeXBlPjo6cGFyc2VQcmltYXJ5RXhwcmUKICAgICBjYXNlIFRISVNUT0tFTjogewogICAg ICAgICBKU1Rva2VuTG9jYXRpb24gbG9jYXRpb24odG9rZW5Mb2NhdGlvbigpKTsKICAgICAgICAg bmV4dCgpOwotICAgICAgICByZXR1cm4gY29udGV4dC50aGlzRXhwcihsb2NhdGlvbiwgbV90aGlz VERaTW9kZSk7CisgICAgICAgIHJldHVybiBjb250ZXh0LmNyZWF0ZVRoaXNFeHByKGxvY2F0aW9u LCBtX3RoaXNURFpNb2RlKTsKICAgICB9CiAgICAgY2FzZSBJREVOVDogewogICAgIGlkZW50aWZp ZXJFeHByZXNzaW9uOgpAQCAtMjkzMyw3ICsyOTMzLDcgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVC dWlsZGVyPiBUcmVlRXhwcmVzc2lvbiBQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VNZW1iZXJFeHBy ZXMKICAgICAgICAgICAgIGlmIChtX3ZtLT5wcm9wZXJ0eU5hbWVzLT50YXJnZXQgPT0gKmlkZW50 KSB7CiAgICAgICAgICAgICAgICAgc2VtYW50aWNGYWlsSWZGYWxzZShjdXJyZW50U2NvcGUoKS0+ aXNGdW5jdGlvbigpLCAibmV3LnRhcmdldCBpcyBvbmx5IHZhbGlkIGluc2lkZSBmdW5jdGlvbnMi KTsKICAgICAgICAgICAgICAgICBiYXNlSXNOZXdUYXJnZXQgPSB0cnVlOwotICAgICAgICAgICAg ICAgIGJhc2UgPSBjb250ZXh0Lm5ld1RhcmdldEV4cHIobG9jYXRpb24pOworICAgICAgICAgICAg ICAgIGJhc2UgPSBjb250ZXh0LmNyZWF0ZU5ld1RhcmdldEV4cHIobG9jYXRpb24pOwogICAgICAg ICAgICAgICAgIG5ld0NvdW50LS07CiAgICAgICAgICAgICAgICAgbmV4dCgpOwogICAgICAgICAg ICAgfSBlbHNlCkBAIC0yOTQzLDcgKzI5NDMsNyBAQCB0ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxk ZXI+IFRyZWVFeHByZXNzaW9uIFBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZU1lbWJlckV4cHJlcwog ICAgIH0KIAogICAgIGlmIChiYXNlSXNTdXBlcikgewotICAgICAgICBiYXNlID0gY29udGV4dC5z dXBlckV4cHIobG9jYXRpb24pOworICAgICAgICBiYXNlID0gY29udGV4dC5jcmVhdGVTdXBlckV4 cHIobG9jYXRpb24pOwogICAgICAgICBuZXh0KCk7CiAgICAgICAgIGN1cnJlbnRTY29wZSgpLT5z ZXROZWVkc1N1cGVyQmluZGluZygpOwogICAgIH0gZWxzZSBpZiAoIWJhc2VJc05ld1RhcmdldCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU3ludGF4Q2hlY2tlci5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9TeW50YXhDaGVja2VyLmgKaW5kZXggZWFj MjIxMC4uZGU2ZWVmZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9T eW50YXhDaGVja2VyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9TeW50YXhD aGVja2VyLmgKQEAgLTE1NCw5ICsxNTQsOSBAQCBwdWJsaWM6CiAgICAgRXhwcmVzc2lvblR5cGUg Y3JlYXRlTG9naWNhbE5vdChjb25zdCBKU1Rva2VuTG9jYXRpb24mLCBFeHByZXNzaW9uVHlwZSkg eyByZXR1cm4gVW5hcnlFeHByOyB9CiAgICAgRXhwcmVzc2lvblR5cGUgY3JlYXRlVW5hcnlQbHVz KGNvbnN0IEpTVG9rZW5Mb2NhdGlvbiYsIEV4cHJlc3Npb25UeXBlKSB7IHJldHVybiBVbmFyeUV4 cHI7IH0KICAgICBFeHByZXNzaW9uVHlwZSBjcmVhdGVWb2lkKGNvbnN0IEpTVG9rZW5Mb2NhdGlv biYsIEV4cHJlc3Npb25UeXBlKSB7IHJldHVybiBVbmFyeUV4cHI7IH0KLSAgICBFeHByZXNzaW9u VHlwZSB0aGlzRXhwcihjb25zdCBKU1Rva2VuTG9jYXRpb24mLCBUaGlzVERaTW9kZSkgeyByZXR1 cm4gVGhpc0V4cHI7IH0KLSAgICBFeHByZXNzaW9uVHlwZSBzdXBlckV4cHIoY29uc3QgSlNUb2tl bkxvY2F0aW9uJikgeyByZXR1cm4gU3VwZXJFeHByOyB9Ci0gICAgRXhwcmVzc2lvblR5cGUgbmV3 VGFyZ2V0RXhwcihjb25zdCBKU1Rva2VuTG9jYXRpb24mKSB7IHJldHVybiBOZXdUYXJnZXRFeHBy OyB9CisgICAgRXhwcmVzc2lvblR5cGUgY3JlYXRlVGhpc0V4cHIoY29uc3QgSlNUb2tlbkxvY2F0 aW9uJiwgVGhpc1REWk1vZGUpIHsgcmV0dXJuIFRoaXNFeHByOyB9CisgICAgRXhwcmVzc2lvblR5 cGUgY3JlYXRlU3VwZXJFeHByKGNvbnN0IEpTVG9rZW5Mb2NhdGlvbiYpIHsgcmV0dXJuIFN1cGVy RXhwcjsgfQorICAgIEV4cHJlc3Npb25UeXBlIGNyZWF0ZU5ld1RhcmdldEV4cHIoY29uc3QgSlNU b2tlbkxvY2F0aW9uJikgeyByZXR1cm4gTmV3VGFyZ2V0RXhwcjsgfQogICAgIEV4cHJlc3Npb25U eXBlIGNyZWF0ZVJlc29sdmUoY29uc3QgSlNUb2tlbkxvY2F0aW9uJiwgY29uc3QgSWRlbnRpZmll ciosIGludCkgeyByZXR1cm4gUmVzb2x2ZUV4cHI7IH0KICAgICBFeHByZXNzaW9uVHlwZSBjcmVh dGVPYmplY3RMaXRlcmFsKGNvbnN0IEpTVG9rZW5Mb2NhdGlvbiYpIHsgcmV0dXJuIE9iamVjdExp dGVyYWxFeHByOyB9CiAgICAgRXhwcmVzc2lvblR5cGUgY3JlYXRlT2JqZWN0TGl0ZXJhbChjb25z dCBKU1Rva2VuTG9jYXRpb24mLCBpbnQpIHsgcmV0dXJuIE9iamVjdExpdGVyYWxFeHByOyB9Ci0t IAoyLjQuNAoK