147580 2015-08-03 11:54:33 -0700 jsc-tailcall: Callee save registers should be saved after the stack pointer is set up 2015-09-14 10:58:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff basile_clement oldest_to_newest 1114284 0 msaboff 2015-08-03 11:54:33 -0700 Since callee save registers are placed in the local variable area of the stack, they should be saved only after the stack pointer has been set for the code block being executed. 1114319 1 258103 msaboff 2015-08-03 13:14:19 -0700 Created attachment 258103 Patch 1114335 2 msaboff 2015-08-03 13:46:08 -0700 Committed r187759: <http://trac.webkit.org/changeset/187759> 1125641 3 258103 ossy 2015-09-14 10:58:25 -0700 Comment on attachment 258103 Patch Cleared review? from attachment 258103 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 258103 2015-08-03 13:14:19 -0700 2015-09-14 10:58:25 -0700 Patch 147580.patch text/plain 3511 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg3NzQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE1LTA4LTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGpzYy10YWlsY2FsbDogQ2FsbGVlIHNhdmUgcmVnaXN0ZXJzIHNob3VsZCBiZSBzYXZlZCBh ZnRlciB0aGUgc3RhY2sgcG9pbnRlciBpcyBzZXQgdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzU4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmVkIHRoZSBzYXZpbmcgb2YgY2FsbGVlIHNhdmVz IHRvIGFmdGVyIHdlIGNoZWNrIGZvciBzdGFjayBvdmVyZmxvdyBhbmQgaGF2ZQorICAgICAgICBz ZXQgdXAgdGhlIHN0YWNrIHBvaW50ZXIuCisKKyAgICAgICAgKiBkZmcvREZHSklUQ29tcGlsZXIu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjpjb21waWxlKToKKyAgICAgICAg KiBqaXQvSklULmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGlsZSk6CisgICAg ICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206CisKIDIwMTUtMDctMzEgIE1pY2hh ZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAganNjLXRhaWxjYWxsOiBS RUdSRVNTSU9OKHIxODc2NzYpOiBCcm9rZSBzdHJlc3MvdGFpbC1jYWxsLW5vLXN0YWNrLW92ZXJm bG93LmpzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVy LmNwcAkocmV2aXNpb24gMTg3NjgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdK SVRDb21waWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5MCw3ICsyOTAsNiBAQCB2b2lkIEpJ VENvbXBpbGVyOjpjb21waWxlKCkKIAogICAgIHNldFN0YXJ0T2ZDb2RlKCk7CiAgICAgY29tcGls ZUVudHJ5KCk7Ci0gICAgY29tcGlsZVNldHVwUmVnaXN0ZXJzRm9yRW50cnkoKTsKICAgICBtX3Nw ZWN1bGF0aXZlID0gc3RkOjptYWtlX3VuaXF1ZTxTcGVjdWxhdGl2ZUpJVD4oKnRoaXMpOwogCiAg ICAgLy8gUGxhbnQgYSBjaGVjayB0aGF0IHN1ZmZpY2llbnQgc3BhY2UgaXMgYXZhaWxhYmxlIGlu IHRoZSBKU1N0YWNrLgpAQCAtMjk5LDYgKzI5OCw3IEBAIHZvaWQgSklUQ29tcGlsZXI6OmNvbXBp bGUoKQogCiAgICAgYWRkUHRyKFRydXN0ZWRJbW0zMihtX2dyYXBoLnN0YWNrUG9pbnRlck9mZnNl dCgpICogc2l6ZW9mKFJlZ2lzdGVyKSksIEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyLCBzdGFj a1BvaW50ZXJSZWdpc3Rlcik7CiAgICAgY2hlY2tTdGFja1BvaW50ZXJBbGlnbm1lbnQoKTsKKyAg ICBjb21waWxlU2V0dXBSZWdpc3RlcnNGb3JFbnRyeSgpOwogICAgIGNvbXBpbGVCb2R5KCk7CiAg ICAgc2V0RW5kT2ZNYWluUGF0aCgpOwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuY3Bw CShyZXZpc2lvbiAxODc2ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUyNiw5ICs1MjYsNiBAQCBDb21waWxhdGlvblJlc3VsdCBKSVQ6 OnByaXZhdGVDb21waWxlKEpJCiAKICAgICBMYWJlbCBiZWdpbkxhYmVsKHRoaXMpOwogCi0gICAg ZW1pdFNhdmVDYWxsZWVTYXZlcygpOwotICAgIGVtaXRNYXRlcmlhbGl6ZVRhZ0NoZWNrUmVnaXN0 ZXJzKCk7Ci0KICAgICBzYW1wbGVDb2RlQmxvY2sobV9jb2RlQmxvY2spOwogI2lmIEVOQUJMRShP UENPREVfU0FNUExJTkcpCiAgICAgc2FtcGxlSW5zdHJ1Y3Rpb24obV9jb2RlQmxvY2stPmluc3Ry dWN0aW9ucygpLmJlZ2luKCkpOwpAQCAtNTYwLDYgKzU1Nyw5IEBAIENvbXBpbGF0aW9uUmVzdWx0 IEpJVDo6cHJpdmF0ZUNvbXBpbGUoSkkKICAgICBtb3ZlKHJlZ1QxLCBzdGFja1BvaW50ZXJSZWdp c3Rlcik7CiAgICAgY2hlY2tTdGFja1BvaW50ZXJBbGlnbm1lbnQoKTsKIAorICAgIGVtaXRTYXZl Q2FsbGVlU2F2ZXMoKTsKKyAgICBlbWl0TWF0ZXJpYWxpemVUYWdDaGVja1JlZ2lzdGVycygpOwor CiAgICAgcHJpdmF0ZUNvbXBpbGVNYWluUGFzcygpOwogICAgIHByaXZhdGVDb21waWxlTGlua1Bh c3MoKTsKICAgICBwcml2YXRlQ29tcGlsZVNsb3dDYXNlcygpOwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkocmV2aXNp b24gMTg3NjgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJw cmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC04NDUsMTMgKzg0NSw2IEBAIG1hY3JvIHByb2xv Z3VlKGNvZGVCbG9ja0dldHRlciwgY29kZUJsb2MKIAogICAgIGNvZGVCbG9ja1NldHRlcih0MSkK IAotICAgIHByZXNlcnZlQ2FsbGVlU2F2ZXNVc2VkQnlMTEludCgpCi0KLSAgICBpZiBKU1ZBTFVF NjQKLSAgICAgICAgbW92ZSBUYWdUeXBlTnVtYmVyLCB0YWdUeXBlTnVtYmVyCi0gICAgICAgIGFk ZHAgVGFnQml0VHlwZU90aGVyLCB0YWdUeXBlTnVtYmVyLCB0YWdNYXNrCi0gICAgZW5kCi0KICAg ICAjIFNldCB1cCB0aGUgUEMuCiAgICAgaWYgSlNWQUxVRTY0CiAgICAgICAgIGxvYWRwIENvZGVC bG9jazo6bV9pbnN0cnVjdGlvbnNbdDFdLCBQQgpAQCAtODgyLDYgKzg3NSwxMyBAQCBtYWNybyBw cm9sb2d1ZShjb2RlQmxvY2tHZXR0ZXIsIGNvZGVCbG9jCiAKIC5zdGFja0hlaWdodE9LOgogICAg IG1vdmUgdDAsIHNwCisKKyAgICBwcmVzZXJ2ZUNhbGxlZVNhdmVzVXNlZEJ5TExJbnQoKQorCisg ICAgaWYgSlNWQUxVRTY0CisgICAgICAgIG1vdmUgVGFnVHlwZU51bWJlciwgdGFnVHlwZU51bWJl cgorICAgICAgICBhZGRwIFRhZ0JpdFR5cGVPdGhlciwgdGFnVHlwZU51bWJlciwgdGFnTWFzawor ICAgIGVuZAogZW5kCiAKICMgRXhwZWN0cyB0aGF0IENvZGVCbG9jayBpcyBpbiB0MSwgd2hpY2gg aXMgd2hhdCBwcm9sb2d1ZSgpIGxlYXZlcyBiZWhpbmQuCg==