147577 2015-08-03 11:37:16 -0700 Don't set up the callsite to operationGetByValDefault when the optimization is already done 2015-08-03 12:25:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue fpizlo ggaren mark.lam msaboff saam oldest_to_newest 1114273 0 ysuzuki 2015-08-03 11:37:16 -0700 Don't set up the callsite to operationGetByValDefault when the optimization is already done 1114278 1 258093 ysuzuki 2015-08-03 11:46:28 -0700 Created attachment 258093 Patch 1114279 2 ysuzuki 2015-08-03 11:47:13 -0700 During seeing the code for get_by_val IC in https://bugs.webkit.org/show_bug.cgi?id=147480, I've found one issue. This patch fixes it. 1114286 3 258093 ysuzuki 2015-08-03 11:55:15 -0700 Comment on attachment 258093 Patch Thank you for your review! 1114293 4 258093 commit-queue 2015-08-03 12:25:13 -0700 Comment on attachment 258093 Patch Clearing flags on attachment: 258093 Committed r187750: <http://trac.webkit.org/changeset/187750> 1114294 5 commit-queue 2015-08-03 12:25:16 -0700 All reviewed patches have been landed. Closing bug. 258093 2015-08-03 11:46:28 -0700 2015-08-03 12:25:13 -0700 Patch bug-147577-20150803114623.patch text/plain 7329 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 M2UyOTgzZjQyMzk0MDBmNWQyZThlMDJmMTEwYzcyOGRlMzc0NDEyLi5lMGZlNzMwMDc4MmI4MDAx NWNmMTY2ZjIwMWJmYTk4MjBiN2YxMjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNS0wOC0wMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBEb24ndCBzZXQgdXAgdGhlIGNhbGxzaXRlIHRvIG9wZXJhdGlvbkdl dEJ5VmFsRGVmYXVsdCB3aGVuIHRoZSBvcHRpbWl6YXRpb24gaXMgYWxyZWFkeSBkb25lCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc1NzcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvcGVyYXRpb25HZXRC eVZhbERlZmF1bHQgc2hvdWxkIGJlIGNhbGxlZCBvbmx5IHdoZW4gdGhlIElDIGlzIG5vdCBzZXQu CisgICAgICAgIG9wZXJhdGlvbkdldEJ5VmFsU3RyaW5nIGJyZWFrcyB0aGlzIGludmFyaWFudCBh bmQgYEFTU0VSVCghYnlWYWxJbmZvLnN0dWJSb3V0aW5lKWAgaW4KKyAgICAgICAgb3BlcmF0aW9u R2V0QnlWYWxEZWZhdWx0IHJhaXNlcyB0aGUgYXNzZXJ0aW9uIGZhaWx1cmUuCisgICAgICAgIElu IHRoaXMgcGF0Y2gsIHdlIGNoYW5nZSB0aGUgY2FsbHNpdGUgc2V0dGluZyB1cCBjb2RlIGluIG9w ZXJhdGlvbkdldEJ5VmFsU3RyaW5nIHdoZW4KKyAgICAgICAgdGhlIElDIGlzIGFscmVhZHkgc2V0 LiBBbmQgdG8gbWFrZSB0aGUgb3BlcmF0aW9uJ3MgbWVhbmluZyBleHBsaWNpdGx5LCB3ZSBjaGFu Z2VkIHRoZQorICAgICAgICBuYW1lIG9wZXJhdGlvbkdldEJ5VmFsRGVmYXVsdCB0byBvcGVyYXRp b25HZXRCeVZhbE9wdGltaXplLCB0aGF0IGlzIGFsaWduZWQgdG8gdGhlCisgICAgICAgIEdldEJ5 SWQgY2FzZS4KKworICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKiBq aXQvSklUT3BlcmF0aW9ucy5oOgorICAgICAgICAqIGppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHA6 CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdFNsb3dfb3BfZ2V0X2J5X3ZhbCk6CisgICAgICAgICog aml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRT bG93X29wX2dldF9ieV92YWwpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9vcGVyYXRpb24tZ2V0 LWJ5LXZhbC1kZWZhdWx0LXNob3VsZC1ub3QtY2FsbGVkLWZvci1hbHJlYWR5LW9wdGltaXplZC1z aXRlLmpzOiBBZGRlZC4KKyAgICAgICAgKGhlbGxvKToKKwogMjAxNS0wOC0wMyAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtGVExdIFJlbW92ZSB1bnVz ZWQgc2NyaXB0cyByZWxhdGVkIHRvIG5hdGl2ZSBjYWxsIGlubGluaW5nCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAppbmRleCA0YjU4YjQ0ZDAwNDJkMjdiMjRj MDNjY2ZkNmNjYWY5OGRhYTc4MzFhLi44YTY5NzVjMTZkNmI5NmVjYTFmMjk2M2Q0ZjU5MTJiZjA1 Njg5NmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlv bnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAK QEAgLTE1MDksNyArMTUwOSw3IEBAIEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0 aW9uR2V0QnlWYWxHZW5lcmljKEV4ZWNTdGF0ZSogZXhlYywgRW5jb2RlZEpTCiAgICAgcmV0dXJu IEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwogfQogCi1FbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFU SU9OIG9wZXJhdGlvbkdldEJ5VmFsRGVmYXVsdChFeGVjU3RhdGUqIGV4ZWMsIEVuY29kZWRKU1Zh bHVlIGVuY29kZWRCYXNlLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkU3Vic2NyaXB0LCBBcnJheVBy b2ZpbGUqIGFycmF5UHJvZmlsZSkKK0VuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0 aW9uR2V0QnlWYWxPcHRpbWl6ZShFeGVjU3RhdGUqIGV4ZWMsIEVuY29kZWRKU1ZhbHVlIGVuY29k ZWRCYXNlLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkU3Vic2NyaXB0LCBBcnJheVByb2ZpbGUqIGFy cmF5UHJvZmlsZSkKIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwogICAgIE5hdGl2ZUNhbGxG cmFtZVRyYWNlciB0cmFjZXIoJnZtLCBleGVjKTsKQEAgLTE2NDMsOCArMTY0MywxMiBAQCBFbmNv ZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdldEJ5VmFsU3RyaW5nKEV4ZWNTdGF0 ZSogZXhlYywgRW5jb2RlZEpTVgogICAgICAgICAgICAgcmVzdWx0ID0gYXNTdHJpbmcoYmFzZVZh bHVlKS0+Z2V0SW5kZXgoZXhlYywgaSk7CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAgcmVz dWx0ID0gYmFzZVZhbHVlLmdldChleGVjLCBpKTsKLSAgICAgICAgICAgIGlmICghaXNKU1N0cmlu ZyhiYXNlVmFsdWUpKQotICAgICAgICAgICAgICAgIGN0aVBhdGNoQ2FsbEJ5UmV0dXJuQWRkcmVz cyhleGVjLT5jb2RlQmxvY2soKSwgUmV0dXJuQWRkcmVzc1B0cihPVVJfUkVUVVJOX0FERFJFU1Mp LCBGdW5jdGlvblB0cihvcGVyYXRpb25HZXRCeVZhbERlZmF1bHQpKTsKKyAgICAgICAgICAgIGlm ICghaXNKU1N0cmluZyhiYXNlVmFsdWUpKSB7CisgICAgICAgICAgICAgICAgdW5zaWduZWQgYnl0 ZWNvZGVPZmZzZXQgPSBleGVjLT5sb2NhdGlvbkFzQnl0ZWNvZGVPZmZzZXQoKTsKKyAgICAgICAg ICAgICAgICBBU1NFUlQoYnl0ZWNvZGVPZmZzZXQpOworICAgICAgICAgICAgICAgIEJ5VmFsSW5m byYgYnlWYWxJbmZvID0gZXhlYy0+Y29kZUJsb2NrKCktPmdldEJ5VmFsSW5mbyhieXRlY29kZU9m ZnNldCAtIDEpOworICAgICAgICAgICAgICAgIGN0aVBhdGNoQ2FsbEJ5UmV0dXJuQWRkcmVzcyhl eGVjLT5jb2RlQmxvY2soKSwgUmV0dXJuQWRkcmVzc1B0cihPVVJfUkVUVVJOX0FERFJFU1MpLCBG dW5jdGlvblB0cihieVZhbEluZm8uc3R1YlJvdXRpbmUgPyBvcGVyYXRpb25HZXRCeVZhbEdlbmVy aWMgOiBvcGVyYXRpb25HZXRCeVZhbE9wdGltaXplKSk7CisgICAgICAgICAgICB9CiAgICAgICAg IH0KICAgICB9IGVsc2UgewogICAgICAgICBiYXNlVmFsdWUucmVxdWlyZU9iamVjdENvZXJjaWJs ZShleGVjKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0 aW9ucy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmgKaW5kZXgg MTcwOWQyNTg2MjFhZjQ0ZmE1ZWQ2YWJkNjQwYTE1MGI0MjNjYjgwZi4uY2FjZmYyY2Q5YmQyYWEw YmY3ZTczMGNmZGUwZjEzMGZjODI2OWRkOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRPcGVyYXRpb25zLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRPcGVyYXRpb25zLmgKQEAgLTMxMCw3ICszMTAsNyBAQCB2b2lkIEpJVF9PUEVSQVRJT04gb3Bl cmF0aW9uUG9wU2NvcGUoRXhlY1N0YXRlKiwgaW50MzJfdCkgV1RGX0lOVEVSTkFMOwogdm9pZCBK SVRfT1BFUkFUSU9OIG9wZXJhdGlvblByb2ZpbGVEaWRDYWxsKEV4ZWNTdGF0ZSosIEVuY29kZWRK U1ZhbHVlKSBXVEZfSU5URVJOQUw7CiB2b2lkIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uUHJvZmls ZVdpbGxDYWxsKEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlKSBXVEZfSU5URVJOQUw7CiBFbmNv ZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkNoZWNrSGFzSW5zdGFuY2UoRXhlY1N0 YXRlKiwgRW5jb2RlZEpTVmFsdWUsIEVuY29kZWRKU1ZhbHVlIGJhc2VWYWwpIFdURl9JTlRFUk5B TDsKLUVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uR2V0QnlWYWxEZWZhdWx0 KEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRCYXNlLCBFbmNvZGVkSlNWYWx1ZSBl bmNvZGVkU3Vic2NyaXB0LCBBcnJheVByb2ZpbGUqKSBXVEZfSU5URVJOQUw7CitFbmNvZGVkSlNW YWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdldEJ5VmFsT3B0aW1pemUoRXhlY1N0YXRlKiwg RW5jb2RlZEpTVmFsdWUgZW5jb2RlZEJhc2UsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRTdWJzY3Jp cHQsIEFycmF5UHJvZmlsZSopIFdURl9JTlRFUk5BTDsKIEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVS QVRJT04gb3BlcmF0aW9uR2V0QnlWYWxHZW5lcmljKEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVl IGVuY29kZWRCYXNlLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkU3Vic2NyaXB0LCBBcnJheVByb2Zp bGUqKSBXVEZfSU5URVJOQUw7CiBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlv bkdldEJ5VmFsU3RyaW5nKEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRCYXNlLCBF bmNvZGVkSlNWYWx1ZSBlbmNvZGVkU3Vic2NyaXB0KSBXVEZfSU5URVJOQUw7CiBFbmNvZGVkSlNW YWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkhhc0luZGV4ZWRQcm9wZXJ0eURlZmF1bHQoRXhl Y1N0YXRlKiwgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZEJhc2UsIEVuY29kZWRKU1ZhbHVlIGVuY29k ZWRTdWJzY3JpcHQsIEFycmF5UHJvZmlsZSopIFdURl9JTlRFUk5BTDsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKaW5kZXggYzBhNTRiN2Y5MzY0 ZmQxN2I1NGRiZDJjODRlMGMyN2Q5M2ZmNzY2Yy4uNGVmMDZkOTIxM2EyYjFkYmZmYmE0YzdjMzM0 ZDJmNmYxYzQ3OTE3ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQ cm9wZXJ0eUFjY2Vzcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9w ZXJ0eUFjY2Vzcy5jcHAKQEAgLTIyNCw3ICsyMjQsNyBAQCB2b2lkIEpJVDo6ZW1pdFNsb3dfb3Bf Z2V0X2J5X3ZhbChJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uLCBWZWN0b3I8U2xvd0Nh cwogICAgIAogICAgIGVtaXRHZXRWaXJ0dWFsUmVnaXN0ZXIoYmFzZSwgcmVnVDApOwogICAgIGVt aXRHZXRWaXJ0dWFsUmVnaXN0ZXIocHJvcGVydHksIHJlZ1QxKTsKLSAgICBDYWxsIGNhbGwgPSBj YWxsT3BlcmF0aW9uKG9wZXJhdGlvbkdldEJ5VmFsRGVmYXVsdCwgZHN0LCByZWdUMCwgcmVnVDEs IHByb2ZpbGUpOworICAgIENhbGwgY2FsbCA9IGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uR2V0QnlW YWxPcHRpbWl6ZSwgZHN0LCByZWdUMCwgcmVnVDEsIHByb2ZpbGUpOwogCiAgICAgbV9ieVZhbENv bXBpbGF0aW9uSW5mb1ttX2J5VmFsSW5zdHJ1Y3Rpb25JbmRleF0uc2xvd1BhdGhUYXJnZXQgPSBz bG93UGF0aDsKICAgICBtX2J5VmFsQ29tcGlsYXRpb25JbmZvW21fYnlWYWxJbnN0cnVjdGlvbklu ZGV4XS5yZXR1cm5BZGRyZXNzID0gY2FsbDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MzMl82NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3BwCmluZGV4IDE0OGQ3NmM2Y2Y4YjhjNjgx OWQxNWJhMzJhNDA5NDRhMDBjZGE0ZjEuLjYwOWNhMTM4ODIyN2RiNWJkYTUzOTI3NTMwM2RhZGQy ZDhiMWNlYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVy dHlBY2Nlc3MzMl82NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9w ZXJ0eUFjY2VzczMyXzY0LmNwcApAQCAtMjY1LDcgKzI2NSw3IEBAIHZvaWQgSklUOjplbWl0U2xv d19vcF9nZXRfYnlfdmFsKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24sIFZlY3RvcjxT bG93Q2FzCiAgICAgCiAgICAgZW1pdExvYWQoYmFzZSwgcmVnVDEsIHJlZ1QwKTsKICAgICBlbWl0 TG9hZChwcm9wZXJ0eSwgcmVnVDMsIHJlZ1QyKTsKLSAgICBDYWxsIGNhbGwgPSBjYWxsT3BlcmF0 aW9uKG9wZXJhdGlvbkdldEJ5VmFsRGVmYXVsdCwgZHN0LCByZWdUMSwgcmVnVDAsIHJlZ1QzLCBy ZWdUMiwgcHJvZmlsZSk7CisgICAgQ2FsbCBjYWxsID0gY2FsbE9wZXJhdGlvbihvcGVyYXRpb25H ZXRCeVZhbE9wdGltaXplLCBkc3QsIHJlZ1QxLCByZWdUMCwgcmVnVDMsIHJlZ1QyLCBwcm9maWxl KTsKIAogICAgIG1fYnlWYWxDb21waWxhdGlvbkluZm9bbV9ieVZhbEluc3RydWN0aW9uSW5kZXhd LnNsb3dQYXRoVGFyZ2V0ID0gc2xvd1BhdGg7CiAgICAgbV9ieVZhbENvbXBpbGF0aW9uSW5mb1tt X2J5VmFsSW5zdHJ1Y3Rpb25JbmRleF0ucmV0dXJuQWRkcmVzcyA9IGNhbGw7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL29wZXJhdGlvbi1nZXQtYnktdmFs LWRlZmF1bHQtc2hvdWxkLW5vdC1jYWxsZWQtZm9yLWFscmVhZHktb3B0aW1pemVkLXNpdGUuanMg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL29wZXJhdGlvbi1nZXQtYnktdmFs LWRlZmF1bHQtc2hvdWxkLW5vdC1jYWxsZWQtZm9yLWFscmVhZHktb3B0aW1pemVkLXNpdGUuanMK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uZDllMjRjMzZkZmI4MDg5ZDBmNGM0ZjNmMTVhZjUwMDE3YjkxZGIzNwotLS0g L2Rldi9udWxsCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb3BlcmF0 aW9uLWdldC1ieS12YWwtZGVmYXVsdC1zaG91bGQtbm90LWNhbGxlZC1mb3ItYWxyZWFkeS1vcHRp bWl6ZWQtc2l0ZS5qcwpAQCAtMCwwICsxLDEyIEBACitmdW5jdGlvbiBoZWxsbyhvYmplY3QsIG5h bWUpCit7CisgICAgcmV0dXJuIG9iamVjdFtuYW1lXTsKK30KK25vSW5saW5lKGhlbGxvKTsKK2Zv ciAodmFyIGkgPSAwOyBpIDwgMTAwOyArK2kpCisgICAgaGVsbG8oWzAsMSwyLDNdLCAxKTsKK2hl bGxvKFswLjEsMC4yLDAuMywwLjRdLCAxKTsKK2hlbGxvKCdzdHJpbmcnLCAxKTsKK2hlbGxvKCdz dHJpbmcnLCAxKTsKK2hlbGxvKFt0cnVlLCBmYWxzZSwgdHJ1ZSwgZmFsc2VdLCAxKTsKK2hlbGxv KFt0cnVlLCBmYWxzZSwgdHJ1ZSwgZmFsc2VdLCAxKTsK