147567 2015-08-03 10:57:02 -0700 Fix error handling case in Cache::dumpContentsToFile() 2015-08-03 12:20:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez andersca cgarcia commit-queue koivisto oldest_to_newest 1114235 0 cdumez 2015-08-03 10:57:02 -0700 Cache::dumpContentsToFile() was expecting openFile() to return 0 in case of error. However, it returns invalidPlatformFileHandle, which is -1 on Unix. 1114236 1 258078 cdumez 2015-08-03 10:58:20 -0700 Created attachment 258078 Patch 1114271 2 258078 kling 2015-08-03 11:36:13 -0700 Comment on attachment 258078 Patch Whoops! 1114290 3 258078 commit-queue 2015-08-03 12:20:38 -0700 Comment on attachment 258078 Patch Clearing flags on attachment: 258078 Committed r187749: <http://trac.webkit.org/changeset/187749> 1114291 4 commit-queue 2015-08-03 12:20:41 -0700 All reviewed patches have been landed. Closing bug. 258078 2015-08-03 10:58:20 -0700 2015-08-03 12:20:38 -0700 Patch bug-147567-20150803105814.patch text/plain 1593 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjlhYzJmN2JiMGU4NTgy YjE0MjMzZmMyOTE4NWZlY2Q2MGU5ZmY3YS4uYTc1MTk5YTQ4NmZiM2M0ZjcwYjZiMTk3NTVmYzQ4 OGIxMTUzM2YyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA4LTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGVycm9yIGhhbmRsaW5n IGNhc2UgaW4gQ2FjaGU6OmR1bXBDb250ZW50c1RvRmlsZSgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc1NjcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWNoZTo6ZHVtcENvbnRlbnRzVG9GaWxlKCkg d2FzIGV4cGVjdGluZyBvcGVuRmlsZSgpIHRvIHJldHVybiAwIGluIGNhc2UKKyAgICAgICAgb2Yg ZXJyb3IuIEhvd2V2ZXIsIGl0IHJldHVybnMgaW52YWxpZFBsYXRmb3JtRmlsZUhhbmRsZSwgd2hp Y2ggaXMgLTEgb24KKyAgICAgICAgVW5peC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2Nh Y2hlL05ldHdvcmtDYWNoZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6Q2Fj aGU6OmR1bXBDb250ZW50c1RvRmlsZSk6CisKIDIwMTUtMDgtMDMgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBP cHRpb25zR1RLLmNtYWtlIGFuZCBORVdTIGZvciAyLjkuNSByZWxlYXNlLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKaW5kZXgg NTY0NDIxMWIwMjU2Mzk0ZGEzNzlmMzdiYzQ0YzQ0ZmFjYjEwMThiNS4uOWVjMmVkZmMwY2E0YWJk Y2JmNGU1MzFlYmIzMmU4ZDNiNjI2YjQzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCkBAIC00ODIsNyArNDgyLDcgQEAg dm9pZCBDYWNoZTo6ZHVtcENvbnRlbnRzVG9GaWxlKCkKICAgICBpZiAoIW1fc3RvcmFnZSkKICAg ICAgICAgcmV0dXJuOwogICAgIGF1dG8gZmQgPSBXZWJDb3JlOjpvcGVuRmlsZShkdW1wRmlsZVBh dGgoKSwgV2ViQ29yZTo6T3BlbkZvcldyaXRlKTsKLSAgICBpZiAoIWZkKQorICAgIGlmICghV2Vi Q29yZTo6aXNIYW5kbGVWYWxpZChmZCkpCiAgICAgICAgIHJldHVybjsKICAgICBhdXRvIHByb2xv Z3VlID0gU3RyaW5nKCJ7XG5cImVudHJpZXNcIjogW1xuIikudXRmOCgpOwogICAgIFdlYkNvcmU6 OndyaXRlVG9GaWxlKGZkLCBwcm9sb2d1ZS5kYXRhKCksIHByb2xvZ3VlLmxlbmd0aCgpKTsK