147565 2015-08-03 10:52:54 -0700 ChildWidgetState::ChildWidgetIs* naming is redundant. 2015-08-03 11:24:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan cdumez commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1114230 0 zalan 2015-08-03 10:52:54 -0700 Use ChildWidgetState { IsValid, IsDestroyed } instead. 1114241 1 258080 zalan 2015-08-03 11:02:46 -0700 Created attachment 258080 Patch 1114247 2 cdumez 2015-08-03 11:14:28 -0700 I would even use { Valid, Destroyed }. 1114258 3 zalan 2015-08-03 11:24:59 -0700 Committed r187746: <http://trac.webkit.org/changeset/187746> 258080 2015-08-03 11:02:46 -0700 2015-08-03 11:13:17 -0700 Patch bug-147565-20150803110240.patch text/plain 5124 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZjMWFkODZjYmVhM2I3 ODM0ZjIwOTMzYWUzZDk0ODBjOGY2YTIwMi4uZjQzOTgzZDE5NDI4ZjQ4ZDIzMTFlYmNjYjkyNTZj MDg2MTU2YWMwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACisyMDE1LTA4LTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hpbGRXaWRnZXRTdGF0ZTo6 Q2hpbGRXaWRnZXRJcyogbmFtaW5nIGlzIHJlZHVuZGFudC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzU2NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHN0cm9uZ2x5IHR5cGVkIGVudW0gcmVx dWlyZXMgdG8gd3JpdGUgb3V0ICdDaGlsZFdpZGdldFN0YXRlOjpDaGlsZFdpZGdldElzRGVzdHJv eWVkJywKKyAgICAgICAgdGhlIGVudW1lcmF0b3IgbGlzdCBuYW1lcyBjYW4gYmUgc2hvcnRlbmVk LgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBiZWhhdmlvdXIuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyRnJhbWVCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZyYW1lQmFz ZTo6cGVmb3JtTGF5b3V0V2l0aEZsYXR0ZW5pbmcpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJXaWRnZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyV2lkZ2V0Ojp1cGRhdGVXaWRn ZXRQb3NpdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcldpZGdldC5oOgorCiAyMDE1 LTA4LTAzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUGFzcyBD b250cm9sU3RhdGVzJiB0byBSZW5kZXJUaGVtZSBtZXRob2RzIGluc3RlYWQgb2YgQ29udHJvbFN0 YXRlcyoKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NzUyMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVC YXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGcmFtZUJhc2UuY3BwCmlu ZGV4IGNkYmNjZGYyZmU3MzIyODdmYzdhYjkyMjE4ZGViNzRjNjA3ZWM0OTIuLmJjYjhkM2Y3NmE2 Yjg2MjcxM2Q4OTZiNDNlODQ3ODAzNWZmMGM0YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJGcmFtZUJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJGcmFtZUJhc2UuY3BwCkBAIC03MSwxNCArNzEsMTQgQEAgUmVuZGVyVmlldyog UmVuZGVyRnJhbWVCYXNlOjpjaGlsZFJlbmRlclZpZXcoKSBjb25zdAogdm9pZCBSZW5kZXJGcmFt ZUJhc2U6OnBlZm9ybUxheW91dFdpdGhGbGF0dGVuaW5nKGJvb2wgaGFzRml4ZWRXaWR0aCwgYm9v bCBoYXNGaXhlZEhlaWdodCkKIHsKICAgICBpZiAoIWNoaWxkUmVuZGVyVmlldygpIHx8ICFzaG91 bGRFeHBhbmRGcmFtZSh3aWR0aCgpLCBoZWlnaHQoKSwgaGFzRml4ZWRXaWR0aCwgaGFzRml4ZWRI ZWlnaHQpKSB7Ci0gICAgICAgIGlmICh1cGRhdGVXaWRnZXRQb3NpdGlvbigpID09IENoaWxkV2lk Z2V0U3RhdGU6OkNoaWxkV2lkZ2V0SXNEZXN0cm95ZWQpCisgICAgICAgIGlmICh1cGRhdGVXaWRn ZXRQb3NpdGlvbigpID09IENoaWxkV2lkZ2V0U3RhdGU6OklzRGVzdHJveWVkKQogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICBjaGlsZFZpZXcoKS0+bGF5b3V0KCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKICAgICAvLyBuZWVkIHRvIHVwZGF0ZSB0byBjYWxjdWxhdGUgbWluL21heCBj b3JyZWN0bHkKLSAgICBpZiAodXBkYXRlV2lkZ2V0UG9zaXRpb24oKSA9PSBDaGlsZFdpZGdldFN0 YXRlOjpDaGlsZFdpZGdldElzRGVzdHJveWVkKQorICAgIGlmICh1cGRhdGVXaWRnZXRQb3NpdGlv bigpID09IENoaWxkV2lkZ2V0U3RhdGU6OklzRGVzdHJveWVkKQogICAgICAgICByZXR1cm47CiAg ICAgCiAgICAgLy8gaWYgc2Nyb2xsYmFycyBhcmUgb2ZmLCBhbmQgdGhlIHdpZHRoIG9yIGhlaWdo dCBhcmUgZml4ZWQKQEAgLTk1LDcgKzk1LDcgQEAgdm9pZCBSZW5kZXJGcmFtZUJhc2U6OnBlZm9y bUxheW91dFdpdGhGbGF0dGVuaW5nKGJvb2wgaGFzRml4ZWRXaWR0aCwgYm9vbCBoYXNGaXgKICAg ICAgICAgQVNTRVJUKGNoaWxkUmVuZGVyVmlldygpKTsKICAgICAgICAgc2V0V2lkdGgoc3RkOjpt YXgod2lkdGgoKSwgY2hpbGRSZW5kZXJWaWV3KCktPm1pblByZWZlcnJlZExvZ2ljYWxXaWR0aCgp ICsgaEJvcmRlcikpOwogICAgICAgICAvLyB1cGRhdGUgYWdhaW4gdG8gcGFzcyB0aGUgbmV3IHdp ZHRoIHRvIHRoZSBjaGlsZCBmcmFtZQotICAgICAgICBpZiAodXBkYXRlV2lkZ2V0UG9zaXRpb24o KSA9PSBDaGlsZFdpZGdldFN0YXRlOjpDaGlsZFdpZGdldElzRGVzdHJveWVkKQorICAgICAgICBp ZiAodXBkYXRlV2lkZ2V0UG9zaXRpb24oKSA9PSBDaGlsZFdpZGdldFN0YXRlOjpJc0Rlc3Ryb3ll ZCkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgY2hpbGRWaWV3KCktPmxheW91dCgpOwog ICAgIH0KQEAgLTEwNyw3ICsxMDcsNyBAQCB2b2lkIFJlbmRlckZyYW1lQmFzZTo6cGVmb3JtTGF5 b3V0V2l0aEZsYXR0ZW5pbmcoYm9vbCBoYXNGaXhlZFdpZHRoLCBib29sIGhhc0ZpeAogICAgIGlm IChpc1Njcm9sbGFibGUgfHwgIWhhc0ZpeGVkV2lkdGggfHwgY2hpbGRSZW5kZXJWaWV3KCktPmlz RnJhbWVTZXQoKSkKICAgICAgICAgc2V0V2lkdGgoc3RkOjptYXg8TGF5b3V0VW5pdD4od2lkdGgo KSwgY2hpbGRWaWV3KCktPmNvbnRlbnRzV2lkdGgoKSArIGhCb3JkZXIpKTsKIAotICAgIGlmICh1 cGRhdGVXaWRnZXRQb3NpdGlvbigpID09IENoaWxkV2lkZ2V0U3RhdGU6OkNoaWxkV2lkZ2V0SXNE ZXN0cm95ZWQpCisgICAgaWYgKHVwZGF0ZVdpZGdldFBvc2l0aW9uKCkgPT0gQ2hpbGRXaWRnZXRT dGF0ZTo6SXNEZXN0cm95ZWQpCiAgICAgICAgIHJldHVybjsKIAogICAgIEFTU0VSVCghY2hpbGRW aWV3KCktPmxheW91dFBlbmRpbmcoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyV2lkZ2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJX aWRnZXQuY3BwCmluZGV4IGQ3NWIwZmRkZjhhNDA4MjBiNjQwNzIxYjc4NWM5NmQ4MjQ1ZmM5MDYu LmI1YTcwODNhODVmMjRkMTVhMmM4YTgyZmI1NWExMWY2NmM5OWQ3MzcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwCkBAIC0zMDYsMTIgKzMwNiwxMiBAQCB2b2lk IFJlbmRlcldpZGdldDo6c2V0T3ZlcmxhcFRlc3RSZXN1bHQoYm9vbCBpc092ZXJsYXBwZWQpCiBS ZW5kZXJXaWRnZXQ6OkNoaWxkV2lkZ2V0U3RhdGUgUmVuZGVyV2lkZ2V0Ojp1cGRhdGVXaWRnZXRQ b3NpdGlvbigpCiB7CiAgICAgaWYgKCFtX3dpZGdldCkKLSAgICAgICAgcmV0dXJuIENoaWxkV2lk Z2V0U3RhdGU6OkNoaWxkV2lkZ2V0SXNEZXN0cm95ZWQ7CisgICAgICAgIHJldHVybiBDaGlsZFdp ZGdldFN0YXRlOjpJc0Rlc3Ryb3llZDsKIAogICAgIFdlYWtQdHI8UmVuZGVyV2lkZ2V0PiB3ZWFr VGhpcyA9IGNyZWF0ZVdlYWtQdHIoKTsKICAgICBib29sIHdpZGdldFNpemVDaGFuZ2VkID0gdXBk YXRlV2lkZ2V0R2VvbWV0cnkoKTsKICAgICBpZiAoIXdlYWtUaGlzIHx8ICFtX3dpZGdldCkKLSAg ICAgICAgcmV0dXJuIENoaWxkV2lkZ2V0U3RhdGU6OkNoaWxkV2lkZ2V0SXNEZXN0cm95ZWQ7Cisg ICAgICAgIHJldHVybiBDaGlsZFdpZGdldFN0YXRlOjpJc0Rlc3Ryb3llZDsKIAogICAgIC8vIGlm IHRoZSBmcmFtZSBzaXplIGdvdCBjaGFuZ2VkLCBvciBpZiB2aWV3IG5lZWRzIGxheW91dCAocG9z c2libHkgaW5kaWNhdGluZwogICAgIC8vIGNvbnRlbnQgc2l6ZSBpcyB3cm9uZykgd2UgaGF2ZSB0 byBkbyBhIGxheW91dCB0byBzZXQgdGhlIHJpZ2h0IHdpZGdldCBzaXplLgpAQCAtMzIxLDcgKzMy MSw3IEBAIFJlbmRlcldpZGdldDo6Q2hpbGRXaWRnZXRTdGF0ZSBSZW5kZXJXaWRnZXQ6OnVwZGF0 ZVdpZGdldFBvc2l0aW9uKCkKICAgICAgICAgaWYgKCh3aWRnZXRTaXplQ2hhbmdlZCB8fCBmcmFt ZVZpZXcubmVlZHNMYXlvdXQoKSkgJiYgZnJhbWVWaWV3LmZyYW1lKCkucGFnZSgpKQogICAgICAg ICAgICAgZnJhbWVWaWV3LmxheW91dCgpOwogICAgIH0KLSAgICByZXR1cm4gQ2hpbGRXaWRnZXRT dGF0ZTo6Q2hpbGRXaWRnZXRJc1ZhbGlkOworICAgIHJldHVybiBDaGlsZFdpZGdldFN0YXRlOjpJ c1ZhbGlkOwogfQogCiBJbnRSZWN0IFJlbmRlcldpZGdldDo6d2luZG93Q2xpcFJlY3QoKSBjb25z dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5oIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5oCmluZGV4IDhhMWEwMTNjODg5 ZDI2NjI0YjRmM2Q4MjRmMTlmMTg3ZWM4NWFlNDAuLmE2MDA5YzNmMDZmY2I3OTAyNWQzZTZjZmI2 MTViZDQ2ODkyM2UyMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJXaWRnZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyV2lkZ2V0LmgK QEAgLTY3LDcgKzY3LDcgQEAgcHVibGljOgogCiAgICAgc3RhdGljIFJlbmRlcldpZGdldCogZmlu ZChjb25zdCBXaWRnZXQqKTsKIAotICAgIGVudW0gY2xhc3MgQ2hpbGRXaWRnZXRTdGF0ZSB7IENo aWxkV2lkZ2V0SXNWYWxpZCwgQ2hpbGRXaWRnZXRJc0Rlc3Ryb3llZCB9OworICAgIGVudW0gY2xh c3MgQ2hpbGRXaWRnZXRTdGF0ZSB7IElzVmFsaWQsIElzRGVzdHJveWVkIH07CiAgICAgQ2hpbGRX aWRnZXRTdGF0ZSB1cGRhdGVXaWRnZXRQb3NpdGlvbigpIFdBUk5fVU5VU0VEX1JFVFVSTjsKICAg ICBXRUJDT1JFX0VYUE9SVCBJbnRSZWN0IHdpbmRvd0NsaXBSZWN0KCkgY29uc3Q7CiAK