147554 2015-08-02 22:55:00 -0700 Web Inspector: Don't show 'Reveal In Debugger Tab' menu item if already in Debugger tab 2015-08-04 15:47:01 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mattbaker mattbaker commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1114148 0 mattbaker 2015-08-02 22:55:00 -0700 * SUMMARY Don't show 'Reveal In Debugger Tab' menu item if already in Debugger tab. It should only appear when right-clicking breakpoints in the Resources tab. * STEPS TO REPRODUCE 1. Set a breakpoint 2. Right-click breakpoint from Debugger tab 3. Click Reveal In Debugger tab => The breakpoint line is reselected. Not necessary. 1114167 1 258056 mattbaker 2015-08-03 05:20:59 -0700 Created attachment 258056 [Patch] Proposed Fix 1114834 2 258056 commit-queue 2015-08-04 15:46:58 -0700 Comment on attachment 258056 [Patch] Proposed Fix Clearing flags on attachment: 258056 Committed r187900: <http://trac.webkit.org/changeset/187900> 1114835 3 commit-queue 2015-08-04 15:47:01 -0700 All reviewed patches have been landed. Closing bug. 258056 2015-08-03 05:20:59 -0700 2015-08-04 15:46:58 -0700 [Patch] Proposed Fix bug-147554-20150803052055.patch text/plain 2465 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk M2M4Yjg0MmUzY2RkNTg3NDdhODMxZjdjNDJjNjk1MmUzMzcwNDlhLi42YmQ4OGI3MzVkMzQ1MGFi NTk0YjI0ZjE0Y2YxNjQ2MjY4M2M4MTczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0wOC0wMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG9uJ3Qgc2hvdyAnUmV2ZWFsIEluIERlYnVnZ2Vy IFRhYicgbWVudSBpdGVtIGlmIGFscmVhZHkgaW4gRGVidWdnZXIgdGFiCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc1NTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayBjdXJyZW50IHRhYiBiZWZv cmUgYXBwZW5kaW5nIGNvbnRleHQgbWVudSBpdGVtcy4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmlzU2hvd2luZ0RlYnVnZ2Vy VGFiKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9y LmpzOgorCiAyMDE1LTA4LTAyICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBVbm5hbWVzcGFjZWQgRm9ybWF0dGVyIGNsYXNzZXMgYnJl YWsgQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCAxNGMyNGM3NTMzOTQwMTAwM2Yx ZmRkNGI2NmU3Y2M4OGQ3MGExMDdhLi5iOGM3MzZiM2RiZTM2NzgzNzBjMzM5MTc4YTM4YWQzOWVh NjIwZTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzCkBAIC03OTQsNiArNzk0LDExIEBAIFdlYkluc3BlY3Rvci5zaG93RGVidWdnZXJU YWIgPSBmdW5jdGlvbihicmVha3BvaW50VG9TZWxlY3QsIHNob3dTY29wZUNoYWluRGV0YWlsCiAg ICAgdGhpcy50YWJCcm93c2VyLnNob3dUYWJGb3JDb250ZW50Vmlldyh0YWJDb250ZW50Vmlldyk7 CiB9OwogCitXZWJJbnNwZWN0b3IuaXNTaG93aW5nRGVidWdnZXJUYWIgPSBmdW5jdGlvbigpCit7 CisgICAgcmV0dXJuIHRoaXMudGFiQnJvd3Nlci5zZWxlY3RlZFRhYkNvbnRlbnRWaWV3IGluc3Rh bmNlb2YgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyVGFiQ29udGVudFZpZXc7Cit9OworCiBXZWJJbnNw ZWN0b3Iuc2hvd1Jlc291cmNlc1RhYiA9IGZ1bmN0aW9uKCkKIHsKICAgICB2YXIgdGFiQ29udGVu dFZpZXcgPSB0aGlzLnRhYkJyb3dzZXIuYmVzdFRhYkNvbnRlbnRWaWV3Rm9yQ2xhc3MoV2ViSW5z cGVjdG9yLlJlc291cmNlc1RhYkNvbnRlbnRWaWV3KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRF ZGl0b3IuanMKaW5kZXggZTI3NDI3ZWM2MDk1YTExYWU2MGRlNzAyNzRlMmMwNjBiODZlYWZkZC4u NGU4ZTI1NjViZjY3YTZmMzhmNGMyZTU1NTAwZmNmNGQ5NjVjYzc3YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0 b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291 cmNlQ29kZVRleHRFZGl0b3IuanMKQEAgLTEwMjIsNyArMTAyMiw3IEBAIFdlYkluc3BlY3Rvci5T b3VyY2VDb2RlVGV4dEVkaXRvciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMg V2ViSW5zcGVjCiAgICAgICAgIH0KIAogICAgICAgICAvLyBTaW5nbGUgYnJlYWtwb2ludC4KLSAg ICAgICAgaWYgKGJyZWFrcG9pbnRzLmxlbmd0aCA9PT0gMSkgeworICAgICAgICBpZiAoYnJlYWtw b2ludHMubGVuZ3RoID09PSAxICYmICFXZWJJbnNwZWN0b3IuaXNTaG93aW5nRGVidWdnZXJUYWIo KSkgewogICAgICAgICAgICAgdmFyIGJyZWFrcG9pbnQgPSBicmVha3BvaW50c1swXTsKIAogICAg ICAgICAgICAgYnJlYWtwb2ludC5hcHBlbmRDb250ZXh0TWVudUl0ZW1zKGNvbnRleHRNZW51LCBl dmVudC50YXJnZXQpOwo=