147544 2015-08-02 13:20:46 -0700 Web Inspector: Unnamespaced Formatter classes break CSSStyleDeclarationTextEditor 2015-08-03 14:32:29 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mattbaker mattbaker burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1114108 0 mattbaker 2015-08-02 13:20:46 -0700 * SUMMARY Unnamespaced Formatter classes break CSSStyleDeclarationTextEditor. * STEPS TO REPRODUCE 1. Open Elements tab 2. In details sidebar go to Styles/Rules 3. Details sidebar is empty except for pseudo-class checkboxes 4. Inspect the Inspector, view console log. => [Error] Uncaught exception in inspector page while dispatching callback for command CSS.getComputedStyleForNode: (2) ReferenceError: Can't find variable: FormatterContentBuilder _formattedContentFromEditor@file://.../Views/CSSStyleDeclarationTextEditor.js:1473:50\ * NOTES For some reason I can only reproduce this in local builds, but namespacing FormatterContentBuilder and Formatter fixes the issue (and these should be namespaces anyway). 1114109 1 258039 mattbaker 2015-08-02 13:27:09 -0700 Created attachment 258039 [Patch] Proposed Fix 1114127 2 258039 burg 2015-08-02 16:14:22 -0700 Comment on attachment 258039 [Patch] Proposed Fix r=me 1114136 3 258039 commit-queue 2015-08-02 18:44:15 -0700 Comment on attachment 258039 [Patch] Proposed Fix Clearing flags on attachment: 258039 Committed r187732: <http://trac.webkit.org/changeset/187732> 1114137 4 commit-queue 2015-08-02 18:44:19 -0700 All reviewed patches have been landed. Closing bug. 1114355 5 258039 joepeck 2015-08-03 14:12:10 -0700 Comment on attachment 258039 [Patch] Proposed Fix I think this would break PrettyPrinting test harness: Source/WebInspectorUI/Tools/PrettyPrinting/* These classes were not WebInspector prefixed because they didn't rely on anything WebInspector and could be used outside of it. But it should be find to put them into the namespace. My guess is this broke when converting classes to use block scoping. In that case the class name would likely not be exported. 1114367 6 mattbaker 2015-08-03 14:32:29 -0700 (In reply to comment #5) > Comment on attachment 258039 [details] > [Patch] Proposed Fix > > I think this would break PrettyPrinting test harness: > > Source/WebInspectorUI/Tools/PrettyPrinting/* I'll file a follow up to fix it. > My guess is this broke when converting classes to use block scoping. In that > case the class name would likely not be exported. Ah, makes sense. 258039 2015-08-02 13:27:09 -0700 2015-08-02 18:44:15 -0700 [Patch] Proposed Fix bug-147544-20150802132704.patch text/plain 4903 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 YmQ5NmQwNmM4NzAzZjgyMDRkNjFjMDI4MWRjOWEwMWU4ODllZmYzLi4zODhmY2U1NzdiYmJjYWE5 MTE1Njk1MThlMWVhZDAzNjg2NjEyMTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMiBAQAorMjAxNS0wOC0wMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5uYW1lc3BhY2VkIEZvcm1hdHRlciBjbGFzc2Vz IGJyZWFrIENTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc1NDQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBGb3JtYXR0ZXIgYW5kIEZvcm1hdHRl ckNvbnRlbnRCdWlsZGVyIHRvIFdlYkluc3BlY3RvciBuYW1lc3BhY2UuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Zvcm1hdHRlci5qczoKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0Zvcm1hdHRlckNvbnRlbnRCdWlsZGVyLmpzOgorICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IucHJvdG90 eXBlLl9mb3JtYXR0ZWRDb250ZW50RnJvbUVkaXRvcik6CisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9UZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3Iu cHJvdG90eXBlLnByZXR0eVByaW50LnByZXR0eVByaW50QW5kVXBkYXRlRWRpdG9yKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5wcmV0dHlQcmludCk6CisKIDIw MTUtMDgtMDIgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFJFR1JFU1NJT04gKHIxODc2ODkpOiBUaW1lbGluZSBvdmVydmlldyBncmFw aCBsYXlvdXQgaXMgYnJva2VuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDc1MzkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRm9ybWF0dGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRm9ybWF0dGVyLmpzCmluZGV4IGMwOWM1NTY1 Njk5MjEzNjI5YWE0MzJiYmFlNmVhOWM4Njk0YzVlMmYuLjJhMTY1MjczM2NkODAyYjE1M2Q2Njkx MmJhOTA3NTczN2MzNTY3MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Zvcm1hdHRlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Gb3JtYXR0ZXIuanMKQEAgLTIzLDcgKzIz LDcgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCi1jbGFzcyBG b3JtYXR0ZXIKK1dlYkluc3BlY3Rvci5Gb3JtYXR0ZXIgPSBjbGFzcyBGb3JtYXR0ZXIKIHsKICAg ICBjb25zdHJ1Y3Rvcihjb2RlTWlycm9yLCBidWlsZGVyKQogICAgIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Zvcm1hdHRlckNv bnRlbnRCdWlsZGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvRm9ybWF0dGVyQ29udGVudEJ1aWxkZXIuanMKaW5kZXggNGQ3NDFlZWRhMWZjNmQx NzQ0MDQyOGYyNDQ1NTZhMWQ5Mjk5NTM4Mi4uZTkxNzMxNDFiNzk5YTVlMzAxZTQ5OGE2YzBlOWNm OGIwODE1OWMwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvRm9ybWF0dGVyQ29udGVudEJ1aWxkZXIuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRm9ybWF0dGVyQ29udGVudEJ1 aWxkZXIuanMKQEAgLTI0LDcgKzI0LDcgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB TUFHRS4KICAqLwogCi1jbGFzcyBGb3JtYXR0ZXJDb250ZW50QnVpbGRlcgorV2ViSW5zcGVjdG9y LkZvcm1hdHRlckNvbnRlbnRCdWlsZGVyID0gY2xhc3MgRm9ybWF0dGVyQ29udGVudEJ1aWxkZXIK IHsKICAgICBjb25zdHJ1Y3RvcihtYXBwaW5nLCBvcmlnaW5hbExpbmVFbmRpbmdzLCBmb3JtYXR0 ZWRMaW5lRW5kaW5ncywgb3JpZ2luYWxPZmZzZXQsIGZvcm1hdHRlZE9mZnNldCwgaW5kZW50U3Ry aW5nKQogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0 b3IuanMKaW5kZXggOGRjMTJjYzlhNzdlMGI1NmE1ZGVlYmE3ODVkOGVlNTkzMGViOTQ4ZC4uNTcz NGY4NTA2ZDZkZTc1YzU5MDhiOGVkNjAxZWYzM2JhODQ3MWVhMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRl eHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKQEAgLTE0NzAsOCArMTQ3MCw4IEBA IFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvciA9IGNsYXNzIENTU1N0 eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yCiAgICAgICAgIHZhciBtYXBwaW5nID0ge29yaWdpbmFs OiBbMF0sIGZvcm1hdHRlZDogWzBdfTsKICAgICAgICAgLy8gRklYTUU6IDxyZGFyOi8vcHJvYmxl bS8xMDU5Mzk0OD4gUHJvdmlkZSBhIHdheSB0byBjaGFuZ2UgdGhlIHRhYiB3aWR0aCBpbiB0aGUg V2ViIEluc3BlY3RvcgogICAgICAgICB2YXIgaW5kZW50U3RyaW5nID0gIiAgICAiOwotICAgICAg ICB2YXIgYnVpbGRlciA9IG5ldyBGb3JtYXR0ZXJDb250ZW50QnVpbGRlcihtYXBwaW5nLCBbXSwg W10sIDAsIDAsIGluZGVudFN0cmluZyk7Ci0gICAgICAgIHZhciBmb3JtYXR0ZXIgPSBuZXcgRm9y bWF0dGVyKHRoaXMuX2NvZGVNaXJyb3IsIGJ1aWxkZXIpOworICAgICAgICB2YXIgYnVpbGRlciA9 IG5ldyBXZWJJbnNwZWN0b3IuRm9ybWF0dGVyQ29udGVudEJ1aWxkZXIobWFwcGluZywgW10sIFtd LCAwLCAwLCBpbmRlbnRTdHJpbmcpOworICAgICAgICB2YXIgZm9ybWF0dGVyID0gbmV3IFdlYklu c3BlY3Rvci5Gb3JtYXR0ZXIodGhpcy5fY29kZU1pcnJvciwgYnVpbGRlcik7CiAgICAgICAgIHZh ciBzdGFydCA9IHtsaW5lOiAwLCBjaDogMH07CiAgICAgICAgIHZhciBlbmQgPSB7bGluZTogdGhp cy5fY29kZU1pcnJvci5saW5lQ291bnQoKSAtIDF9OwogICAgICAgICBmb3JtYXR0ZXIuZm9ybWF0 KHN0YXJ0LCBlbmQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5kZXggMjg0NDQwYTcxMGUyMmFjYTY4ZmMyMmFj ZDhkZmYzYmRlNTRiZDljMC4uOWJkZTllZDJlZTMxOWRiMTVhMzBiYjM3NTk5MmY2ZDVkNDhiMjY0 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UZXh0RWRpdG9yLmpzCkBAIC03MzgsOCArNzM4LDggQEAgV2ViSW5zcGVjdG9yLlRleHRF ZGl0b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAg ICAgICAgICAgICAgIHZhciBvcmlnaW5hbExpbmVFbmRpbmdzID0gW107CiAgICAgICAgICAgICAg ICAgdmFyIGZvcm1hdHRlZExpbmVFbmRpbmdzID0gW107CiAgICAgICAgICAgICAgICAgdmFyIG1h cHBpbmcgPSB7b3JpZ2luYWw6IFswXSwgZm9ybWF0dGVkOiBbMF19OwotICAgICAgICAgICAgICAg IHZhciBidWlsZGVyID0gbmV3IEZvcm1hdHRlckNvbnRlbnRCdWlsZGVyKG1hcHBpbmcsIG9yaWdp bmFsTGluZUVuZGluZ3MsIGZvcm1hdHRlZExpbmVFbmRpbmdzLCAwLCAwLCBpbmRlbnRTdHJpbmcp OwotICAgICAgICAgICAgICAgIHZhciBmb3JtYXR0ZXIgPSBuZXcgRm9ybWF0dGVyKHRoaXMuX2Nv ZGVNaXJyb3IsIGJ1aWxkZXIpOworICAgICAgICAgICAgICAgIHZhciBidWlsZGVyID0gbmV3IFdl Ykluc3BlY3Rvci5Gb3JtYXR0ZXJDb250ZW50QnVpbGRlcihtYXBwaW5nLCBvcmlnaW5hbExpbmVF bmRpbmdzLCBmb3JtYXR0ZWRMaW5lRW5kaW5ncywgMCwgMCwgaW5kZW50U3RyaW5nKTsKKyAgICAg ICAgICAgICAgICB2YXIgZm9ybWF0dGVyID0gbmV3IFdlYkluc3BlY3Rvci5Gb3JtYXR0ZXIodGhp cy5fY29kZU1pcnJvciwgYnVpbGRlcik7CiAgICAgICAgICAgICAgICAgZm9ybWF0dGVyLmZvcm1h dChzdGFydCwgZW5kKTsKIAogICAgICAgICAgICAgICAgIHRoaXMuX2Zvcm1hdHRlclNvdXJjZU1h cCA9IFdlYkluc3BlY3Rvci5Gb3JtYXR0ZXJTb3VyY2VNYXAuZnJvbUJ1aWxkZXIoYnVpbGRlcik7 Cg==