147535 2015-08-01 23:14:19 -0700 Inline video controls overlap each other while playing video in slideover mode 2015-08-03 14:07:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 1114077 0 dino 2015-08-01 23:14:19 -0700 Inline video controls overlap each other while playing video in slideover mode 1114078 1 dino 2015-08-01 23:17:11 -0700 <rdar://problem/22026864> 1114079 2 258024 dino 2015-08-01 23:17:38 -0700 Created attachment 258024 Patch 1114097 3 258024 eric.carlson 2015-08-02 06:17:20 -0700 Comment on attachment 258024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review Nice, the Changelog is longer than the patch > Source/WebCore/ChangeLog:22 > + (audio::-webkit-media-controls-panel .hidden): Deleted. Nit: This wasn't deleted. 1114098 4 258024 simon.fraser 2015-08-02 08:45:40 -0700 Comment on attachment 258024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review > Source/WebCore/ChangeLog:16 > + Meanwhile, now that we use the CSS zoom property for scaling, we > + don't need to factor in the page scale factor when calculating > + the size. Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that? 1114126 5 258024 dino 2015-08-02 15:55:08 -0700 Comment on attachment 258024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review >> Source/WebCore/ChangeLog:16 >> + the size. > > Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that? You're right. I need to adjust for this. 1114351 6 dino 2015-08-03 14:07:01 -0700 Committed r187762: <http://trac.webkit.org/changeset/187762> 258024 2015-08-01 23:17:38 -0700 2015-08-02 06:17:20 -0700 Patch bug-147535-20150802161733.patch text/plain 3467 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdjZDk2MzlmZTI5NDU4 Y2I3NzlhYTE5NTY3NjhlYzE2NjVjMmYwZi4uNTQyNjE0ZTkyMDNhMTIwYmEzNTA3ZWZlMTEwNWYw NWI2ZGNlZTdhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA4LTAxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBJbmxpbmUgdmlkZW8gY29udHJv bHMgb3ZlcmxhcCBlYWNoIG90aGVyIHdoaWxlIHBsYXlpbmcgdmlkZW8gaW4gc2xpZGVvdmVyIG1v ZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzUz NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjIwMjY4NjQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm93IHRoYXQgdGhlIHJlc2l6aW5nIGNvZGUg aXMgaW4gdGhlIHNoYXJlZCBjb250cm9sbGVyLCB3ZSBuZWVkIHRvCisgICAgICAgIG1ha2Ugc3Vy ZSB0byBoaWRlIHRoZSB0aW1lbGluZSBzY3J1YmJlciBpbiBpT1Mgd2hlbiB0aGUgY29udHJvbHMK KyAgICAgICAgZ2V0IHRvbyBzbWFsbC4gVGhpcyBpbnZvbHZlZCBhZGRpbmcgdGhlIGRyb3BwZWQg Y2xhc3MgdG8gdGhlIHRpbWVsaW5lLAorICAgICAgICBhbmQgcnVsZXMgZm9yIGhpZGluZyB0byB0 aGUgQ1NTLgorCisgICAgICAgIE1lYW53aGlsZSwgbm93IHRoYXQgd2UgdXNlIHRoZSBDU1Mgem9v bSBwcm9wZXJ0eSBmb3Igc2NhbGluZywgd2UKKyAgICAgICAgZG9uJ3QgbmVlZCB0byBmYWN0b3Ig aW4gdGhlIHBhZ2Ugc2NhbGUgZmFjdG9yIHdoZW4gY2FsY3VsYXRpbmcKKyAgICAgICAgdGhlIHNp emUuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxl LmpzOgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUudXBkYXRlTGF5b3V0Rm9yRGlzcGxh eWVkV2lkdGgpOiBEb24ndCB1c2UgcGFnZVNjYWxlRmFjdG9yLgorICAgICAgICAqIE1vZHVsZXMv bWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmNzczoKKyAgICAgICAgKGF1ZGlvOjotd2Vi a2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsIC5kcm9wcGVkKTogQWRkIGRpc3BsYXkgbm9uZSBmb3Ig dGhpcyBydWxlLgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwg LmhpZGRlbik6IERlbGV0ZWQuCisKIDIwMTUtMDctMjkgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBw bGUuY29tPgogCiAgICAgICAgIERvbid0IHVzZSAoRGV0YWlscykgd2hlbiBleHBvc2luZyBTUEkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzQXBwbGUuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVk aWFDb250cm9sc0FwcGxlLmpzCmluZGV4IDQ2ZTEzYzg0ODY2OGQ5NDdlZmIwNmUzOGI4Nzk3Y2Zl NzQ3ODNmMTkuLjcxMzNkMjc5MWZiMDFmNTE5MWNlNTEzZjllMTQ3MjNlNTRjNTE0YzcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xz QXBwbGUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh Q29udHJvbHNBcHBsZS5qcwpAQCAtMTQ1Myw3ICsxNDUzLDcgQEAgQ29udHJvbGxlci5wcm90b3R5 cGUgPSB7CiAgICAgICAgIGlmICghdGhpcy5jb250cm9scyB8fCAhdGhpcy5jb250cm9scy5wYW5l bCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgdmlzaWJsZVdpZHRoID0gdGhp cy5jb250cm9scy5wYW5lbC5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKS53aWR0aCAqIHRoaXMuX3Bh Z2VTY2FsZUZhY3RvcjsKKyAgICAgICAgdmFyIHZpc2libGVXaWR0aCA9IHRoaXMuY29udHJvbHMu cGFuZWwuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkud2lkdGg7CiAgICAgICAgIGlmICh2aXNpYmxl V2lkdGggPD0gMCB8fCB2aXNpYmxlV2lkdGggPT0gdGhpcy5jdXJyZW50RGlzcGxheVdpZHRoKQog ICAgICAgICAgICAgcmV0dXJuOwogCkBAIC0xNDcwLDYgKzE0NzAsNyBAQCBDb250cm9sbGVyLnBy b3RvdHlwZSA9IHsKIAogICAgICAgICAvLyBDaGVjayBpZiB0aGVyZSBpcyBlbm91Z2ggcm9vbSBm b3IgdGhlIHNjcnViYmVyLgogICAgICAgICB2YXIgc2hvdWxkRHJvcFRpbWVsaW5lID0gKHZpc2li bGVXaWR0aCAtIHZpc2libGVCdXR0b25XaWR0aCkgPCB0aGlzLk1pbmltdW1UaW1lbGluZVdpZHRo OworICAgICAgICB0aGlzLmNvbnRyb2xzLnRpbWVsaW5lLmNsYXNzTGlzdC50b2dnbGUodGhpcy5D bGFzc05hbWVzLmRyb3BwZWQsIHNob3VsZERyb3BUaW1lbGluZSk7CiAgICAgICAgIHRoaXMuY29u dHJvbHMuY3VycmVudFRpbWUuY2xhc3NMaXN0LnRvZ2dsZSh0aGlzLkNsYXNzTmFtZXMuZHJvcHBl ZCwgc2hvdWxkRHJvcFRpbWVsaW5lKTsKICAgICAgICAgdGhpcy5jb250cm9scy50aHVtYm5haWxU cmFjay5jbGFzc0xpc3QudG9nZ2xlKHRoaXMuQ2xhc3NOYW1lcy5kcm9wcGVkLCBzaG91bGREcm9w VGltZWxpbmUpOwogICAgICAgICB0aGlzLmNvbnRyb2xzLnJlbWFpbmluZ1RpbWUuY2xhc3NMaXN0 LnRvZ2dsZSh0aGlzLkNsYXNzTmFtZXMuZHJvcHBlZCwgc2hvdWxkRHJvcFRpbWVsaW5lKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRy b2xzaU9TLmNzcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzaU9TLmNzcwppbmRleCA2ZjY3NzM1Y2I4NGJiN2M2NjBlNGI5MzBjZjkxYmFkODMyN2U1 Y2IyLi40Y2FkMmVkMjRkY2VjN2Y2OWZjMGVmYmU3MTUwYTExNjA4ZjUwMzBlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5j c3MKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJv bHNpT1MuY3NzCkBAIC0xNTMsNyArMTUzLDkgQEAgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJv bHMtcGFuZWwgewogfQogCiB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCAuaGlk ZGVuLAotYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwgLmhpZGRlbiB7CithdWRp bzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCAuaGlkZGVuLAordmlkZW86Oi13ZWJraXQt bWVkaWEtY29udHJvbHMtcGFuZWwgLmRyb3BwZWQsCithdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250 cm9scy1wYW5lbCAuZHJvcHBlZCB7CiAgICAgZGlzcGxheTogbm9uZTsKIH0KIAo=