147526 2015-08-01 01:22:10 -0700 Build with VS2015 2015-08-01 13:15:36 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen benjamin cmarcelo commit-queue oldest_to_newest 1114009 0 achristensen 2015-08-01 01:22:10 -0700 This completes r187702 1114011 1 258006 achristensen 2015-08-01 01:26:16 -0700 Created attachment 258006 Patch 1114045 2 258006 mmaxfield 2015-08-01 12:21:08 -0700 Comment on attachment 258006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258006&action=review r=me > Source/WebCore/bindings/js/JSDOMBinding.h:216 > + WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref)); just say "globalObject, Ref<DOMClass>(*node));" you may even be able to get away with removing the <DOMClass> from the line above 1114050 3 achristensen 2015-08-01 12:56:25 -0700 http://trac.webkit.org/changeset/187721 1114051 4 achristensen 2015-08-01 12:57:11 -0700 (In reply to comment #2) > > Source/WebCore/bindings/js/JSDOMBinding.h:216 > > + WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref)); > > just say "globalObject, Ref<DOMClass>(*node));" > > you may even be able to get away with removing the <DOMClass> from the line > above Template parameter was necessary, WTF::move was not. 1114055 5 achristensen 2015-08-01 13:15:36 -0700 Thanks for the fix, Myles. I should probably look at the code I commit :( http://trac.webkit.org/changeset/187722 258006 2015-08-01 01:26:16 -0700 2015-08-01 12:21:08 -0700 Patch bug-147526-20150801012613.patch text/plain 3868 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODc3MTQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTAxICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNvbXBpbGUgZXJyb3JzIHdp dGggVlMyMDE1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDc1MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHd0Zi9TdHJpbmdFeHRyYXMuaDoKKyAgICAgICAgKHNucHJpbnRmKToKKyAgICAgICAgKHd0 Zl92c25wcmludGYpOgorICAgICAgICBWUzIwMTUgaGFzIGFuIGltcGxlbWVudGF0aW9uIG9mIHNu cHJpbnRmLgorCiAyMDE1LTA3LTMxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUHJlcGFyZSBmb3IgVlMyMDE1CkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9TdHJpbmdFeHRyYXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9TdHJpbmdF eHRyYXMuaAkocmV2aXNpb24gMTg3NzE0KQorKysgU291cmNlL1dURi93dGYvU3RyaW5nRXh0cmFz LmgJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQwLDcgQEAKIAogI2luY2x1ZGUgPGVycm5vLmg+ CiAKKyNpZiBfTVNDX1ZFUiA8IDE5MDAKIGlubGluZSBpbnQgc25wcmludGYoY2hhciogYnVmZmVy LCBzaXplX3QgY291bnQsIGNvbnN0IGNoYXIqIGZvcm1hdCwgLi4uKSAKIHsKICAgICBpbnQgcmVz dWx0OwpAQCAtNTcsNiArNTgsNyBAQCBpbmxpbmUgaW50IHNucHJpbnRmKGNoYXIqIGJ1ZmZlciwg c2l6ZV90CiAKICAgICByZXR1cm4gcmVzdWx0OwogfQorI2VuZGlmCiAKIGlubGluZSBkb3VibGUg d3RmX3ZzbnByaW50ZihjaGFyKiBidWZmZXIsIHNpemVfdCBjb3VudCwgY29uc3QgY2hhciogZm9y bWF0LCB2YV9saXN0IGFyZ3MpCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODc3MTQpCisr KyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBA QAorMjAxNS0wOC0wMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgorCisgICAgICAgIEZpeCBjb21waWxlIGVycm9ycyB3aXRoIFZTMjAxNQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NTI2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJp bmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZVdyYXBwZXIpOgorICAgICAgICBFeHBs aWNpdGx5IG1ha2UgYSBSZWYmJiB0byBhdm9pZCB1bnJlc29sdmVkIHN5bWJvbHMgd2l0aCBWUzIw MTUuCisKIDIwMTUtMDctMjcgIE1hdHQgUmFqY2EgIDxtcmFqY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIE1lZGlhIFNlc3Npb246IGluZm9ybSB0aGUgVUkgcHJvY2VzcyB3aGVuIHRoZSBmb2N1c2Vk IENvbnRlbnQgbWVkaWEgZWxlbWVudCBjaGFuZ2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTUJpbmRpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTUJpbmRpbmcuaAkocmV2aXNpb24gMTg3NzE0KQorKysgU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxMiw3ICsy MTIsOCBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBXcmFwcGVyQ2xhc3MsIHR5cGVuYW1lCiB7CiAgICAg QVNTRVJUKG5vZGUpOwogICAgIEFTU0VSVCghZ2V0Q2FjaGVkV3JhcHBlcihnbG9iYWxPYmplY3Qt PndvcmxkKCksIG5vZGUpKTsKLSAgICBXcmFwcGVyQ2xhc3MqIHdyYXBwZXIgPSBXcmFwcGVyQ2xh c3M6OmNyZWF0ZShnZXRET01TdHJ1Y3R1cmU8V3JhcHBlckNsYXNzPihnbG9iYWxPYmplY3QtPnZt KCksIGdsb2JhbE9iamVjdCksIGdsb2JhbE9iamVjdCwgKm5vZGUpOworICAgIFJlZjxET01DbGFz cz4gcmVmID0gKm5vZGU7CisgICAgV3JhcHBlckNsYXNzKiB3cmFwcGVyID0gV3JhcHBlckNsYXNz OjpjcmVhdGUoZ2V0RE9NU3RydWN0dXJlPFdyYXBwZXJDbGFzcz4oZ2xvYmFsT2JqZWN0LT52bSgp LCBnbG9iYWxPYmplY3QpLCBnbG9iYWxPYmplY3QsIFdURjo6bW92ZShyZWYpKTsKICAgICBjYWNo ZVdyYXBwZXIoZ2xvYmFsT2JqZWN0LT53b3JsZCgpLCBub2RlLCB3cmFwcGVyKTsKICAgICByZXR1 cm4gd3JhcHBlcjsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NzcxNCkKKysr IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA4LTAxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v cmc+CisKKyAgICAgICAgRml4IGNvbXBpbGUgZXJyb3JzIHdpdGggVlMyMDE1CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc1MjYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdERMTC5jcHA6Cisg ICAgICAgIChzaHV0RG93bldlYktpdCk6CisgICAgICAgIChsb2FkUmVzb3VyY2VJbnRvQnVmZmVy KTogTmVlZHMgdG8gYmUgZXhwb3J0ZWQgZnJvbSBXZWJLaXQuZGxsIHRvIGxpbmsgd2l0aCBDTWFr ZSB1c2luZyBWUzIwMTUuCisKIDIwMTUtMDctMjcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVc2UgTmluamEgb24gV2luZG93cy4KSW5kZXg6 IFNvdXJjZS9XZWJLaXQvd2luL1dlYktpdERMTC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC93aW4vV2ViS2l0RExMLmNwcAkocmV2aXNpb24gMTg3NzE0KQorKysgU291cmNlL1dlYktp dC93aW4vV2ViS2l0RExMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU3LDcgKzE1Nyw3IEBAIHZv aWQgc2h1dERvd25XZWJLaXQoKQogfQogCiAvL0ZJWE1FOiBXZSBzaG91bGQgY29uc2lkZXIgbW92 aW5nIHRoaXMgdG8gYSBuZXcgZmlsZSBmb3IgY3Jvc3MtcHJvamVjdCBmdW5jdGlvbmFsaXR5Ci1Q YXNzUmVmUHRyPFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcj4gbG9hZFJlc291cmNlSW50b0J1ZmZlcihj b25zdCBjaGFyKiBuYW1lKQorV0VCS0lUX0FQSSBQYXNzUmVmUHRyPFdlYkNvcmU6OlNoYXJlZEJ1 ZmZlcj4gbG9hZFJlc291cmNlSW50b0J1ZmZlcihjb25zdCBjaGFyKiBuYW1lKQogewogICAgIGlu dCBpZHI7CiAgICAgLy8gdGVtcG9yYXJ5IGhhY2sgdG8gZ2V0IHJlc291cmNlIGlkCg==