147514 2015-07-31 15:31:52 -0700 usingDot in drawLineForDocumentMarker assigns bool twice 2015-08-04 15:37:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED PlatformOnly P2 Normal --- 1 mdaiter mdaiter bfulgham commit-queue eric.carlson jeremyj-wk jer.noble jonlee mdaiter webkit-bug-importer webkit.review.bot oldest_to_newest 1113897 0 mdaiter 2015-07-31 15:31:52 -0700 Needless reassign of bool 1113900 1 257971 mdaiter 2015-07-31 15:38:25 -0700 Created attachment 257971 Patch 1114027 2 257971 eric.carlson 2015-08-01 09:04:59 -0700 Comment on attachment 257971 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257971&action=review > Source/WebCore/ChangeLog:9 > + (WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted. This comment is not correct, the method was not deleted. 1114821 3 257971 commit-queue 2015-08-04 15:37:04 -0700 Comment on attachment 257971 Patch Clearing flags on attachment: 257971 Committed r187896: <http://trac.webkit.org/changeset/187896> 1114822 4 commit-queue 2015-08-04 15:37:08 -0700 All reviewed patches have been landed. Closing bug. 257971 2015-07-31 15:38:25 -0700 2015-08-04 15:37:04 -0700 Patch bug-147514-20150731153823.patch text/plain 1579 mdaiter U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmYyNDNmZTNhYWU3YjY0 N2ZlN2Q0ZDU2ODFlMmMyYTBhYjZlY2U3NS4uNTM3NzhlOTVkOWFkYzc4NGIzZWM1MjlhY2MxNmIx NTk3NDNiZWJhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA3LTMxICBNYXR0 aGV3IERhaXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgorCisgICAgICAgIE5lZWRsZXNzIGFzc2ln bm1lbnQgb2YgdXNpbmdEb3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0NzUxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dE1hYy5tbToK KyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JEb2N1bWVudE1h cmtlcik6IERlbGV0ZWQuCisKIDIwMTUtMDctMzEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBJbWFnZUJ1ZmZlckRhdGFDRyBzaG91bGQgbm90IGFkZCBJT1N1cmZh Y2VzIHRvIHRoZSBwb29sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvR3JhcGhpY3NDb250ZXh0TWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dE1hYy5tbQppbmRleCBiMjZjMmMzNTcyNzk3YWQy N2NiY2RhYzExYjg5NmU1NjUzZTc3ZjZjLi45MzY1ODc4ODMwODJhODU5NmY1MGE4NjAzNmIyM2I2 ZjA1NTQzYjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvR3JhcGhpY3NDb250ZXh0TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHRNYWMubW0KQEAgLTE4NCw3ICsxODQsNiBAQCB2b2lk IEdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JEb2N1bWVudE1hcmtlcihjb25zdCBGbG9hdFBv aW50JiBwb2ludCwgZmxvYXQgdwogI2lmICFQTEFURk9STShJT1MpCiAgICAgICAgICAgICBpZiAo IXNwZWxsaW5nUGF0dGVybkNvbG9yKQogICAgICAgICAgICAgICAgIHNwZWxsaW5nUGF0dGVybkNv bG9yID0gW21ha2VQYXR0ZXJuQ29sb3IoQCJOU1NwZWxsaW5nRG90IiwgQCJTcGVsbGluZ0RvdCIs IFtOU0NvbG9yIHJlZENvbG9yXSwgdXNpbmdEb3RGb3JTcGVsbGluZykgcmV0YWluXTsKLSAgICAg ICAgICAgIHVzaW5nRG90ID0gdXNpbmdEb3RGb3JTcGVsbGluZzsKICAgICAgICAgICAgIHBhdHRl cm5Db2xvciA9IHNwZWxsaW5nUGF0dGVybkNvbG9yOwogI2Vsc2UKICAgICAgICAgICAgIHN0YXRp YyBDR1BhdHRlcm5SZWYgc3BlbGxpbmdQYXR0ZXJuID0gY3JlYXRlRG90UGF0dGVybih1c2luZ0Rv dEZvclNwZWxsaW5nLCAiU3BlbGxpbmdEb3QiKS5sZWFrUmVmKCk7Cg==