147509 2015-07-31 15:02:23 -0700 [iOS] use a media-specific user gesture check 2018-06-18 03:19:08 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186593 InRadar P2 Normal --- 1 eric.carlson eric.carlson fred.wang oldest_to_newest 1113877 0 eric.carlson 2015-07-31 15:02:23 -0700 ScriptController::processingUserGesture now only returns true for an event handler triggered by a touch end. This is correct in most contexts, and we should have probably done this from the beginning, but it breaks some existing scripts that try to trigger media loading or playback in a touch start handler, so add a media-specific method that allows touch start or touch end events. 1113881 1 eric.carlson 2015-07-31 15:03:02 -0700 rdar://problem/22015509 1113896 2 257969 eric.carlson 2015-07-31 15:31:40 -0700 Created attachment 257969 Proposed patch. 1113908 3 eric.carlson 2015-07-31 16:00:05 -0700 Committed r187688: https://trac.webkit.org/r187688 1113926 4 eric.carlson 2015-07-31 17:09:55 -0700 Plus r187694: https://trac.webkit.org/r187694 1433930 5 fred.wang 2018-06-18 03:19:08 -0700 Where is ProcessingPotentialUserGesture actually used? For someone just reading WebKit's code, it's not obvious why UserGestureIndicator.h actually needs to define ProcessingPotentialUserGesture and processingUserGestureForMedia(). 257969 2015-07-31 15:31:40 -0700 2015-07-31 15:44:26 -0700 Proposed patch. webcore_patch_1.txt text/plain 5232 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NzY4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA3LTMxICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIHVzZSBhIG1l ZGlhLXNwZWNpZmljIHVzZXIgZ2VzdHVyZSBjaGVjaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2Vz dHVyZUZvck1lZGlhKTogTmV3LgorICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xs ZXIuaDoKKworICAgICAgICAqIGRvbS9Vc2VyR2VzdHVyZUluZGljYXRvci5jcHA6CisgICAgICAg IChXZWJDb3JlOjppc0RlZmluaXRlKTogQWxsb3cgRGVmaW5pdGVseVByb2Nlc3NpbmdNZWRpYVVz ZXJHZXN0dXJlLgorICAgICAgICAoV2ViQ29yZTo6VXNlckdlc3R1cmVJbmRpY2F0b3I6OnByb2Nl c3NpbmdVc2VyR2VzdHVyZUZvck1lZGlhKTogTmV3LgorICAgICAgICAqIGRvbS9Vc2VyR2VzdHVy ZUluZGljYXRvci5oOgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWQpOiBVc2UgU2NyaXB0Q29udHJv bGxlcjo6cHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVkaWEgaW5zdGVhZCBvZiAKKyAgICAgICAg ICBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnBsYXkpOiBEaXR0by4KKwogMjAxNS0wNy0zMSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEltYWdlQnVmZmVyRGF0YUNHIHNo b3VsZCBub3QgYWRkIElPU3VyZmFjZXMgdG8gdGhlIHBvb2wKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxODc1ODIp CisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzA2LDYgKzMwNiwxMSBAQCBib29sIFNjcmlwdENvbnRyb2xsZXI6OnBy b2Nlc3NpbmdVc2VyR2VzCiAgICAgcmV0dXJuIFVzZXJHZXN0dXJlSW5kaWNhdG9yOjpwcm9jZXNz aW5nVXNlckdlc3R1cmUoKTsKIH0KIAorYm9vbCBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5n VXNlckdlc3R1cmVGb3JNZWRpYSgpCit7CisgICAgcmV0dXJuIFVzZXJHZXN0dXJlSW5kaWNhdG9y Ojpwcm9jZXNzaW5nVXNlckdlc3R1cmVGb3JNZWRpYSgpOworfQorCiBib29sIFNjcmlwdENvbnRy b2xsZXI6OmNhbkFjY2Vzc0Zyb21DdXJyZW50T3JpZ2luKEZyYW1lICpmcmFtZSkKIHsKICAgICBF eGVjU3RhdGUqIGV4ZWMgPSBKU01haW5UaHJlYWRFeGVjU3RhdGU6OmN1cnJlbnRTdGF0ZSgpOwpJ bmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuaAko cmV2aXNpb24gMTg3NTgyKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29u dHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjEsNiArMTIxLDcgQEAgcHVibGljOgogICAg IHZvaWQgZGlzYWJsZUV2YWwoY29uc3QgU3RyaW5nJiBlcnJvck1lc3NhZ2UpOwogCiAgICAgV0VC Q09SRV9FWFBPUlQgc3RhdGljIGJvb2wgcHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCk7CisgICAgV0VC Q09SRV9FWFBPUlQgc3RhdGljIGJvb2wgcHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVkaWEoKTsK IAogICAgIHN0YXRpYyBib29sIGNhbkFjY2Vzc0Zyb21DdXJyZW50T3JpZ2luKEZyYW1lKik7CiAg ICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBjYW5FeGVjdXRlU2NyaXB0cyhSZWFzb25Gb3JDYWxsaW5n Q2FuRXhlY3V0ZVNjcmlwdHMpOwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1VzZXJHZXN0dXJl SW5kaWNhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vVXNlckdlc3R1 cmVJbmRpY2F0b3IuY3BwCShyZXZpc2lvbiAxODc1ODIpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20v VXNlckdlc3R1cmVJbmRpY2F0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw3IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGJvb2wgaXNEZWZpbml0ZShQcm9jZXNzaW5n VXNlckdlc3R1cmVTdGF0ZSBzdGF0ZSkKIHsKLSAgICByZXR1cm4gc3RhdGUgPT0gRGVmaW5pdGVs eVByb2Nlc3NpbmdVc2VyR2VzdHVyZSB8fCBzdGF0ZSA9PSBEZWZpbml0ZWx5Tm90UHJvY2Vzc2lu Z1VzZXJHZXN0dXJlOworICAgIHJldHVybiBzdGF0ZSA9PSBEZWZpbml0ZWx5UHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlIHx8IHN0YXRlID09IERlZmluaXRlbHlOb3RQcm9jZXNzaW5nVXNlckdlc3R1cmUg fHwgc3RhdGUgPT0gRGVmaW5pdGVseVByb2Nlc3NpbmdNZWRpYVVzZXJHZXN0dXJlOwogfQogCiBQ cm9jZXNzaW5nVXNlckdlc3R1cmVTdGF0ZSBVc2VyR2VzdHVyZUluZGljYXRvcjo6c19zdGF0ZSA9 IERlZmluaXRlbHlOb3RQcm9jZXNzaW5nVXNlckdlc3R1cmU7CkBAIC02Niw0ICs2NiwxMiBAQCBi b29sIFVzZXJHZXN0dXJlSW5kaWNhdG9yOjpwcm9jZXNzaW5nVXNlCiAgICAgcmV0dXJuIGlzTWFp blRocmVhZCgpID8gc19zdGF0ZSA9PSBEZWZpbml0ZWx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlIDog ZmFsc2U7CiB9CiAKK2Jvb2wgVXNlckdlc3R1cmVJbmRpY2F0b3I6OnByb2Nlc3NpbmdVc2VyR2Vz dHVyZUZvck1lZGlhKCkKK3sKKyAgICBpZiAoIWlzTWFpblRocmVhZCgpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICByZXR1cm4gc19zdGF0ZSA9PSBEZWZpbml0ZWx5UHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlIHx8IHNfc3RhdGUgPT0gRGVmaW5pdGVseVByb2Nlc3NpbmdNZWRpYVVzZXJHZXN0 dXJlOworfQorCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vVXNlckdlc3R1cmVJbmRpY2F0 b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vVXNlckdlc3R1cmVJbmRpY2F0 b3IuaAkocmV2aXNpb24gMTg3NTgyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL1VzZXJHZXN0dXJl SW5kaWNhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDcgQEAgY2xhc3MgRG9jdW1l bnQ7CiAKIGVudW0gUHJvY2Vzc2luZ1VzZXJHZXN0dXJlU3RhdGUgewogICAgIERlZmluaXRlbHlQ cm9jZXNzaW5nVXNlckdlc3R1cmUsCisgICAgRGVmaW5pdGVseVByb2Nlc3NpbmdNZWRpYVVzZXJH ZXN0dXJlLAogICAgIFBvc3NpYmx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlLAogICAgIERlZmluaXRl bHlOb3RQcm9jZXNzaW5nVXNlckdlc3R1cmUKIH07CkBAIC00Miw2ICs0Myw3IEBAIGNsYXNzIFVz ZXJHZXN0dXJlSW5kaWNhdG9yIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShVc2VyR2VzdHVy ZUluZGljYXRvcik7CiBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wgcHJvY2Vzc2luZ1VzZXJHZXN0 dXJlKCk7CisgICAgc3RhdGljIGJvb2wgcHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVkaWEoKTsK IAogICAgIC8vIElmIGEgZG9jdW1lbnQgaXMgcHJvdmlkZWQsIGl0cyBsYXN0IGtub3duIHVzZXIg Z2VzdHVyZSB0aW1lc3RhbXAgaXMgdXBkYXRlZC4KICAgICBXRUJDT1JFX0VYUE9SVCBleHBsaWNp dCBVc2VyR2VzdHVyZUluZGljYXRvcihQcm9jZXNzaW5nVXNlckdlc3R1cmVTdGF0ZSwgRG9jdW1l bnQqID0gbnVsbHB0cik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAJKHJldmlzaW9uIDE4NzU4MikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkyMCw3ICs5MjAsNyBAQCB2b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OmxvYWQoKQogICAgIAogICAgIGlmICghbV9tZWRpYVNlc3Npb24tPmRhdGFM b2FkaW5nUGVybWl0dGVkKCp0aGlzKSkKICAgICAgICAgcmV0dXJuOwotICAgIGlmIChTY3JpcHRD b250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKSkKKyAgICBpZiAoU2NyaXB0Q29udHJv bGxlcjo6cHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVkaWEoKSkKICAgICAgICAgcmVtb3ZlQmVo YXZpb3JzUmVzdHJpY3Rpb25zQWZ0ZXJGaXJzdFVzZXJHZXN0dXJlKCk7CiAKICAgICBwcmVwYXJl Rm9yTG9hZCgpOwpAQCAtMjgzOSw3ICsyODM5LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpw bGF5KCkKIAogICAgIGlmICghbV9tZWRpYVNlc3Npb24tPnBsYXliYWNrUGVybWl0dGVkKCp0aGlz KSkKICAgICAgICAgcmV0dXJuOwotICAgIGlmIChTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5n VXNlckdlc3R1cmUoKSkKKyAgICBpZiAoU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1VzZXJH ZXN0dXJlRm9yTWVkaWEoKSkKICAgICAgICAgcmVtb3ZlQmVoYXZpb3JzUmVzdHJpY3Rpb25zQWZ0 ZXJGaXJzdFVzZXJHZXN0dXJlKCk7CiAKICAgICBwbGF5SW50ZXJuYWwoKTsK