147506 2015-07-31 14:17:24 -0700 Crashes under HTMLMediaElement::updateActiveTextTrackCues() when destroying CachedPage. 2015-07-31 15:44:07 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kling kling commit-queue oldest_to_newest 1113849 0 kling 2015-07-31 14:17:24 -0700 <rdar://problem/21939014> 1113851 1 257959 kling 2015-07-31 14:18:06 -0700 Created attachment 257959 Patch 1113855 2 psolanki 2015-07-31 14:21:27 -0700 *** Bug 147505 has been marked as a duplicate of this bug. *** 1113858 3 257959 cdumez 2015-07-31 14:24:46 -0700 Comment on attachment 257959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257959&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5542 > + if (!ActiveDOMObject::scriptExecutionContext() || ActiveDOMObject::scriptExecutionContext()->activeDOMObjectsAreStopped()) nit: Do we really need the "ActiveDOMObject::"? > Source/WebCore/html/HTMLMediaElement.cpp:5543 > + return; But now we're not doing the updateSleepDisabling() call anymore in this case, why is this OK? 1113864 4 257959 cdumez 2015-07-31 14:38:57 -0700 Comment on attachment 257959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257959&action=review r=me >> Source/WebCore/html/HTMLMediaElement.cpp:5542 >> + if (!ActiveDOMObject::scriptExecutionContext() || ActiveDOMObject::scriptExecutionContext()->activeDOMObjectsAreStopped()) > > nit: Do we really need the "ActiveDOMObject::"? let's use document(). >> Source/WebCore/html/HTMLMediaElement.cpp:5543 >> + return; > > But now we're not doing the updateSleepDisabling() call anymore in this case, why is this OK? Sorry, I thought you were in clearMediaPlayer(), never mind my comment. 1113871 5 257962 kling 2015-07-31 14:50:55 -0700 Created attachment 257962 Patch for landing 1113901 6 257962 commit-queue 2015-07-31 15:44:03 -0700 Comment on attachment 257962 Patch for landing Clearing flags on attachment: 257962 Committed r187687: <http://trac.webkit.org/changeset/187687> 1113902 7 commit-queue 2015-07-31 15:44:07 -0700 All reviewed patches have been landed. Closing bug. 257959 2015-07-31 14:18:06 -0700 2015-07-31 14:50:55 -0700 Patch bug-147506.diff text/plain 1706 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MGNiYTRkLi44YmY5YjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTUtMDctMzEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIENyYXNoZXMgdW5kZXIgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlQWN0aXZlVGV4dFRyYWNr Q3VlcygpIHdoZW4gZGVzdHJveWluZyBDYWNoZWRQYWdlLgorICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMTQ3NTA2PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjE5MzkwMTQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgbWVzcyB3 aXRoIHRoZSBtZWRpYSBlbGVtZW50J3MgdGV4dCB0cmFja3MgYmVsb3cgaXRzIEFjdGl2ZURPTU9i amVjdDo6c3RvcCgpCisgICAgICAgIGltcGxlbWVudGF0aW9uLCBzaW5jZSB0aGF0IG1heSBjYXVz ZSBET00gbXV0YXRpb25zLgorCisgICAgICAgIEkgZG9uJ3QgaGF2ZSBhIHJlcHJvIG9yIGEgdGVz dCBmb3IgdGhpcywgYnV0IHBsZW50eSBvZiBjcmFzaCBsb2dzIHRvIGluZGljYXRlIHRoYXQKKyAg ICAgICAgd2UncmUgZ2V0dGluZyBvdXJzZWx2ZXMgaW50byB0cm91YmxlIGJ5IG1vZGlmeWluZyB0 aGUgRE9NIGR1cmluZyBDYWNoZWRQYWdlIHRlYXJkb3duLgorCisgICAgICAgICogaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNv bmZpZ3VyZVRleHRUcmFja0Rpc3BsYXkpOgorCiAyMDE1LTA3LTMwICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNlbGVjdGluZyBpbiBhbiBpZnJhbWUg Y2FuIGNhdXNlIG1haW4gcGFnZSBzY3JvbGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwCmluZGV4IGZhZDVmZTIuLmFkNTlmMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtNTUzOSw2ICs1NTM5LDkgQEAgdm9pZCBIVE1MTWVk aWFFbGVtZW50Ojpjb25maWd1cmVUZXh0VHJhY2tEaXNwbGF5KFRleHRUcmFja1Zpc2liaWxpdHlD aGVja1R5cGUgY2gKICAgICBpZiAobV9wcm9jZXNzaW5nUHJlZmVyZW5jZUNoYW5nZSkKICAgICAg ICAgcmV0dXJuOwogCisgICAgaWYgKCFBY3RpdmVET01PYmplY3Q6OnNjcmlwdEV4ZWN1dGlvbkNv bnRleHQoKSB8fCBBY3RpdmVET01PYmplY3Q6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+YWN0 aXZlRE9NT2JqZWN0c0FyZVN0b3BwZWQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYm9vbCBo YXZlVmlzaWJsZVRleHRUcmFjayA9IGZhbHNlOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBtX3RleHRUcmFja3MtPmxlbmd0aCgpOyArK2kpIHsKICAgICAgICAgaWYgKG1fdGV4dFRyYWNr cy0+aXRlbShpKS0+bW9kZSgpID09IFRleHRUcmFjazo6c2hvd2luZ0tleXdvcmQoKSkgewo= 257962 2015-07-31 14:50:55 -0700 2015-07-31 15:44:03 -0700 Patch for landing land-147506.diff text/plain 1625 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MGNiYTRkLi42YzlhMjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTUtMDctMzEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIENyYXNoZXMgdW5kZXIgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlQWN0aXZlVGV4dFRyYWNr Q3VlcygpIHdoZW4gZGVzdHJveWluZyBDYWNoZWRQYWdlLgorICAgICAgICA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMTQ3NTA2PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjE5MzkwMTQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgRG9uJ3QgbWVzcyB3aXRo IHRoZSBtZWRpYSBlbGVtZW50J3MgdGV4dCB0cmFja3MgYmVsb3cgaXRzIEFjdGl2ZURPTU9iamVj dDo6c3RvcCgpCisgICAgICAgIGltcGxlbWVudGF0aW9uLCBzaW5jZSB0aGF0IG1heSBjYXVzZSBE T00gbXV0YXRpb25zLgorCisgICAgICAgIEkgZG9uJ3QgaGF2ZSBhIHJlcHJvIG9yIGEgdGVzdCBm b3IgdGhpcywgYnV0IHBsZW50eSBvZiBjcmFzaCBsb2dzIHRvIGluZGljYXRlIHRoYXQKKyAgICAg ICAgd2UncmUgZ2V0dGluZyBvdXJzZWx2ZXMgaW50byB0cm91YmxlIGJ5IG1vZGlmeWluZyB0aGUg RE9NIGR1cmluZyBDYWNoZWRQYWdlIHRlYXJkb3duLgorCisgICAgICAgICogaHRtbC9IVE1MTWVk aWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZp Z3VyZVRleHRUcmFja0Rpc3BsYXkpOgorCiAyMDE1LTA3LTMwICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNlbGVjdGluZyBpbiBhbiBpZnJhbWUgY2Fu IGNhdXNlIG1haW4gcGFnZSBzY3JvbGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwCmluZGV4IGZhZDVmZTIuLmM4YTRiMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcApAQCAtNTUzOSw2ICs1NTM5LDkgQEAgdm9pZCBIVE1MTWVkaWFF bGVtZW50Ojpjb25maWd1cmVUZXh0VHJhY2tEaXNwbGF5KFRleHRUcmFja1Zpc2liaWxpdHlDaGVj a1R5cGUgY2gKICAgICBpZiAobV9wcm9jZXNzaW5nUHJlZmVyZW5jZUNoYW5nZSkKICAgICAgICAg cmV0dXJuOwogCisgICAgaWYgKGRvY3VtZW50KCkuYWN0aXZlRE9NT2JqZWN0c0FyZVN0b3BwZWQo KSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYm9vbCBoYXZlVmlzaWJsZVRleHRUcmFjayA9IGZh bHNlOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX3RleHRUcmFja3MtPmxlbmd0aCgp OyArK2kpIHsKICAgICAgICAgaWYgKG1fdGV4dFRyYWNrcy0+aXRlbShpKS0+bW9kZSgpID09IFRl eHRUcmFjazo6c2hvd2luZ0tleXdvcmQoKSkgewo=