147504 2015-07-31 14:14:09 -0700 [Cocoa] Latin quotes are used with the system font on Chinese devices 2015-08-10 20:07:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield dino jonlee simon.fraser thorton webkit-bug-importer oldest_to_newest 1113843 0 mmaxfield 2015-07-31 14:14:09 -0700 [Cocoa] Latin quotes are used with the system font on Chinese devices 1113844 1 257958 mmaxfield 2015-07-31 14:15:40 -0700 Created attachment 257958 Patch 1113845 2 mmaxfield 2015-07-31 14:16:09 -0700 <rdar://problem/22047626> 1113924 3 mmaxfield 2015-07-31 17:00:59 -0700 Committed r187693: <http://trac.webkit.org/changeset/187693> 1116038 4 257958 darin 2015-08-08 14:07:24 -0700 Comment on attachment 257958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257958&action=review > Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:45 > + if (fontData->platformData().isCompositeFontReference() || fontData->isSystemFont()) So this means that system fonts will never used our fast code path? I guess that’s OK since we don’t expect most websites to use them? 1116458 5 mmaxfield 2015-08-10 20:07:05 -0700 (In reply to comment #4) > Comment on attachment 257958 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257958&action=review > > > Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:45 > > + if (fontData->platformData().isCompositeFontReference() || fontData->isSystemFont()) > > So this means that system fonts will never used our fast code path? I guess > that’s OK since we don’t expect most websites to use them? Yes. 257958 2015-07-31 14:15:40 -0700 2015-07-31 14:20:38 -0700 Patch bug-147504-20150731141538.patch text/plain 1780 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNhZmNmYjdhNjI1YzMx NDVmZmRmMjNjODNhNzZjZWRjYzgzMzcwMy4uNWUyMmIxZDhjYzdlODcwZjBmNzkxZWZjZTI3Zjc2 ZmI1ZmI3YWFjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA3LTMxICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBM YXRpbiBxdW90ZXMgYXJlIHVzZWQgd2l0aCB0aGUgc3lzdGVtIGZvbnQgb24gQ2hpbmVzZSBkZXZp Y2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc1 MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg c3lzdGVtIGZvbnQgaGFzIHNvbWUgZmFuY3kgbG9naWMgcmVnYXJkaW5nIGNoYXJhY3RlciBzZWxl Y3Rpb24gd2hpY2ggcmVxdWlyZXMKKyAgICAgICAgdXNpbmcgQ29yZSBUZXh0IGZvciBnbHlwaCBz ZWxlY3Rpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGVzdHMgY2FuJ3QgY2hh bmdlIHRoZSBzeXN0ZW0gbGFuZ3VhZ2Ugb2YgdGhlIGRldmljZS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL21hYy9HbHlwaFBhZ2VNYWMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2hv dWxkVXNlQ29yZVRleHQpOgorCiAyMDE1LTA3LTMxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgT25seSBnZW5lcmF0ZSAidGhlbWVXaW4qIiBVc2VyQWdl bnRTdHlsZVNoZWV0IGNvbnN0YW50cyBmb3IgV2luZG93cyBidWlsZHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HbHlwaFBhZ2VNYWMuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dseXBoUGFnZU1hYy5jcHAKaW5kZXgg NjAzNmExMjcyOWY3MmVkZmQ3MzcxMGMwZjc4OWNlYjdiOGIxYWI0ZS4uNWE5NTdjNTIyYzZjMWM0 Y2RmZWM3NGM5Y2ZlYWU2YWEyNjI5YjU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvbWFjL0dseXBoUGFnZU1hYy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dseXBoUGFnZU1hYy5jcHAKQEAgLTQyLDcgKzQyLDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0aWMgYm9vbCBzaG91bGRVc2VDb3JlVGV4dChjb25z dCBVQ2hhciogYnVmZmVyLCB1bnNpZ25lZCBidWZmZXJMZW5ndGgsIGNvbnN0IEZvbnQqIGZvbnRE YXRhKQogewotICAgIGlmIChmb250RGF0YS0+cGxhdGZvcm1EYXRhKCkuaXNDb21wb3NpdGVGb250 UmVmZXJlbmNlKCkpCisgICAgaWYgKGZvbnREYXRhLT5wbGF0Zm9ybURhdGEoKS5pc0NvbXBvc2l0 ZUZvbnRSZWZlcmVuY2UoKSB8fCBmb250RGF0YS0+aXNTeXN0ZW1Gb250KCkpCiAgICAgICAgIHJl dHVybiB0cnVlOwogICAgIGlmIChmb250RGF0YS0+cGxhdGZvcm1EYXRhKCkud2lkdGhWYXJpYW50 KCkgIT0gUmVndWxhcldpZHRoIHx8IGZvbnREYXRhLT5oYXNWZXJ0aWNhbEdseXBocygpKSB7CiAg ICAgICAgIC8vIElkZW9ncmFwaHMgZG9uJ3QgaGF2ZSBhIHZlcnRpY2FsIHZhcmlhbnQgb3Igd2lk dGggdmFyaWFudHMuCg==