147499 2015-07-31 12:51:10 -0700 jsc-tailcall:Eliminate the unsafe use of regT5 in arityFixupGenerator() for X86-64 Windows 2015-09-14 10:58:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff basile_clement oldest_to_newest 1113797 0 msaboff 2015-07-31 12:51:10 -0700 The fix for https://bugs.webkit.org/show_bug.cgi?id=147461 eliminated rdi as regT5 on X86-64 Windows. rcx became the new regT5 for Windows X86-64, but that is also argumentGPR0. The only use of regT5 is arityFixupGenerator() which also requires that regT5 doesn't collide with various register, including argumentGPR0. 1113801 1 257947 msaboff 2015-07-31 12:59:15 -0700 Created attachment 257947 Patch 1113804 2 msaboff 2015-07-31 13:02:03 -0700 Committed r187670: <http://trac.webkit.org/changeset/187670> 1125639 3 257947 ossy 2015-09-14 10:58:07 -0700 Comment on attachment 257947 Patch Cleared review? from attachment 257947 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 257947 2015-07-31 12:59:15 -0700 2015-09-14 10:58:07 -0700 Patch 147499.patch text/plain 4071 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg3NjY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE1LTA3LTMxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGpzYy10YWlsY2FsbDpFbGltaW5hdGUgdGhlIHVuc2FmZSB1c2Ugb2YgcmVnVDUgaW4gYXJp dHlGaXh1cEdlbmVyYXRvcigpIGZvciBYODYtNjQgV2luZG93cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NDk5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIFg4Ni02NCwgV2luZG93cywgcmVnVDAg aXMgZnJlZSBzbyB1c2UgdGhhdCByZWdpc3RlciBpbnN0ZWFkIG9mIHJlZ1Q1LgorCisgICAgICAg ICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6CisgICAgICAgIChKU0M6OmFyaXR5Rml4dXBHZW5l cmF0b3IpOgorCiAyMDE1LTA3LTMwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgogCiAgICAgICAgIGpzYy10YWlsY2FsbDogTExpbnQsIEJhc2VsaW5lIGFuZCBERkcgSklUIHNo b3VsZCBzYXZlICYgcmVzdG9yZSBwbGF0Zm9ybSdzIGNhbGxlZS1zYXZlIHJlZ2lzdGVycwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAkocmV2 aXNpb24gMTg3NjM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRv cnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjUsOCArMzY1LDEzIEBAIE1hY3JvQXNzZW1ibGVy Q29kZVJlZiBhcml0eUZpeHVwR2VuZXJhdG8KICAgICBKU0ludGVyZmFjZUpJVCBqaXQodm0pOwog CiAgICAgLy8gV2UgZW50ZXIgd2l0aCBmaXh1cCBjb3VudCwgaW4gYWxpZ25lZCBzdGFjayB1bml0 cywgaW4gYXJndW1lbnRHUFIwIGFuZCB0aGUgcmV0dXJuIHRodW5rIGluIGFyZ3VtZW50R1BSMQot ICAgIC8vIFdlIGhhdmUgdGhlIGd1YXJhbnRlZSB0aGF0IGEwLCBhMSwgYTIsIHQzLCB0NCBhbmQg dDUgYXJlIGFsbCBkaXN0aW5jdCA6LSkKKyAgICAvLyBXZSBoYXZlIHRoZSBndWFyYW50ZWUgdGhh dCBhMCwgYTEsIGEyLCB0MywgdDQgYW5kIHQ1IChvciB0MCBmb3IgV2luZG93cykgYXJlIGFsbCBk aXN0aW5jdCA6LSkKICNpZiBVU0UoSlNWQUxVRTY0KQorI2lmIE9TKFdJTkRPV1MpCisgICAgY29u c3QgR1BSUmVnIGV4dHJhVGVtcCA9IEpTSW50ZXJmYWNlSklUOjpyZWdUMDsKKyNlbHNlCisgICAg Y29uc3QgR1BSUmVnIGV4dHJhVGVtcCA9IEpTSW50ZXJmYWNlSklUOjpyZWdUNTsKKyNlbmRpZgog IyAgaWYgQ1BVKFg4Nl82NCkKICAgICBqaXQucG9wKEpTSW50ZXJmYWNlSklUOjpyZWdUNCk7CiAj ICBlbmRpZgpAQCAtMzc4LDI1ICszODMsMjUgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIGFyaXR5 Rml4dXBHZW5lcmF0bwogCiAgICAgLy8gTW92ZSBjdXJyZW50IGZyYW1lIGRvd24gYXJndW1lbnRH UFIwIG51bWJlciBvZiBzbG90cwogICAgIEpTSW50ZXJmYWNlSklUOjpMYWJlbCBjb3B5TG9vcChq aXQubGFiZWwoKSk7Ci0gICAgaml0LmxvYWQ2NChKU0ludGVyZmFjZUpJVDo6cmVnVDMsIEpTSW50 ZXJmYWNlSklUOjpyZWdUNSk7Ci0gICAgaml0LnN0b3JlNjQoSlNJbnRlcmZhY2VKSVQ6OnJlZ1Q1 LCBNYWNyb0Fzc2VtYmxlcjo6QmFzZUluZGV4KEpTSW50ZXJmYWNlSklUOjpyZWdUMywgSlNJbnRl cmZhY2VKSVQ6OmFyZ3VtZW50R1BSMCwgSlNJbnRlcmZhY2VKSVQ6OlRpbWVzRWlnaHQpKTsKKyAg ICBqaXQubG9hZDY0KEpTSW50ZXJmYWNlSklUOjpyZWdUMywgZXh0cmFUZW1wKTsKKyAgICBqaXQu c3RvcmU2NChleHRyYVRlbXAsIE1hY3JvQXNzZW1ibGVyOjpCYXNlSW5kZXgoSlNJbnRlcmZhY2VK SVQ6OnJlZ1QzLCBKU0ludGVyZmFjZUpJVDo6YXJndW1lbnRHUFIwLCBKU0ludGVyZmFjZUpJVDo6 VGltZXNFaWdodCkpOwogICAgIGppdC5hZGRQdHIoSlNJbnRlcmZhY2VKSVQ6OlRydXN0ZWRJbW0z Mig4KSwgSlNJbnRlcmZhY2VKSVQ6OnJlZ1QzKTsKICAgICBqaXQuYnJhbmNoU3ViMzIoTWFjcm9B c3NlbWJsZXI6Ok5vblplcm8sIEpTSW50ZXJmYWNlSklUOjpUcnVzdGVkSW1tMzIoMSksIEpTSW50 ZXJmYWNlSklUOjphcmd1bWVudEdQUjIpLmxpbmtUbyhjb3B5TG9vcCwgJmppdCk7CiAKICAgICAv LyBGaWxsIGluIGFyZ3VtZW50R1BSMCAtIDEgbWlzc2luZyBhcmcgc2xvdHMgd2l0aCB1bmRlZmlu ZWQKICAgICBqaXQubW92ZShKU0ludGVyZmFjZUpJVDo6YXJndW1lbnRHUFIwLCBKU0ludGVyZmFj ZUpJVDo6YXJndW1lbnRHUFIyKTsKLSAgICBqaXQubW92ZShKU0ludGVyZmFjZUpJVDo6VHJ1c3Rl ZEltbTY0KFZhbHVlVW5kZWZpbmVkKSwgSlNJbnRlcmZhY2VKSVQ6OnJlZ1Q1KTsKKyAgICBqaXQu bW92ZShKU0ludGVyZmFjZUpJVDo6VHJ1c3RlZEltbTY0KFZhbHVlVW5kZWZpbmVkKSwgZXh0cmFU ZW1wKTsKICAgICBqaXQuYWRkMzIoSlNJbnRlcmZhY2VKSVQ6OlRydXN0ZWRJbW0zMigxKSwgSlNJ bnRlcmZhY2VKSVQ6OmFyZ3VtZW50R1BSMik7CiAgICAgSlNJbnRlcmZhY2VKSVQ6OkxhYmVsIGZp bGxVbmRlZmluZWRMb29wKGppdC5sYWJlbCgpKTsKLSAgICBqaXQuc3RvcmU2NChKU0ludGVyZmFj ZUpJVDo6cmVnVDUsIE1hY3JvQXNzZW1ibGVyOjpCYXNlSW5kZXgoSlNJbnRlcmZhY2VKSVQ6OnJl Z1QzLCBKU0ludGVyZmFjZUpJVDo6YXJndW1lbnRHUFIwLCBKU0ludGVyZmFjZUpJVDo6VGltZXNF aWdodCkpOworICAgIGppdC5zdG9yZTY0KGV4dHJhVGVtcCwgTWFjcm9Bc3NlbWJsZXI6OkJhc2VJ bmRleChKU0ludGVyZmFjZUpJVDo6cmVnVDMsIEpTSW50ZXJmYWNlSklUOjphcmd1bWVudEdQUjAs IEpTSW50ZXJmYWNlSklUOjpUaW1lc0VpZ2h0KSk7CiAgICAgaml0LmFkZFB0cihKU0ludGVyZmFj ZUpJVDo6VHJ1c3RlZEltbTMyKDgpLCBKU0ludGVyZmFjZUpJVDo6cmVnVDMpOwogICAgIGppdC5i cmFuY2hBZGQzMihNYWNyb0Fzc2VtYmxlcjo6Tm9uWmVybywgSlNJbnRlcmZhY2VKSVQ6OlRydXN0 ZWRJbW0zMigxKSwgSlNJbnRlcmZhY2VKSVQ6OmFyZ3VtZW50R1BSMikubGlua1RvKGZpbGxVbmRl ZmluZWRMb29wLCAmaml0KTsKICAgICAKICAgICAvLyBBZGp1c3QgY2FsbCBmcmFtZSByZWdpc3Rl ciBhbmQgc3RhY2sgcG9pbnRlciB0byBhY2NvdW50IGZvciBtaXNzaW5nIGFyZ3MKLSAgICBqaXQu bW92ZShKU0ludGVyZmFjZUpJVDo6YXJndW1lbnRHUFIwLCBKU0ludGVyZmFjZUpJVDo6cmVnVDUp OwotICAgIGppdC5sc2hpZnQ2NChKU0ludGVyZmFjZUpJVDo6VHJ1c3RlZEltbTMyKDMpLCBKU0lu dGVyZmFjZUpJVDo6cmVnVDUpOwotICAgIGppdC5hZGRQdHIoSlNJbnRlcmZhY2VKSVQ6OnJlZ1Q1 LCBKU0ludGVyZmFjZUpJVDo6Y2FsbEZyYW1lUmVnaXN0ZXIpOwotICAgIGppdC5hZGRQdHIoSlNJ bnRlcmZhY2VKSVQ6OnJlZ1Q1LCBKU0ludGVyZmFjZUpJVDo6c3RhY2tQb2ludGVyUmVnaXN0ZXIp OworICAgIGppdC5tb3ZlKEpTSW50ZXJmYWNlSklUOjphcmd1bWVudEdQUjAsIGV4dHJhVGVtcCk7 CisgICAgaml0LmxzaGlmdDY0KEpTSW50ZXJmYWNlSklUOjpUcnVzdGVkSW1tMzIoMyksIGV4dHJh VGVtcCk7CisgICAgaml0LmFkZFB0cihleHRyYVRlbXAsIEpTSW50ZXJmYWNlSklUOjpjYWxsRnJh bWVSZWdpc3Rlcik7CisgICAgaml0LmFkZFB0cihleHRyYVRlbXAsIEpTSW50ZXJmYWNlSklUOjpz dGFja1BvaW50ZXJSZWdpc3Rlcik7CiAKICMgIGlmIENQVShYODZfNjQpCiAgICAgaml0LnB1c2go SlNJbnRlcmZhY2VKSVQ6OnJlZ1Q0KTsK