147493 2015-07-31 11:09:34 -0700 Media Session: add test to ensure that switching media sessions pauses elements 2015-07-31 22:34:47 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson mrajca webkit-bug-importer oldest_to_newest 1113758 0 mrajca 2015-07-31 11:09:34 -0700 When switching media sessions, elements belonging to the old session should be paused. 1113759 1 257933 mrajca 2015-07-31 11:11:08 -0700 Created attachment 257933 Patch 1113763 2 257933 eric.carlson 2015-07-31 11:19:22 -0700 Comment on attachment 257933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257933&action=review > LayoutTests/media/session/switching-sessions.html:37 > + run('video.session = new MediaSession("transient")'); > + > + testExpected('video.paused', true); > + > + endTest(); It might be good to register a 'pause' event handler and call endTest from there. 1113985 3 mrajca 2015-07-31 22:24:56 -0700 (In reply to comment #2) > Comment on attachment 257933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257933&action=review > > > LayoutTests/media/session/switching-sessions.html:37 > > + run('video.session = new MediaSession("transient")'); > > + > > + testExpected('video.paused', true); > > + > > + endTest(); > > It might be good to register a 'pause' event handler and call endTest from > there. In the case where a media element is not paused, this will be faster than letting the test time out while waiting for an event to fire. I think I'll keep this. 1113988 4 mrajca 2015-07-31 22:34:47 -0700 Committed r187710: <http://trac.webkit.org/changeset/187710> 257933 2015-07-31 11:11:08 -0700 2015-07-31 11:19:22 -0700 Patch bug-147493-20150731111106.patch text/plain 3842 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NjU0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDA2YTJjYzZjMTFmZDY1YThmNDk4 ZDZjZDQ5NmZhZTBlMTFjZWY3MC4uNjNkNTZhYThlMTM3YTJkNjFmOGJiMmMyNDNjNmRiZWMzNDBj NTY3OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTMxICBNYXR0IFJhamNhICA8bXJh amNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiBhZGQgdGVzdCB0byBlbnN1 cmUgdGhhdCBzd2l0Y2hpbmcgbWVkaWEgc2Vzc2lvbnMgcGF1c2VzIGVsZW1lbnRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc0OTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL3Nlc3Npb24v c3dpdGNoaW5nLXNlc3Npb25zLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEv c2Vzc2lvbi9zd2l0Y2hpbmctc2Vzc2lvbnMuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZv cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6IE1lZGlhIFNlc3Npb24gc3VwcG9ydCBpcyBkaXNhYmxl ZCBieSBkZWZhdWx0LgorCiAyMDE1LTA3LTMwICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNv bT4KIAogICAgICAgICBNZWRpYSBTZXNzaW9uOiBhZGQgdGVzdCBmb3IgTWVkaWFTZXNzaW9uLnJl bGVhc2VTZXNzaW9uKCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3Nlc3Npb24vc3dp dGNoaW5nLXNlc3Npb25zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL3Nlc3Npb24v c3dpdGNoaW5nLXNlc3Npb25zLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMzhkODNiNzdhY2Vi Nzg3M2QyMTBkMzNhMDRmNWE2OWY5NDVlZTNiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvbWVkaWEvc2Vzc2lvbi9zd2l0Y2hpbmctc2Vzc2lvbnMtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMTQgQEAKK1doZW4gc3dpdGNoaW5nIG1lZGlhIHNlc3Npb25zLCBtZWRpYSBlbGVtZW50cyBi ZWxvbmdpbmcgdG8gdGhlIG9sZCBzZXNzaW9uIHNob3VsZCBiZSBwYXVzZWQuCisKKworUlVOKHNl c3Npb24gPSBuZXcgTWVkaWFTZXNzaW9uKCJjb250ZW50IikpCitFVkVOVChjYW5wbGF5dGhyb3Vn aCkKK0VYUEVDVEVEICh2aWRlby5wYXVzZWQgPT0gJ3RydWUnKSBPSworQmVnaW4gcGxheWluZyBt ZWRpYS4KK0VWRU5UKHBsYXlpbmcpCitNZWRpYSBiZWdhbiBwbGF5aW5nLgorRVhQRUNURUQgKHZp ZGVvLnBhdXNlZCA9PSAnZmFsc2UnKSBPSworUlVOKHZpZGVvLnNlc3Npb24gPSBuZXcgTWVkaWFT ZXNzaW9uKCJ0cmFuc2llbnQiKSkKK0VYUEVDVEVEICh2aWRlby5wYXVzZWQgPT0gJ3RydWUnKSBP SworRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvc2Vzc2lvbi9z d2l0Y2hpbmctc2Vzc2lvbnMuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3Nlc3Npb24vc3dpdGNo aW5nLXNlc3Npb25zLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDI3YzU2NDU5NDU1ZmJiZDI2YjhiYzUwYzhi MDFjMjAyMjYwNzkwNgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3Nlc3Np b24vc3dpdGNoaW5nLXNlc3Npb25zLmh0bWwKQEAgLTAsMCArMSw0NSBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi92aWRlby10ZXN0LmpzIj48 L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vbWVkaWEtZmlsZS5qcyI+PC9zY3JpcHQ+Cisg ICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgICB2YXIgc2Vzc2lvbjsK KworICAgICAgICBmdW5jdGlvbiBydW5UZXN0KCkgCisgICAgICAgIHsKKyAgICAgICAgICAgIHJ1 bignc2Vzc2lvbiA9IG5ldyBNZWRpYVNlc3Npb24oImNvbnRlbnQiKScpOworCisgICAgICAgICAg ICBmaW5kTWVkaWFFbGVtZW50KCk7CisgICAgICAgICAgICB3YWl0Rm9yRXZlbnQoJ2NhbnBsYXl0 aHJvdWdoJywgYmVnaW5QbGF5aW5nKTsKKyAgICAgICAgICAgIHZpZGVvLnNyYyA9IGZpbmRNZWRp YUZpbGUoInZpZGVvIiwgIi4uL2NvbnRlbnQvY291bnRpbmciKTsKKyAgICAgICAgICAgIHZpZGVv LnNlc3Npb24gPSBzZXNzaW9uOworICAgICAgICAgICAgd2FpdEZvckV2ZW50KCdwbGF5aW5nJywg YmVnYW5QbGF5aW5nLCBmYWxzZSwgdHJ1ZSwgdmlkZW8pOworICAgICAgICB9CisKKyAgICAgICAg ZnVuY3Rpb24gYmVnaW5QbGF5aW5nKGV2ZW50KQorICAgICAgICB7CisgICAgICAgICAgICB0ZXN0 RXhwZWN0ZWQoJ3ZpZGVvLnBhdXNlZCcsIHRydWUpOworCisgICAgICAgICAgICBjb25zb2xlV3Jp dGUoIkJlZ2luIHBsYXlpbmcgbWVkaWEuIik7CisgICAgICAgICAgICB2aWRlby5wbGF5KCk7Cisg ICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBiZWdhblBsYXlpbmcoZXZlbnQpCisgICAgICAg IHsKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiTWVkaWEgYmVnYW4gcGxheWluZy4iKTsKKyAg ICAgICAgICAgIHRlc3RFeHBlY3RlZCgndmlkZW8ucGF1c2VkJywgZmFsc2UpOworCisgICAgICAg ICAgICBydW4oJ3ZpZGVvLnNlc3Npb24gPSBuZXcgTWVkaWFTZXNzaW9uKCJ0cmFuc2llbnQiKScp OworCisgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoJ3ZpZGVvLnBhdXNlZCcsIHRydWUpOworCisg ICAgICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKyAgICA8cD5XaGVuIHN3aXRjaGluZyBtZWRpYSBz ZXNzaW9ucywgbWVkaWEgZWxlbWVudHMgYmVsb25naW5nIHRvIHRoZSBvbGQgc2Vzc2lvbiBzaG91 bGQgYmUgcGF1c2VkLjwvcD4KKyAgICA8dmlkZW8gaWQ9InZpZGVvIiAvPgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwNDVh ODM3M2I0ZGZmMjE4NjI3NzEzZTM1YjczZWIzMTkwZjEwZWFkLi5kZDhiODM5MmIzNjk1MWY0Yzg3 ODFhYjE1Nzg3MDU1NTYwZmY3ZWU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4 cGVjdGF0aW9ucwpAQCAtMTAwMCw2ICsxMDAwLDcgQEAgbWVkaWEvc2Vzc2lvbi9kZWZhdWx0LXNl c3Npb24uaHRtbAogbWVkaWEvc2Vzc2lvbi9wbGF5LXBhdXNlLW1lZGlhLWV2ZW50cy1pbi1jb250 ZW50LXNlc3Npb25zLmh0bWwKIG1lZGlhL3Nlc3Npb24vcGxheS1wYXVzZS1tZWRpYS1ldmVudHMt aW4tbm9uLWNvbnRlbnQtc2Vzc2lvbnMuaHRtbAogbWVkaWEvc2Vzc2lvbi9yZWxlYXNpbmctc2Vz c2lvbnMuaHRtbAorbWVkaWEvc2Vzc2lvbi9zd2l0Y2hpbmctc2Vzc2lvbnMuaHRtbAogbWVkaWEv c2Vzc2lvbi9zZXNzaW9uLWNyZWF0aW9uLmh0bWwKIG1lZGlhL3Nlc3Npb24vdHJhY2stbWVkaWEt ZXZlbnRzLWRpc2FibGVkLmh0bWwKIG1lZGlhL3Nlc3Npb24vdHJhY2stbWVkaWEtZXZlbnRzLWlu LWNvbnRlbnQtc2Vzc2lvbnMuaHRtbAo=