<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>14746</bug_id>
          
          <creation_ts>2007-07-24 05:13:32 -0700</creation_ts>
          <short_desc>REGRESSION (r21430): Form state not saved for forms that submit via HTTPS even if they do not contain a password field</short_desc>
          <delta_ts>2007-08-14 13:26:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>https://svn.macosforge.org/projects/webkit/wiki/WikiStart?action=history</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, Regression</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>beidson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>3840</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2007-07-24 05:13:32 -0700</bug_when>
    <thetext>From &lt;http://trac.webkit.org/projects/webkit/changeset/21430&gt;:

-    // Do not save doc state if the page has a password field and a form that would be submitted via https.
+    // Do not save doc state if the page has a form that would be submitted via https.
     Document* document = m_frame-&gt;document();
     ASSERT(document);
-    if (document-&gt;hasPasswordField() &amp;&amp; document-&gt;hasSecureForm())
-        return;
         
+    if (document-&gt;hasSecureForm())
+         return;

The result is that pages like the one in the URL do not save form state. I do not understand this expansion of the class of documents that do not save state.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2754</commentid>
    <comment_count>1</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2007-08-09 09:47:48 -0700</bug_when>
    <thetext>I have a very strong recollection that when I was writing this patch, we discovered that the fact that we *did* save form state for HTTPS was a regression from Safari 2, as many high-security commercial sites refuse to work with your browser if you remember form state at all.

I might be misremembering this and confusing it with a different issue, however, so I&apos;m exploring this...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2753</commentid>
    <comment_count>2</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2007-08-09 10:02:47 -0700</bug_when>
    <thetext>I used https://addons.mozilla.org/en-US/firefox/ to test this.

There&apos;s a search field there.  Enter text in the search field and search.  Then go back.

In Safari 2 the text is remembered.  In ToT, it is not.

*sigh*</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2656</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-08-10 06:14:27 -0700</bug_when>
    <thetext>&lt;rdar://problem/5401041&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2370</commentid>
    <comment_count>4</comment_count>
    <who name="">mitz</who>
    <bug_when>2007-08-13 22:09:50 -0700</bug_when>
    <thetext>Fixed by Adele in &lt;http://trac.webkit.org/projects/webkit/changeset/25064&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2312</commentid>
    <comment_count>5</comment_count>
    <who name="">mitz</who>
    <bug_when>2007-08-14 13:26:03 -0700</bug_when>
    <thetext>Test in &lt;http://trac.webkit.org/projects/webkit/changeset/25072&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>