147456 2015-07-30 14:50:58 -0700 LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1 2015-07-31 14:26:48 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck ap burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1113503 0 joepeck 2015-07-30 14:50:58 -0700 * SUMMARY LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1. I suppose I could have used one of the existing bugs covering slow / flakey tests, but I started tackling this just as a generic issue. * NOTES It appears as though when running under WK2 the Inspector Process ends up throttling DOM Timers. So setTimeout(0) ends up taking ~1 second, leading to significantly slower tests. 1113504 1 joepeck 2015-07-30 14:51:41 -0700 <rdar://problem/22039803> 1113539 2 257864 joepeck 2015-07-30 16:05:24 -0700 Created attachment 257864 [PATCH] Proposed Fix This should address current unskipped flakey tests and make them run aster. I'll have a separate change that rebases / unskips / unslows tests. 1113587 3 257864 commit-queue 2015-07-30 17:17:35 -0700 Comment on attachment 257864 [PATCH] Proposed Fix Clearing flags on attachment: 257864 Committed r187627: <http://trac.webkit.org/changeset/187627> 1113588 4 commit-queue 2015-07-30 17:17:44 -0700 All reviewed patches have been landed. Closing bug. 1113608 5 257864 ap 2015-07-30 17:53:35 -0700 Comment on attachment 257864 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=257864&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:265 > +- (void)_setHiddenPageDOMTimerThrottlingEnabled:(BOOL)hiddenPageDOMTimerRhrottlingEnabled Rhottling! 1113842 6 joepeck 2015-07-31 14:11:22 -0700 (In reply to comment #5) > Comment on attachment 257864 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257864&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:265 > > +- (void)_setHiddenPageDOMTimerThrottlingEnabled:(BOOL)hiddenPageDOMTimerRhrottlingEnabled > > Rhottling! Oops! I'll quick fix. 1113860 7 joepeck 2015-07-31 14:26:48 -0700 https://trac.webkit.org/r187682 257864 2015-07-30 16:05:24 -0700 2015-07-30 17:17:35 -0700 [PATCH] Proposed Fix better-tests.patch text/plain 5600 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYWQ4MDc2Li42Mzg4M2M2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMg QEAKKzIwMTUtMDctMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBMYXlvdXRUZXN0cy9pbnNwZWN0b3IgZnJlcXVlbnRseSBydW4gc2xvdyBhbmQgdGlt ZW91dCB3aGVuIHJ1biBpbiBXZWJLaXQyIGJ1dCBub3QgV2ViS2l0MQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NDU2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnkgZGVmYXVsdCwgV2ViS2l0MiBXZWJQ YWdlJ3Mgb24gUExBVEZPUk0oQ09DT0EpIGVuYWJsaW5nIERPTSBUaW1lcgorICAgICAgICB0aHJv dHRsaW5nLiBVbmRlciB0ZXN0aW5nLCB0aGlzIGVuZHMgdXAgaW1wYWN0aW5nIFdlYiBJbnNwZWN0 b3IKKyAgICAgICAgdGVzdHMgdGhhdCBjcmVhdGUgdGhlaXIgb3duIFdLV2ViVmlldyB3aGljaCBu ZXZlciBnZXRzIGRpc3BsYXllZAorICAgICAgICBhbmQgc28gZ2V0cyB0aHJvdHRsZWQuIERpc2Fi bGUgdGhyb3R0bGluZyBvbiB0aGUgSW5zcGVjdG9yJ3MgdmlldworICAgICAgICBkdXJpbmcgdGVz dGluZy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZh dGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW06Cisg ICAgICAgICgtW1dLUHJlZmVyZW5jZXMgX2hpZGRlblBhZ2VET01UaW1lclRocm90dGxpbmdFbmFi bGVkXSk6CisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgX3NldEhpZGRlblBhZ2VET01UaW1lclRo cm90dGxpbmdFbmFibGVkOl0pOgorICAgICAgICBTUEkgdG8gdG9nZ2xlIERPTSB0aW1lciB0aHJv dHRsaW5nLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OmNyZWF0ZUluc3BlY3RvclBhZ2UpOgor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oOgorICAgICAgICAoV2ViS2l0 OjpXZWJJbnNwZWN0b3JQcm94eTo6aXNVbmRlclRlc3QpOgorICAgICAgICBQcm92aWRlIGEgd2F5 IHRvIGdldCBpZiB3ZSBhcmUgdW5kZXIgdGVzdCwgYW5kIHNldCBpdCBiZWZvcmUKKyAgICAgICAg Y2FsbGluZyBpbnRvIHRoZSBwbGF0Zm9ybSBtZXRob2QuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv bWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0 b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVJbnNwZWN0b3JQYWdlKToKKyAgICAgICAgV2hlbiB0ZXN0 aW5nLCBkaXNhYmxlIHRpbWVyIHRocm90dGxpbmcuCisKIDIwMTUtMDctMjcgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUGF0aEFwcGxpZXJGdW5jdGlv biBzaG91bGQgdGFrZSBhIHJlZmVyZW5jZSB0byBhIFBhdGhFbGVtZW50CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0gYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0KaW5kZXggY2Yz ZjFkNi4uMjhiY2JjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1ByZWZlcmVuY2VzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tQcmVmZXJlbmNlcy5tbQpAQCAtMjU3LDYgKzI1NywxNiBAQCBzdGF0aWMgX1dLU3Rv cmFnZUJsb2NraW5nUG9saWN5IHRvQVBJKFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luOjpTdG9yYWdl QmxvY2tpbmdQbwogICAgIF9wcmVmZXJlbmNlcy0+c2V0TG9nc1BhZ2VNZXNzYWdlc1RvU3lzdGVt Q29uc29sZUVuYWJsZWQobG9nc1BhZ2VNZXNzYWdlc1RvU3lzdGVtQ29uc29sZUVuYWJsZWQpOwog fQogCistIChCT09MKV9oaWRkZW5QYWdlRE9NVGltZXJUaHJvdHRsaW5nRW5hYmxlZAoreworICAg IHJldHVybiBfcHJlZmVyZW5jZXMtPmhpZGRlblBhZ2VET01UaW1lclRocm90dGxpbmdFbmFibGVk KCk7Cit9CisKKy0gKHZvaWQpX3NldEhpZGRlblBhZ2VET01UaW1lclRocm90dGxpbmdFbmFibGVk OihCT09MKWhpZGRlblBhZ2VET01UaW1lclJocm90dGxpbmdFbmFibGVkCit7CisgICAgX3ByZWZl cmVuY2VzLT5zZXRIaWRkZW5QYWdlRE9NVGltZXJUaHJvdHRsaW5nRW5hYmxlZChoaWRkZW5QYWdl RE9NVGltZXJSaHJvdHRsaW5nRW5hYmxlZCk7Cit9CisKIC0gKEJPT0wpX2FsbG93RmlsZUFjY2Vz c0Zyb21GaWxlVVJMcwogewogICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPmFsbG93RmlsZUFjY2Vz c0Zyb21GaWxlVVJMcygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oCmluZGV4IGExZjNjMjIuLmZjYTNjMWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJl bmNlc1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL UHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTYyLDYgKzYyLDggQEAgdHlwZWRlZiBOU19PUFRJT05T KE5TVUludGVnZXIsIF9XS0phdmFTY3JpcHRSdW50aW1lRmxhZ3MpIHsKIAogQHByb3BlcnR5IChu b25hdG9taWMsIHNldHRlcj1fc2V0TG9nc1BhZ2VNZXNzYWdlc1RvU3lzdGVtQ29uc29sZUVuYWJs ZWQ6KSBCT09MIF9sb2dzUGFnZU1lc3NhZ2VzVG9TeXN0ZW1Db25zb2xlRW5hYmxlZCBXS19BVkFJ TEFCTEUoV0tfTUFDX1RCQSwgV0tfSU9TX1RCQSk7CiAKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBz ZXR0ZXI9X3NldEhpZGRlblBhZ2VET01UaW1lclRocm90dGxpbmdFbmFibGVkOikgQk9PTCBfaGlk ZGVuUGFnZURPTVRpbWVyVGhyb3R0bGluZ0VuYWJsZWQgV0tfQVZBSUxBQkxFKFdLX01BQ19UQkEs IFdLX0lPU19UQkEpOworCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRBbGxvd0Zp bGVBY2Nlc3NGcm9tRmlsZVVSTHM6KSBCT09MIF9hbGxvd0ZpbGVBY2Nlc3NGcm9tRmlsZVVSTHMg V0tfQVZBSUxBQkxFKFdLX01BQ19UQkEsIFdLX0lPU19UQkEpOwogQHByb3BlcnR5IChub25hdG9t aWMsIHNldHRlcj1fc2V0SmF2YVNjcmlwdFJ1bnRpbWVGbGFnczopIF9XS0phdmFTY3JpcHRSdW50 aW1lRmxhZ3MgX2phdmFTY3JpcHRSdW50aW1lRmxhZ3MgV0tfQVZBSUxBQkxFKFdLX01BQ19UQkEs IFdLX0lPU19UQkEpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi SW5zcGVjdG9yUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3Rv clByb3h5LmNwcAppbmRleCAzZjRlN2Y4Li45ZGI2Y2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKQEAgLTQ4NCwxMyArNDg0LDEzIEBAIHZv aWQgV2ViSW5zcGVjdG9yUHJveHk6OmNyZWF0ZUluc3BlY3RvclBhZ2UoSVBDOjpBdHRhY2htZW50 IGNvbm5lY3Rpb25JZGVudGlmaWVyCiAgICAgaWYgKCFtX2luc3BlY3RlZFBhZ2UpCiAgICAgICAg IHJldHVybjsKIAotICAgIGVhZ2VybHlDcmVhdGVJbnNwZWN0b3JQYWdlKCk7Ci0KLSAgICBBU1NF UlQobV9pbnNwZWN0b3JQYWdlKTsKLSAgICBpZiAoIW1faW5zcGVjdG9yUGFnZSkKLSAgICAgICAg cmV0dXJuOwotCiAgICAgbV91bmRlclRlc3QgPSB1bmRlclRlc3Q7CisgICAgZWFnZXJseUNyZWF0 ZUluc3BlY3RvclBhZ2UoKTsKKworICAgIEFTU0VSVChtX2luc3BlY3RvclBhZ2UpOworICAgIGlm ICghbV9pbnNwZWN0b3JQYWdlKQorICAgICAgICByZXR1cm47CisKICAgICBtX2Nvbm5lY3Rpb25J ZGVudGlmaWVyID0gV1RGOjptb3ZlKGNvbm5lY3Rpb25JZGVudGlmaWVyKTsKIAogICAgIG1faW5z cGVjdG9yUGFnZS0+cHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6OldlYkluc3BlY3RvclVJOjpFc3Rh Ymxpc2hDb25uZWN0aW9uKG1fY29ubmVjdGlvbklkZW50aWZpZXIsIG1faW5zcGVjdGVkUGFnZS0+ cGFnZUlEKCksIG1fdW5kZXJUZXN0KSwgbV9pbnNwZWN0b3JQYWdlLT5wYWdlSUQoKSk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCmluZGV4IDc4ZDQwYWIu LmIyZDNkZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0 b3JQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94 eS5oCkBAIC0yMDYsNiArMjA2LDggQEAgcHJpdmF0ZToKICAgICBib29sIGNhbkF0dGFjaCgpIGNv bnN0IHsgcmV0dXJuIG1fY2FuQXR0YWNoOyB9CiAgICAgYm9vbCBzaG91bGRPcGVuQXR0YWNoZWQo KTsKIAorICAgIGJvb2wgaXNVbmRlclRlc3QoKSBjb25zdCB7IHJldHVybiBtX3VuZGVyVGVzdDsg fQorCiAgICAgdm9pZCBvcGVuKCk7CiAKICAgICAvLyBUaGUgaW5zcGVjdG9yIGxldmVsIGlzIHVz ZWQgdG8gZ2l2ZSBkaWZmZXJlbnQgcHJlZmVyZW5jZXMgdG8gZWFjaCBpbnNwZWN0b3IKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1t CmluZGV4IDQ1ZDg5NWUuLjgwNmY0OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQpAQCAtNDIwLDYgKzQyMCw5IEBAIFdl YlBhZ2VQcm94eSogV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRlSW5zcGVjdG9yUGFn ZSgpCiAjZW5kaWYKICAgICBwcmVmZXJlbmNlcy5fYWxsb3dGaWxlQWNjZXNzRnJvbUZpbGVVUkxz ID0gWUVTOwogICAgIHByZWZlcmVuY2VzLl9qYXZhU2NyaXB0UnVudGltZUZsYWdzID0gMDsKKyAg ICBpZiAoaXNVbmRlclRlc3QoKSkKKyAgICAgICAgcHJlZmVyZW5jZXMuX2hpZGRlblBhZ2VET01U aW1lclRocm90dGxpbmdFbmFibGVkID0gTk87CisKICAgICBbY29uZmlndXJhdGlvbiBzZXRQcm9j ZXNzUG9vbDogOjpXZWJLaXQ6OndyYXBwZXIoaW5zcGVjdG9yUHJvY2Vzc1Bvb2woKSldOwogICAg IFtjb25maWd1cmF0aW9uIF9zZXRHcm91cElkZW50aWZpZXI6aW5zcGVjdG9yUGFnZUdyb3VwSWRl bnRpZmllcigpXTsKIAo=