147442 2015-07-29 22:37:11 -0700 Web Inspector: Add special case for deleting the next character when editing rules in the CSS Sidebar 2015-07-30 12:24:16 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1113309 0 hi 2015-07-29 22:37:11 -0700 In the CSS sidebar, if the cursor is on the first line of a rule and that line is blank, when the user hits delete the next character should be removed instead of nothing happening (a delete is attempted, but there is nothing to delete so nothing happens). 1113311 1 webkit-bug-importer 2015-07-29 22:38:08 -0700 <rdar://problem/22066577> 1113312 2 257820 hi 2015-07-29 22:38:53 -0700 Created attachment 257820 Patch 1113459 3 257820 commit-queue 2015-07-30 12:24:12 -0700 Comment on attachment 257820 Patch Clearing flags on attachment: 257820 Committed r187598: <http://trac.webkit.org/changeset/187598> 1113460 4 commit-queue 2015-07-30 12:24:16 -0700 All reviewed patches have been landed. Closing bug. 257820 2015-07-29 22:38:53 -0700 2015-07-30 12:24:12 -0700 Patch bug-147442-20150729223729.patch text/plain 2399 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4YWU4MjAyNTA3MzIyMGUzNTE0YjA0MDc0ZmVi Y2VhOWUwYThkZTEuLmI0ZTJkZTk1MDc4YTk2ZWY0NzFiNDJkOTQ1ZGYxOTA5ZDNjNDdjNDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA3LTI5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB ZGQgc3BlY2lhbCBjYXNlIGZvciBkZWxldGluZyB0aGUgbmV4dCBjaGFyYWN0ZXIgd2hlbiBlZGl0 aW5nIHJ1bGVzIGluIHRoZSBDU1MgU2lkZWJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NDQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIGN1cnNvciBpcyBvbiB0aGUgZmlyc3QgcG9zaXRp b24gb2YgdGhlIGZpcnN0IGxpbmUgaW4gYSBDU1MgUnVsZSBhbmQgdGhhdCBsaW5lCisgICAgICAg IGhhcyBubyBjb250ZW50LCBkZWxldGUgdGhlIGxpbmUgaW5zdGVhZCBvZiBkb2luZyBub3RoaW5n LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4 dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4 dEVkaXRvci5wcm90b3R5cGUuX2hhbmRsZUJlZm9yZUNoYW5nZSk6CisKIDIwMTUtMDctMjkgIE5p a2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogQm9yZGVyIGxpbmUgaW4gdGhlIGRlYnVnIHBvcG92ZXIgc2hvdWxkIGJlIHNlbWktdHJh bnNwYXJlbnQgYmxhY2ssIG5vdCBkYXJrIHllbGxvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0 b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHls ZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwppbmRleCA5MDE3ZjI5YWZlM2ZiYjczMzI2YTk0MGNi MTVkNjc2NjcwOWU4NzNjLi5kZWZjNGZjOTEyM2NjZThjNWRmOGE5YTJmMzJiZjZhZWJlYWU3OTFm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D U1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwpA QCAtNDc0LDExICs0NzQsMjIgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0 RWRpdG9yID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IKIAogICAgIF9oYW5k bGVCZWZvcmVDaGFuZ2UoY29kZU1pcnJvciwgY2hhbmdlKQogICAgIHsKLSAgICAgICAgaWYgKGNo YW5nZS5vcmlnaW4gIT09ICIrZGVsZXRlIiB8fCAoIWNoYW5nZS50by5saW5lICYmICFjaGFuZ2Uu dG8uY2gpIHx8IHRoaXMuX2NvbXBsZXRpb25Db250cm9sbGVyLmlzU2hvd2luZ0NvbXBsZXRpb25z KCkpCisgICAgICAgIGlmIChjaGFuZ2Uub3JpZ2luICE9PSAiK2RlbGV0ZSIgfHwgdGhpcy5fY29t cGxldGlvbkNvbnRyb2xsZXIuaXNTaG93aW5nQ29tcGxldGlvbnMoKSkKICAgICAgICAgICAgIHJl dHVybiBDb2RlTWlycm9yLlBhc3M7CiAKLSAgICAgICAgdmFyIG1hcmtzID0gY29kZU1pcnJvci5m aW5kTWFya3NBdChjaGFuZ2UudG8pOworICAgICAgICBpZiAoIWNoYW5nZS50by5saW5lICYmICFj aGFuZ2UudG8uY2gpIHsKKyAgICAgICAgICAgIGlmIChjb2RlTWlycm9yLmxpbmVDb3VudCgpID09 PSAxKQorICAgICAgICAgICAgICAgIHJldHVybiBDb2RlTWlycm9yLlBhc3M7CisKKyAgICAgICAg ICAgIHZhciBsaW5lID0gY29kZU1pcnJvci5nZXRMaW5lKGNoYW5nZS50by5saW5lKTsKKyAgICAg ICAgICAgIGlmIChsaW5lICYmIGxpbmUudHJpbSgpLmxlbmd0aCkKKyAgICAgICAgICAgICAgICBy ZXR1cm4gQ29kZU1pcnJvci5QYXNzOworCisgICAgICAgICAgICBjb2RlTWlycm9yLmV4ZWNDb21t YW5kKCJkZWxldGVMaW5lIik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KIAorICAg ICAgICB2YXIgbWFya3MgPSBjb2RlTWlycm9yLmZpbmRNYXJrc0F0KGNoYW5nZS50byk7CiAgICAg ICAgIGlmICghbWFya3MubGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJuIENvZGVNaXJyb3IuUGFz czsKIAo=