147425 2015-07-29 16:32:04 -0700 [WK2] Use FastMalloc in IPC::MessageDecoder 2015-07-30 10:37:26 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez andersca commit-queue ggaren kling sam oldest_to_newest 1113203 0 cdumez 2015-07-29 16:32:04 -0700 Use FastMalloc in IPC::MessageDecoder instead of system malloc, for performance reasons and consistency. 1113209 1 257783 cdumez 2015-07-29 16:49:18 -0700 Created attachment 257783 Patch 1113260 2 257783 commit-queue 2015-07-29 19:35:36 -0700 Comment on attachment 257783 Patch Clearing flags on attachment: 257783 Committed r187572: <http://trac.webkit.org/changeset/187572> 1113261 3 commit-queue 2015-07-29 19:35:42 -0700 All reviewed patches have been landed. Closing bug. 1113399 4 andersca 2015-07-30 10:29:05 -0700 It's using malloc/free for a reason. See https://bugs.webkit.org/show_bug.cgi?id=101130 1113400 5 cdumez 2015-07-30 10:37:26 -0700 (In reply to comment #4) > It's using malloc/free for a reason. See > https://bugs.webkit.org/show_bug.cgi?id=101130 I see. This bug seems rather old (we were still using TCMalloc) and the fix was speculative. There is no reason that I know of we shouldn't be able to use fastMalloc here. I would propose we give this a shot and revert if we start seeing crashes in this area (unless you know of a reason why we definitely should not use fastMalloc here). 257783 2015-07-29 16:49:18 -0700 2015-07-29 19:35:36 -0700 Patch bug-147425-20150729164755.patch text/plain 1855 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTUxNTUzOGYzOTI4NDFl YjNiMzY2MDVjOGVlZjNhNDc5NDQ3ZjVjNS4uMmMyN2M4MmRlYTcyYmIwYjk2OGI0Yzg0MzkxN2Y5 ODVmZmMzNDRiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA3LTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gVXNlIEZhc3RNYWxs b2MgaW4gSVBDOjpNZXNzYWdlRGVjb2RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIEZhc3RNYWxsb2MgaW4gSVBDOjpNZXNzYWdlRGVjb2RlciBp bnN0ZWFkIG9mIHN5c3RlbSBtYWxsb2MsIGZvcgorICAgICAgICBwZXJmb3JtYW5jZSByZWFzb25z IGFuZCBjb25zaXN0ZW5jeS4KKworICAgICAgICAqIFBsYXRmb3JtL0lQQy9Bcmd1bWVudERlY29k ZXIuY3BwOgorICAgICAgICAoSVBDOjpBcmd1bWVudERlY29kZXI6On5Bcmd1bWVudERlY29kZXIp OgorICAgICAgICAoSVBDOjpBcmd1bWVudERlY29kZXI6OmluaXRpYWxpemUpOgorCiAyMDE1LTA3 LTI4ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAg ICAgW2lPU10gUkVHUkVTU0lPTihyMTY4MDc1KTogRnVsbHNjcmVlbiB3ZWIgdmlkZW8gZG9lc24n dCBwYXVzZSBvbiBzY3JlZW4gbG9jawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZv cm0vSVBDL0FyZ3VtZW50RGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMv QXJndW1lbnREZWNvZGVyLmNwcAppbmRleCA3ZDllMzhhMDJiMTZmMjdiMWVhNWE1Y2NiNzlkOTQ4 Yjk2NWY4MzI5Li5mYmE4ZWQ2ZDMwZWMxMTMzYWU4NzNkOGRjNTg5ZjVhMDkwNjAxMzc5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQXJndW1lbnREZWNvZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQXJndW1lbnREZWNvZGVyLmNwcApAQCAt NDYsNyArNDYsNyBAQCBBcmd1bWVudERlY29kZXI6OkFyZ3VtZW50RGVjb2Rlcihjb25zdCB1aW50 OF90KiBidWZmZXIsIHNpemVfdCBidWZmZXJTaXplLCBWZWN0bwogQXJndW1lbnREZWNvZGVyOjp+ QXJndW1lbnREZWNvZGVyKCkKIHsKICAgICBBU1NFUlQobV9idWZmZXIpOwotICAgIGZyZWUobV9i dWZmZXIpOworICAgIGZhc3RGcmVlKG1fYnVmZmVyKTsKICAgICAvLyBGSVhNRTogV2UgbmVlZCB0 byBkaXNwb3NlIG9mIHRoZSBtYWNoIHBvcnRzIGluIGNhc2VzIG9mIGZhaWx1cmUuCiB9CiAKQEAg LTYxLDcgKzYxLDcgQEAgc3RhdGljIGlubGluZSB1aW50OF90KiByb3VuZFVwVG9BbGlnbm1lbnQo dWludDhfdCogcHRyLCB1bnNpZ25lZCBhbGlnbm1lbnQpCiAKIHZvaWQgQXJndW1lbnREZWNvZGVy Ojppbml0aWFsaXplKGNvbnN0IHVpbnQ4X3QqIGJ1ZmZlciwgc2l6ZV90IGJ1ZmZlclNpemUpCiB7 Ci0gICAgbV9idWZmZXIgPSBzdGF0aWNfY2FzdDx1aW50OF90Kj4obWFsbG9jKGJ1ZmZlclNpemUp KTsKKyAgICBtX2J1ZmZlciA9IHN0YXRpY19jYXN0PHVpbnQ4X3QqPihmYXN0TWFsbG9jKGJ1ZmZl clNpemUpKTsKIAogICAgIEFTU0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihtX2J1 ZmZlcikgJSBhbGlnbm9mKHVpbnQ2NF90KSkpOwogCg==