14742 2007-07-23 23:28:31 -0700 Document::recalcStyle(Force) called for every updateStyleIgnorePendingStylesheets while waiting for stylesheets 2007-08-09 20:56:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) All All RESOLVED FIXED http://www.bbc.co.uk/history/historic_figures/ InRadar P2 Normal --- 1 mitz webkit-unassigned ddkilzer oldest_to_newest 3855 0 mitz 2007-07-23 23:28:31 -0700 If stylesheets have not yet loaded, updateStyleIgnorePendingStylesheets() will call updateStyleSelector() which calls recalcStyle(Force). This is *not* a regression from the m_didCalculateStyleSelector patch (which fixed a Yahoo! Mail crash), but still would be nice to fix at some point. Basically you need updateStyleSelector() to only set a flag and postpone the update until later when you need it. 3850 1 15656 mitz 2007-07-23 23:30:58 -0700 Created attachment 15656 Patch (not for now) 3278 2 mitz 2007-08-01 00:26:53 -0700 See also bug 14839. 3290 3 ddkilzer 2007-08-01 06:56:07 -0700 *** Bug 14839 has been marked as a duplicate of this bug. *** 3291 4 ddkilzer 2007-08-01 06:56:49 -0700 <rdar://problem/5376306> 3329 5 mitz 2007-08-01 11:32:05 -0700 (In reply to comment #3) > *** Bug 14839 has been marked as a duplicate of this bug. *** Raising priority to P2 since the bug affects a popular website. Dave, could you check if this is a regression from the Safari/WebKit that shipped with Tiger? 3214 6 ddkilzer 2007-08-01 15:10:43 -0700 (In reply to comment #5) > Raising priority to P2 since the bug affects a popular website. Dave, could you > check if this is a regression from the Safari/WebKit that shipped with Tiger? It is a slight regression for the Safari 3 Public Beta v. 3.0.3 on Tiger: Using a 1.5 GHz PowerBook G4: Using Mac OS X 10.4.10 (8R218) Tiger: - Safari 2.0.4 (419.3) with its original WebKit: ~8 seconds - Safari 3 Public Beta 3.0.3 (522.12.1) with its original WebKit: ~10 seconds However, Safari on Leopard is slightly better than Safari 2.0.4 on Tiger. 3154 7 ddkilzer 2007-08-02 06:44:51 -0700 On the same hardware on Mac OS X 10.4.10 (8R218) using Safari 3 Public Beta v. 3.0.3 (522.12.1) with a DEBUG BUILD of ToT Webkit r24803, the page loads in ~2 seconds. Testing methodology: 1. Launch Safari/WebKit. 2. Open the page once (untimed). 3. Hit Cmd-R and time the load. 4. Repeat Step 3 five or six times to get a ballpark figure. 3069 8 mitz 2007-08-03 08:00:51 -0700 (In reply to comment #7) > On the same hardware on Mac OS X 10.4.10 (8R218) using Safari 3 Public Beta v. > 3.0.3 (522.12.1) with a DEBUG BUILD of ToT Webkit r24803, the page loads in ~2 > seconds. Just to make sure I understood, a debug build of r24803 is almost 5 times faster than the beta? 3070 9 15818 mitz 2007-08-03 08:07:05 -0700 Created attachment 15818 Patch (for now) This is a very pinpointed and conservative fix. I think in the long run, Document::updateStyleSelector() should be replaced with a function that just sets a "style selector dirty" flag, and Document::styleSelector() should lazily update the style selector as needed. That is worth doing even if JavaScript becomes interruptible, because it will coalesce style updates. 3072 10 ddkilzer 2007-08-03 08:21:07 -0700 (In reply to comment #8) > (In reply to comment #7) > > On the same hardware on Mac OS X 10.4.10 (8R218) using Safari 3 Public Beta v. > > 3.0.3 (522.12.1) with a DEBUG BUILD of ToT Webkit r24803, the page loads in ~2 > > seconds. > > Just to make sure I understood, a debug build of r24803 is almost 5 times > faster than the beta? Correct. 2889 11 15818 hyatt 2007-08-07 12:58:21 -0700 Comment on attachment 15818 Patch (for now) r=me 2686 12 mrowe 2007-08-09 20:56:46 -0700 Landed in r24973. 15656 2007-07-23 23:30:58 -0700 2007-08-03 08:07:05 -0700 Patch (not for now) 14742_r0.patch text/plain 2890 mitz SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDI0NTA1KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTAsNyArMzEwLDcgQEAgRG9jdW1lbnQ6OkRvY3VtZW50 KERPTUltcGxlbWVudGF0aW9uKiBpbQogICAgIG1fdXNlc0ZpcnN0TGV0dGVyUnVsZXMgPSBmYWxz ZTsKIAogICAgIG1fc3R5bGVTZWxlY3RvciA9IG5ldyBDU1NTdHlsZVNlbGVjdG9yKHRoaXMsIG1f dXNlcnNoZWV0LCBtX3N0eWxlU2hlZXRzLmdldCgpLCAhaW5Db21wYXRNb2RlKCkpOwotICAgIG1f ZGlkQ2FsY3VsYXRlU3R5bGVTZWxlY3RvciA9IGZhbHNlOworICAgIG1fbmVlZHNTdHlsZVNlbGVj dG9yVXBkYXRlID0gdHJ1ZTsKICAgICBtX3BlbmRpbmdTdHlsZXNoZWV0cyA9IDA7CiAgICAgbV9p Z25vcmVQZW5kaW5nU3R5bGVzaGVldHMgPSBmYWxzZTsKICAgICBtX3BlbmRpbmdTaGVldExheW91 dCA9IE5vTGF5b3V0V2l0aFBlbmRpbmdTaGVldHM7CkBAIC05NjMsNiArOTYzLDEwIEBAIHZvaWQg RG9jdW1lbnQ6OnNldERvY3VtZW50Q2hhbmdlZChib29sIGIKIAogdm9pZCBEb2N1bWVudDo6cmVj YWxjU3R5bGUoU3R5bGVDaGFuZ2UgY2hhbmdlKQogeworICAgIGlmIChtX25lZWRzU3R5bGVTZWxl Y3RvclVwZGF0ZSkKKyAgICAgICAgLy8gdXBkYXRlU3R5bGVTZWxlY3RvciBkb2VzIGEgcmVjYWxj U3R5bGUoRm9yY2UpLgorICAgICAgICByZXR1cm4gdXBkYXRlU3R5bGVTZWxlY3RvcigpOworCiAg ICAgaWYgKG1faW5TdHlsZVJlY2FsYykKICAgICAgICAgcmV0dXJuOyAvLyBHdWFyZCBhZ2FpbnN0 IHJlLWVudHJhbmN5LiAtZHdoCiAgICAgICAgIApAQCAtMTA4NCw3ICsxMDg4LDggQEAgdm9pZCBE b2N1bWVudDo6dXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZwogICAgICAgICAvLyBzdXNwZW5kIEpT IGluc3RlYWQgb2YgZG9pbmcgYSBsYXlvdXQgd2l0aCBpbmFjY3VyYXRlIGluZm9ybWF0aW9uLgog ICAgICAgICBpZiAoYm9keSgpICYmICFib2R5KCktPnJlbmRlcmVyKCkgJiYgbV9wZW5kaW5nU2hl ZXRMYXlvdXQgPT0gTm9MYXlvdXRXaXRoUGVuZGluZ1NoZWV0cykKICAgICAgICAgICAgIG1fcGVu ZGluZ1NoZWV0TGF5b3V0ID0gRGlkTGF5b3V0V2l0aFBlbmRpbmdTaGVldHM7Ci0gICAgICAgIHVw ZGF0ZVN0eWxlU2VsZWN0b3IoKTsgICAgCisgICAgICAgIGlmIChtX25lZWRzU3R5bGVTZWxlY3Rv clVwZGF0ZSkKKyAgICAgICAgICAgIHVwZGF0ZVN0eWxlU2VsZWN0b3IoKTsgICAgCiAgICAgfQog CiAgICAgdXBkYXRlTGF5b3V0KCk7CkBAIC0xOTMyLDggKzE5MzcsMTAgQEAgdm9pZCBEb2N1bWVu dDo6dXBkYXRlU3R5bGVTZWxlY3RvcigpCiB7CiAgICAgLy8gRG9uJ3QgYm90aGVyIHVwZGF0aW5n LCBzaW5jZSB3ZSBoYXZlbid0IGxvYWRlZCBhbGwgb3VyIHN0eWxlIGluZm8geWV0CiAgICAgLy8g YW5kIGhhdmVuJ3QgY2FsY3VsYXRlZCB0aGUgc3R5bGUgc2VsZWN0b3IgZm9yIHRoZSBmaXJzdCB0 aW1lLgotICAgIGlmICghbV9kaWRDYWxjdWxhdGVTdHlsZVNlbGVjdG9yICYmICFoYXZlU3R5bGVz aGVldHNMb2FkZWQoKSkKKyAgICBpZiAoIWhhdmVTdHlsZXNoZWV0c0xvYWRlZCgpICYmICEoYm9k eSgpICYmIGJvZHkoKS0+cmVuZGVyZXIoKSkpIHsKKyAgICAgICAgbV9uZWVkc1N0eWxlU2VsZWN0 b3JVcGRhdGUgPSB0cnVlOwogICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgaWYgKGRpZExh eW91dFdpdGhQZW5kaW5nU3R5bGVzaGVldHMoKSAmJiBtX3BlbmRpbmdTdHlsZXNoZWV0cyA8PSAw KSB7CiAgICAgICAgIG1fcGVuZGluZ1NoZWV0TGF5b3V0ID0gSWdub3JlTGF5b3V0V2l0aFBlbmRp bmdTaGVldHM7CkBAIC0xOTQ3LDYgKzE5NTQsNyBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVTdHls ZVNlbGVjdG9yKCkKICNlbmRpZgogCiAgICAgcmVjYWxjU3R5bGVTZWxlY3RvcigpOworICAgIG1f bmVlZHNTdHlsZVNlbGVjdG9yVXBkYXRlID0gZmFsc2U7CiAgICAgcmVjYWxjU3R5bGUoRm9yY2Up OwogCiAjaWZkZWYgSU5TVFJVTUVOVF9MQVlPVVRfU0NIRURVTElORwpAQCAtMjA5OCw3ICsyMTA2 LDYgQEAgdm9pZCBEb2N1bWVudDo6cmVjYWxjU3R5bGVTZWxlY3RvcigpCiAgICAgICAgIHVzZXJz aGVldCArPSBtX3ByaW50U2hlZXQ7CiAgICAgbV9zdHlsZVNlbGVjdG9yID0gbmV3IENTU1N0eWxl U2VsZWN0b3IodGhpcywgdXNlcnNoZWV0LCBtX3N0eWxlU2hlZXRzLmdldCgpLCAhaW5Db21wYXRN b2RlKCkpOwogICAgIG1fc3R5bGVTZWxlY3Rvci0+c2V0RW5jb2RlZFVSTChtX3VybCk7Ci0gICAg bV9kaWRDYWxjdWxhdGVTdHlsZVNlbGVjdG9yID0gdHJ1ZTsKIH0KIAogdm9pZCBEb2N1bWVudDo6 c2V0SG92ZXJOb2RlKFBhc3NSZWZQdHI8Tm9kZT4gbmV3SG92ZXJOb2RlKQpJbmRleDogV2ViQ29y ZS9kb20vRG9jdW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Eb2N1bWVudC5oCShy ZXZpc2lvbiAyNDUwNSkKKysrIFdlYkNvcmUvZG9tL0RvY3VtZW50LmgJKHdvcmtpbmcgY29weSkK QEAgLTY1MCw3ICs2NTAsNyBAQCBwdWJsaWM6CiAKIHByb3RlY3RlZDoKICAgICBDU1NTdHlsZVNl bGVjdG9yKiBtX3N0eWxlU2VsZWN0b3I7Ci0gICAgYm9vbCBtX2RpZENhbGN1bGF0ZVN0eWxlU2Vs ZWN0b3I7CisgICAgYm9vbCBtX25lZWRzU3R5bGVTZWxlY3RvclVwZGF0ZTsKIAogICAgIEZyYW1l KiBtX2ZyYW1lOwogICAgIERvY0xvYWRlciogbV9kb2NMb2FkZXI7Cg== 15818 2007-08-03 08:07:05 -0700 2007-08-07 12:58:21 -0700 Patch (for now) 14742_r4.patch text/plain 2188 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDg0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDctMDgtMDMgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzQyCisgICAgICAgICAg RG9jdW1lbnQ6OnJlY2FsY1N0eWxlKEZvcmNlKSBjYWxsZWQgZm9yIGV2ZXJ5IHVwZGF0ZVN0eWxl SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzIHdoaWxlIHdhaXRpbmcgZm9yIHN0eWxlc2hlZXRzCisg ICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzNzYzMDY+CisKKyAgICAgICAgdXBkYXRlU3R5bGVT ZWxlY3RvcigpIGlzIG5vcm1hbGx5IGNhbGxlZCB3aGVuIHNvbWV0aGluZyBjaGFuZ2VzIHRoYXQg ZmFjdG9ycworICAgICAgICBpbnRvIHRoZSBzdHlsZSBzZWxlY3Rvci4gSG93ZXZlciwgdXBkYXRl TGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCkgY2FsbHMgaXQgZm9yCisgICAgICAgIGEg ZGlmZmVyZW50IHJlYXNvbiwgbmFtZWx5IHRvIGFjY291bnQgZm9yIGFsbCB0aGUgcHJlY2VkaW5n IGNoYW5nZXMgdGhhdCB3ZXJlIGlnbm9yZWQKKyAgICAgICAgYmVjYXVzZSBvZiB0aGUgZWFybHkg cmV0dXJuIGluIHVwZGF0ZVN0eWxlU2VsZWN0b3IoKS4gQWZ0ZXIgdGhhdCwgdGhlIGVhcmx5IHJl dHVybgorICAgICAgICBjYW4gbm8gbG9uZ2VyIG9jY3VyLCBzbyBjaGFuZ2VzIGFyZSBhY2NvdW50 ZWQgZm9yIGFzIHRoZXkgaGFwcGVuLCBhbmQKKyAgICAgICAgdXBkYXRlTGF5b3V0SWdub3JlUGVu ZGluZ1N0eWxlc2hlZXRzKCkgZG9lcyBub3QgbmVlZCB0byBjYWxsIHVwZGF0ZVN0eWxlU2VsZWN0 b3IoKQorICAgICAgICBhZ2Fpbi4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hl ZXRzKTogQ2FsbCB1cGRhdGVTdHlsZVNlbGVjdG9yKCkKKyAgICAgICAgb25seSBiZWZvcmUgdGhl IGZpcnN0IGxheW91dC4KKwogMjAwNy0wOC0wMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmCkluZGV4OiBXZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lv biAyNDgyNSkKKysrIFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTA4Niw5ICsxMDg2LDEwIEBAIHZvaWQgRG9jdW1lbnQ6OnVwZGF0ZUxheW91dElnbm9yZVBlbmRp bmcKICAgICAgICAgLy8gbW9tZW50LiAgSWYgaXQgd2VyZSBtb3JlIHJlZmluZWQsIHdlIG1pZ2h0 IGJlIGFibGUgdG8gZG8gc29tZXRoaW5nIGJldHRlci4pCiAgICAgICAgIC8vIEl0J3Mgd29ydGgg bm90aW5nIHRob3VnaCB0aGF0IHRoaXMgZW50aXJlIG1ldGhvZCBpcyBhIGhhY2ssIHNpbmNlIHdo YXQgd2UgcmVhbGx5IHdhbnQgdG8gZG8gaXMKICAgICAgICAgLy8gc3VzcGVuZCBKUyBpbnN0ZWFk IG9mIGRvaW5nIGEgbGF5b3V0IHdpdGggaW5hY2N1cmF0ZSBpbmZvcm1hdGlvbi4KLSAgICAgICAg aWYgKGJvZHkoKSAmJiAhYm9keSgpLT5yZW5kZXJlcigpICYmIG1fcGVuZGluZ1NoZWV0TGF5b3V0 ID09IE5vTGF5b3V0V2l0aFBlbmRpbmdTaGVldHMpCisgICAgICAgIGlmIChib2R5KCkgJiYgIWJv ZHkoKS0+cmVuZGVyZXIoKSAmJiBtX3BlbmRpbmdTaGVldExheW91dCA9PSBOb0xheW91dFdpdGhQ ZW5kaW5nU2hlZXRzKSB7CiAgICAgICAgICAgICBtX3BlbmRpbmdTaGVldExheW91dCA9IERpZExh eW91dFdpdGhQZW5kaW5nU2hlZXRzOwotICAgICAgICB1cGRhdGVTdHlsZVNlbGVjdG9yKCk7ICAg IAorICAgICAgICAgICAgdXBkYXRlU3R5bGVTZWxlY3RvcigpOworICAgICAgICB9CiAgICAgfQog CiAgICAgdXBkYXRlTGF5b3V0KCk7Cg==