147414 2015-07-29 12:04:38 -0700 Media Session: test Play/Pause media control events delivered to non-Content media sessions 2015-07-30 15:14:00 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson mrajca webkit-bug-importer oldest_to_newest 1113133 0 mrajca 2015-07-29 12:04:38 -0700 Add tests to ensure that Transient, Transient Solo, and Ambient media sessions don't respond to media control events. 1113136 1 webkit-bug-importer 2015-07-29 12:05:16 -0700 <rdar://problem/22056208> 1113187 2 257774 mrajca 2015-07-29 14:50:12 -0700 Created attachment 257774 Patch 1113353 3 257774 eric.carlson 2015-07-30 07:37:33 -0700 Comment on attachment 257774 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257774&action=review > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31 > + video.play(); Nit: If you want to add the event listener with "video.on<event type>", I think it will make the test results easier to understand if you log the event name as you would if you used waitForEvent, eg: consoleWrite("EVENT(" + event.type + ")"); > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62 > + <p>'Transient' sessions should not respond to Play/Pause media control events.</p> You are testing both transient and ambient sessions. 1113509 4 mrajca 2015-07-30 15:12:34 -0700 (In reply to comment #3) > Comment on attachment 257774 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257774&action=review > > > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31 > > + video.play(); > > Nit: If you want to add the event listener with "video.on<event type>", I > think it will make the test results easier to understand if you log the > event name as you would if you used waitForEvent, eg: > > consoleWrite("EVENT(" + event.type + ")"); I switched to `waitForEvent`. > > > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62 > > + <p>'Transient' sessions should not respond to Play/Pause media control events.</p> > > You are testing both transient and ambient sessions. Good catch. 1113510 5 mrajca 2015-07-30 15:14:00 -0700 Committed r187612: <http://trac.webkit.org/changeset/187612> 257774 2015-07-29 14:50:12 -0700 2015-07-30 07:37:33 -0700 Patch bug-147414-20150729144849.patch text/plain 5786 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NTUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjBkNzUxZDlmYzA4MDlhNzFkODBj NWIzYmYyOTA2YjFmNzRiZDQ4Mi4uNTA0YTcxM2U1YzEzYzAxMjQ3NWE5YTRlMmQ5NWJlOTc5YTc3 NTg4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACisyMDE1LTA3LTI5ICBNYXR0IFJhamNhICA8bXJh amNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiB0ZXN0IFBsYXkvUGF1c2Ug bWVkaWEgY29udHJvbCBldmVudHMgZGVsaXZlcmVkIHRvIG5vbi1Db250ZW50IG1lZGlhIHNlc3Np b25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc0 MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1l ZGlhL3Nlc3Npb24vcGxheS1wYXVzZS1tZWRpYS1ldmVudHMtaW4tbm9uLWNvbnRlbnQtc2Vzc2lv bnMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS9zZXNzaW9uL3BsYXktcGF1 c2UtbWVkaWEtZXZlbnRzLWluLW5vbi1jb250ZW50LXNlc3Npb25zLmh0bWw6IEFkZGVkLgorICAg ICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOiBNZWRpYSBTZXNzaW9uIHN1cHBv cnQgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdC4KKwogMjAxNS0wNy0yOSAgTWF0dCBSYWpjYSAgPG1y YWpjYUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWEgU2Vzc2lvbjogdGVzdCBQbGF5L1BhdXNl IG1lZGlhIGNvbnRyb2wgZXZlbnRzIGRlbGl2ZXJlZCB0byBDb250ZW50IG1lZGlhIHNlc3Npb25z CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc0MTMK IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvc2Vzc2lvbi9wbGF5LXBhdXNlLW1lZGlh LWV2ZW50cy1pbi1ub24tY29udGVudC1zZXNzaW9ucy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9tZWRpYS9zZXNzaW9uL3BsYXktcGF1c2UtbWVkaWEtZXZlbnRzLWluLW5vbi1jb250ZW50LXNl c3Npb25zLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kYzM3YmZkMWRkYWJlNTRiNzAyYjAzNTVi N2FhZTU1YzczZTVkNDgzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvc2Vz c2lvbi9wbGF5LXBhdXNlLW1lZGlhLWV2ZW50cy1pbi1ub24tY29udGVudC1zZXNzaW9ucy1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSwzOCBAQAorJ1RyYW5zaWVudCcgc2Vzc2lvbnMgc2hvdWxkIG5v dCByZXNwb25kIHRvIFBsYXkvUGF1c2UgbWVkaWEgY29udHJvbCBldmVudHMuCisKKworLS0tCitU ZXN0aW5nICJ0cmFuc2llbnQiIHNlc3Npb24ga2luZAorLS0tCitFVkVOVChjYW5wbGF5dGhyb3Vn aCkKK01lZGlhIGJlZ2FuIHBsYXlpbmcuCitFWFBFQ1RFRCAodmlkZW8ucGF1c2VkID09ICdmYWxz ZScpIE9LCitFWFBFQ1RFRCAoaW50ZXJuYWxzLm1lZGlhU2Vzc2lvbkN1cnJlbnRTdGF0ZShzZXNz aW9uKSA9PSAnYWN0aXZlJykgT0sKK05vbi1Db250ZW50IE1lZGlhIFNlc3Npb25zIHNob3VsZCBu b3QgcmVzcG9uZCB0byBQbGF5L1BhdXNlIGV2ZW50cy4KK1NlbmRpbmcgUGxheS9QYXVzZSBtZWRp YSBldmVudC4KK1JVTihpbnRlcm5hbHMuc2VuZE1lZGlhQ29udHJvbEV2ZW50KCJwbGF5LXBhdXNl IikpCitFWFBFQ1RFRCAodmlkZW8ucGF1c2VkID09ICdmYWxzZScpIE9LCistLS0KK1Rlc3Rpbmcg InRyYW5zaWVudC1zb2xvIiBzZXNzaW9uIGtpbmQKKy0tLQorRVZFTlQoY2FucGxheXRocm91Z2gp CitNZWRpYSBiZWdhbiBwbGF5aW5nLgorRVhQRUNURUQgKHZpZGVvLnBhdXNlZCA9PSAnZmFsc2Un KSBPSworRVhQRUNURUQgKGludGVybmFscy5tZWRpYVNlc3Npb25DdXJyZW50U3RhdGUoc2Vzc2lv bikgPT0gJ2FjdGl2ZScpIE9LCitOb24tQ29udGVudCBNZWRpYSBTZXNzaW9ucyBzaG91bGQgbm90 IHJlc3BvbmQgdG8gUGxheS9QYXVzZSBldmVudHMuCitTZW5kaW5nIFBsYXkvUGF1c2UgbWVkaWEg ZXZlbnQuCitSVU4oaW50ZXJuYWxzLnNlbmRNZWRpYUNvbnRyb2xFdmVudCgicGxheS1wYXVzZSIp KQorRVhQRUNURUQgKHZpZGVvLnBhdXNlZCA9PSAnZmFsc2UnKSBPSworLS0tCitUZXN0aW5nICJh bWJpZW50IiBzZXNzaW9uIGtpbmQKKy0tLQorRVZFTlQoY2FucGxheXRocm91Z2gpCitNZWRpYSBi ZWdhbiBwbGF5aW5nLgorRVhQRUNURUQgKHZpZGVvLnBhdXNlZCA9PSAnZmFsc2UnKSBPSworRVhQ RUNURUQgKGludGVybmFscy5tZWRpYVNlc3Npb25DdXJyZW50U3RhdGUoc2Vzc2lvbikgPT0gJ2Fj dGl2ZScpIE9LCitOb24tQ29udGVudCBNZWRpYSBTZXNzaW9ucyBzaG91bGQgbm90IHJlc3BvbmQg dG8gUGxheS9QYXVzZSBldmVudHMuCitTZW5kaW5nIFBsYXkvUGF1c2UgbWVkaWEgZXZlbnQuCitS VU4oaW50ZXJuYWxzLnNlbmRNZWRpYUNvbnRyb2xFdmVudCgicGxheS1wYXVzZSIpKQorRVhQRUNU RUQgKHZpZGVvLnBhdXNlZCA9PSAnZmFsc2UnKSBPSworRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvbWVkaWEvc2Vzc2lvbi9wbGF5LXBhdXNlLW1lZGlhLWV2ZW50cy1pbi1u b24tY29udGVudC1zZXNzaW9ucy5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvc2Vzc2lvbi9wbGF5 LXBhdXNlLW1lZGlhLWV2ZW50cy1pbi1ub24tY29udGVudC1zZXNzaW9ucy5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjRkZTk4Yzc0ZDY1MmM2ZGQyOGEwYWRhNWIwMTliYzNkMzJhMDhmNmQKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9zZXNzaW9uL3BsYXktcGF1c2UtbWVkaWEtZXZlbnRz LWluLW5vbi1jb250ZW50LXNlc3Npb25zLmh0bWwKQEAgLTAsMCArMSw2NSBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi92aWRlby10ZXN0Lmpz Ij48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vbWVkaWEtZmlsZS5qcyI+PC9zY3JpcHQ+ CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgICB2YXIgc2Vzc2lv bjsKKworICAgICAgICBmdW5jdGlvbiBydW5BbGxUZXN0cygpCisgICAgICAgIHsKKyAgICAgICAg ICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudCgnY2FucGxh eXRocm91Z2gnLCBiZWdpblBsYXlpbmcpOworICAgICAgICAgICAgcnVuVGVzdCgidHJhbnNpZW50 Iik7CisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBydW5UZXN0KHNlc3Npb25LaW5kKSAK KyAgICAgICAgeworICAgICAgICAgICAgY29uc29sZVdyaXRlKCctLS0nKTsKKyAgICAgICAgICAg IGNvbnNvbGVXcml0ZSgnVGVzdGluZyAiJyArIHNlc3Npb25LaW5kICsgJyIgc2Vzc2lvbiBraW5k Jyk7CisgICAgICAgICAgICBjb25zb2xlV3JpdGUoJy0tLScpOworCisgICAgICAgICAgICBzZXNz aW9uID0gbmV3IE1lZGlhU2Vzc2lvbihzZXNzaW9uS2luZCk7CisKKyAgICAgICAgICAgIHZpZGVv LnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgIi4uL2NvbnRlbnQvY291bnRpbmciKTsKKyAg ICAgICAgICAgIHZpZGVvLnNlc3Npb24gPSBzZXNzaW9uOworICAgICAgICAgICAgdmlkZW8ub25w bGF5aW5nID0gYmVnYW5QbGF5aW5nOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gYmVn aW5QbGF5aW5nKGV2ZW50KQorICAgICAgICB7CisgICAgICAgICAgICB2aWRlby5wbGF5KCk7Cisg ICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBiZWdhblBsYXlpbmcoZXZlbnQpCisgICAgICAg IHsKKyAgICAgICAgICAgIHZpZGVvLm9ucGxheWluZyA9IG51bGw7CisKKyAgICAgICAgICAgIGNv bnNvbGVXcml0ZSgiTWVkaWEgYmVnYW4gcGxheWluZy4iKTsKKyAgICAgICAgICAgIHRlc3RFeHBl Y3RlZCgndmlkZW8ucGF1c2VkJywgZmFsc2UpOworCisgICAgICAgICAgICBpZiAod2luZG93Lmlu dGVybmFscykgeworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgnaW50ZXJuYWxzLm1lZGlh U2Vzc2lvbkN1cnJlbnRTdGF0ZShzZXNzaW9uKScsICJhY3RpdmUiKTsKKworICAgICAgICAgICAg ICAgIGNvbnNvbGVXcml0ZSgiTm9uLUNvbnRlbnQgTWVkaWEgU2Vzc2lvbnMgc2hvdWxkIG5vdCBy ZXNwb25kIHRvIFBsYXkvUGF1c2UgZXZlbnRzLiIpOworICAgICAgICAgICAgICAgIGNvbnNvbGVX cml0ZSgiU2VuZGluZyBQbGF5L1BhdXNlIG1lZGlhIGV2ZW50LiIpOworICAgICAgICAgICAgICAg IHJ1bignaW50ZXJuYWxzLnNlbmRNZWRpYUNvbnRyb2xFdmVudCgicGxheS1wYXVzZSIpJyk7Cisg ICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCd2aWRlby5wYXVzZWQnLCBmYWxzZSk7CisgICAg ICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICh2aWRlby5zZXNzaW9uLmtp bmQgPT0gInRyYW5zaWVudCIpCisgICAgICAgICAgICAgICAgcnVuVGVzdCgidHJhbnNpZW50LXNv bG8iKTsKKyAgICAgICAgICAgIGVsc2UgaWYgKHZpZGVvLnNlc3Npb24ua2luZCA9PSAidHJhbnNp ZW50LXNvbG8iKQorICAgICAgICAgICAgICAgIHJ1blRlc3QoImFtYmllbnQiKTsKKyAgICAgICAg ICAgIGVsc2UgaWYgKHZpZGVvLnNlc3Npb24ua2luZCA9PSAiYW1iaWVudCIpCisgICAgICAgICAg ICAgICAgZW5kVGVzdCgpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGZhaWxU ZXN0KCJVbmV4cGVjdGVkIHNlc3Npb24ga2luZCIpOworICAgICAgICB9CisgICAgPC9zY3JpcHQ+ Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1bkFsbFRlc3RzKCkiPgorICAgIDxwPidUcmFuc2ll bnQnIHNlc3Npb25zIHNob3VsZCBub3QgcmVzcG9uZCB0byBQbGF5L1BhdXNlIG1lZGlhIGNvbnRy b2wgZXZlbnRzLjwvcD4KKyAgICA8dmlkZW8gaWQ9InZpZGVvIiAvPgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA0YTZlMDU2 YTliOTM2OTkwNjRiMTk2OGJjN2YyOWNiMmM5YmJmODM3Li44YTM5ZjI2OTUwYmY1NzA0YjViZjY5 MmRmZTA0ODZmY2U0MTIwZDAyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucwpAQCAtOTk4LDYgKzk5OCw3IEBAIG1lZGlhL3Nlc3Npb24vY29udGVudC1pbnRlcnJ1 cHRpb25zLmh0bWwKIG1lZGlhL3Nlc3Npb24vY29udHJvbHMtZXhpc3RlbmNlLmh0bWwKIG1lZGlh L3Nlc3Npb24vZGVmYXVsdC1zZXNzaW9uLmh0bWwKIG1lZGlhL3Nlc3Npb24vcGxheS1wYXVzZS1t ZWRpYS1ldmVudHMtaW4tY29udGVudC1zZXNzaW9ucy5odG1sCittZWRpYS9zZXNzaW9uL3BsYXkt cGF1c2UtbWVkaWEtZXZlbnRzLWluLW5vbi1jb250ZW50LXNlc3Npb25zLmh0bWwKIG1lZGlhL3Nl c3Npb24vdHJhbnNpZW50LWludGVycnVwdGlvbnMuaHRtbAogbWVkaWEvc2Vzc2lvbi90cmFuc2ll bnQtc29sby1pbnRlcnJ1cHRpb25zLmh0bWwKIAo=