147413 2015-07-29 12:02:21 -0700 Media Session: test Play/Pause media control events delivered to Content media sessions 2015-07-30 14:58:50 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson mrajca webkit-bug-importer oldest_to_newest 1113132 0 mrajca 2015-07-29 12:02:21 -0700 Add tests that ensure that: - Play/Pause media control events delivered to active Content media sessions play/pause participating media elements. - Play/Pause media control events delivered to idle Content media sessions don't affect playback in media elements. 1113167 1 257767 mrajca 2015-07-29 14:22:55 -0700 Created attachment 257767 Patch 1113168 2 webkit-bug-importer 2015-07-29 14:23:23 -0700 <rdar://problem/22059292> 1113355 3 257767 eric.carlson 2015-07-30 07:41:51 -0700 Comment on attachment 257767 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257767&action=review > LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt:18 > +EVENT(canplaythrough) > +EXPECTED (internals.mediaSessionCurrentState(session) == 'idle') OK > +Idle Media Sessions should not respond to Play/Pause events. > +EXPECTED (video.paused == 'true') OK > +Sending Play/Pause media event. > +RUN(internals.sendMediaControlEvent("play-pause")) > +EXPECTED (video.paused == 'true') OK > +Playing media. > +Media began playing. > +EXPECTED (video.paused == 'false') OK > +EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK > +Sending Play/Pause media event. > +RUN(internals.sendMediaControlEvent("play-pause")) > +EXPECTED (video.paused == 'true') OK > +END OF TEST Nit: I think it will be much easier to understand these results if you put a blank line between logical tests. > LayoutTests/media/session/play-pause-media-events-in-content-sessions.html:44 > + function beganPlaying(event) > + { > + video.onplaying = null; > + > + consoleWrite("Media began playing."); > + testExpected('video.paused', false); Ditto my comments in previous patches about manually adding logging if you use "video.on<event type>". 1113502 4 mrajca 2015-07-30 14:50:53 -0700 (In reply to comment #3) > Comment on attachment 257767 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257767&action=review > > > LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt:18 > > +EVENT(canplaythrough) > > +EXPECTED (internals.mediaSessionCurrentState(session) == 'idle') OK > > +Idle Media Sessions should not respond to Play/Pause events. > > +EXPECTED (video.paused == 'true') OK > > +Sending Play/Pause media event. > > +RUN(internals.sendMediaControlEvent("play-pause")) > > +EXPECTED (video.paused == 'true') OK > > +Playing media. > > +Media began playing. > > +EXPECTED (video.paused == 'false') OK > > +EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK > > +Sending Play/Pause media event. > > +RUN(internals.sendMediaControlEvent("play-pause")) > > +EXPECTED (video.paused == 'true') OK > > +END OF TEST > > Nit: I think it will be much easier to understand these results if you put a > blank line between logical tests. Fixed. > > > LayoutTests/media/session/play-pause-media-events-in-content-sessions.html:44 > > + function beganPlaying(event) > > + { > > + video.onplaying = null; > > + > > + consoleWrite("Media began playing."); > > + testExpected('video.paused', false); > > Ditto my comments in previous patches about manually adding logging if you > use "video.on<event type>". I switched to `waitForEvent`. 1113505 5 mrajca 2015-07-30 14:58:50 -0700 Committed r187611: <http://trac.webkit.org/changeset/187611> 257767 2015-07-29 14:22:55 -0700 2015-07-30 07:41:51 -0700 Patch bug-147413-20150729142132.patch text/plain 4981 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NTUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjA4NGQ1ODlkNTBkNWNkZGNlYWQw NGZiZWJjOTJjNzJhMzc0MjkzNS4uZjBkNzUxZDlmYzA4MDlhNzFkODBjNWIzYmYyOTA2YjFmNzRi ZDQ4MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTI5ICBNYXR0IFJhamNhICA8bXJh amNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiB0ZXN0IFBsYXkvUGF1c2Ug bWVkaWEgY29udHJvbCBldmVudHMgZGVsaXZlcmVkIHRvIENvbnRlbnQgbWVkaWEgc2Vzc2lvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzQxMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEv c2Vzc2lvbi9wbGF5LXBhdXNlLW1lZGlhLWV2ZW50cy1pbi1jb250ZW50LXNlc3Npb25zLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEvc2Vzc2lvbi9wbGF5LXBhdXNlLW1lZGlh LWV2ZW50cy1pbi1jb250ZW50LXNlc3Npb25zLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOiBNZWRpYSBTZXNzaW9uIHN1cHBvcnQgaXMgZGlzYWJs ZWQgYnkgZGVmYXVsdC4KKwogMjAxNS0wNy0xOSAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBsZS5j b20+CiAKICAgICAgICAgTWVkaWEgU2Vzc2lvbjogdGVzdCAnVHJhbnNpZW50IFNvbG8nIGludGVy cnVwdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3Nlc3Npb24vcGxheS1wYXVz ZS1tZWRpYS1ldmVudHMtaW4tY29udGVudC1zZXNzaW9ucy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9tZWRpYS9zZXNzaW9uL3BsYXktcGF1c2UtbWVkaWEtZXZlbnRzLWluLWNvbnRlbnQtc2Vz c2lvbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdiNzU5MjY3YTQxY2M4MGJmOGY2M2ZmNzA3 MWQ1N2M3YWY2ZDJlYTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9zZXNz aW9uL3BsYXktcGF1c2UtbWVkaWEtZXZlbnRzLWluLWNvbnRlbnQtc2Vzc2lvbnMtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMTkgQEAKKydDb250ZW50JyBzZXNzaW9ucyB0aGF0IGFyZSBhY3RpdmUg c2hvdWxkIHJlc3BvbmQgdG8gUGxheS9QYXVzZSBtZWRpYSBjb250cm9sIGV2ZW50cy4KKworCitF VkVOVChjYW5wbGF5dGhyb3VnaCkKK0VYUEVDVEVEIChpbnRlcm5hbHMubWVkaWFTZXNzaW9uQ3Vy cmVudFN0YXRlKHNlc3Npb24pID09ICdpZGxlJykgT0sKK0lkbGUgTWVkaWEgU2Vzc2lvbnMgc2hv dWxkIG5vdCByZXNwb25kIHRvIFBsYXkvUGF1c2UgZXZlbnRzLgorRVhQRUNURUQgKHZpZGVvLnBh dXNlZCA9PSAndHJ1ZScpIE9LCitTZW5kaW5nIFBsYXkvUGF1c2UgbWVkaWEgZXZlbnQuCitSVU4o aW50ZXJuYWxzLnNlbmRNZWRpYUNvbnRyb2xFdmVudCgicGxheS1wYXVzZSIpKQorRVhQRUNURUQg KHZpZGVvLnBhdXNlZCA9PSAndHJ1ZScpIE9LCitQbGF5aW5nIG1lZGlhLgorTWVkaWEgYmVnYW4g cGxheWluZy4KK0VYUEVDVEVEICh2aWRlby5wYXVzZWQgPT0gJ2ZhbHNlJykgT0sKK0VYUEVDVEVE IChpbnRlcm5hbHMubWVkaWFTZXNzaW9uQ3VycmVudFN0YXRlKHNlc3Npb24pID09ICdhY3RpdmUn KSBPSworU2VuZGluZyBQbGF5L1BhdXNlIG1lZGlhIGV2ZW50LgorUlVOKGludGVybmFscy5zZW5k TWVkaWFDb250cm9sRXZlbnQoInBsYXktcGF1c2UiKSkKK0VYUEVDVEVEICh2aWRlby5wYXVzZWQg PT0gJ3RydWUnKSBPSworRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvc2Vzc2lvbi9wbGF5LXBhdXNlLW1lZGlhLWV2ZW50cy1pbi1jb250ZW50LXNlc3Npb25zLmh0 bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9zZXNzaW9uL3BsYXktcGF1c2UtbWVkaWEtZXZlbnRzLWlu LWNvbnRlbnQtc2Vzc2lvbnMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ODFiNGMyZTAxOTIzYzI0NjBlZmMz NWVlNjZkMTE5ZTU1NDkxNjk4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEv c2Vzc2lvbi9wbGF5LXBhdXNlLW1lZGlhLWV2ZW50cy1pbi1jb250ZW50LXNlc3Npb25zLmh0bWwK QEAgLTAsMCArMSw2MiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxz Y3JpcHQgc3JjPSIuLi92aWRlby10ZXN0LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0i Li4vbWVkaWEtZmlsZS5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFz Y3JpcHQiPgorICAgICAgICB2YXIgc2Vzc2lvbjsKKworICAgICAgICBmdW5jdGlvbiBydW5UZXN0 KCkgCisgICAgICAgIHsKKyAgICAgICAgICAgIHNlc3Npb24gPSBuZXcgTWVkaWFTZXNzaW9uKCJj b250ZW50Iik7CisKKyAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgICAg IHdhaXRGb3JFdmVudCgnY2FucGxheXRocm91Z2gnLCBiZWdpblBsYXlpbmcpOworICAgICAgICAg ICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiLi4vY29udGVudC9jb3VudGlu ZyIpOworICAgICAgICAgICAgdmlkZW8uc2Vzc2lvbiA9IHNlc3Npb247CisgICAgICAgICAgICB2 aWRlby5vbnBsYXlpbmcgPSBiZWdhblBsYXlpbmc7CisgICAgICAgIH0KKworICAgICAgICBmdW5j dGlvbiBiZWdpblBsYXlpbmcoZXZlbnQpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICh3aW5k b3cuaW50ZXJuYWxzKQorICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgnaW50ZXJuYWxzLm1l ZGlhU2Vzc2lvbkN1cnJlbnRTdGF0ZShzZXNzaW9uKScsICJpZGxlIik7CisgICAgICAgICAgICAK KyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiSWRsZSBNZWRpYSBTZXNzaW9ucyBzaG91bGQgbm90 IHJlc3BvbmQgdG8gUGxheS9QYXVzZSBldmVudHMuIik7CisKKyAgICAgICAgICAgIHRlc3RFeHBl Y3RlZCgndmlkZW8ucGF1c2VkJywgdHJ1ZSk7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlm ICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCJTZW5k aW5nIFBsYXkvUGF1c2UgbWVkaWEgZXZlbnQuIik7CisgICAgICAgICAgICAgICAgcnVuKCdpbnRl cm5hbHMuc2VuZE1lZGlhQ29udHJvbEV2ZW50KCJwbGF5LXBhdXNlIiknKTsKKyAgICAgICAgICAg ICAgICB0ZXN0RXhwZWN0ZWQoJ3ZpZGVvLnBhdXNlZCcsIHRydWUpOworICAgICAgICAgICAgfQor CisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIlBsYXlpbmcgbWVkaWEuIik7CisgICAgICAgICAg ICB2aWRlby5wbGF5KCk7CisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBiZWdhblBsYXlp bmcoZXZlbnQpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZpZGVvLm9ucGxheWluZyA9IG51bGw7 CisKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiTWVkaWEgYmVnYW4gcGxheWluZy4iKTsKKyAg ICAgICAgICAgIHRlc3RFeHBlY3RlZCgndmlkZW8ucGF1c2VkJywgZmFsc2UpOworCisgICAgICAg ICAgICBpZiAod2luZG93LmludGVybmFscykgeworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3Rl ZCgnaW50ZXJuYWxzLm1lZGlhU2Vzc2lvbkN1cnJlbnRTdGF0ZShzZXNzaW9uKScsICJhY3RpdmUi KTsKKworICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiU2VuZGluZyBQbGF5L1BhdXNlIG1l ZGlhIGV2ZW50LiIpOworICAgICAgICAgICAgICAgIHJ1bignaW50ZXJuYWxzLnNlbmRNZWRpYUNv bnRyb2xFdmVudCgicGxheS1wYXVzZSIpJyk7CisgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVk KCd2aWRlby5wYXVzZWQnLCB0cnVlKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZW5k VGVzdCgpOworICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9 InJ1blRlc3QoKSI+CisgICAgPHA+J0NvbnRlbnQnIHNlc3Npb25zIHRoYXQgYXJlIGFjdGl2ZSBz aG91bGQgcmVzcG9uZCB0byBQbGF5L1BhdXNlIG1lZGlhIGNvbnRyb2wgZXZlbnRzLjwvcD4KKyAg ICA8dmlkZW8gaWQ9InZpZGVvIiAvPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA2ZTI4ZGM3NGQxNzI4MDJkOTg0OWM4OWY3 ZmUxYzgxMDRiNzBjMzdiLi40YTZlMDU2YTliOTM2OTkwNjRiMTk2OGJjN2YyOWNiMmM5YmJmODM3 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtOTk3LDYg Kzk5Nyw3IEBAIHdlYmtpdC5vcmcvYi8xNDA2MzkgaHR0cC90ZXN0cy9tZWRpYS92aWRlby1wbGF5 LXdhaXRpbmcuaHRtbCBbIFBhc3MgVGltZW91dCBdCiBtZWRpYS9zZXNzaW9uL2NvbnRlbnQtaW50 ZXJydXB0aW9ucy5odG1sCiBtZWRpYS9zZXNzaW9uL2NvbnRyb2xzLWV4aXN0ZW5jZS5odG1sCiBt ZWRpYS9zZXNzaW9uL2RlZmF1bHQtc2Vzc2lvbi5odG1sCittZWRpYS9zZXNzaW9uL3BsYXktcGF1 c2UtbWVkaWEtZXZlbnRzLWluLWNvbnRlbnQtc2Vzc2lvbnMuaHRtbAogbWVkaWEvc2Vzc2lvbi90 cmFuc2llbnQtaW50ZXJydXB0aW9ucy5odG1sCiBtZWRpYS9zZXNzaW9uL3RyYW5zaWVudC1zb2xv LWludGVycnVwdGlvbnMuaHRtbAogCg==