147398 2015-07-28 21:18:56 -0700 Avoid unnecessarily constructing PlatformMediaSessionManager on Document destruction 2015-07-29 00:18:09 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue eric.carlson jer.noble oldest_to_newest 1113025 0 cdumez 2015-07-28 21:18:56 -0700 When looking at a benchmark trace, I saw the following: 54,16.2%,15.5%,WebCore::HTMLDocument::~HTMLDocument() (in WebCore) 54,16.2%,15.5%, WebCore::Document::~Document() (in WebCore) 54,16.2%,15.5%, WebCore::PlatformMediaSessionManager::sharedManager() (in WebCore) 54,16.2%,15.5%, WebCore::MediaSessionManageriOS::MediaSessionManageriOS() (in WebCore) 54,16.2%,15.5%, -[WebMediaSessionHelper initWithCallback:] (in WebCore) 54,16.2%,15.5%, -[WebMediaSessionHelper allocateVolumeView] (in WebCore) 50,15.0%,14.4%, -[MPVolumeView initWithFrame:style:] (in MediaPlayer) 4,1.2%,1.2%, initMPVolumeView() (in WebCore) We end up constructing a PlatformMediaSessionManager when destroying a Document, because of a call to PlatformMediaSessionManager::shared().stopAllMediaPlaybackForProcess(). This seems unfortunate. 1113026 1 257730 cdumez 2015-07-28 21:24:02 -0700 Created attachment 257730 Patch 1113055 2 257730 commit-queue 2015-07-29 00:18:03 -0700 Comment on attachment 257730 Patch Clearing flags on attachment: 257730 Committed r187544: <http://trac.webkit.org/changeset/187544> 1113056 3 commit-queue 2015-07-29 00:18:09 -0700 All reviewed patches have been landed. Closing bug. 257730 2015-07-28 21:24:02 -0700 2015-07-29 00:18:03 -0700 Patch bug-147398-20150728212240.patch text/plain 6589 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIyYjJmNWQ5MTFmNGM5 MzE3NjQzNDc1YzIyNTYwZTc5MmJmODZiMC4uODFlZDljOTA4ODc1M2VjMmFhMjFjYzIzOTdlMDFh NzViNjlmYWMzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA3LTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgdW5uZWNlc3Nhcmls eSBjb25zdHJ1Y3RpbmcgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyIG9uIERvY3VtZW50IGRl c3RydWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDczOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBPbmx5IGNhbGwgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzdG9wQWxsTWVkaWFQbGF5 YmFja0ZvclByb2Nlc3MoKSBpbgorICAgICAgICBkZXN0cnVjdG9ycyBpZiBhbiBQbGF0Zm9ybU1l ZGlhU2Vzc2lvbk1hbmFnZXIgaW5zdGFuY2UgYWxyZWFkeSBleGlzdHMsIHRvCisgICAgICAgIGF2 b2lkIGNvbnN0cnVjdGluZyBvbmUgdW5lY2Vzc2FyaWx5IGF0IHRoYXQgcG9pbnQuCisKKyAgICAg ICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6On5Eb2N1 bWVudCk6CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5h Z2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6 c2hhcmVkTWFuYWdlcik6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1h bmFnZXI6OnNoYXJlZE1hbmFnZXJJZkV4aXN0cyk6CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8v UGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyLmg6CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8v aW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9y bU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXIpOgorICAgICAgICAoV2ViQ29yZTo6 UGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VySWZFeGlzdHMpOgorCiAy MDE1LTA3LTI3ICBKb24gRGF2aXMgIDxqb25kQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRpbmcg V2ViIENvbXBvbmVudHMgdG8gZmVhdHVyZSBzdGF0dXMgcGFnZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlMzgz ZDY5YzhjMGEzMjdkM2ZmZDdlMDVmNjFlNmIwMzU5NGViNjAxLi5kMDFiZTQ3MjQ1YjIwMGE1Zjlm MDQ3Zjk4NmQzMzYwNmM5YzhlNDIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUt MDctMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1 bm5lY2Vzc2FyaWx5IGNvbnN0cnVjdGluZyBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIgb24g RG9jdW1lbnQgZGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NzM5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE9ubHkgY2FsbCBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnN0b3BB bGxNZWRpYVBsYXliYWNrRm9yUHJvY2VzcygpIGluCisgICAgICAgIGRlc3RydWN0b3JzIGlmIGFu IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciBpbnN0YW5jZSBhbHJlYWR5IGV4aXN0cywgdG8g CisgICAgICAgIGF2b2lkIGNvbnN0cnVjdGluZyBvbmUgdW5lY2Vzc2FyaWx5IGF0IHRoYXQgcG9p bnQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJQcm9jZXNzOjpkaWRDbG9zZSk6CisKIDIwMTUtMDctMjcgIFRpbSBIb3J0b24gIDx0 aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRmlyc3QgaW4td2luZG93IHZpZXdT dGF0ZUNoYW5nZSBzeW5jaHJvbm91c2x5IGJsb2NrcyBkZXNwaXRlIG5vdCBwcmV2aW91c2x5IGJl aW5nIGluLXdpbmRvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggZDg2MzEyYjIyMDk0ZjUy NWExMDVhMmQ0ZGIwZjlkODdlMGFkNjFkOS4uOWIwYzIyMGMxNmZiZmU3OWFkMzgxODU3ZDdmOThl NDZhYjZkYzRkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC02MzQsNyArNjM0LDggQEAg RG9jdW1lbnQ6On5Eb2N1bWVudCgpCiAgICAgICAgIG1fY2FjaGVkUmVzb3VyY2VMb2FkZXItPnNl dERvY3VtZW50KG51bGxwdHIpOwogCiAjaWYgRU5BQkxFKFZJREVPKQotICAgIFBsYXRmb3JtTWVk aWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFuYWdlcigpLnN0b3BBbGxNZWRpYVBsYXliYWNrRm9y RG9jdW1lbnQodGhpcyk7CisgICAgaWYgKGF1dG8qIHBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdl ciA9IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFuYWdlcklmRXhpc3RzKCkp CisgICAgICAgIHBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci0+c3RvcEFsbE1lZGlhUGxheWJh Y2tGb3JEb2N1bWVudCh0aGlzKTsKICNlbmRpZgogICAgIAogICAgIC8vIFdlIG11c3QgY2FsbCBj bGVhclJhcmVEYXRhKCkgaGVyZSBzaW5jZSBhIERvY3VtZW50IGNsYXNzIGluaGVyaXRzIFRyZWVT Y29wZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1N ZWRpYVNlc3Npb25NYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1Bs YXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5jcHAKaW5kZXggZGUxZDg2MWVlYTkyOTg0OWQwOWUx ZDE2YzIzMDhmZTNhMjFjMTJiZC4uOGNhZDNmMzc0NGU1ODhkOTQzN2UzZmM3YWFjYTVmOWUyY2E1 NDRlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1N ZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9QbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCkBAIC0zNywxMCArMzcsMTggQEAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogI2lmICFQTEFURk9STShJT1MpCitzdGF0aWMgUGxhdGZvcm1N ZWRpYVNlc3Npb25NYW5hZ2VyKiBwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIgPSBudWxscHRy OworCiBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXImIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFu YWdlcjo6c2hhcmVkTWFuYWdlcigpCiB7Ci0gICAgREVQUkVDQVRFRF9ERUZJTkVfU1RBVElDX0xP Q0FMKFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciwgbWFuYWdlciwgKCkpOwotICAgIHJldHVy biBtYW5hZ2VyOworICAgIGlmICghcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyKQorICAgICAg ICBwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIgPSBuZXcgUGxhdGZvcm1NZWRpYVNlc3Npb25N YW5hZ2VyOworICAgIHJldHVybiAqcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOworfQorCitQ bGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIqIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6 c2hhcmVkTWFuYWdlcklmRXhpc3RzKCkKK3sKKyAgICByZXR1cm4gcGxhdGZvcm1NZWRpYVNlc3Np b25NYW5hZ2VyOwogfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL1BsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyLmgKaW5kZXggMDFkM2Ix ZTY2MDNkNjY0Y2NiYTQxMzRkODgxMWRkZTNkYmI5OTc5ZS4uNTAzZDk5YmQyMWVlZTQwYjUzNGQ1 OTI3MjUwZjBjZjBmMTg4NzY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyLmgKQEAgLTQ0LDYgKzQ0 LDcgQEAgY2xhc3MgUmVtb3RlQ29tbWFuZExpc3RlbmVyOwogY2xhc3MgUGxhdGZvcm1NZWRpYVNl c3Npb25NYW5hZ2VyIDogcHJpdmF0ZSBSZW1vdGVDb21tYW5kTGlzdGVuZXJDbGllbnQsIHByaXZh dGUgU3lzdGVtU2xlZXBMaXN0ZW5lcjo6Q2xpZW50LCBwcml2YXRlIEF1ZGlvSGFyZHdhcmVMaXN0 ZW5lcjo6Q2xpZW50IHsKICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKKyAg ICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyKiBzaGFy ZWRNYW5hZ2VySWZFeGlzdHMoKTsKICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgUGxhdGZvcm1N ZWRpYVNlc3Npb25NYW5hZ2VyJiBzaGFyZWRNYW5hZ2VyKCk7CiAgICAgdmlydHVhbCB+UGxhdGZv cm1NZWRpYVNlc3Npb25NYW5hZ2VyKCkgeyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL2lvcy9NZWRpYVNlc3Npb25NYW5hZ2VySU9TLm1tIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KaW5kZXgg NTQ0ZmVlZTRlNDc1YTYzNzU3N2U3YjcxNjQxNDJiOWZlYWZmMTZiZC4uOGVjNTY0MjE3YTYyZDgx NTQyY2NhMmJjZTc0NmNhZmJmZmZlZGJiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KQEAgLTEx MCwxMCArMTEwLDE4IEBAIEBlbmQKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitzdGF0aWMgTWVk aWFTZXNzaW9uTWFuYWdlcmlPUyogcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyID0gbnVsbHB0 cjsKKwogUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyJiBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1h bmFnZXI6OnNoYXJlZE1hbmFnZXIoKQogewotICAgIERFUFJFQ0FURURfREVGSU5FX1NUQVRJQ19M T0NBTChNZWRpYVNlc3Npb25NYW5hZ2VyaU9TLCBtYW5hZ2VyLCAoKSk7Ci0gICAgcmV0dXJuIG1h bmFnZXI7CisgICAgaWYgKCFwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIpCisgICAgICAgIHBs YXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciA9IG5ldyBNZWRpYVNlc3Npb25NYW5hZ2VyaU9TOwor ICAgIHJldHVybiAqcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOworfQorCitQbGF0Zm9ybU1l ZGlhU2Vzc2lvbk1hbmFnZXIqIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFu YWdlcklmRXhpc3RzKCkKK3sKKyAgICByZXR1cm4gcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2Vy OwogfQogCiBNZWRpYVNlc3Npb25NYW5hZ2VyaU9TOjpNZWRpYVNlc3Npb25NYW5hZ2VyaU9TKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IGVhNDA2ZGQ1MjJl NWEyNWE0ZDc0M2ZlYzhhMmI2MGEyOWVkOGNjNzYuLjU4N2U3MWRiNzljYjA3ZjhmYmVkZDMwYzkx NjM1YWM4ZDhmZDBkNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNw cApAQCAtNjYxLDcgKzY2MSw4IEBAIHZvaWQgV2ViUHJvY2Vzczo6ZGlkQ2xvc2UoSVBDOjpDb25u ZWN0aW9uJikKIAogI2lmIEVOQUJMRShWSURFTykKICAgICAvLyBGSVhNRSgxNDY2NTcpOiBUaGlz IGV4cGxpY2l0IG1lZGlhIHN0b3AgY29tbWFuZCBzaG91bGQgbm90IGJlIG5lY2Vzc2FyeQotICAg IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFuYWdlcigpLnN0b3BBbGxNZWRp YVBsYXliYWNrRm9yUHJvY2VzcygpOworICAgIGlmIChhdXRvKiBwbGF0Zm9ybU1lZGlhU2Vzc2lv bk1hbmFnZXIgPSBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXJJZkV4 aXN0cygpKQorICAgICAgICBwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXItPnN0b3BBbGxNZWRp YVBsYXliYWNrRm9yUHJvY2VzcygpOwogI2VuZGlmCiAKICAgICAvLyBUaGUgVUkgcHJvY2VzcyBj bG9zZWQgdGhpcyBjb25uZWN0aW9uLCBzaHV0IGRvd24uCg==