147395 2015-07-28 18:45:33 -0700 [GTK] Missing casts in BrowserWindow.c 2015-07-28 23:48:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro cgarcia commit-queue mcatanzaro oldest_to_newest 1112994 0 mcatanzaro 2015-07-28 18:45:33 -0700 ../../Tools/MiniBrowser/gtk/BrowserWindow.c:817:22: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types] window->boldItem = item; ^ ~~~~ ../../Tools/MiniBrowser/gtk/BrowserWindow.c:824:24: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types] window->italicItem = item; ^ ~~~~ ../../Tools/MiniBrowser/gtk/BrowserWindow.c:831:27: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types] window->underlineItem = item; ^ ~~~~ ../../Tools/MiniBrowser/gtk/BrowserWindow.c:839:31: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types] window->strikethroughItem = item; ^ ~~~~ 1113014 1 257727 mcatanzaro 2015-07-28 20:10:58 -0700 Created attachment 257727 Patch 1113051 2 257727 commit-queue 2015-07-28 23:48:39 -0700 Comment on attachment 257727 Patch Clearing flags on attachment: 257727 Committed r187541: <http://trac.webkit.org/changeset/187541> 1113052 3 commit-queue 2015-07-28 23:48:44 -0700 All reviewed patches have been landed. Closing bug. 257727 2015-07-28 20:10:58 -0700 2015-07-28 23:48:39 -0700 Patch bug-147395-20150728220935.patch text/plain 2764 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzNmODYwMGZhZTEyODdiYzI4M2I5ODA0ZDAwMjFhNTZl MDk1MmQwOS4uNWIzYWNjYjhhMjQwN2EyY2U4ZDRiN2JlM2Y0ODVhZGViNmFkYzEyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA3LTI4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBNaXNzaW5nIGNhc3RzIGluIEJyb3dzZXJXaW5kb3cuYworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3Mzk1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jOgorICAgICAgICAoYnJvd3NlcldpbmRvd1NldHVwRWRpdG9y VG9vbGJhcik6CisKIDIwMTUtMDctMjggIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp bC5jb20+CiAKICAgICAgICAgW0VTNl0gQWRkIEVOQUJMRV9FUzZfTU9EVUxFUyBjb21waWxlIHRp bWUgZmxhZyB3aXRoIHRoZSBkZWZhdWx0IHZhbHVlICJmYWxzZSIKZGlmZiAtLWdpdCBhL1Rvb2xz L01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsv QnJvd3NlcldpbmRvdy5jCmluZGV4IDg4MDc5MWIzN2U0N2ZiMTY2Nzc0NTM2M2VkMTU2MDZkN2Q3 ZjE0MTYuLjlhNDkwMmU1OTg3N2I0Mzg2N2M5NmFhZmZkZjYzMGFiZjA4NDExMzMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWlu aUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAtODE0LDIxICs4MTQsMjEgQEAgc3RhdGlj IHZvaWQgYnJvd3NlcldpbmRvd1NldHVwRWRpdG9yVG9vbGJhcihCcm93c2VyV2luZG93ICp3aW5k b3cpCiAgICAgZ3RrX3Rvb2xiYXJfc2V0X3N0eWxlKEdUS19UT09MQkFSKHRvb2xiYXIpLCBHVEtf VE9PTEJBUl9CT1RIX0hPUklaKTsKIAogICAgIEd0a1Rvb2xJdGVtICppdGVtID0gZ3RrX3RvZ2ds ZV90b29sX2J1dHRvbl9uZXdfZnJvbV9zdG9jayhHVEtfU1RPQ0tfQk9MRCk7Ci0gICAgd2luZG93 LT5ib2xkSXRlbSA9IGl0ZW07CisgICAgd2luZG93LT5ib2xkSXRlbSA9IEdUS19XSURHRVQoaXRl bSk7CiAgICAgZ3RrX3dpZGdldF9zZXRfbmFtZShHVEtfV0lER0VUKGl0ZW0pLCAiQm9sZCIpOwog ICAgIGdfc2lnbmFsX2Nvbm5lY3QoR19PQkpFQ1QoaXRlbSksICJ0b2dnbGVkIiwgR19DQUxMQkFD SyhlZGl0aW5nQ29tbWFuZENhbGxiYWNrKSwgd2luZG93KTsKICAgICBndGtfdG9vbGJhcl9pbnNl cnQoR1RLX1RPT0xCQVIodG9vbGJhciksIGl0ZW0sIC0xKTsKICAgICBndGtfd2lkZ2V0X3Nob3co R1RLX1dJREdFVChpdGVtKSk7CiAKICAgICBpdGVtID0gZ3RrX3RvZ2dsZV90b29sX2J1dHRvbl9u ZXdfZnJvbV9zdG9jayhHVEtfU1RPQ0tfSVRBTElDKTsKLSAgICB3aW5kb3ctPml0YWxpY0l0ZW0g PSBpdGVtOworICAgIHdpbmRvdy0+aXRhbGljSXRlbSA9IEdUS19XSURHRVQoaXRlbSk7CiAgICAg Z3RrX3dpZGdldF9zZXRfbmFtZShHVEtfV0lER0VUKGl0ZW0pLCAiSXRhbGljIik7CiAgICAgZ19z aWduYWxfY29ubmVjdChHX09CSkVDVChpdGVtKSwgInRvZ2dsZWQiLCBHX0NBTExCQUNLKGVkaXRp bmdDb21tYW5kQ2FsbGJhY2spLCB3aW5kb3cpOwogICAgIGd0a190b29sYmFyX2luc2VydChHVEtf VE9PTEJBUih0b29sYmFyKSwgaXRlbSwgLTEpOwogICAgIGd0a193aWRnZXRfc2hvdyhHVEtfV0lE R0VUKGl0ZW0pKTsKIAogICAgIGl0ZW0gPSBndGtfdG9nZ2xlX3Rvb2xfYnV0dG9uX25ld19mcm9t X3N0b2NrKEdUS19TVE9DS19VTkRFUkxJTkUpOwotICAgIHdpbmRvdy0+dW5kZXJsaW5lSXRlbSA9 IGl0ZW07CisgICAgd2luZG93LT51bmRlcmxpbmVJdGVtID0gR1RLX1dJREdFVChpdGVtKTsKICAg ICBndGtfd2lkZ2V0X3NldF9uYW1lKEdUS19XSURHRVQoaXRlbSksICJVbmRlcmxpbmUiKTsKICAg ICBnX3NpZ25hbF9jb25uZWN0KEdfT0JKRUNUKGl0ZW0pLCAidG9nZ2xlZCIsIEdfQ0FMTEJBQ0so ZWRpdGluZ0NvbW1hbmRDYWxsYmFjayksIHdpbmRvdyk7CiAgICAgZ3RrX3Rvb2xiYXJfaW5zZXJ0 KEdUS19UT09MQkFSKHRvb2xiYXIpLCBpdGVtLCAtMSk7CkBAIC04MzYsNyArODM2LDcgQEAgc3Rh dGljIHZvaWQgYnJvd3NlcldpbmRvd1NldHVwRWRpdG9yVG9vbGJhcihCcm93c2VyV2luZG93ICp3 aW5kb3cpCiAKICAgICBpdGVtID0gZ3RrX3RvZ2dsZV90b29sX2J1dHRvbl9uZXdfZnJvbV9zdG9j ayhHVEtfU1RPQ0tfU1RSSUtFVEhST1VHSCk7CiAgICAgZ3RrX3dpZGdldF9zZXRfbmFtZShHVEtf V0lER0VUKGl0ZW0pLCAiU3RyaWtldGhyb3VnaCIpOwotICAgIHdpbmRvdy0+c3RyaWtldGhyb3Vn aEl0ZW0gPSBpdGVtOworICAgIHdpbmRvdy0+c3RyaWtldGhyb3VnaEl0ZW0gPSBHVEtfV0lER0VU KGl0ZW0pOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QoR19PQkpFQ1QoaXRlbSksICJ0b2dnbGVkIiwg R19DQUxMQkFDSyhlZGl0aW5nQ29tbWFuZENhbGxiYWNrKSwgd2luZG93KTsKICAgICBndGtfdG9v bGJhcl9pbnNlcnQoR1RLX1RPT0xCQVIodG9vbGJhciksIGl0ZW0sIC0xKTsKICAgICBndGtfd2lk Z2V0X3Nob3coR1RLX1dJREdFVChpdGVtKSk7Cg==