147383 2015-07-28 16:37:47 -0700 Speed up the Stringifier::toJSON() fast case 2015-07-28 19:17:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1112926 0 benjamin 2015-07-28 16:37:47 -0700 Speed up the Stringifier::toJSON() fast case 1112928 1 257701 benjamin 2015-07-28 16:39:47 -0700 Created attachment 257701 Patch 1112999 2 257701 kling 2015-07-28 19:02:24 -0700 Comment on attachment 257701 Patch k 1113005 3 257701 benjamin 2015-07-28 19:17:04 -0700 Comment on attachment 257701 Patch Clearing flags on attachment: 257701 Committed r187537: <http://trac.webkit.org/changeset/187537> 1113006 4 benjamin 2015-07-28 19:17:07 -0700 All reviewed patches have been landed. Closing bug. 257701 2015-07-28 16:39:47 -0700 2015-07-28 19:17:04 -0700 Patch bug-147383-20150728163825.patch text/plain 6292 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NjNjNDVhMjg3NzljMjdlNmU3NzM2OGJiZjFiNmU0MjAwNDBlMDUzLi5kMTQ1ZTkyNmFhOTNiYTJl ZWRlMDYyNWE0NjQ5MWFhZjJlMjAyODdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wNy0yOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBTcGVlZCB1cCB0aGUgU3RyaW5naWZpZXI6OnRvSlNPTigpIGZhc3Qg Y2FzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3 MzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBy dW50aW1lL0pTT05PYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpTdHJpbmdpZmllcjo6dG9KU09O KToKKyAgICAgICAgKEpTQzo6U3RyaW5naWZpZXI6OnRvSlNPTkltcGwpOgorCiAyMDE1LTA3LTI4 ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHOjpQdXRTdGFj a1NpbmtpbmdQaGFzZSBzaG91bGQgYmUgbW9yZSBhZ2dyZXNzaXZlIGFib3V0IGl0cyAibm8gR2V0 U3RhY2sgdW50aWwgcHV0IiBydWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU09OT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T05PYmplY3QuY3BwCmluZGV4IDQ5ZDZiMTU4OTIxNTlmMTBkZGVkYjQ1ZDJjZmIwNjRhYTFhNTg4 ZGIuLmY2N2JhN2VjZThkYzM5NGE4MTA4M2YzNjc3ZmQyNjg5NWU2YTA3ZWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCkBAIC0xMDgsNiArMTA4LDcg QEAgcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgSG9sZGVyOwogCiAgICAgSlNWYWx1ZSB0b0pT T04oSlNWYWx1ZSwgY29uc3QgUHJvcGVydHlOYW1lRm9yRnVuY3Rpb25DYWxsJik7CisgICAgSlNW YWx1ZSB0b0pTT05JbXBsKEpTVmFsdWUsIGNvbnN0IFByb3BlcnR5TmFtZUZvckZ1bmN0aW9uQ2Fs bCYpOwogCiAgICAgZW51bSBTdHJpbmdpZnlSZXN1bHQgeyBTdHJpbmdpZnlGYWlsZWQsIFN0cmlu Z2lmeVN1Y2NlZWRlZCwgU3RyaW5naWZ5RmFpbGVkRHVlVG9VbmRlZmluZWRWYWx1ZSB9OwogICAg IFN0cmluZ2lmeVJlc3VsdCBhcHBlbmRTdHJpbmdpZmllZFZhbHVlKFN0cmluZ0J1aWxkZXImLCBK U1ZhbHVlLCBKU09iamVjdCogaG9sZGVyLCBjb25zdCBQcm9wZXJ0eU5hbWVGb3JGdW5jdGlvbkNh bGwmKTsKQEAgLTI1MywxMiArMjU0LDE2IEBAIExvY2FsPFVua25vd24+IFN0cmluZ2lmaWVyOjpz dHJpbmdpZnkoSGFuZGxlPFVua25vd24+IHZhbHVlKQogICAgIHJldHVybiBMb2NhbDxVbmtub3du PihtX2V4ZWMtPnZtKCksIGpzU3RyaW5nKG1fZXhlYywgcmVzdWx0LnRvU3RyaW5nKCkpKTsKIH0K IAotaW5saW5lIEpTVmFsdWUgU3RyaW5naWZpZXI6OnRvSlNPTihKU1ZhbHVlIHZhbHVlLCBjb25z dCBQcm9wZXJ0eU5hbWVGb3JGdW5jdGlvbkNhbGwmIHByb3BlcnR5TmFtZSkKK0FMV0FZU19JTkxJ TkUgSlNWYWx1ZSBTdHJpbmdpZmllcjo6dG9KU09OKEpTVmFsdWUgdmFsdWUsIGNvbnN0IFByb3Bl cnR5TmFtZUZvckZ1bmN0aW9uQ2FsbCYgcHJvcGVydHlOYW1lKQogewogICAgIEFTU0VSVCghbV9l eGVjLT5oYWRFeGNlcHRpb24oKSk7CiAgICAgaWYgKCF2YWx1ZS5pc09iamVjdCgpIHx8ICFhc09i amVjdCh2YWx1ZSktPmhhc1Byb3BlcnR5KG1fZXhlYywgbV9leGVjLT52bSgpLnByb3BlcnR5TmFt ZXMtPnRvSlNPTikpCiAgICAgICAgIHJldHVybiB2YWx1ZTsKKyAgICByZXR1cm4gdG9KU09OSW1w bCh2YWx1ZSwgcHJvcGVydHlOYW1lKTsKK30KIAorSlNWYWx1ZSBTdHJpbmdpZmllcjo6dG9KU09O SW1wbChKU1ZhbHVlIHZhbHVlLCBjb25zdCBQcm9wZXJ0eU5hbWVGb3JGdW5jdGlvbkNhbGwmIHBy b3BlcnR5TmFtZSkKK3sKICAgICBKU1ZhbHVlIHRvSlNPTkZ1bmN0aW9uID0gYXNPYmplY3QodmFs dWUpLT5nZXQobV9leGVjLCBtX2V4ZWMtPnZtKCkucHJvcGVydHlOYW1lcy0+dG9KU09OKTsKICAg ICBpZiAobV9leGVjLT5oYWRFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIGpzTnVsbCgpOwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGJlMTk5YmYwMzEzYjlmMWQ4YTkwOTZlOTU2NWVjNTJiNjRmMjA2NzcuLjU5ODE3OTAy ZjJjZDE2NWMwMDMyYmIxM2NhYTg5ZGNiMmQ0M2E1NzMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAor MjAxNS0wNy0yOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKworICAg ICAgICBTcGVlZCB1cCB0aGUgU3RyaW5naWZpZXI6OnRvSlNPTigpIGZhc3QgY2FzZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MzgzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSB0aGUgZmFzdCBj YXNlIG9mIFN0cmluZ2lmaWVyOjp0b0pTT04oKSBpbmxpbmUgYW5kIHRoZSB1bmNvbW1vbgorICAg ICAgICBjYXNlIG91dC1vZi1saW5lLgorCisgICAgICAgICoganMvZG9tL0pTT04tc3RyaW5naWZ5 LXN0cmluZy1vYmplY3Qtd2l0aC10b2pzb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBqcy9kb20vSlNPTi1zdHJpbmdpZnktc3RyaW5nLW9iamVjdC13aXRoLXRvanNvbi5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBqcy9yZXNvdXJjZXMvSlNPTi1zdHJpbmdpZnktc3RyaW5nLW9iamVj dC13aXRoLXRvanNvbi5qczogQWRkZWQuCisgICAgICAgIChzdHJpbmdPYmplY3QudG9KU09OKToK KyAgICAgICAgKFN0cmluZy5wcm90b3R5cGUudG9KU09OKToKKwogMjAxNS0wNy0yOCAgSm9zZXBo IFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEluY2x1ZGUgPHRlbXBsYXRlPiBub2RlIGNvbnRlbnQgaW4gRE9NIFRyZWUKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2pzL2RvbS9KU09OLXN0cmluZ2lmeS1zdHJpbmctb2JqZWN0LXdpdGgtdG9q c29uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2pzL2RvbS9KU09OLXN0cmluZ2lmeS1zdHJp bmctb2JqZWN0LXdpdGgtdG9qc29uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41ZTQxYzVkZGRh NGM0MDc5MzVlMTNhYTg2YjlmNjFkMzE1ZjEzM2M2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvanMvZG9tL0pTT04tc3RyaW5naWZ5LXN0cmluZy1vYmplY3Qtd2l0aC10b2pzb24tZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1BBU1MgbmF0aXZlSlNPTi5zdHJpbmdpZnkoc3Ry aW5nT2JqZWN0KSBpcyAiXCJGb29cIiIKK1BBU1MgbmF0aXZlSlNPTi5zdHJpbmdpZnkoc3RyaW5n T2JqZWN0KSBpcyBKU09OLnN0cmluZ2lmeShzdHJpbmdPYmplY3QpCitQQVNTIG5hdGl2ZUpTT04u c3RyaW5naWZ5KHN0cmluZ09iamVjdCkgaXMgIlwiV2VpcmQgQ2FzZSAxXCIiCitQQVNTIG5hdGl2 ZUpTT04uc3RyaW5naWZ5KHN0cmluZ09iamVjdCkgaXMgSlNPTi5zdHJpbmdpZnkoc3RyaW5nT2Jq ZWN0KQorUEFTUyBuYXRpdmVKU09OLnN0cmluZ2lmeShzdHJpbmdPYmplY3QpIGlzICJcIkJhclwi IgorUEFTUyBuYXRpdmVKU09OLnN0cmluZ2lmeShzdHJpbmdPYmplY3QpIGlzIEpTT04uc3RyaW5n aWZ5KHN0cmluZ09iamVjdCkKK1BBU1MgbmF0aXZlSlNPTi5zdHJpbmdpZnkoc3RyaW5nT2JqZWN0 KSBpcyAiXCJXZWlyZCBDYXNlIDJcIiIKK1BBU1MgbmF0aXZlSlNPTi5zdHJpbmdpZnkoc3RyaW5n T2JqZWN0KSBpcyBKU09OLnN0cmluZ2lmeShzdHJpbmdPYmplY3QpCitQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvanMvZG9tL0pTT04tc3RyaW5naWZ5LXN0cmluZy1vYmplY3Qtd2l0aC10b2pzb24uaHRtbCBi L0xheW91dFRlc3RzL2pzL2RvbS9KU09OLXN0cmluZ2lmeS1zdHJpbmctb2JqZWN0LXdpdGgtdG9q c29uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uMTQ4MjJlYzU0ZGNjZjUyNDc2NTBkNjkwNzhiZDM3ZDczNDU2 MDE3YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2pzL2RvbS9KU09OLXN0cmluZ2lm eS1zdHJpbmctb2JqZWN0LXdpdGgtdG9qc29uLmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPCFET0NU WVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4K KzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgordmFyIG5hdGl2ZUpTT04gPSB0aGlzLkpTT047Cit0 aGlzLkpTT04gPSBudWxsOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pz b24yLWVzNS1jb21wYXQuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9K U09OLXN0cmluZ2lmeS1zdHJpbmctb2JqZWN0LXdpdGgtdG9qc29uLmpzIj48L3NjcmlwdD4KKzxz Y3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwv Ym9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9qcy9yZXNvdXJjZXMvSlNPTi1zdHJpbmdpZnktc3RyaW5nLW9iamVjdC13aXRo LXRvanNvbi5qcyBiL0xheW91dFRlc3RzL2pzL3Jlc291cmNlcy9KU09OLXN0cmluZ2lmeS1zdHJp bmctb2JqZWN0LXdpdGgtdG9qc29uLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ1ZDc1YTNhMWZhMmQxNmU4Y2I4 ZWIzZDRiZWU1N2ZhMzhhMmYwMzgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9qcy9y ZXNvdXJjZXMvSlNPTi1zdHJpbmdpZnktc3RyaW5nLW9iamVjdC13aXRoLXRvanNvbi5qcwpAQCAt MCwwICsxLDE1IEBACit2YXIgc3RyaW5nT2JqZWN0ID0gbmV3IFN0cmluZygiRm9vIik7CitzaG91 bGRCZUVxdWFsVG9TdHJpbmcoJ25hdGl2ZUpTT04uc3RyaW5naWZ5KHN0cmluZ09iamVjdCknLCAn IkZvbyInKTsKK3Nob3VsZEJlKCduYXRpdmVKU09OLnN0cmluZ2lmeShzdHJpbmdPYmplY3QpJywg J0pTT04uc3RyaW5naWZ5KHN0cmluZ09iamVjdCknKTsKKworc3RyaW5nT2JqZWN0LnRvSlNPTiA9 IGZ1bmN0aW9uKCkgeyByZXR1cm4gIldlaXJkIENhc2UgMSI7IH0KK3Nob3VsZEJlRXF1YWxUb1N0 cmluZygnbmF0aXZlSlNPTi5zdHJpbmdpZnkoc3RyaW5nT2JqZWN0KScsICciV2VpcmQgQ2FzZSAx IicpOworc2hvdWxkQmUoJ25hdGl2ZUpTT04uc3RyaW5naWZ5KHN0cmluZ09iamVjdCknLCAnSlNP Ti5zdHJpbmdpZnkoc3RyaW5nT2JqZWN0KScpOworCit2YXIgc3RyaW5nT2JqZWN0ID0gbmV3IFN0 cmluZygiQmFyIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ25hdGl2ZUpTT04uc3RyaW5naWZ5 KHN0cmluZ09iamVjdCknLCAnIkJhciInKTsKK3Nob3VsZEJlKCduYXRpdmVKU09OLnN0cmluZ2lm eShzdHJpbmdPYmplY3QpJywgJ0pTT04uc3RyaW5naWZ5KHN0cmluZ09iamVjdCknKTsKKworU3Ry aW5nLnByb3RvdHlwZS50b0pTT04gPSBmdW5jdGlvbigpIHsgcmV0dXJuICJXZWlyZCBDYXNlIDIi OyB9CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ25hdGl2ZUpTT04uc3RyaW5naWZ5KHN0cmluZ09i amVjdCknLCAnIldlaXJkIENhc2UgMiInKTsKK3Nob3VsZEJlKCduYXRpdmVKU09OLnN0cmluZ2lm eShzdHJpbmdPYmplY3QpJywgJ0pTT04uc3RyaW5naWZ5KHN0cmluZ09iamVjdCknKTsKXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==