147371 2015-07-28 13:38:40 -0700 DFG::PutStackSinkingPhase should be more aggressive about its "no GetStack until put" rule 2015-07-28 13:51:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1112840 0 fpizlo 2015-07-28 13:38:40 -0700 PutStackSinkingPhase assumes that you won't issue a GetStack until you've already done a PutStack or some other store to that stack location (for example via ForwardVarargs or because it's an argument). One of the reasons why it currently doesn't enforce this because it's sloppy about using ConflictingFlush, the current signal that the stack slot is dirty. We should fix both issues. 1112845 1 257676 fpizlo 2015-07-28 13:40:33 -0700 Created attachment 257676 the patch 1112849 2 257676 mark.lam 2015-07-28 13:48:19 -0700 Comment on attachment 257676 the patch r=me 1112852 3 fpizlo 2015-07-28 13:51:59 -0700 Landed in http://trac.webkit.org/changeset/187510 257676 2015-07-28 13:40:33 -0700 2015-07-28 13:48:19 -0700 the patch blah.patch text/plain 4098 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg3NTA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE1LTA3LTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpQdXRTdGFja1NpbmtpbmdQaGFzZSBzaG91bGQgYmUgbW9yZSBhZ2dyZXNzaXZlIGFib3V0 IGl0cyAibm8gR2V0U3RhY2sgdW50aWwgcHV0IiBydWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDczNzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUd28gZml4ZXM6CisKKyAgICAgICAgLSBNYWtlIENv bmZsaWN0aW5nRmx1c2ggcmVhbGx5IG1lYW4gdGhhdCB5b3UgY2FuJ3QgbG9hZCBmcm9tIHRoZSBz dGFjayBzbG90LiBUaGlzIG1lYW5zIG5vdAorICAgICAgICAgIHVzaW5nIENvbmZsaWN0aW5nRmx1 c2ggZm9yIGFyZ3VtZW50cy4KKworICAgICAgICAtIEFzc2VydCB0aGF0IGEgR2V0U3RhY2sgbmV2 ZXIgc2VlcyBDb25mbGljdGluZ0ZsdXNoLgorCisgICAgICAgICogZGZnL0RGR1B1dFN0YWNrU2lu a2luZ1BoYXNlLmNwcDoKKwogMjAxNS0wNy0yOCAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xl bWVudEBhcHBsZS5jb20+CiAKICAgICAgICAgTWlzbGVhZGluZyBlcnJvciBtZXNzYWdlOiAiQXQg bGVhc3Qgb25lIGRpZ2l0IG11c3Qgb2NjdXIgYWZ0ZXIgYSBkZWNpbWFsIHBvaW50IgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQdXRTdGFja1NpbmtpbmdQaGFzZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQdXRTdGFja1NpbmtpbmdQ aGFzZS5jcHAJKHJldmlzaW9uIDE4NzQ5NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHUHV0U3RhY2tTaW5raW5nUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYsOCArMjE2 LDkgQEAgcHVibGljOgogICAgICAgICAgICAgZGVmZXJyZWRBdFRhaWxbYmxvY2tdID0KICAgICAg ICAgICAgICAgICBPcGVyYW5kczxGbHVzaEZvcm1hdD4oT3BlcmFuZHNMaWtlLCBibG9jay0+dmFy aWFibGVzQXRIZWFkKTsKICAgICAgICAgfQotICAgICAgICAKLSAgICAgICAgZGVmZXJyZWRBdEhl YWQuYXRJbmRleCgwKS5maWxsKENvbmZsaWN0aW5nRmx1c2gpOworCisgICAgICAgIGZvciAodW5z aWduZWQgbG9jYWwgPSBkZWZlcnJlZEF0SGVhZC5hdEluZGV4KDApLm51bWJlck9mTG9jYWxzKCk7 IGxvY2FsLS07KQorICAgICAgICAgICAgZGVmZXJyZWRBdEhlYWQuYXRJbmRleCgwKS5sb2NhbChs b2NhbCkgPSBDb25mbGljdGluZ0ZsdXNoOwogICAgICAgICAKICAgICAgICAgZG8gewogICAgICAg ICAgICAgY2hhbmdlZCA9IGZhbHNlOwpAQCAtMjMwLDEyICsyMzEsMTggQEAgcHVibGljOgogICAg ICAgICAgICAgICAgICAgICAgICAgZGF0YUxvZygiRGVmZXJyZWQgYXQgIiwgbm9kZSwgIjoiLCBk ZWZlcnJlZCwgIlxuIik7CiAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAg ICBpZiAobm9kZS0+b3AoKSA9PSBHZXRTdGFjaykgeworICAgICAgICAgICAgICAgICAgICAgICAg REZHX0FTU0VSVCgKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLCBub2RlLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlZmVycmVkLm9wZXJhbmQobm9kZS0+c3RhY2tB Y2Nlc3NEYXRhKCktPmxvY2FsKSAhPSBDb25mbGljdGluZ0ZsdXNoKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgLy8gQSBHZXRTdGFjayBkb2Vzbid0 IGFmZmVjdCBhbnl0aGluZywgc2luY2Ugd2Uga25vdyB3aGljaCBsb2NhbCB3ZSBhcmUgcmVhZGlu ZwogICAgICAgICAgICAgICAgICAgICAgICAgLy8gZnJvbS4KICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgICAgICBhdXRvIGVzY2FwZUhhbmRsZXIgPSBbJl0gKFZpcnR1YWxS ZWdpc3RlciBvcGVyYW5kKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAodmVyYm9zZSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhTG9nKCJGb3IgIiwgbm9kZSwgIiBlc2Nh cGluZyAiLCBvcGVyYW5kLCAiXG4iKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChvcGVy YW5kLmlzSGVhZGVyKCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICAgICAgICAgICAgICAgICAgLy8gV2Ugd2lsbCBtYXRlcmlhbGl6ZSBqdXN0IGJlZm9yZSBh bnkgcmVhZHMuCkBAIC00MDYsNiArNDEzLDEwIEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAg ICAgU3RhY2tBY2Nlc3NEYXRhKiBkYXRhID0gbm9kZS0+c3RhY2tBY2Nlc3NEYXRhKCk7CiAgICAg ICAgICAgICAgICAgICAgIEZsdXNoRm9ybWF0IGZvcm1hdCA9IGRlZmVycmVkLm9wZXJhbmQoZGF0 YS0+bG9jYWwpOwogICAgICAgICAgICAgICAgICAgICBpZiAoIWlzQ29uY3JldGUoZm9ybWF0KSkg eworICAgICAgICAgICAgICAgICAgICAgICAgREZHX0FTU0VSVCgKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtX2dyYXBoLCBub2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRl ZmVycmVkLm9wZXJhbmQoZGF0YS0+bG9jYWwpICE9IENvbmZsaWN0aW5nRmx1c2gpOworICAgICAg ICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAvLyBUaGlzIG1lYW5z IHRoZXJlIGlzIG5vIGRlZmVycmFsLiBObyBkZWZlcnJhbCBtZWFucyB0aGF0IHRoZSBtb3N0CiAg ICAgICAgICAgICAgICAgICAgICAgICAvLyBhdXRob3JpdGF0aXZlIHZhbHVlIGZvciB0aGlzIHN0 YWNrIHNsb3QgaXMgd2hhdCBpcyBzdG9yZWQgaW4gdGhlIHN0YWNrLiBTbywKICAgICAgICAgICAg ICAgICAgICAgICAgIC8vIGtlZXAgdGhlIEdldFN0YWNrLgpAQCAtNDI3LDEyICs0MzgsMTggQEAg cHVibGljOgogICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgIGRlZmF1bHQ6IHsKICAg ICAgICAgICAgICAgICAgICAgYXV0byBlc2NhcGVIYW5kbGVyID0gWyZdIChWaXJ0dWFsUmVnaXN0 ZXIgb3BlcmFuZCkgeworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZlcmJvc2UpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZGF0YUxvZygiRm9yICIsIG5vZGUsICIgZXNjYXBpbmcg Iiwgb3BlcmFuZCwgIlxuIik7CisKICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChvcGVyYW5k LmlzSGVhZGVyKCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgIEZsdXNoRm9ybWF0IGZvcm1h dCA9IGRlZmVycmVkLm9wZXJhbmQob3BlcmFuZCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBp ZiAoIWlzQ29uY3JldGUoZm9ybWF0KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmICghaXND b25jcmV0ZShmb3JtYXQpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gSXQncyBk ZWFkIG5vdywgcmF0aGVyIHRoYW4gY29uZmxpY3RpbmcuCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZGVmZXJyZWQub3BlcmFuZChvcGVyYW5kKSA9IERlYWRGbHVzaDsKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgLy8gR290dGEgaW5zZXJ0 IGEgUHV0U3RhY2suCiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAodmVyYm9zZSkK