147365 2015-07-28 11:02:46 -0700 Handle null CFArrayRef returning from _CFHTTPParsedCookiesWithResponseHeaderFields 2022-10-05 15:10:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified ASSIGNED P2 Normal --- 1 beidson beidson ahmad.saleem792 ap bfulgham oldest_to_newest 1112759 0 beidson 2015-07-28 11:02:46 -0700 Handle null CFArrayRef returning from _CFHTTPParsedCookiesWithResponseHeaderFields Per CF API naming conventions, this SPI is allowed to return null, and it sometimes does. Properly handle he null check so our "createCookies" function never returns null. <rdar://problem/21995928> 1112763 1 257661 beidson 2015-07-28 11:06:57 -0700 Created attachment 257661 Patch v1 1112766 2 beidson 2015-07-28 11:13:52 -0700 https://trac.webkit.org/changeset/187490 1112775 3 257661 darin 2015-07-28 11:24:23 -0700 Comment on attachment 257661 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=257661&action=review > Source/WebCore/platform/network/cf/CookieJarCFNet.cpp:117 > static CFArrayRef createCookies(CFDictionaryRef headerFields, CFURLRef url) Peculiar that this one function returns CFArrayRef rather than RetainPtr<CFArrayRef>, when all the rest in the file use RetainPtr. I think we should come back here and change it. > Source/WebCore/platform/network/cf/CookieJarCFNet.cpp:125 > + parsedCookies = CFArrayCreate(kCFAllocatorDefault, 0, 0, &kCFTypeArrayCallBacks); Too bad there is no CF equivalent to @[], annoying to create a new array every time, although not a real problem. 1903557 4 ahmad.saleem792 2022-10-05 15:09:49 -0700 CookieJarCFNet.cpp is no more in same shape or form but we still have following: https://github.com/WebKit/WebKit/blob/a2db53cd97dc8136ac5c2a22d4cd2b53d0d717d6/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp#L228 and this ASSERT already added: https://github.com/WebKit/WebKit/blob/a2db53cd97dc8136ac5c2a22d4cd2b53d0d717d6/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp#L181 Do we need anything from this patch or we can close this? Thanks! 257661 2015-07-28 11:06:57 -0700 2015-07-28 11:10:40 -0700 Patch v1 patch text/plain 2398 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYTI5Nzk3Li44YTljZjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTUtMDctMjggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIEhhbmRsZSBudWxsIENGQXJyYXlSZWYgcmV0dXJuaW5nIGZyb20gX0NGSFRUUFBhcnNlZENv b2tpZXNXaXRoUmVzcG9uc2VIZWFkZXJGaWVsZHMuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y MTk5NTkyOD4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcz NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvY2YvQ29va2llSmFyQ0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 ZmlsdGVyQ29va2llcyk6IEFTU0VSVCB0aGUgaW5wdXQgaXMgbm90IG51bGwuCisgICAgICAgIChX ZWJDb3JlOjpjcmVhdGVDb29raWVzKTogQWx3YXlzIHJldHVybiBhIENGQXJyYXlSZWYsIGV2ZW4g aWYgaXQncyBlbXB0eS4KKwogMjAxNS0wNy0yNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBFbmhhbmNlIEFuaW1hdGlvbiBsb2dnaW5nIHNsaWdodGx5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0Nvb2tpZUph ckNGTmV0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQ29va2llSmFy Q0ZOZXQuY3BwCmluZGV4IGU5ZGZhZWMuLjQwNGE0NGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQ29va2llSmFyQ0ZOZXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQ29va2llSmFyQ0ZOZXQuY3BwCkBAIC04MCw2ICs4 MCw3IEBAIHN0YXRpYyBpbmxpbmUgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBjb29raWVWYWx1ZShD RkhUVFBDb29raWVSZWYgY29va2llKQogCiBzdGF0aWMgUmV0YWluUHRyPENGQXJyYXlSZWY+IGZp bHRlckNvb2tpZXMoQ0ZBcnJheVJlZiB1bmZpbHRlcmVkQ29va2llcykKIHsKKyAgICBBU1NFUlQo dW5maWx0ZXJlZENvb2tpZXMpOwogICAgIENGSW5kZXggY291bnQgPSBDRkFycmF5R2V0Q291bnQo dW5maWx0ZXJlZENvb2tpZXMpOwogICAgIFJldGFpblB0cjxDRk11dGFibGVBcnJheVJlZj4gZmls dGVyZWRDb29raWVzID0gYWRvcHRDRihDRkFycmF5Q3JlYXRlTXV0YWJsZSgwLCBjb3VudCwgJmtD RlR5cGVBcnJheUNhbGxCYWNrcykpOwogICAgIGZvciAoQ0ZJbmRleCBpID0gMDsgaSA8IGNvdW50 OyArK2kpIHsKQEAgLTExNiwxMCArMTE3LDE0IEBAIHN0YXRpYyBSZXRhaW5QdHI8Q0ZBcnJheVJl Zj4gY29weUNvb2tpZXNGb3JVUkxXaXRoRmlyc3RQYXJ0eVVSTChjb25zdCBOZXR3b3JrU3RvCiBz dGF0aWMgQ0ZBcnJheVJlZiBjcmVhdGVDb29raWVzKENGRGljdGlvbmFyeVJlZiBoZWFkZXJGaWVs ZHMsIENGVVJMUmVmIHVybCkKIHsKICNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSA5MDAwMCkKLSAgICByZXR1cm4gX0NGSFRUUFBhcnNlZENv b2tpZXNXaXRoUmVzcG9uc2VIZWFkZXJGaWVsZHMoa0NGQWxsb2NhdG9yRGVmYXVsdCwgaGVhZGVy RmllbGRzLCB1cmwpOworICAgIENGQXJyYXlSZWYgcGFyc2VkQ29va2llcyA9IF9DRkhUVFBQYXJz ZWRDb29raWVzV2l0aFJlc3BvbnNlSGVhZGVyRmllbGRzKGtDRkFsbG9jYXRvckRlZmF1bHQsIGhl YWRlckZpZWxkcywgdXJsKTsKICNlbHNlCi0gICAgcmV0dXJuIENGSFRUUENvb2tpZUNyZWF0ZVdp dGhSZXNwb25zZUhlYWRlckZpZWxkcyhrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBoZWFkZXJGaWVsZHMs IHVybCk7CisgICAgQ0ZBcnJheVJlZiBwYXJzZWRDb29raWVzID0gQ0ZIVFRQQ29va2llQ3JlYXRl V2l0aFJlc3BvbnNlSGVhZGVyRmllbGRzKGtDRkFsbG9jYXRvckRlZmF1bHQsIGhlYWRlckZpZWxk cywgdXJsKTsKICNlbmRpZgorICAgIGlmICghcGFyc2VkQ29va2llcykKKyAgICAgICAgcGFyc2Vk Q29va2llcyA9IENGQXJyYXlDcmVhdGUoa0NGQWxsb2NhdG9yRGVmYXVsdCwgMCwgMCwgJmtDRlR5 cGVBcnJheUNhbGxCYWNrcyk7CisKKyAgICByZXR1cm4gcGFyc2VkQ29va2llczsKIH0KIAogdm9p ZCBzZXRDb29raWVzRnJvbURPTShjb25zdCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mIHNlc3Npb24s IGNvbnN0IFVSTCYgZmlyc3RQYXJ0eSwgY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgdmFs dWUpCg==