147359 2015-07-28 09:51:38 -0700 webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com 2015-07-28 12:39:44 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue dbates glenn rniwa oldest_to_newest 1112729 0 ap 2015-07-28 09:51:38 -0700 appspot is currently down, and so are webkitbot and WKR. It doesn't appear that their dependency on appspot is needed though - we do get log entries in webkit-queues.appspot.com datastore when the bots start, but these seem pretty useless. 1112730 1 257650 ap 2015-07-28 09:55:17 -0700 Created attachment 257650 proposed fix def begin_work_queue(self): _log.info("CAUTION: %s will discard all local changes in \"%s\"" % (self.name, self._tool.scm().checkout_root)) # This is obviously not enabled on bots. Not sure how much we care about the case when someone runs WKR or webkitbot locally. if self._options.confirm: response = self._tool.user.prompt("Are you sure? Type \"yes\" to continue: ") if (response != "yes"): _log.error("User declined.") sys.exit(1) _log.info("Running WebKit %s." % self.name) # This raises an exception after a long timeout, and prevents the queue from running. self._tool.status_server.update_status(self.name, "Starting Queue") 1112811 2 257650 commit-queue 2015-07-28 12:39:40 -0700 Comment on attachment 257650 proposed fix Clearing flags on attachment: 257650 Committed r187501: <http://trac.webkit.org/changeset/187501> 1112812 3 commit-queue 2015-07-28 12:39:44 -0700 All reviewed patches have been landed. Closing bug. 257650 2015-07-28 09:55:17 -0700 2015-07-28 12:39:40 -0700 proposed fix webkitbot.txt text/plain 2026 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NzQ4NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTA3LTI4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIHdlYmtpdGJvdCBhbmQgV0tSIHVubmVjZXNzYXJpbHkgcmVseSBvbiB3ZWJr aXQtcXVldWVzLmFwcHNwb3QuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDczNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRi b3QucHk6CisgICAgICAgIChOZXdDb21taXRCb3QuYmVnaW5fd29ya19xdWV1ZSk6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3QucHk6CisgICAgICAg IChTaGVyaWZmQm90LmJlZ2luX3dvcmtfcXVldWUpOgorCiAyMDE1LTA3LTI3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXNlIE5pbmphIG9u IFdpbmRvd3MuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3 Y29tbWl0Ym90LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9uZXdjb21taXRib3QucHkJKHJldmlzaW9uIDE4NzQ4NSkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkJKHdvcmtpbmcgY29weSkK QEAgLTcwLDcgKzcwLDYgQEAgY2xhc3MgTmV3Q29tbWl0Qm90KEFic3RyYWN0UXVldWUsIFN0ZXBT ZQogICAgICMgQWJzdHJhY3RRdWV1ZSBtZXRob2RzCiAKICAgICBkZWYgYmVnaW5fd29ya19xdWV1 ZShzZWxmKToKLSAgICAgICAgQWJzdHJhY3RRdWV1ZS5iZWdpbl93b3JrX3F1ZXVlKHNlbGYpCiAg ICAgICAgIHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9uID0gaW50KHNlbGYuX3Rvb2wuc2NtKCkuaGVh ZF9zdm5fcmV2aXNpb24oKSkKICAgICAgICAgc2VsZi5faXJjX2JvdCA9IElSQ0JvdChzZWxmLm5h bWUsIHNlbGYuX3Rvb2wsIEFnZW50KHNlbGYuX3Rvb2wsIHNlbGYpLCBzZWxmLl9jb21tYW5kcykK ICAgICAgICAgc2VsZi5fdG9vbC5lbnN1cmVfaXJjX2Nvbm5lY3RlZChzZWxmLl9pcmNfYm90Lmly Y19kZWxlZ2F0ZSgpKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L3NoZXJpZmZib3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3NoZXJpZmZib3QucHkJKHJldmlzaW9uIDE4NzQ4NSkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zaGVyaWZmYm90LnB5CSh3b3JraW5nIGNvcHkpCkBA IC00Nyw3ICs0Nyw2IEBAIGNsYXNzIFNoZXJpZmZCb3QoQWJzdHJhY3RRdWV1ZSwgU3RlcFNlcXUK ICAgICAjIEFic3RyYWN0UXVldWUgbWV0aG9kcwogCiAgICAgZGVmIGJlZ2luX3dvcmtfcXVldWUo c2VsZik6Ci0gICAgICAgIEFic3RyYWN0UXVldWUuYmVnaW5fd29ya19xdWV1ZShzZWxmKQogICAg ICAgICBzZWxmLl9zaGVyaWZmID0gU2hlcmlmZihzZWxmLl90b29sLCBzZWxmKQogICAgICAgICBz ZWxmLl9pcmNfYm90ID0gSVJDQm90KHNlbGYubmFtZSwgc2VsZi5fdG9vbCwgc2VsZi5fc2hlcmlm ZiwgaXJjX2NvbW1hbmRzKQogICAgICAgICBzZWxmLl90b29sLmVuc3VyZV9pcmNfY29ubmVjdGVk KHNlbGYuX2lyY19ib3QuaXJjX2RlbGVnYXRlKCkpCg==