147351 2015-07-27 20:04:00 -0700 [iOS] REGRESSION (r187376): Form editing buttons are missing from the Shortcut Bar 2015-07-27 21:36:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz commit-queue oldest_to_newest 1112656 0 mitz 2015-07-27 20:04:00 -0700 <rdar://problem/22023691> After <http://trac.webkit.org/r187376>, when focusing a form field, the previous/next button and the optional AutoFill button are missing from the Shortcut Bar. Patch forthcoming. 1112659 1 257630 mitz 2015-07-27 20:31:31 -0700 Created attachment 257630 Ensure that _formAccessoryView gets initialized when needed even if -inputAccessoryView is always nil 1112668 2 257630 commit-queue 2015-07-27 21:36:55 -0700 Comment on attachment 257630 Ensure that _formAccessoryView gets initialized when needed even if -inputAccessoryView is always nil Clearing flags on attachment: 257630 Committed r187481: <http://trac.webkit.org/changeset/187481> 1112669 3 commit-queue 2015-07-27 21:36:58 -0700 All reviewed patches have been landed. Closing bug. 257630 2015-07-27 20:31:31 -0700 2015-07-27 21:36:55 -0700 Ensure that _formAccessoryView gets initialized when needed even if -inputAccessoryView is always nil bug-147351-20150727203010.patch text/plain 3792 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NzQ3NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA3LTI3ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUkVHUkVTU0lPTiAocjE4 NzM3Nik6IEZvcm0gZWRpdGluZyBidXR0b25zIGFyZSBtaXNzaW5nIGZyb20gdGhlIFNob3J0Y3V0 IEJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3 MzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug d2VyZSByZWx5aW5nIG9uIC1bV0tDb250ZW50VmlldyBpbnB1dEFjY2Vzc29yeVZpZXddIGdldHRp bmcgY2FsbGVkIHRvIGluaXRpYWxpemUgdGhlIGZvcm0KKyAgICAgICAgYWNjZXNzb3J5IHZpZXcs IGV2ZW4gd2hlbiB0aGF0IG1ldGhvZCB3b3VsZCBhbHdheXMgcmV0dXJuIG5pbCwgYXMgaXQgZG9l cyBvbiBpUGFkLiBBZnRlcgorICAgICAgICByMTg3Mzc2LCB0aGF0IG1ldGhvZCBjaGFuZ2VkIHRv IGluaXRpYWxpemluZyB0aGUgdmlldyBvbmx5IHdoZW4gcmV0dXJuaW5nIGl0LCB3aGljaCBjYXVz ZWQKKyAgICAgICAgdGhpcyBidWcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZGlzcGxheUZv cm1Ob2RlSW5wdXRWaWV3XSk6IENhbGwgdGhlIG5ldyAtX2Vuc3VyZUZvcm1BY2Nlc3NvcnlWaWV3 IGZyb20KKyAgICAgICAgaGVyZSwgd2hlbiB3ZSBhcmUgZ29pbmcgdG8gbmVlZCB0aGUgdmlldy4K KyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZW5zdXJlRm9ybUFjY2Vzc29yeVZpZXddKTogTW92 ZWQgaW5pdGlhbGl6YXRpb24gY29kZSBmcm9tCisgICAgICAgIC1pbnB1dEFjY2Vzc29yeVZpZXcg aGVyZSwgYW5kIHJlbW92ZWQgb3V0ZGF0ZWQgK2luc3RhbmNlc1Jlc3BvbmRUb1NlbGVjdG9yOiBj aGVjay4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBpbnB1dEFjY2Vzc29yeVZpZXddKTogTm93 IGNhbGxzIHRocm91Z2ggLWZvcm1BY2Nlc3NvcnlWaWV3LgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IGZvcm1BY2Nlc3NvcnlWaWV3XSk6IEFkZGVkIGNhbGwgdG8gLV9lbnN1cmVGb3JtQWNjZXNz b3J5VmlldyBoZXJlLgorCiAyMDE1LTA3LTI3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25A YXBwbGUuY29tPgogCiAgICAgICAgIEZpcnN0IGluLXdpbmRvdyB2aWV3U3RhdGVDaGFuZ2Ugc3lu Y2hyb25vdXNseSBibG9ja3MgZGVzcGl0ZSBub3QgcHJldmlvdXNseSBiZWluZyBpbi13aW5kb3cK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAxODc0MzQpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5 KQpAQCAtMjE1LDEwICsyMTUsNiBAQCArIChCT09MKV9hZGRDb21wbGV0aW9uOih2b2lkKF4pKEJP T0wpKWNvCiBAZW5kCiAKICNpZiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA5 MDAwMAotQGludGVyZmFjZSBVSVdlYkZvcm1BY2Nlc3NvcnkgKFN0YWdpbmdUb1JlbW92ZSkKLS0g KGlkKWluaXRXaXRoSW5wdXRBc3Npc3RhbnRJdGVtOihVSVRleHRJbnB1dEFzc2lzdGFudEl0ZW0g KilpbnB1dEFzc2lzdGFudEl0ZW07Ci1AZW5kCi0KIEBwcm90b2NvbCBVSVNlbGVjdGlvbkludGVy YWN0aW9uQXNzaXN0YW50OwogI2VuZGlmCiAKQEAgLTgxOCw2ICs4MTQsNyBAQCAtICh2b2lkKV9k aXNwbGF5Rm9ybU5vZGVJbnB1dFZpZXcKICAgICAgICAgICAgICAgYWxsb3dTY2FsaW5nOihfYXNz aXN0ZWROb2RlSW5mb3JtYXRpb24uYWxsb3dzVXNlclNjYWxpbmcgJiYgIVVJQ3VycmVudFVzZXJJ bnRlcmZhY2VJZGlvbUlzUGFkKCkpCiAgICAgICAgICAgICAgICBmb3JjZVNjcm9sbDpbc2VsZiBy ZXF1aXJlc0FjY2Vzc29yeVZpZXddXTsKICAgICBfZGlkQWNjZXNzb3J5VGFiSW5pdGlhdGVGb2N1 cyA9IE5POworICAgIFtzZWxmIF9lbnN1cmVGb3JtQWNjZXNzb3J5Vmlld107CiAgICAgW3NlbGYg X3VwZGF0ZUFjY2Vzc29yeV07CiB9CiAKQEAgLTEyNTcsMjIgKzEyNTQsMjUgQEAgLSAoQk9PTCly ZXF1aXJlc0FjY2Vzc29yeVZpZXcKICAgICB9CiB9CiAKLS0gKFVJVmlldyAqKWlucHV0QWNjZXNz b3J5VmlldworLSAodm9pZClfZW5zdXJlRm9ybUFjY2Vzc29yeVZpZXcKIHsKLSAgICBpZiAoIVtz ZWxmIHJlcXVpcmVzQWNjZXNzb3J5Vmlld10pCi0gICAgICAgIHJldHVybiBuaWw7CisgICAgaWYg KF9mb3JtQWNjZXNzb3J5VmlldykKKyAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFfZm9ybUFj Y2Vzc29yeVZpZXcpIHsKICNpZiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA5 MDAwMAotICAgICAgICBpZiAoW1VJV2ViRm9ybUFjY2Vzc29yeSBpbnN0YW5jZXNSZXNwb25kVG9T ZWxlY3RvcjpAc2VsZWN0b3IoaW5pdFdpdGhJbnB1dEFzc2lzdGFudEl0ZW06KV0pCi0gICAgICAg ICAgICBfZm9ybUFjY2Vzc29yeVZpZXcgPSBhZG9wdE5TKFtbVUlXZWJGb3JtQWNjZXNzb3J5IGFs bG9jXSBpbml0V2l0aElucHV0QXNzaXN0YW50SXRlbTpbc2VsZiBpbnB1dEFzc2lzdGFudEl0ZW1d XSk7Ci0gICAgICAgIGVsc2UKKyAgICBfZm9ybUFjY2Vzc29yeVZpZXcgPSBhZG9wdE5TKFtbVUlX ZWJGb3JtQWNjZXNzb3J5IGFsbG9jXSBpbml0V2l0aElucHV0QXNzaXN0YW50SXRlbTpzZWxmLmlu cHV0QXNzaXN0YW50SXRlbV0pOworI2Vsc2UKKyAgICBfZm9ybUFjY2Vzc29yeVZpZXcgPSBhZG9w dE5TKFtbVUlXZWJGb3JtQWNjZXNzb3J5IGFsbG9jXSBpbml0XSk7CiAjZW5kaWYKLSAgICAgICAg ICAgIF9mb3JtQWNjZXNzb3J5VmlldyA9IGFkb3B0TlMoW1tVSVdlYkZvcm1BY2Nlc3NvcnkgYWxs b2NdIGluaXRdKTsKLSAgICAgICAgW19mb3JtQWNjZXNzb3J5VmlldyBzZXREZWxlZ2F0ZTpzZWxm XTsKLSAgICB9CisgICAgW19mb3JtQWNjZXNzb3J5VmlldyBzZXREZWxlZ2F0ZTpzZWxmXTsKK30K IAotICAgIHJldHVybiBfZm9ybUFjY2Vzc29yeVZpZXcuZ2V0KCk7CistIChVSVZpZXcgKilpbnB1 dEFjY2Vzc29yeVZpZXcKK3sKKyAgICBpZiAoIVtzZWxmIHJlcXVpcmVzQWNjZXNzb3J5Vmlld10p CisgICAgICAgIHJldHVybiBuaWw7CisKKyAgICByZXR1cm4gc2VsZi5mb3JtQWNjZXNzb3J5Vmll dzsKIH0KIAogLSAoTlNBcnJheSAqKXN1cHBvcnRlZFBhc3RlYm9hcmRUeXBlc0ZvckN1cnJlbnRT ZWxlY3Rpb24KQEAgLTI5NjcsNiArMjk2Nyw3IEBAIC0gKFZlY3RvcjxPcHRpb25JdGVtPiYpYXNz aXN0ZWROb2RlU2VsZWMKIAogLSAoVUlXZWJGb3JtQWNjZXNzb3J5ICopZm9ybUFjY2Vzc29yeVZp ZXcKIHsKKyAgICBbc2VsZiBfZW5zdXJlRm9ybUFjY2Vzc29yeVZpZXddOwogICAgIHJldHVybiBf Zm9ybUFjY2Vzc29yeVZpZXcuZ2V0KCk7CiB9CiAK