147341 2015-07-27 16:43:20 -0700 ShrinkToFit() all the DFA's vectors when we no longer need to add new nodes to it 2015-07-27 17:13:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1112586 0 benjamin 2015-07-27 16:43:20 -0700 ShrinkToFit() all the DFA's vectors when we no longer need to add new nodes to it 1112587 1 257613 benjamin 2015-07-27 16:44:35 -0700 Created attachment 257613 Patch 1112592 2 257613 ggaren 2015-07-27 16:47:51 -0700 Comment on attachment 257613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257613&action=review r=me > Source/WebCore/contentextensions/DFA.h:44 > + void finalize(); I would call this "shrinkToFit". "Finalize" usually means "I'm not going to use this anymore". 1112613 3 benjamin 2015-07-27 17:13:47 -0700 Committed r187467: <http://trac.webkit.org/changeset/187467> 257613 2015-07-27 16:44:35 -0700 2015-07-27 16:47:51 -0700 Patch bug-147341-20150727164314.patch text/plain 2741 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEyOTc5NzA4YzBmOGNh MGJiMGQ0NjRhZGIzYjFlZDllNzYxZjExZi4uMDY3YmIxNDYwNDM3N2RmMzBmZjYzOTA2OTYzNDFi OTFlZTZjMjllNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA3LTI3ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFNocmlua1RvRml0 KCkgYWxsIHRoZSBERkEncyB2ZWN0b3JzIHdoZW4gd2Ugbm8gbG9uZ2VyIG5lZWQgdG8gYWRkIG5l dyBub2RlcyB0byBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ3MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgZmluYWxpemVyIHRvIHRoZSBERkEgdG8gcmVkdWNlIHRoZSB0b3RhbCBtZW1v cnkgbmVlZGVkCisgICAgICAgIHRvIHN0b3JlIGl0LgorCisgICAgICAgIE9uIHJlYWwgdGVzdCBs aXN0cywgdGhpcyBjdXRzIHRoZSBwZWFrIG1lbW9yeSB1c2FnZSBieSBhYm91dCAxIG1lZ2FieXRl LgorCisgICAgICAgIFRoZSBORkEgYWxyZWFkeSBoYWQgYSBmaW5hbGl6ZXIsIG5vIG5lZWQgdG8g bW9kaWZ5IHRoYXQgb25lLgorCisgICAgICAgICogY29udGVudGV4dGVuc2lvbnMvREZBLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRFeHRlbnNpb25zOjpERkE6OmZpbmFsaXplKToKKyAg ICAgICAgKiBjb250ZW50ZXh0ZW5zaW9ucy9ERkEuaDoKKyAgICAgICAgKiBjb250ZW50ZXh0ZW5z aW9ucy9ORkFUb0RGQS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50RXh0ZW5zaW9uczo6 TkZBVG9ERkE6OmNvbnZlcnQpOgorCiAyMDE1LTA3LTI3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuaGFuY2UgQW5pbWF0aW9uIGxvZ2dpbmcgc2xp Z2h0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0RGQS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9ERkEuY3BwCmluZGV4IGQwMWNk MmFiYmNiNDEzMzUxNTU1MWZhZGZiYTM0NDA4YWJmYjAwODAuLmI3MDliNDBjZDIxOThmYTIwNGM1 NGZiMzI4ZWJkNmNjNTUxYTQ4OTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRl eHRlbnNpb25zL0RGQS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMv REZBLmNwcApAQCAtNTEsNiArNTEsMTQgQEAgc2l6ZV90IERGQTo6bWVtb3J5VXNlZCgpIGNvbnN0 CiAgICAgICAgICsgbm9kZXMuY2FwYWNpdHkoKSAqIHNpemVvZihERkFOb2RlKTsKIH0KIAordm9p ZCBERkE6OmZpbmFsaXplKCkKK3sKKyAgICBub2Rlcy5zaHJpbmtUb0ZpdCgpOworICAgIGFjdGlv bnMuc2hyaW5rVG9GaXQoKTsKKyAgICB0cmFuc2l0aW9uUmFuZ2VzLnNocmlua1RvRml0KCk7Cisg ICAgdHJhbnNpdGlvbkRlc3RpbmF0aW9ucy5zaHJpbmtUb0ZpdCgpOworfQorCiB2b2lkIERGQTo6 bWluaW1pemUoKQogewogICAgIERGQU1pbmltaXplcjo6bWluaW1pemUoKnRoaXMpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvREZBLmggYi9Tb3VyY2UvV2Vi Q29yZS9jb250ZW50ZXh0ZW5zaW9ucy9ERkEuaAppbmRleCBhMjA5NjQxOWI5ZDQ0Y2ZjOTYwNTI3 ZDZmZjE0ZjVmYmQ2NjdlZDU4Li4xNGVkY2Q0NDI1OWVkMDJjMDFkNjU2ODU0NTRkYTNjYTBkNThk ZjE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9ERkEuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9ERkEuaApAQCAtNDEsNiArNDEs NyBAQCBuYW1lc3BhY2UgQ29udGVudEV4dGVuc2lvbnMgewogc3RydWN0IFdFQkNPUkVfRVhQT1JU IERGQSB7CiAgICAgc3RhdGljIERGQSBlbXB0eSgpOwogCisgICAgdm9pZCBmaW5hbGl6ZSgpOwog ICAgIHZvaWQgbWluaW1pemUoKTsKICAgICB1bnNpZ25lZCBncmFwaFNpemUoKSBjb25zdDsKICAg ICBzaXplX3QgbWVtb3J5VXNlZCgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y29udGVudGV4dGVuc2lvbnMvTkZBVG9ERkEuY3BwIGIvU291cmNlL1dlYkNvcmUvY29udGVudGV4 dGVuc2lvbnMvTkZBVG9ERkEuY3BwCmluZGV4IGVkMmYwZjlmZDdlMGVkM2Y0NDdiNjAwZGYwZmQ0 MGFiYzZhOTkwNjIuLjM4NjM5MWI0ZDcxZmVmOGI0NzNjODJjZWY4Y2UxMTQ2OTQ5NzNmZGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL05GQVRvREZBLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9ORkFUb0RGQS5jcHAKQEAgLTM4 Nyw2ICszODcsNyBAQCBERkEgTkZBVG9ERkE6OmNvbnZlcnQoTkZBJiBuZmEpCiAgICAgICAgIGRm YVNvdXJjZU5vZGUuc2V0VHJhbnNpdGlvbnModHJhbnNpdGlvbnNTdGFydCwgc3RhdGljX2Nhc3Q8 dWludDhfdD4odHJhbnNpdGlvbnNMZW5ndGgpKTsKICAgICB9IHdoaWxlICghdW5wcm9jZXNzZWRO b2Rlcy5pc0VtcHR5KCkpOwogCisgICAgZGZhLmZpbmFsaXplKCk7CiAgICAgcmV0dXJuIGRmYTsK IH0KIAo=