147322 2015-07-27 09:56:43 -0700 Media Session: give media elements unique IDs 2015-07-31 23:40:05 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson mrajca webkit-bug-importer oldest_to_newest 1112428 0 mrajca 2015-07-27 09:56:43 -0700 Web page/element ID pairs will be used to keep track of the "focused" Content media element in the UI process. To be able to identify media elements, we give them unique IDs. 1112429 1 webkit-bug-importer 2015-07-27 09:57:25 -0700 <rdar://problem/22011625> 1112432 2 257565 mrajca 2015-07-27 10:04:12 -0700 Created attachment 257565 Patch 1113930 3 257565 eric.carlson 2015-07-31 17:35:30 -0700 Comment on attachment 257565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257565&action=review As we discussed offline, please file a bug about consolidating this with the MediaPlaybackTargetClient map. > Source/WebCore/html/HTMLMediaElement.cpp:435 > + static uint64_t elementID = 0; > + m_elementID = ++elementID; Nit: we usually put something like this in a static function, eg. uint64_t nextPlaybackTargetClientContextId() in Document.cpp. 1113991 4 mrajca 2015-07-31 22:51:27 -0700 (In reply to comment #3) > Comment on attachment 257565 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257565&action=review > > As we discussed offline, please file a bug about consolidating this with the > MediaPlaybackTargetClient map. Filed: https://bugs.webkit.org/show_bug.cgi?id=147522 > > > Source/WebCore/html/HTMLMediaElement.cpp:435 > > + static uint64_t elementID = 0; > > + m_elementID = ++elementID; > > Nit: we usually put something like this in a static function, eg. uint64_t > nextPlaybackTargetClientContextId() in Document.cpp. Added. 1113995 5 mrajca 2015-07-31 23:40:05 -0700 Committed r187712: <http://trac.webkit.org/changeset/187712> 257565 2015-07-27 10:04:12 -0700 2015-07-31 17:35:30 -0700 Patch bug-147322-20150727100251.patch text/plain 3695 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIwMjY3MjI4OWM3NjFm NjM5MGNkYzYwYTI1MTNmMzlmZWQ1Nzk0OC4uNzk2ZWE5YjFlMzdjZDA2Y2FhZTU3NGY2NWY0NGU4 MThkYzYwMDQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA3LTI3ICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiBnaXZl IG1lZGlhIGVsZW1lbnRzIHVuaXF1ZSBJRHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NzMyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmVsZW1lbnRJRHNUb0VsZW1lbnRzKTogQ3JlYXRlIGEgZ2xvYmFsIG1hcCBvZiBl bGVtZW50IElEcyB0byBlbGVtZW50cy4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1l bnQ6OmVsZW1lbnRXaXRoSUQpOiBSZXRyaWV2ZSB0aGUgZWxlbWVudCB3aXRoIHRoZSBnaXZlbiBJ RC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OkhUTUxNZWRpYUVsZW1lbnQp OiBHaXZlIHRoZSBlbGVtZW50IGEgdW5pcXVlIElELgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1l ZGlhRWxlbWVudDo6cGxheUludGVybmFsKTogUmVtb3ZlZCB3aGl0ZXNwYWNlLgorICAgICAgICAo V2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cGF1c2VJbnRlcm5hbCk6IERpdHRvLgorICAgICAg ICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6ZWxlbWVudElEKToKKwogMjAxNS0wNy0xOSAgTWF0dCBSYWpjYSAgPG1yYWpjYUBh cHBsZS5jb20+CiAKICAgICAgICAgTWVkaWEgU2Vzc2lvbjogYWRkIHN1cHBvcnQgZm9yIGR1Y2tp bmcgbWVkaWEgZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CmluZGV4IDU0ZjA3NjA2Njk3OTc1MGE1ZGNmMWUyNGU2Yzg5NDA5MWIxZjY5NjkuLmEyNDUwYjg5 NDkyMWI0MDM5MTFjZjA2MTE3NDMzYTAxMjVlMGUwMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcApAQCAtMjg4LDYgKzI4OCwyMSBAQCBIYXNoU2V0PEhUTUxNZWRp YUVsZW1lbnQqPiYgSFRNTE1lZGlhRWxlbWVudDo6YWxsTWVkaWFFbGVtZW50cygpCiAgICAgcmV0 dXJuIGVsZW1lbnRzOwogfQogCisjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04pCit0eXBlZGVmIEhh c2hNYXA8dWludDY0X3QsIEhUTUxNZWRpYUVsZW1lbnQqPiBJRFRvRWxlbWVudE1hcDsKKworc3Rh dGljIElEVG9FbGVtZW50TWFwJiBlbGVtZW50SURzVG9FbGVtZW50cygpCit7CisgICAgc3RhdGlj IE5ldmVyRGVzdHJveWVkPElEVG9FbGVtZW50TWFwPiBtYXA7CisgICAgcmV0dXJuIG1hcDsKK30K KworSFRNTE1lZGlhRWxlbWVudCogSFRNTE1lZGlhRWxlbWVudDo6ZWxlbWVudFdpdGhJRCh1aW50 NjRfdCBpZCkKK3sKKyAgICByZXR1cm4gZWxlbWVudElEc1RvRWxlbWVudHMoKS5nZXQoaWQpOwor fQorI2VuZGlmCisKIEhUTUxNZWRpYUVsZW1lbnQ6OkhUTUxNZWRpYUVsZW1lbnQoY29uc3QgUXVh bGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQmIGRvY3VtZW50LCBib29sIGNyZWF0ZWRCeVBh cnNlcikKICAgICA6IEhUTUxFbGVtZW50KHRhZ05hbWUsIGRvY3VtZW50KQogICAgICwgQWN0aXZl RE9NT2JqZWN0KCZkb2N1bWVudCkKQEAgLTQxNiw2ICs0MzEsMTEgQEAgSFRNTE1lZGlhRWxlbWVu dDo6SFRNTE1lZGlhRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVu dCYgZG9jdW0KICNlbmRpZgogCiAjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04pCisgICAgc3RhdGlj IHVpbnQ2NF90IGVsZW1lbnRJRCA9IDA7CisgICAgbV9lbGVtZW50SUQgPSArK2VsZW1lbnRJRDsK KworICAgIGVsZW1lbnRJRHNUb0VsZW1lbnRzKCkuYWRkKG1fZWxlbWVudElELCB0aGlzKTsKKwog ICAgIHNldFNlc3Npb25JbnRlcm5hbChkb2N1bWVudC5kZWZhdWx0TWVkaWFTZXNzaW9uKCkpOwog I2VuZGlmCiAKQEAgLTI4NTEsNyArMjg3MSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cGxh eUludGVybmFsKCkKICAgICAgICAgTE9HKE1lZGlhLCAiICByZXR1cm5pbmcgYmVjYXVzZSBvZiBp bnRlcnJ1cHRpb24iKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICAKKwogICAgIC8vIDQu OC4xMC45LiBQbGF5aW5nIHRoZSBtZWRpYSByZXNvdXJjZQogICAgIGlmICghbV9wbGF5ZXIgfHwg bV9uZXR3b3JrU3RhdGUgPT0gTkVUV09SS19FTVBUWSkKICAgICAgICAgc2NoZWR1bGVEZWxheWVk QWN0aW9uKExvYWRNZWRpYVJlc291cmNlKTsKQEAgLTI5MTcsNyArMjkzNyw3IEBAIHZvaWQgSFRN TE1lZGlhRWxlbWVudDo6cGF1c2VJbnRlcm5hbCgpCiAgICAgICAgIExPRyhNZWRpYSwgIiAgcmV0 dXJuaW5nIGJlY2F1c2Ugb2YgaW50ZXJydXB0aW9uIik7CiAgICAgICAgIHJldHVybjsKICAgICB9 Ci0gICAgCisKICAgICAvLyA0LjguMTAuOS4gUGxheWluZyB0aGUgbWVkaWEgcmVzb3VyY2UKICAg ICBpZiAoIW1fcGxheWVyIHx8IG1fbmV0d29ya1N0YXRlID09IE5FVFdPUktfRU1QVFkpIHsKICAg ICAgICAgLy8gVW5sZXNzIHRoZSByZXN0cmljdGlvbiBvbiBtZWRpYSByZXF1aXJpbmcgdXNlciBh Y3Rpb24gaGFzIGJlZW4gbGlmdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5o CmluZGV4IDk0MGI2MTVjZjk4ZTYyZWQyMWEzYTZkNmUwMDYyNDg4MjY1YjAwMGEuLjdiZjc5Zjhk MTQ3MTJjZjcxOWM5YjU3M2I5ZTgxMzFmMGI4MWViYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5oCkBAIC00MjksNiArNDI5LDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0 U2Vzc2lvbihNZWRpYVNlc3Npb24qKTsKIAogICAgIHZvaWQgc2V0U2hvdWxkRHVjayhib29sKTsK KworICAgIHN0YXRpYyBIVE1MTWVkaWFFbGVtZW50KiBlbGVtZW50V2l0aElEKHVpbnQ2NF90KTsK KyAgICB1aW50NjRfdCBlbGVtZW50SUQoKSBjb25zdCB7IHJldHVybiBtX2VsZW1lbnRJRDsgfQog I2VuZGlmCiAKICNpZiBFTkFCTEUoTUVESUFfU09VUkNFKQpAQCAtODI1LDYgKzgyOCw3IEBAIHBy aXZhdGU6CiAgICAgU3RyaW5nIG1fa2luZDsKICAgICBSZWZQdHI8TWVkaWFTZXNzaW9uPiBtX3Nl c3Npb247CiAgICAgYm9vbCBtX3Nob3VsZER1Y2sgeyBmYWxzZSB9OworICAgIHVpbnQ2NF90IG1f ZWxlbWVudElEOwogI2VuZGlmCiAKICNpZiBFTkFCTEUoTUVESUFfU09VUkNFKQo=