147313 2015-07-26 20:50:55 -0700 [WK2][iOS] WebContent process main thread should have fixed priority 2015-07-26 22:09:55 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 cdumez cdumez barraclough kling rniwa sam oldest_to_newest 1112342 0 cdumez 2015-07-26 20:50:55 -0700 WebContent process main thread should have fixed priority on iOS 9. Priority decay regresses PLT and fixing the priority gives up a ~3% progression on warm PLT. 1112343 1 cdumez 2015-07-26 20:51:09 -0700 rdar://problem/22003112 1112345 2 257541 cdumez 2015-07-26 20:54:12 -0700 Created attachment 257541 Patch 1112347 3 257541 sam 2015-07-26 21:04:47 -0700 Comment on attachment 257541 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257541&action=review > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:176 > + if (parameters.uiProcessBundleIdentifier == "com.apple.mobilesafari") Why only for MobileSafari? If this is a good idea for MobileSafari, why isn't it a good idea all he time? 1112348 4 cdumez 2015-07-26 21:06:13 -0700 (In reply to comment #3) > Comment on attachment 257541 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257541&action=review > > > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:176 > > + if (parameters.uiProcessBundleIdentifier == "com.apple.mobilesafari") > > Why only for MobileSafari? If this is a good idea for MobileSafari, why > isn't it a good idea all he time? Please see radar for more information. 1112350 5 257542 cdumez 2015-07-26 21:23:01 -0700 Created attachment 257542 Patch 1112351 6 cdumez 2015-07-26 21:23:46 -0700 (In reply to comment #3) > Comment on attachment 257541 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257541&action=review > > > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:176 > > + if (parameters.uiProcessBundleIdentifier == "com.apple.mobilesafari") > > Why only for MobileSafari? If this is a good idea for MobileSafari, why > isn't it a good idea all he time? I removed the check as discussed offline. 1112352 7 257542 darin 2015-07-26 21:24:10 -0700 Comment on attachment 257542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257542&action=review Yuck. > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:173 > +#if (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000) No need for the parentheses. 1112354 8 257544 cdumez 2015-07-26 21:30:01 -0700 Created attachment 257544 Patch 1112358 9 257544 cdumez 2015-07-26 22:09:47 -0700 Comment on attachment 257544 Patch Clearing flags on attachment: 257544 Committed r187412: <http://trac.webkit.org/changeset/187412> 1112359 10 cdumez 2015-07-26 22:09:55 -0700 All reviewed patches have been landed. Closing bug. 257541 2015-07-26 20:54:12 -0700 2015-07-26 21:22:56 -0700 Patch bug-147313-20150726205252.patch text/plain 2068 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjllOGE2MDVkMDI0NzRk ZWQ4ZTkzMWRjMDA4MDgxMmRkMmJiOGJhOS4uOGZjMmUwMGY1YzVkYmI3ZDZiNmM4YjdiMTM3ZDhj ZWEzMzJiZGFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA3LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1baU9TXSBXZWJDb250 ZW50IHByb2Nlc3MgbWFpbiB0aHJlYWQgc2hvdWxkIGhhdmUgZml4ZWQgcHJpb3JpdHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzMxMworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjIwMDMxMTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViQ29udGVudCBwcm9jZXNzIG1haW4gdGhyZWFkIHNob3Vs ZCBoYXZlIGZpeGVkIHByaW9yaXR5IG9uIGlPUyA5LgorICAgICAgICBQcmlvcml0eSBkZWNheSBy ZWdyZXNzZXMgUExUIGFuZCBmaXhpbmcgdGhlIG1haW4gdGhyZWFkJ3MgcHJpb3JpdHkKKyAgICAg ICAgZ2l2ZXMgdXAgYSB+MyUgcHJvZ3Jlc3Npb24gb24gd2FybSBQTFQgKHRlc3RlZCBvbiBpUGhv bmUgNXMpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06 CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nl c3MpOgorCiAyMDE1LTA3LTI0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIGlPUyA4IGJ1aWxkIGZpeCBhdHRlbXB0IGFmdGVyIHIxODcyMTUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbSBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4IDI4 N2I0OGE3MWU3ZjE0ZDEwODM4YTFmM2QwOWQ0YWJjNDczOWQ4NTYuLmZlOTFmZDE0MGJkYWJhODI0 MDA2ZTBmMmYyNjA2MWRkNjRiNTU4ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCkBAIC0xNjksNiArMTY5LDEzIEBAIHZvaWQg V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzJiYgcGFyCiAjaWYgKFRBUkdFVF9PU19JUEhPTkUgJiYgX19JUEhPTkVfT1Nf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gOTAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwKQogICAgIF9DRk5ldHdvcmtTZXRB VFNDb250ZXh0KHBhcmFtZXRlcnMubmV0d29ya0FUU0NvbnRleHQuZ2V0KCkpOwogI2VuZGlmCisK KyNpZiAoVEFSR0VUX09TX0lQSE9ORSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJF RCA+PSA5MDAwMCkKKyAgICAvLyBQcmlvcml0eSBkZWNheSBvbiBpT1MgOSBpcyBpbXBhY3Rpbmcg TW9iaWxlU2FmYXJpJ3MgcGFnZSBsb2FkIHRpbWUgc28gd2UgZml4IHRoZSBtYWluIHRocmVhZCBw cmlvcml0eSBvZgorICAgIC8vIE1vYmlsZVNhZmFyaSdzIFdlYlByb2Nlc3NlcyAocmRhcjovL3By b2JsZW0vMjIwMDMxMTIpLgorICAgIGlmIChwYXJhbWV0ZXJzLnVpUHJvY2Vzc0J1bmRsZUlkZW50 aWZpZXIgPT0gImNvbS5hcHBsZS5tb2JpbGVzYWZhcmkiKQorICAgICAgICBwdGhyZWFkX3NldF9m aXhlZHByaW9yaXR5X3NlbGYoKTsKKyNlbmRpZgogfQogCiB2b2lkIFdlYlByb2Nlc3M6OmluaXRp YWxpemVQcm9jZXNzTmFtZShjb25zdCBDaGlsZFByb2Nlc3NJbml0aWFsaXphdGlvblBhcmFtZXRl cnMmIHBhcmFtZXRlcnMpCg== 257542 2015-07-26 21:23:01 -0700 2015-07-26 21:29:56 -0700 Patch bug-147313-20150726212141.patch text/plain 1954 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjllOGE2MDVkMDI0NzRk ZWQ4ZTkzMWRjMDA4MDgxMmRkMmJiOGJhOS4uOGZjMmUwMGY1YzVkYmI3ZDZiNmM4YjdiMTM3ZDhj ZWEzMzJiZGFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA3LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1baU9TXSBXZWJDb250 ZW50IHByb2Nlc3MgbWFpbiB0aHJlYWQgc2hvdWxkIGhhdmUgZml4ZWQgcHJpb3JpdHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzMxMworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjIwMDMxMTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViQ29udGVudCBwcm9jZXNzIG1haW4gdGhyZWFkIHNob3Vs ZCBoYXZlIGZpeGVkIHByaW9yaXR5IG9uIGlPUyA5LgorICAgICAgICBQcmlvcml0eSBkZWNheSBy ZWdyZXNzZXMgUExUIGFuZCBmaXhpbmcgdGhlIG1haW4gdGhyZWFkJ3MgcHJpb3JpdHkKKyAgICAg ICAgZ2l2ZXMgdXAgYSB+MyUgcHJvZ3Jlc3Npb24gb24gd2FybSBQTFQgKHRlc3RlZCBvbiBpUGhv bmUgNXMpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06 CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nl c3MpOgorCiAyMDE1LTA3LTI0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIGlPUyA4IGJ1aWxkIGZpeCBhdHRlbXB0IGFmdGVyIHIxODcyMTUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbSBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4IDI4 N2I0OGE3MWU3ZjE0ZDEwODM4YTFmM2QwOWQ0YWJjNDczOWQ4NTYuLmRiOTBiOTMzNTJkYjdkNzNj NWFmMWU3ZmYwODM5NWE1Njc5MjgxZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCkBAIC0xNjksNiArMTY5LDExIEBAIHZvaWQg V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzJiYgcGFyCiAjaWYgKFRBUkdFVF9PU19JUEhPTkUgJiYgX19JUEhPTkVfT1Nf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gOTAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwKQogICAgIF9DRk5ldHdvcmtTZXRB VFNDb250ZXh0KHBhcmFtZXRlcnMubmV0d29ya0FUU0NvbnRleHQuZ2V0KCkpOwogI2VuZGlmCisK KyNpZiAoVEFSR0VUX09TX0lQSE9ORSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJF RCA+PSA5MDAwMCkKKyAgICAvLyBQcmlvcml0eSBkZWNheSBvbiBpT1MgOSBpcyBpbXBhY3Rpbmcg cGFnZSBsb2FkIHRpbWUgc28gd2UgZml4IHRoZSBwcmlvcml0eSBvZiB0aGUgV2ViUHJvY2Vzcycg bWFpbiB0aHJlYWQgKHJkYXI6Ly9wcm9ibGVtLzIyMDAzMTEyKS4KKyAgICBwdGhyZWFkX3NldF9m aXhlZHByaW9yaXR5X3NlbGYoKTsKKyNlbmRpZgogfQogCiB2b2lkIFdlYlByb2Nlc3M6OmluaXRp YWxpemVQcm9jZXNzTmFtZShjb25zdCBDaGlsZFByb2Nlc3NJbml0aWFsaXphdGlvblBhcmFtZXRl cnMmIHBhcmFtZXRlcnMpCg== 257544 2015-07-26 21:30:01 -0700 2015-07-26 22:09:47 -0700 Patch bug-147313-20150726212841.patch text/plain 1949 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjllOGE2MDVkMDI0NzRk ZWQ4ZTkzMWRjMDA4MDgxMmRkMmJiOGJhOS4uMjA0NjUyYTVmNjdmZWVmOGE2Y2U4ODQ0ZTMyNDlh YTQ3Y2VhNTk1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA3LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1baU9TXSBXZWJDb250 ZW50IHByb2Nlc3MgbWFpbiB0aHJlYWQgc2hvdWxkIGhhdmUgZml4ZWQgcHJpb3JpdHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzMxMworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjIwMDMxMTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCisKKyAgICAgICAgV2ViQ29udGVudCBwcm9jZXNzIG1haW4gdGhyZWFkIHNob3VsZCBo YXZlIGZpeGVkIHByaW9yaXR5IG9uIGlPUyA5LgorICAgICAgICBQcmlvcml0eSBkZWNheSByZWdy ZXNzZXMgUExUIGFuZCBmaXhpbmcgdGhlIG1haW4gdGhyZWFkJ3MgcHJpb3JpdHkKKyAgICAgICAg Z2l2ZXMgdXAgYSB+MyUgcHJvZ3Jlc3Npb24gb24gd2FybSBQTFQgKHRlc3RlZCBvbiBpUGhvbmUg NXMpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06Cisg ICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3Mp OgorCiAyMDE1LTA3LTI0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIGlPUyA4IGJ1aWxkIGZpeCBhdHRlbXB0IGFmdGVyIHIxODcyMTUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbSBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4IDI4N2I0 OGE3MWU3ZjE0ZDEwODM4YTFmM2QwOWQ0YWJjNDczOWQ4NTYuLjRiOTBkYzUyYzMxNjI3YzRmNmU3 ZWQ5OTQyMjkzNTdlNTBiNTFjMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCkBAIC0xNjksNiArMTY5LDExIEBAIHZvaWQgV2Vi UHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRpb25Q YXJhbWV0ZXJzJiYgcGFyCiAjaWYgKFRBUkdFVF9PU19JUEhPTkUgJiYgX19JUEhPTkVfT1NfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gOTAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09T X1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwKQogICAgIF9DRk5ldHdvcmtTZXRBVFND b250ZXh0KHBhcmFtZXRlcnMubmV0d29ya0FUU0NvbnRleHQuZ2V0KCkpOwogI2VuZGlmCisKKyNp ZiBUQVJHRVRfT1NfSVBIT05FICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDkwMDAwCisgICAgLy8gUHJpb3JpdHkgZGVjYXkgb24gaU9TIDkgaXMgaW1wYWN0aW5nIHBhZ2Ug bG9hZCB0aW1lIHNvIHdlIGZpeCB0aGUgcHJpb3JpdHkgb2YgdGhlIFdlYlByb2Nlc3MnIG1haW4g dGhyZWFkIChyZGFyOi8vcHJvYmxlbS8yMjAwMzExMikuCisgICAgcHRocmVhZF9zZXRfZml4ZWRw cmlvcml0eV9zZWxmKCk7CisjZW5kaWYKIH0KIAogdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXpl UHJvY2Vzc05hbWUoY29uc3QgQ2hpbGRQcm9jZXNzSW5pdGlhbGl6YXRpb25QYXJhbWV0ZXJzJiBw YXJhbWV0ZXJzKQo=