147304 2015-07-25 22:10:49 -0700 Web Inspector: Start using Node.prototype.remove 2015-07-27 15:46:06 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1112277 0 nvasilyev 2015-07-25 22:10:49 -0700 Convert the following code: refElem.parendNode.removeChild(refElem) to refElem.remove() Note that when refElem.parendNode is null, refElem.remove() is no-op, it doesn't throw any errors. 1112278 1 webkit-bug-importer 2015-07-25 22:10:59 -0700 <rdar://problem/22000479> 1112281 2 257529 nvasilyev 2015-07-25 22:18:15 -0700 Created attachment 257529 Patch 1112297 3 257529 commit-queue 2015-07-25 23:32:01 -0700 Comment on attachment 257529 Patch Clearing flags on attachment: 257529 Committed r187405: <http://trac.webkit.org/changeset/187405> 1112298 4 commit-queue 2015-07-25 23:32:05 -0700 All reviewed patches have been landed. Closing bug. 1112524 5 257529 joepeck 2015-07-27 15:11:54 -0700 Comment on attachment 257529 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257529&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1269 > - parentElement.removeChild(self); > + self.remove(); Is this valid? Isn't "self" here a WebInspector.TreeElement, not a DOM Element? 1112550 6 joepeck 2015-07-27 15:46:06 -0700 (In reply to comment #5) > Comment on attachment 257529 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257529&action=review > > > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1269 > > - parentElement.removeChild(self); > > + self.remove(); > > Is this valid? Isn't "self" here a WebInspector.TreeElement, not a DOM > Element? Yes, although this still works, it works in lucky / poor way. This is inside of remove(), so it calls remove() again asynchronously, and only stops this loop because eventually the actual RemoveChild DOM event would remove this tree element from the parent. Lets fix this. 257529 2015-07-25 22:18:15 -0700 2015-07-25 23:32:01 -0700 Patch patch.txt text/plain 5414 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdjYWJjOWIuLjZjM2U2NjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA3LTI1ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0YXJ0 IHVzaW5nIE5vZGUucHJvdG90eXBlLnJlbW92ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MzA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5lbGVtZW50RHJhZ1N0YXJ0KToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5lbGVtZW50RHJhZ0VuZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IucmV2ZXJ0RG9tQ2hhbmdl cyk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUuX3VwZGF0ZVNlYXJj aEhpZ2hsaWdodC51cGRhdGVFbnRyeUhpZGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRy ZWVFbGVtZW50LnByb3RvdHlwZS5fdXBkYXRlU2VhcmNoSGlnaGxpZ2h0KToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlLnJlbW92ZU5vZGVDYWxs YmFjayk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLnJl bW92ZSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNpemVyLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlJlc2l6ZXIucHJvdG90eXBlLl9yZXNpemVyTW91c2VEb3duKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5SZXNpemVyLnByb3RvdHlwZS5fcmVzaXplck1vdXNlVXApOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc2l6ZXIpOgorCiAyMDE1LTA3LTI0ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRk IGN1c3RvbSBwYXJhbWV0ZXIgbGlzdHMgZm9yIG5ldyBET00gYXBwZW5kL3ByZXBlbmQvYmVmb3Jl L2FmdGVyL3JlcGxhY2VXaXRoIG1ldGhvZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCBiNGViZjBmLi5hZWU0MzY3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0x NzAzLDcgKzE3MDMsNyBAQCBXZWJJbnNwZWN0b3IuZWxlbWVudERyYWdTdGFydCA9IGZ1bmN0aW9u KGVsZW1lbnQsIGRpdmlkZXJEcmFnLCBlbGVtZW50RHJhZ0VuZCwgZQogICAgIGlmIChlbGVtZW50 KSB7CiAgICAgICAgIC8vIEluc3RhbGwgZ2xhc3MgcGFuZQogICAgICAgICBpZiAoV2ViSW5zcGVj dG9yLl9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmUpCi0gICAgICAgICAgICBXZWJJbnNwZWN0b3Iu X2VsZW1lbnREcmFnZ2luZ0dsYXNzUGFuZS5wYXJlbnRFbGVtZW50LnJlbW92ZUNoaWxkKFdlYklu c3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xhc3NQYW5lKTsKKyAgICAgICAgICAgIFdlYkluc3Bl Y3Rvci5fZWxlbWVudERyYWdnaW5nR2xhc3NQYW5lLnJlbW92ZSgpOwogCiAgICAgICAgIHZhciBn bGFzc1BhbmUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAgZ2xhc3NQ YW5lLnN0eWxlLmNzc1RleHQgPSAicG9zaXRpb246YWJzb2x1dGU7dG9wOjA7Ym90dG9tOjA7bGVm dDowO3JpZ2h0OjA7b3BhY2l0eTowO3otaW5kZXg6MSI7CkBAIC0xNzM0LDcgKzE3MzQsNyBAQCBX ZWJJbnNwZWN0b3IuZWxlbWVudERyYWdFbmQgPSBmdW5jdGlvbihldmVudCkKICAgICBldmVudC50 YXJnZXQub3duZXJEb2N1bWVudC5ib2R5LnN0eWxlLnJlbW92ZVByb3BlcnR5KCJjdXJzb3IiKTsK IAogICAgIGlmIChXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnZ2luZ0dsYXNzUGFuZSkKLSAgICAg ICAgV2ViSW5zcGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmUucGFyZW50RWxlbWVudC5y ZW1vdmVDaGlsZChXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnZ2luZ0dsYXNzUGFuZSk7CisgICAg ICAgIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xhc3NQYW5lLnJlbW92ZSgpOwogCiAg ICAgZGVsZXRlIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xhc3NQYW5lOwogICAgIGRl bGV0ZSBXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnZ2luZ0V2ZW50VGFyZ2V0OwpAQCAtMjAyNyw4 ICsyMDI3LDcgQEAgV2ViSW5zcGVjdG9yLnJldmVydERvbUNoYW5nZXMgPSBmdW5jdGlvbihkb21D aGFuZ2VzKQogICAgICAgICB2YXIgZW50cnkgPSBkb21DaGFuZ2VzW2ldOwogICAgICAgICBzd2l0 Y2ggKGVudHJ5LnR5cGUpIHsKICAgICAgICAgY2FzZSAiYWRkZWQiOgotICAgICAgICAgICAgaWYg KGVudHJ5Lm5vZGUucGFyZW50RWxlbWVudCkKLSAgICAgICAgICAgICAgICBlbnRyeS5ub2RlLnBh cmVudEVsZW1lbnQucmVtb3ZlQ2hpbGQoZW50cnkubm9kZSk7CisgICAgICAgICAgICBlbnRyeS5u b2RlLnJlbW92ZSgpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgImNoYW5nZWQi OgogICAgICAgICAgICAgZW50cnkubm9kZS50ZXh0Q29udGVudCA9IGVudHJ5Lm9sZFRleHQ7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01U cmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0RPTVRyZWVFbGVtZW50LmpzCmluZGV4IDI2Y2YxN2QuLjMzMjVjMWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVF bGVtZW50LmpzCkBAIC0xMjAsOCArMTIwLDcgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50 ID0gY2xhc3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVHJlZUVsZW0KICAg ICAgICAgewogICAgICAgICAgICAgc3dpdGNoIChlbnRyeS50eXBlKSB7CiAgICAgICAgICAgICAg ICAgY2FzZSAiYWRkZWQiOgotICAgICAgICAgICAgICAgICAgICBpZiAoZW50cnkubm9kZS5wYXJl bnRFbGVtZW50KQotICAgICAgICAgICAgICAgICAgICAgICAgZW50cnkubm9kZS5wYXJlbnRFbGVt ZW50LnJlbW92ZUNoaWxkKGVudHJ5Lm5vZGUpOworICAgICAgICAgICAgICAgICAgICBlbnRyeS5u b2RlLnJlbW92ZSgpOwogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAg ICBjYXNlICJjaGFuZ2VkIjoKICAgICAgICAgICAgICAgICAgICAgZW50cnkubm9kZS50ZXh0Q29u dGVudCA9IGVudHJ5Lm9sZFRleHQ7CkBAIC0xMjY3LDcgKzEyNjYsNyBAQCBXZWJJbnNwZWN0b3Iu RE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBET01UcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rv ci5UcmVlRWxlbQogICAgICAgICAgICAgaWYgKCFzZWxmLnBhcmVudCkKICAgICAgICAgICAgICAg ICByZXR1cm47CiAKLSAgICAgICAgICAgIHBhcmVudEVsZW1lbnQucmVtb3ZlQ2hpbGQoc2VsZik7 CisgICAgICAgICAgICBzZWxmLnJlbW92ZSgpOwogICAgICAgICAgICAgcGFyZW50RWxlbWVudC5h ZGp1c3RDb2xsYXBzZWRSYW5nZSgpOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc2l6ZXIuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNpemVyLmpzCmluZGV4IDg5M2VmNmUu LjA3NmE3YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1Jlc2l6ZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvUmVzaXplci5qcwpAQCAtMTEwLDcgKzExMCw3IEBAIFdlYkluc3BlY3Rvci5SZXNp emVyID0gY2xhc3MgUmVzaXplciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAg Ly8gVGhlIGN1cnNvciBjb3VsZCBjaGFuZ2Ugd2hlbiBob3ZlcmluZyBvdmVyIGxpbmtzLCB0ZXh0 LCBvciBvdGhlciBlbGVtZW50cyB3aXRoIGN1cnNvciBjdWVzLgogICAgICAgICAvLyBGSVhNRTog d2hlbiBQb2ludGVyIEV2ZW50cyBzdXBwb3J0IGlzIGF2YWlsYWJsZSB0aGlzIGNvdWxkIGJlIGlt cGxlbWVudGVkIGJ5IGRyYXdpbmcgdGhlIGN1cnNvciBvdXJzZWx2ZXMuCiAgICAgICAgIGlmIChX ZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnZ2luZ0dsYXNzUGFuZSkKLSAgICAgICAgICAgIFdlYklu c3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xhc3NQYW5lLnBhcmVudEVsZW1lbnQucmVtb3ZlQ2hp bGQoV2ViSW5zcGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmUpOworICAgICAgICAgICAg V2ViSW5zcGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmUucmVtb3ZlKCk7CiAKICAgICAg ICAgdmFyIGdsYXNzUGFuZUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsK ICAgICAgICAgZ2xhc3NQYW5lRWxlbWVudC5jbGFzc05hbWUgPSAiZ2xhc3MtcGFuZS1mb3ItZHJh ZyI7CkBAIC0xMzUsNyArMTM1LDcgQEAgV2ViSW5zcGVjdG9yLlJlc2l6ZXIgPSBjbGFzcyBSZXNp emVyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICBkb2N1bWVudC5ib2R5LnN0 eWxlLnJlbW92ZVByb3BlcnR5KCJjdXJzb3IiKTsKIAogICAgICAgICBpZiAoV2ViSW5zcGVjdG9y Ll9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmUpIHsKLSAgICAgICAgICAgIFdlYkluc3BlY3Rvci5f ZWxlbWVudERyYWdnaW5nR2xhc3NQYW5lLnBhcmVudEVsZW1lbnQucmVtb3ZlQ2hpbGQoV2ViSW5z cGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmUpOworICAgICAgICAgICAgV2ViSW5zcGVj dG9yLl9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmUucmVtb3ZlKCk7CiAgICAgICAgICAgICBkZWxl dGUgV2ViSW5zcGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdHbGFzc1BhbmU7CiAgICAgICAgIH0KIAo=