147298 2015-07-25 16:01:00 -0700 Expose TextIndicator-backed snapshot and rect gathering on DOMNode 2015-07-25 17:33:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin commit-queue enrica mitz sam simon.fraser oldest_to_newest 1112234 0 thorton 2015-07-25 16:01:00 -0700 Expose TextIndicator-backed snapshot and rect gathering on DOMNode 1112235 1 257520 thorton 2015-07-25 16:02:05 -0700 Created attachment 257520 Patch 1112236 2 commit-queue 2015-07-25 16:04:45 -0700 Attachment 257520 did not pass style-queue: ERROR: Source/WebCore/bindings/objc/DOM.mm:564: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1112237 3 thorton 2015-07-25 16:13:08 -0700 http://trac.webkit.org/changeset/187391 1112239 4 257520 mitz 2015-07-25 16:19:57 -0700 Comment on attachment 257520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257520&action=review > Source/WebCore/bindings/objc/DOMExtensions.h:113 > +- (void)getPreviewSnapshotImage:(CGImageRef*)cgImage andRects:(NSArray **)rects; Did you mean to add this to the Mac part of the header? This is a public header on Mac, so declarations here requires availability information and some Apple-internal process. 1112241 5 thorton 2015-07-25 16:30:10 -0700 http://trac.webkit.org/changeset/187392 1112246 6 thorton 2015-07-25 17:33:30 -0700 http://trac.webkit.org/changeset/187393 257520 2015-07-25 16:02:05 -0700 2015-07-25 16:08:57 -0700 Patch bug-147298-20150725160046.patch text/plain 3671 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFkMzcwYTQ4NWVjNmQ0 MTVkNWFkMmUzNjJjZjg1ZmU4MGYxYWVlZS4uN2IyMzAxY2NhMWU0OGY0MDA0NDc1M2U2NGVhMmRk MjU4NDZiYWFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTI1ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEV4cG9zZSBUZXh0 SW5kaWNhdG9yLWJhY2tlZCBzbmFwc2hvdCBhbmQgcmVjdCBnYXRoZXJpbmcgb24gRE9NTm9kZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3Mjk4Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTkwNTgzOT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL29iamMvRE9NLm1tOgorICAgICAg ICAoLVtET01Ob2RlIGdldFByZXZpZXdTbmFwc2hvdEltYWdlOmFuZFJlY3RzOl0pOgorICAgICAg ICAqIGJpbmRpbmdzL29iamMvRE9NRXh0ZW5zaW9ucy5oOgorCiAyMDE1LTA3LTI0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gQ2xlYW4gdXAg c2VydmVyIHRydXN0IGhhbmRsaW5nIGluIFJlc291cmNlSGFuZGxlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvb2JqYy9ET00ubW0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9vYmpjL0RPTS5tbQppbmRleCAzM2I2ZGViYWRmZWFjZTM3ZDg3MzIwNzAwNTljMzYwNDQyMTI4 NTQ2Li43Nzg2NzgxZmIzMDNiYmM4YjlkNWRhNTQxYTdlNzQ2OTAyNzYzNTg1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL0RPTS5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9vYmpjL0RPTS5tbQpAQCAtNTAsNiArNTAsNyBAQAogI2ltcG9ydCAiUmFuZ2Uu aCIKICNpbXBvcnQgIlJlbmRlckltYWdlLmgiCiAjaW1wb3J0ICJTY3JpcHRDb250cm9sbGVyLmgi CisjaW1wb3J0ICJUZXh0SW5kaWNhdG9yLmgiCiAjaW1wb3J0ICJXZWJTY3JpcHRPYmplY3RQcml2 YXRlLmgiCiAjaW1wb3J0IDxKYXZhU2NyaXB0Q29yZS9BUElDYXN0Lmg+CiAjaW1wb3J0IDx3dGYv SGFzaE1hcC5oPgpAQCAtNTQxLDYgKzU0Miw0OCBAQCBpZCA8RE9NRXZlbnRUYXJnZXQ+IGtpdChX ZWJDb3JlOjpFdmVudFRhcmdldCogZXZlbnRUYXJnZXQpCiAKICNlbmRpZiAvLyBQTEFURk9STShJ T1MpCiAKKy0gKHZvaWQpZ2V0UHJldmlld1NuYXBzaG90SW1hZ2U6KENHSW1hZ2VSZWYqKWNnSW1h Z2UgYW5kUmVjdHM6KE5TQXJyYXkgKiopcmVjdHMKK3sKKyAgICBpZiAoIWNnSW1hZ2UgfHwgIXJl Y3RzKQorICAgICAgICByZXR1cm47CisKKyAgICAqY2dJbWFnZSA9IG51bGxwdHI7CisgICAgKnJl Y3RzID0gbnVsbHB0cjsKKworICAgIE5vZGUqIGNvcmVOb2RlID0gY29yZShzZWxmKTsKKworICAg IFJlZjxSYW5nZT4gcmFuZ2UgPSByYW5nZU9mQ29udGVudHMoKmNvcmVOb2RlKTsKKworICAgIGZs b2F0IGRldmljZVNjYWxlRmFjdG9yID0gY29yZU5vZGUtPmRvY3VtZW50KCkuZGV2aWNlU2NhbGVG YWN0b3IoKTsKKyAgICBjb25zdCBmbG9hdCBtYXJnaW4gPSA0ICogZGV2aWNlU2NhbGVGYWN0b3I7 CisgICAgUmVmUHRyPFRleHRJbmRpY2F0b3I+IHRleHRJbmRpY2F0b3IgPSBUZXh0SW5kaWNhdG9y OjpjcmVhdGVXaXRoUmFuZ2UocmFuZ2UsIFRleHRJbmRpY2F0b3JQcmVzZW50YXRpb25UcmFuc2l0 aW9uOjpOb25lLCBtYXJnaW4pOworCisgICAgaWYgKCF0ZXh0SW5kaWNhdG9yKQorICAgICAgICBy ZXR1cm47CisKKyAgICBpZiAoSW1hZ2UqIGltYWdlID0gdGV4dEluZGljYXRvci0+Y29udGVudElt YWdlKCkpCisgICAgICAgICpjZ0ltYWdlID0gKENHSW1hZ2VSZWYpQ0ZBdXRvcmVsZWFzZShDR0lt YWdlUmV0YWluKGltYWdlLT5nZXRDR0ltYWdlUmVmKCkpKTsKKworICAgIFJldGFpblB0cjxOU011 dGFibGVBcnJheT4gcmVjdEFycmF5ID0gYWRvcHROUyhbW05TTXV0YWJsZUFycmF5IGFsbG9jXSBp bml0XSk7CisKKyAgICBpZiAoKmNnSW1hZ2UpIHsKKyAgICAgICAgRmxvYXRQb2ludCBvcmlnaW4g PSB0ZXh0SW5kaWNhdG9yLT50ZXh0Qm91bmRpbmdSZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzKCku bG9jYXRpb24oKTsKKyAgICAgICAgZm9yIChjb25zdCBGbG9hdFJlY3QmIHJlY3QgOiB0ZXh0SW5k aWNhdG9yLT50ZXh0UmVjdHNJbkJvdW5kaW5nUmVjdENvb3JkaW5hdGVzKCkpIHsKKyAgICAgICAg ICAgIENHUmVjdCBjZ1JlY3QgPSByZWN0OworICAgICAgICAgICAgY2dSZWN0Lm9yaWdpbi54ICs9 IG9yaWdpbi54KCk7CisgICAgICAgICAgICBjZ1JlY3Qub3JpZ2luLnkgKz0gb3JpZ2luLnkoKTsK KyAgICAgICAgICAgIGNnUmVjdCA9IGNvcmVOb2RlLT5kb2N1bWVudCgpLmZyYW1lKCktPnZpZXco KS0+Y29udGVudHNUb1dpbmRvdyhlbmNsb3NpbmdJbnRSZWN0KGNnUmVjdCkpOworICAgICAgICAg ICAgW3JlY3RBcnJheSBhZGRPYmplY3Q6W05TVmFsdWUgdmFsdWU6JmNnUmVjdCB3aXRoT2JqQ1R5 cGU6QGVuY29kZShDR1JlY3QpXV07CisgICAgICAgIH0KKyAgICB9IGVsc2UgeworICAgICAgICBD R1JlY3QgY2dSZWN0ID0gQ0dSZWN0SW5zZXQocmFuZ2UtPmJvdW5kaW5nUmVjdCgpLCAtbWFyZ2lu LCAtbWFyZ2luKTsKKyAgICAgICAgY2dSZWN0ID0gY29yZU5vZGUtPmRvY3VtZW50KCkuZnJhbWUo KS0+dmlldygpLT5jb250ZW50c1RvV2luZG93KGVuY2xvc2luZ0ludFJlY3QoY2dSZWN0KSk7Cisg ICAgICAgIFtyZWN0QXJyYXkgYWRkT2JqZWN0OltOU1ZhbHVlIHZhbHVlOiZjZ1JlY3Qgd2l0aE9i akNUeXBlOkBlbmNvZGUoQ0dSZWN0KV1dOworICAgIH0KKworICAgICpyZWN0cyA9IHJlY3RBcnJh eS5hdXRvcmVsZWFzZSgpOworfQorCiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBET01Ob2RlIChE T01Ob2RlRXh0ZW5zaW9uc1BlbmRpbmdQdWJsaWMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9vYmpjL0RPTUV4dGVuc2lvbnMuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L29iamMvRE9NRXh0ZW5zaW9ucy5oCmluZGV4IGM4YmYyN2MyODAxNmVmMjI0ZTk5NjI5M2NhYzlm NTExNDIwOWFmODMuLjE0NzQ0ZTlmOGY3NzlhYmE5MWFjZGJmNDJjZjJlNTQzYzIwZmFlODEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL29iamMvRE9NRXh0ZW5zaW9ucy5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL29iamMvRE9NRXh0ZW5zaW9ucy5oCkBAIC0xMDks NiArMTA5LDggQEAgdHlwZWRlZiBzdHJ1Y3QgX1dLUXVhZCB7CiAtIChET01Ob2RlICopbmV4dEZv Y3VzTm9kZTsKIC0gKERPTU5vZGUgKilwcmV2aW91c0ZvY3VzTm9kZTsKICNlbmRpZgorCistICh2 b2lkKWdldFByZXZpZXdTbmFwc2hvdEltYWdlOihDR0ltYWdlUmVmKiljZ0ltYWdlIGFuZFJlY3Rz OihOU0FycmF5ICoqKXJlY3RzOwogQGVuZAogCiBAaW50ZXJmYWNlIERPTUVsZW1lbnQgKERPTUVs ZW1lbnRBcHBLaXRFeHRlbnNpb25zKQo=