147297 2015-07-25 15:36:33 -0700 [GTK] NPAPI code crashes on Wayland 2016-11-30 10:01:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED https://bugzilla.redhat.com/show_bug.cgi?id=1246710 https://bugzilla.redhat.com/show_bug.cgi?id=1246711 https://bugzilla.redhat.com/show_bug.cgi?id=1151769 https://bugzilla.redhat.com/show_bug.cgi?id=1248230 https://bugs.webkit.org/show_bug.cgi?id=164910 P2 Normal --- 81456 1 mcatanzaro webkit-unassigned cgarcia mcatanzaro tpopela zan oldest_to_newest 1112232 0 mcatanzaro 2015-07-25 15:36:33 -0700 With ENABLE_WAYLAND_TARGET=ON, we crash on extensions.gnome.org (with the GNOME Shell browser plugin installed) in WebPageProxy::createPluginContainer, attempting to use GtkSocket, which is illegal because it can only be used with a GdkX11Display. I guess we need to disable NPAPI support entirely when running under Wayland, unless someone volunteers to write code to make this work. 1112304 1 cgarcia 2015-07-26 00:31:52 -0700 We used to disable NPAPI plugins when building the wayland target, I guess now we need to do a runtime check. 1113236 2 mcatanzaro 2015-07-29 18:09:59 -0700 My plan is to build without NPAPI support for F23+, unless somebody wants to fix this with runtime checks, but it seems there are very many places that need the checks. I don't care about X11 support in F23+. 1113323 3 cgarcia 2015-07-29 23:46:43 -0700 (In reply to comment #2) > My plan is to build without NPAPI support for F23+, unless somebody wants to > fix this with runtime checks, but it seems there are very many places that > need the checks. I don't care about X11 support in F23+. I guess we shouldn't care to fix bugs upstream that only happen in Fedora then. 1113325 4 257822 cgarcia 2015-07-29 23:51:40 -0700 Created attachment 257822 Patch I guess this should be enough, I haven't tested it though. Could someone with wayland confirm this patch works? 1113468 5 mcatanzaro 2015-07-30 13:00:47 -0700 (In reply to comment #3) > I guess we shouldn't care to fix bugs upstream that only happen in Fedora > then. I don't understand; if I disable NPAPI in Fedora, then the bug would not occur in Fedora, but only in other distros using Wayland. (In reply to comment #4) > Created attachment 257822 [details] > Patch > > I guess this should be enough, I haven't tested it though. Could someone > with wayland confirm this patch works? Thanks. When I looked at the plugin code, I thought it would need runtime checks in very many places besides this one. But if just that one check will work, then that is awesome. But I can't confirm it works, since my development build is crashing on start under Wayland. I will file another bug about this; it must be a recent regression, since this worked a few weeks ago. 1113472 6 mcatanzaro 2015-07-30 13:20:35 -0700 Bug #147453 1113700 7 257917 cgarcia 2015-07-31 03:36:25 -0700 Created attachment 257917 Different patch Zan suggested me to do that event earlier, so that not even the WebCore frame loader creates the plugin. So, I'm disabling the enable-plugins settings unconditionally for wayland. 1113701 8 257917 zan 2015-07-31 04:00:08 -0700 Comment on attachment 257917 Different patch View in context: https://bugs.webkit.org/attachment.cgi?id=257917&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1600 > + if (WebCore::PlatformDisplay::sharedDisplay().type() == WebCore::PlatformDisplay::Type::Wayland) > + return; Should this throw a warning? 1113702 9 cgarcia 2015-07-31 04:46:55 -0700 (In reply to comment #8) > Comment on attachment 257917 [details] > Different patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257917&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1600 > > + if (WebCore::PlatformDisplay::sharedDisplay().type() == WebCore::PlatformDisplay::Type::Wayland) > > + return; > > Should this throw a warning? I don't think so, this will always be called on construction, because the default value of the setting is TRUE and all properties in WebKitSettings are construct properties. 1113708 10 cgarcia 2015-07-31 05:24:19 -0700 Committed r187641: <http://trac.webkit.org/changeset/187641> 1113711 11 mcatanzaro 2015-07-31 06:28:21 -0700 Thanks. I think we should probably force disable the enable-java setting as well, in case some application queries that and gets confused that plugins are disabled but Java supposedly is enabled. 257822 2015-07-29 23:51:40 -0700 2015-07-31 03:36:25 -0700 Patch wk2-wayland-npapi-crash.diff text/plain 2067 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2ZmZhNzJmLi4yYTE4MTYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTUtMDctMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIE5QQVBJIGNvZGUgY3Jhc2hlcyBvbiBXYXlsYW5kCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcyOTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgY3JldGUgTlBB UEkgcGx1Z2lucyB3aGVuIHJ1bmluZyBvbiBXYXlsYW5kLCBzaW5jZSB0aGV5IGFyZQorICAgICAg ICBub3Qgc3VwcG9ydGVkLiBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSBvcHRpb24gdXNlZCB0 byBiZQorICAgICAgICBpbmNvbXBhdGlibGUgd2l0aCBidWlsZGluZyB3aXRoIHRoZSBXYXlsYW5k IHRhcmdldCwgYnV0IG5vdyB0aGF0CisgICAgICAgIHdlIGFsbG93IHRvIGJ1aWxkIFgxMSBhbmQg V2F5bGFuZCB0YXJnZXRzIGF0IHRoZSBzYW1lIHRpbWUsIHdlCisgICAgICAgIG5lZWQgcnVudGlt ZSBjaGVja3MgdG8gYXZvaWQgY3JlYXRpbmcgTlBBUEkgcGx1Z2lucyBpbiBXYXlsYW5kLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlOjpjcmVhdGVQbHVnaW4pOgorCiAyMDE1LTA3LTI5ICBBbmR5IFZhbldhZ29uZXIg IDx0aGV0YWxlY3JhZnRlckBnbWFpbC5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IGJhc2ljIHR5 cGVzIGZvciBFQ01BU2NyaXB0IEludGVybmF0aW9uYWxpemF0aW9uIEFQSQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IGFhMjBkYzQuLjYzNmZm M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK QEAgLTIwMCw2ICsyMDAsMTAgQEAKICNpbmNsdWRlICJXZWJQcmludE9wZXJhdGlvbkd0ay5oIgog I2VuZGlmCiAKKyNpZiBQTEFURk9STShXQVlMQU5EKQorI2luY2x1ZGUgPFdlYkNvcmUvUGxhdGZv cm1EaXNwbGF5Lmg+CisjZW5kaWYKKwogI2lmIFBMQVRGT1JNKElPUykKICNpbmNsdWRlICJSZW1v dGVMYXllclRyZWVEcmF3aW5nQXJlYS5oIgogI2luY2x1ZGUgIldlYlZpZGVvRnVsbHNjcmVlbk1h bmFnZXIuaCIKQEAgLTY5NSw2ICs2OTksMTEgQEAgdm9pZCBXZWJQYWdlOjppbml0aWFsaXplSW5q ZWN0ZWRCdW5kbGVEaWFnbm9zdGljTG9nZ2luZ0NsaWVudChXS0J1bmRsZVBhZ2VEaWFnbm8KICNp ZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIFBhc3NSZWZQdHI8UGx1Z2luPiBXZWJQYWdl OjpjcmVhdGVQbHVnaW4oV2ViRnJhbWUqIGZyYW1lLCBIVE1MUGx1Z0luRWxlbWVudCogcGx1Z2lu RWxlbWVudCwgY29uc3QgUGx1Z2luOjpQYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzLCBTdHJpbmcmIG5l d01JTUVUeXBlKQogeworI2lmIFBMQVRGT1JNKFdBWUxBTkQpCisgICAgaWYgKFBsYXRmb3JtRGlz cGxheTo6c2hhcmVkRGlzcGxheSgpLnR5cGUoKSA9PSBQbGF0Zm9ybURpc3BsYXk6OlR5cGU6Oldh eWxhbmQpCisgICAgICAgIHJldHVybiBudWxscHRyOworI2VuZGlmCisKICAgICBTdHJpbmcgZnJh bWVVUkxTdHJpbmcgPSBmcmFtZS0+Y29yZUZyYW1lKCktPmxvYWRlcigpLmRvY3VtZW50TG9hZGVy KCktPnJlc3BvbnNlVVJMKCkuc3RyaW5nKCk7CiAgICAgU3RyaW5nIHBhZ2VVUkxTdHJpbmcgPSBt X3BhZ2UtPm1haW5GcmFtZSgpLmxvYWRlcigpLmRvY3VtZW50TG9hZGVyKCktPnJlc3BvbnNlVVJM KCkuc3RyaW5nKCk7CiAK 257917 2015-07-31 03:36:25 -0700 2015-07-31 04:00:08 -0700 Different patch wk2-wayland-plugins.diff text/plain 3227 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZmVmYWMzLi40MmYxMzRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTUtMDctMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIE5QQVBJIGNvZGUgY3Jhc2hlcyBvbiBXYXlsYW5kCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcyOTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgY3JldGUgTlBB UEkgcGx1Z2lucyB3aGVuIHJ1bmluZyBvbiBXYXlsYW5kLCBzaW5jZSB0aGV5IGFyZQorICAgICAg ICBub3Qgc3VwcG9ydGVkLiBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSBvcHRpb24gdXNlZCB0 byBiZQorICAgICAgICBpbmNvbXBhdGlibGUgd2l0aCBidWlsZGluZyB3aXRoIHRoZSBXYXlsYW5k IHRhcmdldCwgYnV0IG5vdyB0aGF0CisgICAgICAgIHdlIGFsbG93IHRvIGJ1aWxkIFgxMSBhbmQg V2F5bGFuZCB0YXJnZXRzIGF0IHRoZSBzYW1lIHRpbWUsIHdlCisgICAgICAgIG5lZWQgcnVudGlt ZSBjaGVja3MgdG8gYXZvaWQgY3JlYXRpbmcgTlBBUEkgcGx1Z2lucyBpbiBXYXlsYW5kLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwOgorICAgICAgICAo d2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfcGx1Z2lucyk6IERvIG5vdCBhbGxvdyB0byBjaGFu Z2UgdGhlCisgICAgICAgIHNldHRpbmcgd2hlbiBydW5uaW5nIGluIFdheWxhbmQuCisgICAgICAg ICogVUlQcm9jZXNzL2d0ay9XZWJQcmVmZXJlbmNlc0d0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVTdG9yZSk6IEluaXRpYWxpemUKKyAg ICAgICAgRW5hYmxlUGx1Z2lucyBwcmVmZXJlbmNlIHRvIGZhbHNlIHdoZW4gcnVubmluZyBpbiBX YXlsYW5kLgorCiAyMDE1LTA3LTMwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CiAKICAgICAgICAgTGF5b3V0VGVzdHMvaW5zcGVjdG9yIGZyZXF1ZW50bHkgcnVuIHNsb3cg YW5kIHRpbWVvdXQgd2hlbiBydW4gaW4gV2ViS2l0MiBidXQgbm90IFdlYktpdDEKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcAppbmRl eCBkOTBlNDMyLi4zZTBjNDg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwCkBAIC00MCw2ICs0MCwxMCBAQAogI2luY2x1ZGUg PGdsaWIvZ2kxOG4tbGliLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCisjaWYg UExBVEZPUk0oV0FZTEFORCkKKyNpbmNsdWRlIDxXZWJDb3JlL1BsYXRmb3JtRGlzcGxheS5oPgor I2VuZGlmCisKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKIHN0cnVjdCBfV2ViS2l0U2V0dGlu Z3NQcml2YXRlIHsKQEAgLTE1OTAsNiArMTU5NCwxMiBAQCB2b2lkIHdlYmtpdF9zZXR0aW5nc19z ZXRfZW5hYmxlX3BsdWdpbnMoV2ViS2l0U2V0dGluZ3MqIHNldHRpbmdzLCBnYm9vbGVhbiBlbmFi bAogewogICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1NFVFRJTkdTKHNldHRpbmdzKSk7 CiAKKyNpZiBQTEFURk9STShXQVlMQU5EKQorICAgIC8vIERvIG5vdCBhbGxvdyB0byBjaGFuZ2Ug dGhpcyBzZXR0aW5nIGluIFdheWxhbmQsIHNpbmNlIHBsdWdpbnMgYXJlIG5vdCBzdXBwb3J0ZWQu CisgICAgaWYgKFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpLnR5cGUo KSA9PSBXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OlR5cGU6OldheWxhbmQpCisgICAgICAgIHJl dHVybjsKKyNlbmRpZgorCiAgICAgV2ViS2l0U2V0dGluZ3NQcml2YXRlKiBwcml2ID0gc2V0dGlu Z3MtPnByaXY7CiAgICAgYm9vbCBjdXJyZW50VmFsdWUgPSBwcml2LT5wcmVmZXJlbmNlcy0+cGx1 Z2luc0VuYWJsZWQoKTsKICAgICBpZiAoY3VycmVudFZhbHVlID09IGVuYWJsZWQpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwCmluZGV4 IGZmYzM1MDYuLjE3ZjE4YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9n dGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9n dGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwCkBAIC0zNSwxMCArMzUsMTMgQEAgbmFtZXNwYWNlIFdl YktpdCB7CiB2b2lkIFdlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVTdG9yZSgpCiB7 CiAjaWYgUExBVEZPUk0oV0FZTEFORCkKLSAgICAvLyBGSVhNRTogQWNjZWxlcmF0ZWQgY29tcG9z aXRpbmcgdW5kZXIgV2F5bGFuZCBpcyBub3QgeWV0IHN1cHBvcnRlZC4KLSAgICAvLyBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE1ODAzCi0gICAgaWYgKFdlYkNvcmU6 OlBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpLnR5cGUoKSA9PSBXZWJDb3JlOjpQbGF0 Zm9ybURpc3BsYXk6OlR5cGU6OldheWxhbmQpCisgICAgaWYgKFdlYkNvcmU6OlBsYXRmb3JtRGlz cGxheTo6c2hhcmVkRGlzcGxheSgpLnR5cGUoKSA9PSBXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6 OlR5cGU6OldheWxhbmQpIHsKKyAgICAgICAgLy8gRklYTUU6IEFjY2VsZXJhdGVkIGNvbXBvc2l0 aW5nIHVuZGVyIFdheWxhbmQgaXMgbm90IHlldCBzdXBwb3J0ZWQuCisgICAgICAgIC8vIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTU4MDMKICAgICAgICAgc2V0QWNj ZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoZmFsc2UpOworCisgICAgICAgIHNldFBsdWdpbnNF bmFibGVkKGZhbHNlKTsKKyAgICB9CiAjZW5kaWYKIH0KIAo=