147289 2015-07-24 20:45:08 -0700 [EFL] Build fix in ProtectionSpaceBase.cpp 2015-07-24 22:31:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue oldest_to_newest 1112187 0 jinwoo7.song 2015-07-24 20:45:08 -0700 In EFL port, we have following build break. ../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp: In member function ‘bool WebCore::ProtectionSpaceBase::isPasswordBased() const’: ../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp:118:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed. 1112188 1 257509 jinwoo7.song 2015-07-24 20:47:07 -0700 Created attachment 257509 Patch 1112192 2 257509 bfulgham 2015-07-24 21:41:27 -0700 Comment on attachment 257509 Patch r=me. 1112198 3 257509 commit-queue 2015-07-24 22:31:15 -0700 Comment on attachment 257509 Patch Clearing flags on attachment: 257509 Committed r187382: <http://trac.webkit.org/changeset/187382> 1112199 4 commit-queue 2015-07-24 22:31:19 -0700 All reviewed patches have been landed. Closing bug. 257509 2015-07-24 20:47:07 -0700 2015-07-24 22:31:15 -0700 Patch bug-147289-20150725124549.patch text/plain 1303 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3Mzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBlZjhkMjg1ZDJiOGU1 YzY5YWZkMTVjZjRkYzM4YzY4M2RlNWVkNy4uZTczZGRjMzkyMzM0MmY1YTBjNzFmYzg5NjQ1NmY1 NjE0ZTRmZDBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTI0ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCdWls ZCBmaXggaW4gUHJvdGVjdGlvblNwYWNlQmFzZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzI4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgYnVpbGQgYnJlYWsgZm9yIFstV2Vycm9y PXJldHVybi10eXBlXSBlcnJvci4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUHJvdGVj dGlvblNwYWNlQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQcm90ZWN0aW9uU3BhY2VCYXNl Ojppc1Bhc3N3b3JkQmFzZWQpOgorCiAyMDE1LTA3LTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgV0tXZWJzaXRlRGF0YVN0b3JlIHJlbW92ZSBtZXRo b2RzIGRvbid0IHByb3Blcmx5IGRlbGV0ZSBjb29raWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZUJhc2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9Qcm90ZWN0aW9uU3BhY2VCYXNlLmNwcAppbmRleCBlYmRj ZDY5ZTJiZjc0MjYwYTU0YThlMTFjZmFlMTAzNzdkYmI0NGQyLi45M2M0ZGRiYTQ4ZjlmZGIzNzFi OTVjYzI5NzBkYWM4Y2U4NTliYzM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZUJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvUHJvdGVjdGlvblNwYWNlQmFzZS5jcHAKQEAgLTExNSw2ICsxMTUsOCBA QCBib29sIFByb3RlY3Rpb25TcGFjZUJhc2U6OmlzUGFzc3dvcmRCYXNlZCgpIGNvbnN0CiAgICAg Y2FzZSBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGVtZVVua25vd246CiAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICB9CisKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogCg==