147288 2015-07-24 19:46:01 -0700 [GTK] Enable persistent cookie storage in MiniBrowser. 2017-03-11 11:05:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 hyungwook.lee hyungwook.lee bugs-noreply mcatanzaro oldest_to_newest 1112180 0 hyungwook.lee 2015-07-24 19:46:01 -0700 I think it will be good if we support persistent cookie storage in MiniBrowser. 1112182 1 257507 hyungwook.lee 2015-07-24 19:58:42 -0700 Created attachment 257507 Patch 1153354 2 257507 mcatanzaro 2016-01-06 20:49:11 -0800 Comment on attachment 257507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257507&action=review Hi Hyungwook, why do you want this? It seems useful to me that when MiniBrowser is restarted, there are no cookies that could be affecting the results of whatever it is I'm testing. Maybe it's not likely to often cause problems in practice, though, so I'm not opposed to this change. > Tools/MiniBrowser/gtk/main.c:298 > + // Enable persistent cookie storage. Please remove this comment, it's a "what" comment and doesn't add any value. We prefer comments that explain "why." 1154617 3 hyungwook.lee 2016-01-11 21:22:37 -0800 I think persistent cookie function is default function of most browser support it. To prevent confusion of using cookie, we'd better to meet another browser's behavior even if it is mini-browser. 1154626 4 268747 hyungwook.lee 2016-01-11 21:45:28 -0800 Created attachment 268747 Patch 1154700 5 268747 cgarcia 2016-01-12 08:43:57 -0800 Comment on attachment 268747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268747&action=review MiniBrowser is not a general purpose browser, it's for testing, so I'm not sure we want to save cookies. I agree it could be useful for testing cookies, though. So, maybe we could add a command line option to pass the cookies storage path, or the other way around, always save cookies and add a command line option to not use persistent cookies. > Tools/MiniBrowser/gtk/main.c:299 > + webkit_cookie_manager_set_persistent_storage(cookieManager, g_build_filename(g_get_user_data_dir(), "webkitgtk", "cookies.db", NULL), WEBKIT_COOKIE_PERSISTENT_STORAGE_SQLITE); This is leaking the value returned by g_build_filename(), it returns a new allocated string that should be freed. Also, I don't think we should use a generic webkitgtk dir, but someting more specific like MiniBrowser. 257507 2015-07-24 19:58:42 -0700 2016-01-11 21:38:57 -0800 Patch bug-147288-20150725115724.patch text/plain 1360 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NzM3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA3LTI0ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtHVEtdIEVuYWJsZSBwZXJzaXN0ZW50IGNvb2tpZSBzdG9y YWdlIGluIE1pbmlCcm93c2VyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ3Mjg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvbWFpbi5jOgorICAgICAgICAobWFpbik6CisK IDIwMTUtMDctMjQgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAg ICAgICBBWDogc2Nyb2xsYWJsZSBlbGVtZW50cyBkbyBub3QgYWxsb3cgMy1maW5nZXIgc3dpcGUK SW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv TWluaUJyb3dzZXIvZ3RrL21haW4uYwkocmV2aXNpb24gMTg3MjgxKQorKysgVG9vbHMvTWluaUJy b3dzZXIvZ3RrL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtMjk1LDYgKzI5NSwxMCBAQCBpbnQg bWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogCiAgICAgd2Via2l0X3dlYl9jb250ZXh0X3Jl Z2lzdGVyX3VyaV9zY2hlbWUod2Via2l0X3dlYl9jb250ZXh0X2dldF9kZWZhdWx0KCksIG1pbmlC cm93c2VyQWJvdXRTY2hlbWUsIGFib3V0VVJJU2NoZW1lUmVxdWVzdENhbGxiYWNrLCBOVUxMLCBO VUxMKTsKIAorICAgIC8vIEVuYWJsZSBwZXJzaXN0ZW50IGNvb2tpZSBzdG9yYWdlLgorICAgIFdl YktpdENvb2tpZU1hbmFnZXIgKmNvb2tpZU1hbmFnZXIgPSB3ZWJraXRfd2ViX2NvbnRleHRfZ2V0 X2Nvb2tpZV9tYW5hZ2VyKHdlYmtpdF93ZWJfY29udGV4dF9nZXRfZGVmYXVsdCgpKTsKKyAgICB3 ZWJraXRfY29va2llX21hbmFnZXJfc2V0X3BlcnNpc3RlbnRfc3RvcmFnZShjb29raWVNYW5hZ2Vy LCBnX2J1aWxkX2ZpbGVuYW1lKGdfZ2V0X3VzZXJfZGF0YV9kaXIoKSwgIndlYmtpdGd0ayIsICJj b29raWVzLmRiIiwgTlVMTCksIFdFQktJVF9DT09LSUVfUEVSU0lTVEVOVF9TVE9SQUdFX1NRTElU RSk7CisKICAgICBpZiAodXJpQXJndW1lbnRzKSB7CiAgICAgICAgIGludCBpOwogCg== 268747 2016-01-11 21:45:28 -0800 2016-01-12 08:43:57 -0800 Patch Patch text/plain 1317 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NDg4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTAxLTExICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtHVEtdIEVuYWJsZSBwZXJzaXN0ZW50IGNvb2tpZSBzdG9y YWdlIGluIE1pbmlCcm93c2VyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ3Mjg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvbWFpbi5jOgorICAgICAgICAobWFpbik6CisK IDIwMTYtMDEtMTEgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAg cnVuLWpzYy1zdHJlc3MtdGVzdHMgc2hvdWxkIHRyeSB0byBmaWd1cmUgb3V0IGEgSlNDIHBhdGgK SW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv TWluaUJyb3dzZXIvZ3RrL21haW4uYwkocmV2aXNpb24gMTk0ODg1KQorKysgVG9vbHMvTWluaUJy b3dzZXIvZ3RrL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtMjk1LDYgKzI5NSw5IEBAIGludCBt YWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAKICAgICB3ZWJraXRfd2ViX2NvbnRleHRfcmVn aXN0ZXJfdXJpX3NjaGVtZSh3ZWJraXRfd2ViX2NvbnRleHRfZ2V0X2RlZmF1bHQoKSwgbWluaUJy b3dzZXJBYm91dFNjaGVtZSwgYWJvdXRVUklTY2hlbWVSZXF1ZXN0Q2FsbGJhY2ssIE5VTEwsIE5V TEwpOwogCisgICAgV2ViS2l0Q29va2llTWFuYWdlciAqY29va2llTWFuYWdlciA9IHdlYmtpdF93 ZWJfY29udGV4dF9nZXRfY29va2llX21hbmFnZXIod2Via2l0X3dlYl9jb250ZXh0X2dldF9kZWZh dWx0KCkpOworICAgIHdlYmtpdF9jb29raWVfbWFuYWdlcl9zZXRfcGVyc2lzdGVudF9zdG9yYWdl KGNvb2tpZU1hbmFnZXIsIGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9kYXRhX2RpcigpLCAi d2Via2l0Z3RrIiwgImNvb2tpZXMuZGIiLCBOVUxMKSwgV0VCS0lUX0NPT0tJRV9QRVJTSVNURU5U X1NUT1JBR0VfU1FMSVRFKTsKKwogICAgIGlmICh1cmlBcmd1bWVudHMpIHsKICAgICAgICAgaW50 IGk7CiAK