147283 2015-07-24 16:45:27 -0700 Don't create UIWebFormAccessory if we don't require accessory view. 2015-07-24 18:09:47 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca commit-queue mitz sam thorton oldest_to_newest 1112139 0 yongjun_zhang 2015-07-24 16:45:27 -0700 Looks like we always create UIWebFormAccessory on WKContentView even when we don't require accessory view (requiresAccessoryView is false). 1112140 1 yongjun_zhang 2015-07-24 16:46:01 -0700 <rdar://problem/21913247> 1112143 2 257493 yongjun_zhang 2015-07-24 17:17:06 -0700 Created attachment 257493 Patch. 1112159 3 257493 commit-queue 2015-07-24 18:09:42 -0700 Comment on attachment 257493 Patch. Clearing flags on attachment: 257493 Committed r187376: <http://trac.webkit.org/changeset/187376> 1112160 4 commit-queue 2015-07-24 18:09:47 -0700 All reviewed patches have been landed. Closing bug. 257493 2015-07-24 17:17:06 -0700 2015-07-24 18:09:42 -0700 Patch. accessory_view.patch text/plain 2004 yongjun_zhang Y29tbWl0IDg0M2NiOGVlMzY0YzE4ODU1Mzg2NzdjZDdlMmFmYjM5YTc3MDI0YjgKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBGcmkgSnVsIDI0 IDE3OjExOjE2IDIwMTUgLTA3MDAKCiAgICBEb24ndCBjcmVhdGUgVUlXZWJGb3JtQWNjZXNzb3J5 IGlmIHdlIGRvbid0IHJlcXVpcmUgYWNjZXNzb3J5IHZpZXcuCiAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MjgzCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGMwYzBhY2QuLjgy N2EwY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNS0wNy0yNCAgWW9uZ2p1biBa aGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGNyZWF0ZSBV SVdlYkZvcm1BY2Nlc3NvcnkgaWYgd2UgZG9uJ3QgcmVxdWlyZSBhY2Nlc3Nvcnkgdmlldy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzI4MworCisg ICAgICAgIERvbid0IHRyeSB0byBpbnRpYWxpemUgX2Zvcm1BY2Nlc3NvcnlWaWV3IGlmIHJlcXVp cmVzQWNjZXNzb3J5VmlldyByZXR1cm5zIGZhbHNlIHNpbmNlIHdlIGRvbid0CisgICAgICAgIG5l ZWQgaXQgeWV0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgaW5wdXRBY2Nlc3NvcnlWaWV3XSk6CisKIDIwMTUtMDctMjQgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBOZXR3b3JraW5n IHByb2Nlc3MgY3Jhc2ggaW4gTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmNvbnZlcnRN YWluUmVzb3VyY2VMb2FkVG9Eb3dubG9hZCB3aGlsZSBhdHRlbXB0aW5nIHRvIGRvd25sb2FkIGEg YmxvYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCBmMWI2MDBlLi4wMjc5ZTU4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQpAQCAtMTI1OSw2ICsxMjU5LDkgQEAgc3RhdGljIHZvaWQgY2FuY2VsUG90ZW50aWFsVGFw SWZOZWNlc3NhcnkoV0tDb250ZW50VmlldyogY29udGVudFZpZXcpCiAKIC0gKFVJVmlldyAqKWlu cHV0QWNjZXNzb3J5VmlldwogeworICAgIGlmICghW3NlbGYgcmVxdWlyZXNBY2Nlc3NvcnlWaWV3 XSkKKyAgICAgICAgcmV0dXJuIG5pbDsKKwogICAgIGlmICghX2Zvcm1BY2Nlc3NvcnlWaWV3KSB7 CiAjaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gOTAwMDAKICAgICAgICAg aWYgKFtVSVdlYkZvcm1BY2Nlc3NvcnkgaW5zdGFuY2VzUmVzcG9uZFRvU2VsZWN0b3I6QHNlbGVj dG9yKGluaXRXaXRoSW5wdXRBc3Npc3RhbnRJdGVtOildKQpAQCAtMTI2OSw5ICsxMjcyLDYgQEAg c3RhdGljIHZvaWQgY2FuY2VsUG90ZW50aWFsVGFwSWZOZWNlc3NhcnkoV0tDb250ZW50Vmlldyog Y29udGVudFZpZXcpCiAgICAgICAgIFtfZm9ybUFjY2Vzc29yeVZpZXcgc2V0RGVsZWdhdGU6c2Vs Zl07CiAgICAgfQogCi0gICAgaWYgKCFbc2VsZiByZXF1aXJlc0FjY2Vzc29yeVZpZXddKQotICAg ICAgICByZXR1cm4gbmlsOwotICAgIAogICAgIHJldHVybiBfZm9ybUFjY2Vzc29yeVZpZXcuZ2V0 KCk7CiB9CiAK