147257 2015-07-24 01:04:23 -0700 Web Inspector: Add custom parameter lists for new DOM append/prepend/before/after/replaceWith methods 2015-07-24 11:41:08 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev sam timothy webkit-bug-importer oldest_to_newest 1111946 0 joepeck 2015-07-24 01:04:23 -0700 * SUMMARY Add custom parameter lists for new DOM append/prepend/before/after/replaceWith methods. If someone views the Element API for `document.body` it would be nice for them to see something for these new methods. * STEPS TO REPRODUCE 1. js> dir(document.body) 2. Expand down to the Element Prototype => "append", "prepend", etc look like they have no parameters * NOTES We are considering just typing `Document` or `api(Document)` to more quickly get you this view without having to expand existing objects. If it was much easier this would be more important. 1111947 1 257446 joepeck 2015-07-24 01:05:03 -0700 Created attachment 257446 [PATCH] Proposed Fix 1112038 2 257446 commit-queue 2015-07-24 11:41:03 -0700 Comment on attachment 257446 [PATCH] Proposed Fix Clearing flags on attachment: 257446 Committed r187350: <http://trac.webkit.org/changeset/187350> 1112039 3 commit-queue 2015-07-24 11:41:08 -0700 All reviewed patches have been landed. Closing bug. 257446 2015-07-24 01:05:03 -0700 2015-07-24 11:41:03 -0700 [PATCH] Proposed Fix parameter-list.patch text/plain 2088 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY0OGU3YzQuLjc2MjI3Y2YgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA3LTI0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIGN1 c3RvbSBwYXJhbWV0ZXIgbGlzdHMgZm9yIG5ldyBET00gYXBwZW5kL3ByZXBlbmQvYmVmb3JlL2Fm dGVyL3JlcGxhY2VXaXRoIG1ldGhvZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NzI1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvTmF0aXZlRnVuY3Rpb25QYXJh bWV0ZXJzLmpzOgorCiAyMDE1LTA3LTIyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmUgc2hvdWxkIGltbWVkaWF0 ZWx5IHN0YXJ0IG1vdmluZyBwbGF5IGhlYWQgd2hlbiBzdGFydGluZyBhIG5ldyByZWNvcmRpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9O YXRpdmVGdW5jdGlvblBhcmFtZXRlcnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvTmF0aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzCmluZGV4IGRhMDJjOTgu LmQxNjBmYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9OYXRpdmVGdW5jdGlvblBhcmFtZXRlcnMuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL05hdGl2ZUZ1bmN0aW9uUGFyYW1ldGVycy5qcwpA QCAtMjExNCw3ICsyMTE0LDIyIEBAIFdlYkluc3BlY3Rvci5OYXRpdmVQcm90b3R5cGVGdW5jdGlv blBhcmFtZXRlcnMgPSB7CiAgICAgICAgIHF1ZXJ5U2VsZWN0b3I6ICJzZWxlY3RvcnMiLAogICAg ICAgICBxdWVyeVNlbGVjdG9yQWxsOiAic2VsZWN0b3JzIiwKICAgICB9OwotCiAgICAgT2JqZWN0 LmFzc2lnbihXZWJJbnNwZWN0b3IuTmF0aXZlUHJvdG90eXBlRnVuY3Rpb25QYXJhbWV0ZXJzLkVs ZW1lbnQsIEVsZW1lbnRRdWVyaWVzKTsKICAgICBPYmplY3QuYXNzaWduKFdlYkluc3BlY3Rvci5O YXRpdmVQcm90b3R5cGVGdW5jdGlvblBhcmFtZXRlcnMuRG9jdW1lbnQsIEVsZW1lbnRRdWVyaWVz KTsKKworICAgIHZhciBDaGlsZE5vZGUgPSB7CisgICAgICAgIGFmdGVyOiAiW25vZGV8c3RyaW5n XS4uLiIsCisgICAgICAgIGJlZm9yZTogIltub2RlfHN0cmluZ10uLi4iLAorICAgICAgICByZXBs YWNlV2l0aDogIltub2RlfHN0cmluZ10uLi4iLAorICAgIH07CisgICAgT2JqZWN0LmFzc2lnbihX ZWJJbnNwZWN0b3IuTmF0aXZlUHJvdG90eXBlRnVuY3Rpb25QYXJhbWV0ZXJzLkVsZW1lbnQsIENo aWxkTm9kZSkKKyAgICBPYmplY3QuYXNzaWduKFdlYkluc3BlY3Rvci5OYXRpdmVQcm90b3R5cGVG dW5jdGlvblBhcmFtZXRlcnMuQ2hhcmFjdGVyRGF0YSwgQ2hpbGROb2RlKTsKKworICAgIHZhciBQ YXJlbnROb2RlID0geworICAgICAgICBhcHBlbmQ6ICJbbm9kZXxzdHJpbmddLi4uIiwKKyAgICAg ICAgcHJlcGVuZDogIltub2RlfHN0cmluZ10uLi4iLAorICAgIH07CisgICAgT2JqZWN0LmFzc2ln bihXZWJJbnNwZWN0b3IuTmF0aXZlUHJvdG90eXBlRnVuY3Rpb25QYXJhbWV0ZXJzLkVsZW1lbnQs IFBhcmVudE5vZGUpOworICAgIE9iamVjdC5hc3NpZ24oV2ViSW5zcGVjdG9yLk5hdGl2ZVByb3Rv dHlwZUZ1bmN0aW9uUGFyYW1ldGVycy5Eb2N1bWVudCwgUGFyZW50Tm9kZSk7CisgICAgT2JqZWN0 LmFzc2lnbihXZWJJbnNwZWN0b3IuTmF0aXZlUHJvdG90eXBlRnVuY3Rpb25QYXJhbWV0ZXJzLkRv Y3VtZW50RnJhZ21lbnQsIFBhcmVudE5vZGUpOwogfSkoKTsK